@in-the-loop-labs/pair-review 3.0.6 → 3.1.1

package/public/js/components/AnalysisConfigModal.js

@@ -275,6 +275,28 @@ class AnalysisConfigModal {
             </div>
           </section>
 
+          <!-- Exclude Previous Findings -->
+          <details class="config-section exclude-previous-section">
+            <summary class="section-title">
+              Exclude Previous Findings
+              <span class="section-hint">(optional)</span>
+            </summary>
+            <div class="exclude-previous-options">
+              <label class="remember-toggle">
+                <input type="checkbox" id="exclude-github-comments" />
+                <span class="toggle-switch"></span>
+                <span class="toggle-label">GitHub PR review comments</span>
+              </label>
+              <p class="option-hint">Skip issues already noted in inline PR review comments</p>
+              <label class="remember-toggle">
+                <input type="checkbox" id="exclude-pr-feedback" />
+                <span class="toggle-switch"></span>
+                <span class="toggle-label">Existing pair-review feedback</span>
+              </label>
+              <p class="option-hint">Skip issues from previous AI suggestions and reviewer comments</p>
+            </div>
+          </details>
+
           <!-- Focus Presets - Hidden for now, may reintroduce later -->
           <section class="config-section" style="display: none;">
             <h4 class="section-title">
@@ -499,7 +521,7 @@ class AnalysisConfigModal {
     container.innerHTML = this.models.map(model => `
       <button class="model-card ${model.id === this.selectedModel ? 'selected' : ''}" data-model="${model.id}" data-tier="${model.tier}">
         <div class="model-badge ${model.badgeClass || ''}">${model.badge || ''}</div>
-        <div class="model-icon">${this.getModelIcon(model.tier)}</div>
+        <div class="model-icon">${model.icon || this.getModelIcon(model.tier)}</div>
         <div class="model-info">
           <span class="model-name">${model.name}</span>
           <span class="model-tagline">${model.tagline || ''}</span>
@@ -549,10 +571,54 @@ class AnalysisConfigModal {
     // Re-render model cards (handles its own event listeners)
     this.renderModelCards();
 
+    // Toggle level toggles visibility based on provider's capabilities
+    const provider = this.providers[providerId];
+    const supportsLevels = provider.capabilities?.review_levels !== false;
+    const supportsCustomInstructions = provider.capabilities?.custom_instructions !== false;
+    const levelToggles = this.modal.querySelector('.single-level-toggles');
+    const skipLevel3Info = this.modal.querySelector('#skip-level3-info');
+    const existingLevelsNote = this.modal.querySelector('.executable-provider-levels-note');
+    const customInstructionsSection = this.modal.querySelector('#custom-instructions')?.closest('.config-section');
+
+    if (!supportsLevels) {
+      if (levelToggles) levelToggles.style.display = 'none';
+      if (skipLevel3Info) skipLevel3Info.style.display = 'none';
+      if (!existingLevelsNote) {
+        const note = document.createElement('div');
+        note.className = 'executable-provider-note executable-provider-levels-note';
+        note.textContent = 'This provider runs its own analysis pipeline';
+        levelToggles?.parentNode?.appendChild(note);
+      }
+    } else {
+      if (levelToggles) levelToggles.style.display = '';
+      if (skipLevel3Info) skipLevel3Info.style.display = '';
+      if (existingLevelsNote) existingLevelsNote.remove();
+    }
+
+    // Toggle custom instructions visibility based on provider's capabilities
+    const instructionsContainer = customInstructionsSection?.querySelector('.instructions-container');
+    const existingInstructionsNote = customInstructionsSection?.querySelector('.executable-provider-instructions-note');
+
+    if (!supportsCustomInstructions) {
+      if (instructionsContainer) instructionsContainer.style.display = 'none';
+      if (!existingInstructionsNote && customInstructionsSection) {
+        const note = document.createElement('div');
+        note.className = 'executable-provider-note executable-provider-instructions-note';
+        note.textContent = 'This provider runs its own analysis pipeline and does not accept custom instructions.';
+        customInstructionsSection.appendChild(note);
+      }
+    } else {
+      if (instructionsContainer) instructionsContainer.style.display = '';
+      if (existingInstructionsNote) existingInstructionsNote.remove();
+    }
+
     // Update selection state for the selected model
     if (this.selectedModel) {
       this.selectModel(this.selectedModel);
     }
+
+    // Update exclude-previous section based on provider's exclude_previous capability
+    this._updateExcludePreviousState();
   }
 
   /**
@@ -711,7 +777,8 @@ class AnalysisConfigModal {
         councilName: selectedCouncil?.name || null,
         councilConfig: councilConfig,
         customInstructions: this.modal.querySelector('#vc-custom-instructions')?.value?.trim() || '',
-        repoInstructions: this.repoInstructions
+        repoInstructions: this.repoInstructions,
+        excludePrevious: this._getAndSaveExcludePrevious()
       };
 
       if (this.onSubmit) this.onSubmit(config);
@@ -736,7 +803,8 @@ class AnalysisConfigModal {
         councilName: selectedCouncil?.name || null,
         councilConfig: councilConfig,
         customInstructions: this.modal.querySelector('#council-custom-instructions')?.value?.trim() || '',
-        repoInstructions: this.repoInstructions
+        repoInstructions: this.repoInstructions,
+        excludePrevious: this._getAndSaveExcludePrevious()
       };
 
       if (this.onSubmit) this.onSubmit(config);
@@ -748,16 +816,23 @@ class AnalysisConfigModal {
     const selectedModelCard = this.modal.querySelector('.model-card.selected');
     const tier = selectedModelCard?.dataset?.tier || 'balanced';
 
+    const selectedProvider = this.providers[this.selectedProvider];
+    const noLevels = selectedProvider?.capabilities?.review_levels === false;
+
     const config = {
       provider: this.selectedProvider,
       model: this.selectedModel,
       tier: tier,
       instructions: this.buildInstructions(),
-      customInstructions: this.modal.querySelector('#custom-instructions')?.value?.trim() || '',
+      customInstructions: selectedProvider?.capabilities?.custom_instructions === false ? '' : (this.modal.querySelector('#custom-instructions')?.value?.trim() || ''),
       presets: Array.from(this.selectedPresets),
       repoInstructions: this.repoInstructions,
       enabledLevels: [...this.enabledLevels],
-      skipLevel3: !this.enabledLevels.includes(3)
+      skipLevel3: !this.enabledLevels.includes(3),
+      noLevels,
+      excludePrevious: selectedProvider?.capabilities?.exclude_previous === false
+        ? undefined
+        : this._getAndSaveExcludePrevious()
     };
 
     if (this.onSubmit) this.onSubmit(config);
@@ -895,6 +970,9 @@ class AnalysisConfigModal {
       }
     }
 
+    // Restore exclude-previous checkbox state from localStorage
+    this._restoreExcludePrevious(options);
+
     // Remove loading state and reveal content
     this._showLoading(false);
 
@@ -953,6 +1031,10 @@ class AnalysisConfigModal {
         <button class="analysis-tab" data-tab="advanced">Advanced</button>
       `;
 
+      // Hoist the exclude-previous section out of the single-model panel
+      // so it remains visible across all tabs.
+      const excludePreviousSection = singlePanel.querySelector('.exclude-previous-section');
+
       // Assemble
       modalBody.innerHTML = '';
       modalBody.appendChild(tabBar);
@@ -960,6 +1042,12 @@ class AnalysisConfigModal {
       modalBody.appendChild(councilPanel);
       modalBody.appendChild(advancedPanel);
 
+      // Place the exclude-previous section after all tab panels,
+      // just before the modal footer, so it's visible on every tab.
+      if (excludePreviousSection) {
+        modalBody.appendChild(excludePreviousSection);
+      }
+
       // Tab click listeners
       tabBar.querySelectorAll('.analysis-tab').forEach(tab => {
         tab.addEventListener('click', () => {
@@ -1068,6 +1156,9 @@ class AnalysisConfigModal {
         dirtyHintContainer.style.display = 'none';
       }
     }
+
+    // Re-evaluate exclude-previous section based on new tab context
+    this._updateExcludePreviousState();
   }
 
   /**
@@ -1212,6 +1303,116 @@ class AnalysisConfigModal {
     }, 200);
   }
 
+  /**
+   * Restore exclude-previous checkbox state from localStorage.
+   * Disables the GitHub checkbox when there is no PR or no GitHub token.
+   * @param {Object} options - show() options
+   * @private
+   */
+  _restoreExcludePrevious(options) {
+    const githubCb = this.modal.querySelector('#exclude-github-comments');
+    const feedbackCb = this.modal.querySelector('#exclude-pr-feedback');
+    if (!githubCb || !feedbackCb) return;
+
+    // Restore saved state
+    let saved = { github: false, feedback: false };
+    try {
+      const raw = localStorage.getItem('pair-review-exclude-previous');
+      if (raw) saved = JSON.parse(raw);
+    } catch (_) { /* ignore parse errors */ }
+
+    githubCb.checked = !!saved.github;
+    feedbackCb.checked = !!saved.feedback;
+
+    // Disable the GitHub checkbox when it cannot be used
+    const canUseGithub = options.hasPr !== false && options.hasGithubToken !== false;
+    githubCb.disabled = !canUseGithub;
+    if (!canUseGithub) {
+      const label = githubCb.closest('.remember-toggle');
+      if (label) label.title = 'Not available — requires a PR with a GitHub token';
+    } else {
+      const label = githubCb.closest('.remember-toggle');
+      if (label) label.title = '';
+    }
+  }
+
+  /**
+   * Read current exclude-previous checkbox state, save to localStorage,
+   * and return the config object.
+   * @returns {{ github: boolean, feedback: boolean }}
+   * @private
+   */
+  _getAndSaveExcludePrevious() {
+    const githubCb = this.modal.querySelector('#exclude-github-comments');
+    const feedbackCb = this.modal.querySelector('#exclude-pr-feedback');
+
+    // When the GitHub checkbox is disabled, preserve the existing localStorage
+    // value for `github` so the user's preference survives contexts where the
+    // option is unavailable.
+    let preservedGithub = false;
+    if (githubCb?.disabled) {
+      try {
+        const raw = localStorage.getItem('pair-review-exclude-previous');
+        if (raw) {
+          const prev = JSON.parse(raw);
+          preservedGithub = !!prev.github;
+        }
+      } catch (_) { /* ignore parse errors */ }
+    }
+
+    const state = {
+      github: githubCb?.disabled ? preservedGithub : !!githubCb?.checked,
+      feedback: !!feedbackCb?.checked
+    };
+    try {
+      localStorage.setItem('pair-review-exclude-previous', JSON.stringify(state));
+    } catch (_) { /* ignore storage errors */ }
+    return state;
+  }
+
+  /**
+   * Update the exclude-previous section's enabled/disabled state based on
+   * the active tab and the selected provider's capabilities.
+   *
+   * Council/Advanced tabs: always enabled (orchestration handles dedup).
+   * Single Model tab: disabled when provider has exclude_previous === false.
+   *
+   * This only toggles the visual state of the entire section — individual
+   * checkbox checked/disabled state is never modified, so persisted
+   * localStorage values remain untouched.
+   * @private
+   */
+  _updateExcludePreviousState() {
+    const section = this.modal.querySelector('.exclude-previous-section');
+    if (!section) return;
+
+    const provider = this.providers[this.selectedProvider];
+    const disabledByCapability = this.activeTab === 'single'
+      && provider?.capabilities?.exclude_previous === false;
+
+    const existingNote = section.querySelector('.executable-provider-exclude-note');
+
+    if (disabledByCapability) {
+      section.classList.add('exclude-previous-disabled');
+      section.setAttribute('open', '');  // Ensure note is visible even if section was collapsed
+
+      if (!existingNote) {
+        const note = document.createElement('div');
+        note.className = 'executable-provider-note executable-provider-exclude-note';
+        note.textContent = 'This provider does not support excluding previous findings.';
+        const options = section.querySelector('.exclude-previous-options');
+        if (options) {
+          section.insertBefore(note, options);
+        } else {
+          section.appendChild(note);
+        }
+      }
+    } else {
+      section.classList.remove('exclude-previous-disabled');
+      if (existingNote) existingNote.remove();
+    }
+  }
+
   /**
    * Cleanup event listeners and pending timeouts
    */

package/public/js/components/ChatPanel.js

@@ -43,6 +43,7 @@ class ChatPanel {
     this._sessionWarm = false; // true once the session has been used in this page load
     this._activeProvider = window.__pairReview?.chatProvider || 'pi';
     this._chatProviders = window.__pairReview?.chatProviders || [];
+    this._enterToSend = window.__pairReview?.chatEnterToSend ?? true;
 
     this._render();
     this._bindEvents();
@@ -141,7 +142,7 @@ class ChatPanel {
         <div class="chat-panel__input-area">
           <textarea class="chat-panel__input" placeholder="Ask about this review..." rows="1"></textarea>
           <div class="chat-panel__input-footer">
-            <span class="chat-panel__input-hint">${typeof navigator !== 'undefined' && navigator.platform?.includes('Mac') ? '\u2318' : 'Ctrl'}+Enter to send</span>
+            <span class="chat-panel__input-hint" title="Configure with chat.enter_to_send">${this._enterToSend ? 'Enter to send, Shift+Enter for newline' : `${typeof navigator !== 'undefined' && navigator.platform?.includes('Mac') ? '\u2318' : 'Ctrl'}+Enter to send`}</span>
             <div class="chat-panel__input-actions">
               <button class="chat-panel__send-btn" title="Send" disabled>
                 <svg viewBox="0 0 16 16" fill="currentColor" width="14" height="14">
@@ -250,10 +251,26 @@ class ChatPanel {
 
     // Keyboard shortcuts
     this.inputEl.addEventListener('keydown', (e) => {
-      if (e.key === 'Enter' && (e.metaKey || e.ctrlKey)) {
-        e.preventDefault();
-        if (this.inputEl.value.trim() && !this.isStreaming) {
-          this.sendMessage();
+      if (e.key === 'Enter') {
+        // Ignore Enter during IME composition (e.g. CJK input) so the
+        // composition-confirming keystroke is not swallowed.
+        if (e.isComposing) return;
+
+        if (this._enterToSend) {
+          // Enter sends, Shift+Enter inserts newline
+          if (e.shiftKey) return; // let browser insert newline
+          e.preventDefault();
+          if (this.inputEl.value.trim() && !this.isStreaming) {
+            this.sendMessage();
+          }
+        } else {
+          // Cmd+Enter / Ctrl+Enter sends, plain Enter inserts newline
+          if (e.metaKey || e.ctrlKey) {
+            e.preventDefault();
+            if (this.inputEl.value.trim() && !this.isStreaming) {
+              this.sendMessage();
+            }
+          }
         }
       }
     });