@in-the-loop-labs/pair-review 3.0.6 → 3.1.0

package/src/routes/chat.js

@@ -20,6 +20,7 @@ const logger = require('../utils/logger');
 const ws = require('../ws');
 const { fireHooks, hasHooks } = require('../hooks/hook-runner');
 const { buildChatStartedPayload, buildChatResumedPayload, buildChatHookContext, getCachedUser } = require('../hooks/payloads');
+const { resolveFormat } = require('../utils/comment-formatter');
 
 /**
  * Fire a chat hook event (non-blocking). Skips async work when no hooks are configured.
@@ -259,8 +260,10 @@ router.post('/api/chat/session', async (req, res) => {
 
       const chatInstructions = await getChatInstructions(db, review);
       const prData = await fetchPrData(db, review);
+      const config = req.app.get('config') || {};
+      const formatConfig = resolveFormat(config.comment_format);
 
-      finalSystemPrompt = buildChatPrompt({ review, prData, chatInstructions });
+      finalSystemPrompt = buildChatPrompt({ review, prData, chatInstructions, commentFormatTemplate: formatConfig.template });
 
       if (!skipAnalysisContext) {
         // Fetch all AI suggestions from the latest analysis run
@@ -268,7 +271,7 @@ router.post('/api/chat/session', async (req, res) => {
           SELECT
             id, ai_run_id, ai_level, ai_confidence,
             file, line_start, line_end, type, title, body,
-            reasoning, status, is_file_level
+            reasoning, status, is_file_level, severity
           FROM comments
           WHERE review_id = ?
             AND source = 'ai'
@@ -323,7 +326,7 @@ router.post('/api/chat/session', async (req, res) => {
       initialContext: initialContextWithPort
     });
 
-    logger.info(`Chat session created: ${session.id} (provider=${provider}, model=${model})`);
+    logger.info(`Chat session created: ${session.id} (provider=${provider})`);
 
     // Register broadcast listeners so events reach all connected clients
     registerChatBroadcast(chatSessionManager, session.id, serverPort);
@@ -390,8 +393,10 @@ router.post('/api/chat/session/:id/message', async (req, res) => {
       }
       const chatInstructions = await getChatInstructions(db, review);
       const prData = await fetchPrData(db, review);
+      const config = req.app.get('config') || {};
+      const fmtConfig = resolveFormat(config.comment_format);
 
-      const systemPrompt = buildChatPrompt({ review, prData, chatInstructions });
+      const systemPrompt = buildChatPrompt({ review, prData, chatInstructions, commentFormatTemplate: fmtConfig.template });
       const cwd = await resolveReviewCwd(db, review);
 
       try {
@@ -405,7 +410,7 @@ router.post('/api/chat/session/:id/message', async (req, res) => {
         // Inject port correction so the agent knows the current server address,
         // even if the conversational history has a stale port from session creation.
         const serverPort = req.socket.localPort;
-        portCorrectionContext = `[Server port: ${serverPort}] The pair-review API is at http://localhost:${serverPort}`;
+        portCorrectionContext = `[Server port: ${serverPort}] The pair-review API is at http://localhost:${serverPort}\n\n[Comment format template: ${fmtConfig.template}]`;
         // Note: we intentionally do NOT re-inject the API cheat sheet on resume.
         // The agent already has the endpoint shapes from the original session context —
         // it only needs the updated port to adjust its curl calls.
@@ -530,8 +535,10 @@ router.post('/api/chat/session/:id/resume', async (req, res) => {
     // initial session's context.
     const chatInstructions = await getChatInstructions(db, review);
     const prData = await fetchPrData(db, review);
+    const config = req.app.get('config') || {};
+    const fmtConfig = resolveFormat(config.comment_format);
 
-    const systemPrompt = buildChatPrompt({ review, prData, chatInstructions });
+    const systemPrompt = buildChatPrompt({ review, prData, chatInstructions, commentFormatTemplate: fmtConfig.template });
     const cwd = await resolveReviewCwd(db, review);
 
     await chatSessionManager.resumeSession(sessionId, { systemPrompt, cwd });
@@ -544,7 +551,7 @@ router.post('/api/chat/session/:id/resume', async (req, res) => {
     // Uses resumeContext (consumed on next sendMessage) instead of saveContextMessage
     // (which only writes to DB and never reaches the agent process).
     chatSessionManager.setResumeContext(sessionId,
-      `[Server port: ${serverPort}] The pair-review API is at http://localhost:${serverPort}`
+      `[Server port: ${serverPort}] The pair-review API is at http://localhost:${serverPort}\n\n[Comment format template: ${fmtConfig.template}]`
     );
 
     logger.info(`[ChatRoute] Explicitly resumed session ${sessionId}`);
@@ -622,7 +629,7 @@ router.get('/api/chat/analysis-context/:runId', async (req, res) => {
       SELECT
         id, ai_run_id, ai_level, ai_confidence,
         file, line_start, line_end, type, title, body,
-        reasoning, status, is_file_level
+        reasoning, status, is_file_level, severity
       FROM comments
       WHERE review_id = ?
         AND source = 'ai'

package/src/routes/config.js

@@ -20,10 +20,9 @@ const {
   isCheckInProgress
 } = require('../ai');
 const { normalizeRepository } = require('../utils/paths');
-const { isRunningViaNpx, saveConfig } = require('../config');
+const { isRunningViaNpx, getGitHubToken } = require('../config');
 const { version } = require('../../package.json');
 const { getAllChatProviders, getAllCachedChatAvailability } = require('../chat/chat-providers');
-const { PRESETS } = require('../utils/comment-formatter');
 const logger = require('../utils/logger');
 
 const router = express.Router();
@@ -45,6 +44,7 @@ router.get('/api/config', (req, res) => {
   res.json({
     version,
     theme: config.theme || 'light',
+    has_github_token: Boolean(getGitHubToken(config)),
     comment_button_action: config.comment_button_action || 'submit',
     comment_format: config.comment_format || 'legacy',
     // Include npx detection for frontend command examples
@@ -53,6 +53,7 @@ router.get('/api/config', (req, res) => {
     chat_provider: config.chat_provider || 'pi',
     chat_providers: chatProviders,
     chat_enable_shortcuts: config.chat?.enable_shortcuts !== false,
+    chat_enter_to_send: config.chat?.enter_to_send !== false,
     pi_available: getCachedAvailability('pi')?.available || false,
     assisted_by_url: config.assisted_by_url || 'https://github.com/in-the-loop-labs/pair-review',
     enable_graphite: config.enable_graphite === true,
@@ -74,124 +75,6 @@ router.get('/api/config', (req, res) => {
   });
 });
 
-/**
- * Update user configuration
- * Updates safe configuration values
- */
-router.patch('/api/config', async (req, res) => {
-  try {
-    const { comment_button_action, chat_enable_shortcuts, comment_format } = req.body;
-
-    // Validate comment_button_action if provided
-    if (comment_button_action !== undefined) {
-      if (!['submit', 'preview'].includes(comment_button_action)) {
-        return res.status(400).json({
-          error: 'Invalid comment_button_action. Must be "submit" or "preview"'
-        });
-      }
-    }
-
-    if (chat_enable_shortcuts !== undefined) {
-      if (typeof chat_enable_shortcuts !== 'boolean') {
-        return res.status(400).json({
-          error: 'Invalid chat_enable_shortcuts. Must be a boolean'
-        });
-      }
-    }
-
-    // Validate comment_format if provided
-    if (comment_format !== undefined) {
-      const validPresets = Object.keys(PRESETS);
-      if (typeof comment_format === 'string') {
-        if (!validPresets.includes(comment_format)) {
-          return res.status(400).json({
-            error: `Invalid comment_format preset. Must be one of: ${validPresets.join(', ')}`
-          });
-        }
-      } else if (typeof comment_format === 'object' && comment_format !== null) {
-        if (!comment_format.template || typeof comment_format.template !== 'string') {
-          return res.status(400).json({
-            error: 'Custom comment_format must have a "template" string'
-          });
-        }
-        // Validate categoryOverrides if provided (must be a string->string mapping)
-        if (comment_format.categoryOverrides !== undefined) {
-          if (typeof comment_format.categoryOverrides !== 'object' || comment_format.categoryOverrides === null || Array.isArray(comment_format.categoryOverrides)) {
-            return res.status(400).json({
-              error: 'categoryOverrides must be an object mapping category names to replacement strings'
-            });
-          }
-          for (const [, value] of Object.entries(comment_format.categoryOverrides)) {
-            if (typeof value !== 'string') {
-              return res.status(400).json({
-                error: 'categoryOverrides must be a string-to-string mapping'
-              });
-            }
-          }
-        }
-        // Validate emojiOverrides if provided (must be a string->string mapping)
-        if (comment_format.emojiOverrides !== undefined) {
-          if (typeof comment_format.emojiOverrides !== 'object' || comment_format.emojiOverrides === null || Array.isArray(comment_format.emojiOverrides)) {
-            return res.status(400).json({
-              error: 'emojiOverrides must be an object mapping category names to emoji strings'
-            });
-          }
-          for (const [, value] of Object.entries(comment_format.emojiOverrides)) {
-            if (typeof value !== 'string') {
-              return res.status(400).json({
-                error: 'emojiOverrides must be a string-to-string mapping'
-              });
-            }
-          }
-        }
-      } else {
-        return res.status(400).json({
-          error: 'comment_format must be a preset name string or a custom template object'
-        });
-      }
-    }
-
-    // Get current config
-    const config = req.app.get('config') || {};
-
-    // Update allowed fields
-    if (comment_button_action !== undefined) {
-      config.comment_button_action = comment_button_action;
-    }
-
-    if (chat_enable_shortcuts !== undefined) {
-      if (!config.chat) config.chat = {};
-      config.chat.enable_shortcuts = chat_enable_shortcuts;
-    }
-
-    if (comment_format !== undefined) {
-      config.comment_format = comment_format;
-    }
-
-    // Save config to file
-    await saveConfig(config);
-
-    // Update app config
-    req.app.set('config', config);
-
-    res.json({
-      success: true,
-      config: {
-        theme: config.theme || 'light',
-        comment_button_action: config.comment_button_action || 'submit',
-        chat_enable_shortcuts: config.chat?.enable_shortcuts !== false,
-        comment_format: config.comment_format || 'legacy'
-      }
-    });
-
-  } catch (error) {
-    logger.error('Error updating config:', error);
-    res.status(500).json({
-      error: 'Failed to update configuration'
-    });
-  }
-});
-
 /**
  * Get repository-specific settings
  * Returns default_instructions, default_provider, and default_model for the repository

package/src/routes/councils.js

@@ -11,6 +11,7 @@ const express = require('express');
 const { v4: uuidv4 } = require('uuid');
 const logger = require('../utils/logger');
 const { CouncilRepository } = require('../database');
+const { getProviderClass } = require('../ai/provider');
 
 const router = express.Router();
 
@@ -129,12 +130,20 @@ function validateCouncilFormat(config) {
     return 'config.levels is required and must be an object';
   }
 
-  const validLevels = ['1', '2', '3'];
-  const hasEnabled = Object.entries(config.levels).some(([key, val]) =>
-    validLevels.includes(key) && val === true
-  );
-  if (!hasEnabled) {
-    return 'At least one level (1, 2, or 3) must be enabled';
+  // Skip level requirement when all voices are executable providers
+  const allExecutable = config.voices.every(v => {
+    const ProviderClass = getProviderClass(v.provider);
+    return ProviderClass?.isExecutable;
+  });
+
+  if (!allExecutable) {
+    const validLevels = ['1', '2', '3'];
+    const hasEnabled = Object.entries(config.levels).some(([key, val]) =>
+      validLevels.includes(key) && val === true
+    );
+    if (!hasEnabled) {
+      return 'At least one level (1, 2, or 3) must be enabled for non-executable providers';
+    }
   }
 
   // Validate consolidation (optional)