@in-the-loop-labs/pair-review 1.6.2 → 2.0.1

package/src/routes/config.js

@@ -37,7 +37,10 @@ router.get('/api/config', (req, res) => {
     theme: config.theme || 'light',
     comment_button_action: config.comment_button_action || 'submit',
     // Include npx detection for frontend command examples
-    is_running_via_npx: isRunningViaNpx()
+    is_running_via_npx: isRunningViaNpx(),
+    enable_chat: config.enable_chat !== false,
+    chat_enable_shortcuts: config.chat?.enable_shortcuts !== false,
+    pi_available: getCachedAvailability('pi')?.available || false
   });
 });
 
@@ -47,7 +50,7 @@ router.get('/api/config', (req, res) => {
  */
 router.patch('/api/config', async (req, res) => {
   try {
-    const { comment_button_action } = req.body;
+    const { comment_button_action, chat_enable_shortcuts } = req.body;
 
     // Validate comment_button_action if provided
     if (comment_button_action !== undefined) {
@@ -58,6 +61,14 @@ router.patch('/api/config', async (req, res) => {
       }
     }
 
+    if (chat_enable_shortcuts !== undefined) {
+      if (typeof chat_enable_shortcuts !== 'boolean') {
+        return res.status(400).json({
+          error: 'Invalid chat_enable_shortcuts. Must be a boolean'
+        });
+      }
+    }
+
     // Get current config
     const config = req.app.get('config') || {};
 
@@ -66,6 +77,11 @@ router.patch('/api/config', async (req, res) => {
       config.comment_button_action = comment_button_action;
     }
 
+    if (chat_enable_shortcuts !== undefined) {
+      if (!config.chat) config.chat = {};
+      config.chat.enable_shortcuts = chat_enable_shortcuts;
+    }
+
     // Save config to file
     const { saveConfig } = require('../config');
     await saveConfig(config);
@@ -77,7 +93,8 @@ router.patch('/api/config', async (req, res) => {
       success: true,
       config: {
         theme: config.theme || 'light',
-        comment_button_action: config.comment_button_action || 'submit'
+        comment_button_action: config.comment_button_action || 'submit',
+        chat_enable_shortcuts: config.chat?.enable_shortcuts !== false
       }
     });
 
@@ -111,7 +128,8 @@ router.get('/api/repos/:owner/:repo/settings', async (req, res) => {
         default_model: null,
         local_path: null,
         default_council_id: null,
-        default_tab: null
+        default_tab: null,
+        default_chat_instructions: null
       });
     }
 
@@ -123,6 +141,7 @@ router.get('/api/repos/:owner/:repo/settings', async (req, res) => {
       local_path: settings.local_path,
       default_council_id: settings.default_council_id,
       default_tab: settings.default_tab,
+      default_chat_instructions: settings.default_chat_instructions,
       created_at: settings.created_at,
       updated_at: settings.updated_at
     });
@@ -142,14 +161,14 @@ router.get('/api/repos/:owner/:repo/settings', async (req, res) => {
 router.post('/api/repos/:owner/:repo/settings', async (req, res) => {
   try {
     const { owner, repo } = req.params;
-    const { default_instructions, default_provider, default_model, local_path, default_council_id, default_tab } = req.body;
+    const { default_instructions, default_provider, default_model, local_path, default_council_id, default_tab, default_chat_instructions } = req.body;
     const repository = normalizeRepository(owner, repo);
     const db = req.app.get('db');
 
     // Validate that at least one setting is provided
-    if (default_instructions === undefined && default_provider === undefined && default_model === undefined && local_path === undefined && default_council_id === undefined && default_tab === undefined) {
+    if (default_instructions === undefined && default_provider === undefined && default_model === undefined && local_path === undefined && default_council_id === undefined && default_tab === undefined && default_chat_instructions === undefined) {
       return res.status(400).json({
-        error: 'At least one setting (default_instructions, default_provider, default_model, local_path, default_council_id, or default_tab) must be provided'
+        error: 'At least one setting (default_instructions, default_provider, default_model, local_path, default_council_id, default_tab, or default_chat_instructions) must be provided'
       });
     }
 
@@ -160,7 +179,8 @@ router.post('/api/repos/:owner/:repo/settings', async (req, res) => {
       default_model,
       local_path,
       default_council_id,
-      default_tab
+      default_tab,
+      default_chat_instructions
     });
 
     logger.info(`Saved repo settings for ${repository}`);
@@ -175,6 +195,7 @@ router.post('/api/repos/:owner/:repo/settings', async (req, res) => {
         local_path: settings.local_path,
         default_council_id: settings.default_council_id,
         default_tab: settings.default_tab,
+        default_chat_instructions: settings.default_chat_instructions,
         updated_at: settings.updated_at
       }
     });

package/src/routes/context-files.js

@@ -0,0 +1,274 @@
+// SPDX-License-Identifier: GPL-3.0-or-later
+/**
+ * Context Files Routes
+ *
+ * Provides endpoints for managing context file ranges that pin specific
+ * line ranges from non-diff files into the diff panel for review.
+ *
+ * All endpoints live under /api/reviews/:reviewId/context-files
+ */
+
+const fs = require('fs');
+const path = require('path');
+const express = require('express');
+const { ReviewRepository, ContextFileRepository, WorktreeRepository } = require('../database');
+const logger = require('../utils/logger');
+const { broadcastReviewEvent } = require('../sse/review-events');
+const { getDiffFileList } = require('../utils/diff-file-list');
+
+const router = express.Router();
+
+/**
+ * Resolve the repository root directory for a review.
+ * Local reviews use local_path; PR reviews look up the worktree path.
+ * Returns null when the root cannot be determined (e.g. worktree not set up).
+ *
+ * @param {object} db     - SQLite database handle
+ * @param {object} review - Review row from the database
+ * @returns {Promise<string|null>} Absolute path to the repo root, or null
+ */
+async function resolveRepoRoot(db, review) {
+  // Local mode – the path is stored directly on the review record
+  if (review.local_path) {
+    return review.local_path;
+  }
+
+  // PR mode – look up the worktree record
+  if (review.pr_number && review.repository) {
+    const worktreeRepo = new WorktreeRepository(db);
+    const worktree = await worktreeRepo.findByPR(review.pr_number, review.repository);
+    if (worktree && worktree.path) {
+      return worktree.path;
+    }
+  }
+
+  return null;
+}
+
+/**
+ * Middleware: validate that :reviewId exists in the reviews table.
+ * Attaches the review record to req.review for downstream handlers.
+ */
+async function validateReviewId(req, res, next) {
+  try {
+    const reviewId = parseInt(req.params.reviewId, 10);
+
+    if (isNaN(reviewId) || reviewId <= 0) {
+      return res.status(400).json({ error: 'Invalid review ID' });
+    }
+
+    const db = req.app.get('db');
+    const reviewRepo = new ReviewRepository(db);
+    const review = await reviewRepo.getReview(reviewId);
+
+    if (!review) {
+      return res.status(404).json({ error: `Review #${reviewId} not found` });
+    }
+
+    req.review = review;
+    req.reviewId = reviewId;
+    next();
+  } catch (error) {
+    next(error);
+  }
+}
+
+/**
+ * POST /api/reviews/:reviewId/context-files
+ * Add a context file range for a review.
+ * Body: { file, line_start, line_end, label? }
+ */
+router.post('/api/reviews/:reviewId/context-files', validateReviewId, async (req, res) => {
+  try {
+    const { file, line_start, line_end, label } = req.body;
+
+    // Validate: file is required and non-empty string
+    if (!file || typeof file !== 'string' || file.trim().length === 0) {
+      return res.status(400).json({ error: 'file is required and must be a non-empty string' });
+    }
+
+    if (file.includes('..') || file.startsWith('/')) {
+      return res.status(400).json({ error: 'file must be a relative path without .. segments' });
+    }
+
+    // Validate: line_start and line_end are positive integers
+    const lineStart = parseInt(line_start, 10);
+    const lineEnd = parseInt(line_end, 10);
+
+    if (isNaN(lineStart) || lineStart <= 0) {
+      return res.status(400).json({ error: 'line_start must be a positive integer' });
+    }
+
+    if (isNaN(lineEnd) || lineEnd <= 0) {
+      return res.status(400).json({ error: 'line_end must be a positive integer' });
+    }
+
+    // Validate: line_end >= line_start
+    if (lineEnd < lineStart) {
+      return res.status(400).json({ error: 'line_end must be >= line_start' });
+    }
+
+    // Validate: max range of 500 lines
+    if (lineEnd - lineStart + 1 > 500) {
+      return res.status(400).json({ error: 'Range cannot exceed 500 lines' });
+    }
+
+    const db = req.app.get('db');
+
+    // Reject files that are already part of the review's diff
+    const diffFiles = await getDiffFileList(db, req.review);
+    if (diffFiles.includes(file.trim())) {
+      return res.status(400).json({
+        error: `Cannot add context file: '${file.trim()}' is already part of the diff`
+      });
+    }
+
+    // Validate that the file exists on disk when we can resolve the repo root
+    const repoRoot = await resolveRepoRoot(db, req.review);
+    if (repoRoot) {
+      const resolved = path.resolve(repoRoot, file.trim());
+      // Double-check the resolved path is still within the repo root (belt-and-suspenders with the .. check above)
+      if (!resolved.startsWith(repoRoot + path.sep) && resolved !== repoRoot) {
+        return res.status(400).json({ error: 'file must be a relative path without .. segments' });
+      }
+      if (!fs.existsSync(resolved)) {
+        return res.status(400).json({ error: 'File not found in repository' });
+      }
+    }
+
+    const contextFileRepo = new ContextFileRepository(db);
+
+    const record = await contextFileRepo.add(
+      req.reviewId,
+      file.trim(),
+      lineStart,
+      lineEnd,
+      label || null
+    );
+
+    res.status(201).json({ success: true, contextFile: record });
+    broadcastReviewEvent(req.reviewId, { type: 'review:context_files_changed' }, { sourceClientId: req.get('X-Client-Id') });
+  } catch (error) {
+    logger.error('Error adding context file:', error);
+    res.status(500).json({ error: 'Failed to add context file' });
+  }
+});
+
+/**
+ * GET /api/reviews/:reviewId/context-files
+ * List all context file ranges for a review.
+ */
+router.get('/api/reviews/:reviewId/context-files', validateReviewId, async (req, res) => {
+  try {
+    const db = req.app.get('db');
+    const contextFileRepo = new ContextFileRepository(db);
+
+    const contextFiles = await contextFileRepo.getByReviewId(req.reviewId);
+
+    res.json({ success: true, contextFiles: contextFiles || [] });
+  } catch (error) {
+    logger.error('Error fetching context files:', error);
+    res.status(500).json({ error: 'Failed to fetch context files' });
+  }
+});
+
+/**
+ * PATCH /api/reviews/:reviewId/context-files/:id
+ * Update the line range of an existing context file entry.
+ * Body: { line_start, line_end }
+ */
+router.patch('/api/reviews/:reviewId/context-files/:id', validateReviewId, async (req, res) => {
+  try {
+    const id = parseInt(req.params.id, 10);
+
+    if (isNaN(id) || id <= 0) {
+      return res.status(400).json({ error: 'Invalid context file ID' });
+    }
+
+    const { line_start, line_end } = req.body;
+
+    const lineStart = parseInt(line_start, 10);
+    const lineEnd = parseInt(line_end, 10);
+
+    if (isNaN(lineStart) || lineStart <= 0) {
+      return res.status(400).json({ error: 'line_start must be a positive integer' });
+    }
+
+    if (isNaN(lineEnd) || lineEnd <= 0) {
+      return res.status(400).json({ error: 'line_end must be a positive integer' });
+    }
+
+    if (lineEnd < lineStart) {
+      return res.status(400).json({ error: 'line_end must be >= line_start' });
+    }
+
+    if (lineEnd - lineStart + 1 > 500) {
+      return res.status(400).json({ error: 'Range cannot exceed 500 lines' });
+    }
+
+    const db = req.app.get('db');
+    const contextFileRepo = new ContextFileRepository(db);
+
+    const updated = await contextFileRepo.updateRange(id, lineStart, lineEnd);
+
+    if (!updated) {
+      return res.status(404).json({ error: 'Context file not found' });
+    }
+
+    res.json({ success: true });
+    broadcastReviewEvent(req.reviewId, { type: 'review:context_files_changed' }, { sourceClientId: req.get('X-Client-Id') });
+  } catch (error) {
+    logger.error('Error updating context file range:', error);
+    res.status(500).json({ error: 'Failed to update context file range' });
+  }
+});
+
+/**
+ * DELETE /api/reviews/:reviewId/context-files/:id
+ * Remove a single context file range by ID.
+ */
+router.delete('/api/reviews/:reviewId/context-files/:id', validateReviewId, async (req, res) => {
+  try {
+    const id = parseInt(req.params.id, 10);
+
+    if (isNaN(id) || id <= 0) {
+      return res.status(400).json({ error: 'Invalid context file ID' });
+    }
+
+    const db = req.app.get('db');
+    const contextFileRepo = new ContextFileRepository(db);
+
+    const deleted = await contextFileRepo.remove(id, req.reviewId);
+
+    if (!deleted) {
+      return res.status(404).json({ error: 'Context file not found' });
+    }
+
+    res.json({ success: true, message: 'Context file removed' });
+    broadcastReviewEvent(req.reviewId, { type: 'review:context_files_changed' }, { sourceClientId: req.get('X-Client-Id') });
+  } catch (error) {
+    logger.error('Error removing context file:', error);
+    res.status(500).json({ error: 'Failed to remove context file' });
+  }
+});
+
+/**
+ * DELETE /api/reviews/:reviewId/context-files
+ * Remove all context file ranges for a review.
+ */
+router.delete('/api/reviews/:reviewId/context-files', validateReviewId, async (req, res) => {
+  try {
+    const db = req.app.get('db');
+    const contextFileRepo = new ContextFileRepository(db);
+
+    const deletedCount = await contextFileRepo.removeAll(req.reviewId);
+
+    res.json({ success: true, deletedCount, message: `Removed ${deletedCount} context file${deletedCount !== 1 ? 's' : ''}` });
+    broadcastReviewEvent(req.reviewId, { type: 'review:context_files_changed' }, { sourceClientId: req.get('X-Client-Id') });
+  } catch (error) {
+    logger.error('Error removing all context files:', error);
+    res.status(500).json({ error: 'Failed to remove context files' });
+  }
+});
+
+module.exports = router;