@in-the-loop-labs/pair-review 1.3.3 → 1.4.1

package/public/js/local.js

@@ -304,14 +304,62 @@ class LocalManager {
         return;
       }
 
-      // Check staleness FIRST, before showing config modal
+      // Run stale check and settings fetch in parallel to minimize dialog delay.
+      // Use AbortController so the fetch is truly cancelled on timeout,
+      // freeing the HTTP connection for subsequent requests.
+      const STALE_TIMEOUT = 2000;
+      const staleAbort = new AbortController();
+      const staleTimer = setTimeout(() => {
+        console.debug(`[Analyze] stale-check timed out after ${STALE_TIMEOUT}ms, aborting`);
+        staleAbort.abort();
+      }, STALE_TIMEOUT);
+      const staleCheckPromise = fetch(`/api/local/${reviewId}/check-stale`, { signal: staleAbort.signal })
+        .then(r => {
+          clearTimeout(staleTimer);
+          if (!r.ok) {
+            console.warn(`Stale check failed with status ${r.status}`);
+            return { _fetchError: true, status: r.status };
+          }
+          return r.json();
+        })
+        .catch(err => {
+          clearTimeout(staleTimer);
+          if (err.name === 'AbortError') {
+            console.debug('[Analyze] stale-check aborted (timeout)');
+          } else {
+            console.warn('[Analyze] stale-check fetch error:', err);
+          }
+          return null;
+        });
+
       try {
-        const staleResponse = await fetch(`/api/local/${reviewId}/check-stale`);
-        if (staleResponse.ok) {
-          const staleData = await staleResponse.json();
+        // Show analysis config modal
+        if (!manager.analysisConfigModal) {
+          clearTimeout(staleTimer);
+          console.warn('AnalysisConfigModal not initialized, proceeding without config');
+          await self.startLocalAnalysis(btn, {});
+          return;
+        }
+
+        // Fetch stale check, repo settings, and last instructions in parallel
+        const [staleResult, repoSettings, lastInstructions] = await Promise.all([
+          staleCheckPromise,
+          manager.fetchRepoSettings().catch(() => null),
+          manager.fetchLastCustomInstructions().catch(() => '')
+        ]);
 
-          if (staleData.isStale === true) {
-            // Working directory has changed - show dialog with options
+        // Process stale check result
+        try {
+          if (staleResult === null) {
+            // Timed out or network error — fail open
+            if (window.toast) {
+              window.toast.showWarning('Could not verify working directory is current.');
+            }
+          } else if (staleResult._fetchError) {
+            if (window.toast) {
+              window.toast.showWarning(`Could not verify working directory is current (${staleResult.status}).`);
+            }
+          } else if (staleResult.isStale === true) {
             if (window.confirmDialog) {
               const choice = await window.confirmDialog.show({
                 title: 'Files Have Changed',
@@ -323,40 +371,22 @@ class LocalManager {
               });
 
               if (choice === 'confirm') {
-                // User wants to refresh first, then continue to analysis
                 await self.refreshDiff();
-                // Continue to config modal after refresh (don't return)
               } else if (choice !== 'secondary') {
-                // User cancelled
                 return;
               }
-              // Both 'confirm' (after refresh) and 'secondary' continue to config modal
             }
-          } else if (staleData.isStale === null && staleData.error) {
-            // Couldn't verify - show toast warning
+          } else if (staleResult.isStale === null && staleResult.error) {
             if (window.toast) {
               window.toast.showWarning('Could not verify working directory is current.');
             }
           }
+        } catch (staleError) {
+          console.warn('[Local] Error processing staleness:', staleError);
+          if (window.toast) {
+            window.toast.showWarning('Could not verify working directory is current.');
+          }
         }
-      } catch (staleError) {
-        console.warn('[Local] Error checking staleness:', staleError);
-        if (window.toast) {
-          window.toast.showWarning('Could not verify working directory is current.');
-        }
-      }
-
-      try {
-        // Show analysis config modal
-        if (!manager.analysisConfigModal) {
-          console.warn('AnalysisConfigModal not initialized, proceeding without config');
-          await self.startLocalAnalysis(btn, {});
-          return;
-        }
-
-        // Get repo settings for default instructions
-        const repoSettings = await manager.fetchRepoSettings().catch(() => null);
-        const lastInstructions = await manager.fetchLastCustomInstructions().catch(() => '');
 
         // Determine model and provider
         const modelStorageKey = `pair-review-model:local-${reviewId}`;
@@ -1361,10 +1391,90 @@ class LocalManager {
     });
   }
 
+  /**
+   * Initialize inline name editing for the review title in the header
+   */
+  initNameEditing() {
+    const nameEl = document.getElementById('local-review-name');
+    if (!nameEl || nameEl.dataset.listenerAttached) return;
+    nameEl.dataset.listenerAttached = 'true';
+
+    const reviewId = this.reviewId;
+
+    nameEl.addEventListener('click', () => {
+      if (nameEl.querySelector('input')) return; // already editing
+
+      const currentName = nameEl.dataset.currentName || '';
+      const input = document.createElement('input');
+      input.type = 'text';
+      input.className = 'local-review-name-input';
+      input.value = currentName;
+      input.placeholder = 'Untitled';
+
+      nameEl.textContent = '';
+      nameEl.appendChild(input);
+      input.focus();
+      input.select();
+
+      let saved = false;
+
+      async function save() {
+        if (saved) return;
+        saved = true;
+        const newName = input.value.trim() || null;
+        try {
+          const response = await fetch(`/api/local/${reviewId}/name`, {
+            method: 'PATCH',
+            headers: { 'Content-Type': 'application/json' },
+            body: JSON.stringify({ name: newName })
+          });
+          if (!response.ok) throw new Error('Save failed');
+          nameEl.dataset.currentName = newName || '';
+          nameEl.textContent = newName || 'Untitled';
+          nameEl.classList.toggle('unnamed', !newName);
+          nameEl.title = 'Click to rename';
+        } catch (error) {
+          // Revert the display to the previous name on failure
+          cancel();
+        }
+      }
+
+      function cancel() {
+        nameEl.textContent = currentName || 'Untitled';
+        nameEl.classList.toggle('unnamed', !currentName);
+        nameEl.title = 'Click to rename';
+      }
+
+      input.addEventListener('blur', save);
+      input.addEventListener('keydown', function(e) {
+        if (e.key === 'Enter') {
+          e.preventDefault();
+          input.removeEventListener('blur', save);
+          save();
+        } else if (e.key === 'Escape') {
+          e.preventDefault();
+          input.removeEventListener('blur', save);
+          cancel();
+        }
+      });
+    });
+  }
+
   /**
    * Update local header with review info
    */
   updateLocalHeader(reviewData) {
+    // Update review name/title in header
+    const nameEl = document.getElementById('local-review-name');
+    if (nameEl) {
+      const name = reviewData.name || '';
+      nameEl.textContent = name || 'Untitled';
+      nameEl.dataset.currentName = name;
+      nameEl.classList.toggle('unnamed', !name);
+      nameEl.title = 'Click to rename';
+      this.initNameEditing();
+    }
+
     // Update repository name
     const repoName = document.getElementById('local-repo-name');
     if (repoName) {

package/public/js/modules/analysis-history.js

@@ -748,7 +748,11 @@ class AnalysisHistoryManager {
       'o1': 'thorough',
       'o1-mini': 'balanced',
       // Copilot models
-      'gpt-4': 'balanced'
+      'gpt-4': 'balanced',
+      // Pi models
+      'default': 'balanced',
+      'multi-model': 'thorough',
+      'review-roulette': 'thorough'
     };
 
     return modelTiers[modelId] || null;

package/public/js/pr.js

@@ -3432,37 +3432,74 @@ class PRManager {
     }
 
     try {
-      // Check if PR has new commits before analysis
+      // Run stale check and settings fetch in parallel to minimize dialog delay.
+      // Use AbortController so the fetch is truly cancelled on timeout,
+      // freeing the HTTP connection for subsequent requests.
+      const STALE_TIMEOUT = 2000;
+      const staleAbort = new AbortController();
+      const staleTimer = setTimeout(() => {
+        console.debug(`[Analyze] stale-check timed out after ${STALE_TIMEOUT}ms, aborting`);
+        staleAbort.abort();
+      }, STALE_TIMEOUT);
+      const staleCheckPromise = fetch(`/api/pr/${owner}/${repo}/${number}/check-stale`, { signal: staleAbort.signal })
+        .then(r => {
+          clearTimeout(staleTimer);
+          if (!r.ok) {
+            console.warn(`Stale check failed with status ${r.status}`);
+            return { _fetchError: true, status: r.status };
+          }
+          return r.json();
+        })
+        .catch(err => {
+          clearTimeout(staleTimer);
+          if (err.name === 'AbortError') {
+            console.debug('[Analyze] stale-check aborted (timeout)');
+          } else {
+            console.warn('[Analyze] stale-check fetch error:', err);
+          }
+          return null;
+        });
+
+      // Show analysis config modal
+      if (!this.analysisConfigModal) {
+        clearTimeout(staleTimer);
+        console.warn('AnalysisConfigModal not initialized, proceeding without config');
+        await this.startAnalysis(owner, repo, number, btn, {});
+        return;
+      }
+
+      // Fetch stale check, repo settings, and last instructions in parallel
+      const [staleResult, repoSettings, lastInstructions] = await Promise.all([
+        staleCheckPromise,
+        this.fetchRepoSettings().catch(() => null),
+        this.fetchLastCustomInstructions().catch(() => '')
+      ]);
+
+      // Process stale check result
       try {
-        const staleResponse = await fetch(`/api/pr/${owner}/${repo}/${number}/check-stale`);
-        if (!staleResponse.ok) {
-          // Handle non-OK responses (401/403/500 etc)
-          const errorText = await staleResponse.text().catch(() => 'Unknown error');
-          console.warn(`Stale check failed with status ${staleResponse.status}:`, errorText);
+        if (staleResult === null) {
+          // Timed out or network error — fail open
+          if (window.toast) {
+            window.toast.showWarning('Could not verify PR is current. Proceeding with analysis.');
+          }
+        } else if (staleResult._fetchError) {
           if (window.toast) {
-            window.toast.showWarning(`Could not verify PR is current (${staleResponse.status}). Proceeding with analysis.`);
+            window.toast.showWarning(`Could not verify PR is current (${staleResult.status}). Proceeding with analysis.`);
           }
-          // Fall through to continue with analysis
         } else {
-          const staleData = await staleResponse.json();
-
           // Handle PR state - show info for closed/merged PRs but still allow analysis
-          if (staleData.prState && (staleData.prState !== 'open' || staleData.merged)) {
-            const stateLabel = staleData.merged ? 'merged' : 'closed';
+          if (staleResult.prState && (staleResult.prState !== 'open' || staleResult.merged)) {
+            const stateLabel = staleResult.merged ? 'merged' : 'closed';
             if (window.toast) {
               window.toast.showWarning(`This PR is ${stateLabel}. Analysis will proceed on the existing data.`);
             }
           }
 
-          // Handle isStale === null (unknown - couldn't check)
-          if (staleData.isStale === null) {
-            // Couldn't verify - show toast and proceed
+          if (staleResult.isStale === null) {
             if (window.toast) {
               window.toast.showWarning('Could not verify PR is current. Proceeding with analysis.');
             }
-            // Continue with analysis
-          } else if (staleData.isStale === true) {
-            // PR is stale - show single dialog with 3 options
+          } else if (staleResult.isStale === true) {
             if (!window.confirmDialog) {
               console.warn('ConfirmDialog not available for stale PR check');
             } else {
@@ -3476,40 +3513,22 @@ class PRManager {
               });
 
               if (choice === 'confirm') {
-                // User wants to refresh first
                 await this.refreshPR();
-                // After refresh, continue with analysis
               } else if (choice === 'secondary') {
-                // User chose to analyze anyway - continue with stale data
+                // User chose to analyze anyway
               } else {
-                // User cancelled
                 return;
               }
             }
           }
-          // If isStale === false, PR is up-to-date, just continue
         }
       } catch (staleError) {
-        // Fail-open: show toast warning and continue with analysis
-        console.warn('Error checking PR staleness:', staleError);
+        console.warn('Error processing PR staleness:', staleError);
         if (window.toast) {
           window.toast.showWarning('Could not verify PR is current. Proceeding with analysis.');
         }
       }
 
-      // Show analysis config modal
-      if (!this.analysisConfigModal) {
-        console.warn('AnalysisConfigModal not initialized, proceeding without config');
-        await this.startAnalysis(owner, repo, number, btn, {});
-        return;
-      }
-
-      // Fetch repo settings and last used instructions in parallel
-      const [repoSettings, lastInstructions] = await Promise.all([
-        this.fetchRepoSettings(),
-        this.fetchLastCustomInstructions()
-      ]);
-
       // Determine the model and provider to use (priority: remembered > repo default > defaults)
       const modelStorageKey = PRManager.getRepoStorageKey('pair-review-model', owner, repo);
       const providerStorageKey = PRManager.getRepoStorageKey('pair-review-provider', owner, repo);

package/public/local.html

@@ -165,6 +165,49 @@
             unicode-bidi: bidi-override;
         }
 
+        /* Editable review name in header */
+        .local-review-name {
+            font-size: 15px;
+            font-weight: 500;
+            color: var(--color-text-primary);
+            cursor: text;
+            padding: 2px 6px;
+            border-radius: 4px;
+            border: 1px dashed var(--color-border-primary);
+            transition: all 0.15s ease;
+            max-width: 360px;
+            overflow: hidden;
+            text-overflow: ellipsis;
+            white-space: nowrap;
+            position: relative;
+        }
+
+        .local-review-name:hover {
+            background: var(--color-bg-secondary);
+            border-color: var(--ai-primary);
+            border-style: solid;
+        }
+
+        .local-review-name.unnamed {
+            color: var(--color-text-tertiary);
+            font-style: italic;
+        }
+
+        .local-review-name-input {
+            font-family: 'DM Sans', -apple-system, sans-serif;
+            font-size: 15px;
+            font-weight: 500;
+            padding: 2px 6px;
+            border: 1px solid #d97706;
+            border-radius: 4px;
+            background: var(--color-bg-primary);
+            color: var(--color-text-primary);
+            outline: none;
+            box-shadow: 0 0 0 2px rgba(217, 119, 6, 0.15);
+            width: 280px;
+            max-width: 360px;
+        }
+
     </style>
 </head>
 <body>
@@ -205,8 +248,8 @@
                 </div>
             </div>
             <div class="header-center">
-                <!-- Title area intentionally left empty for local mode -->
-                <!-- The "Local Mode" badge and header info provide sufficient context -->
+                <!-- Editable review name/title -->
+                <span class="local-review-name" id="local-review-name" title="Click to rename">Untitled</span>
             </div>
             <div class="header-right">
                 <div class="header-icon-group">

package/src/ai/index.js

@@ -41,6 +41,7 @@ require('./codex-provider');
 require('./copilot-provider');
 require('./opencode-provider');
 require('./cursor-agent-provider');
+require('./pi-provider');
 
 // Export the unified API
 module.exports = {