@imwz/wp-pattern-sentinel 1.1.4 → 1.1.5

package/README.md

@@ -212,6 +212,10 @@ node -e "
 
 `block_validation` errors also surface Gutenberg's human-readable issue messages (e.g. `"Expected attribute 'class' of value '…' but got '…'"`), so you no longer need to open the browser console to identify what failed.
 
+A block can also pass validation only because one of its block type's deprecations accepted the markup and migrated it. The editor reports such a block as valid, but it saves different markup, and it shows as broken the next time the page is opened. Sentinel re-validates every parsed block against its original markup and reports these as `block_validation` errors reading "Block was migrated by a deprecation and will save different markup". A common cause is an attribute the block does not support, such as `aria-hidden` on `core/paragraph`.
+
+`--cache` entries record the Sentinel version that passed them, so upgrading Sentinel re-validates every pattern once.
+
 ## npm publish
 
 When ready to publish:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@imwz/wp-pattern-sentinel",
-  "version": "1.1.4",
+  "version": "1.1.5",
   "description": "Browser-based WordPress block pattern validator using Playwright",
   "type": "module",
   "engines": {

package/src/main.js

@@ -17,6 +17,12 @@ import { log, formatResult, printSummary } from './format.js';
 
 const CACHE_FILE = '.sentinel-cache.json';
 
+// Cache entries record the Sentinel version that passed them, so a release
+// that adds or tightens a check re-validates patterns that passed before it.
+const SENTINEL_VERSION = JSON.parse(
+  fs.readFileSync(new URL('../package.json', import.meta.url), 'utf8')
+).version;
+
 function loadCache() {
   try {
     return JSON.parse(fs.readFileSync(path.join(process.cwd(), CACHE_FILE), 'utf8'));
@@ -67,7 +73,7 @@ export async function main() {
       try {
         const content = fs.readFileSync(file, 'utf8');
         const key     = path.relative(process.cwd(), file);
-        if (cache[key]?.passed && cache[key]?.hash === hashContent(content)) {
+        if (cache[key]?.passed && cache[key]?.hash === hashContent(content) && cache[key]?.version === SENTINEL_VERSION) {
           skipped.push(file);
         } else {
           pending.push(file);
@@ -153,7 +159,7 @@ export async function main() {
     for (const result of results) {
       const key = path.relative(process.cwd(), result.patternPath);
       if (result.passed) {
-        cache[key] = { hash: result.hash, passed: true, checkedAt: new Date().toISOString() };
+        cache[key] = { hash: result.hash, passed: true, version: SENTINEL_VERSION, checkedAt: new Date().toISOString() };
       } else {
         delete cache[key];
       }

package/src/validation.js

@@ -1,30 +1,59 @@
 import { log } from './format.js';
 
 /**
- * Walk the block tree and collect any blocks where isValid === false.
+ * Walk the block tree and collect any blocks where isValid === false, plus any
+ * block a deprecation silently migrated.
+ *
+ * When a block fails validation, the parser tries the block type's
+ * deprecations; if one accepts the markup, the block is migrated and reported
+ * as isValid: true with no issues, yet its attributes have changed and it will
+ * save different markup. The editor then shows the block as broken on the next
+ * load. Example: core/paragraph with aria-hidden="true" is taken by an old
+ * paragraph deprecation that drops fontFamily and keeps the whole <p> as the
+ * block's text, so the first save writes a <p> nested inside another <p>.
+ * Re-running validateBlock() on the parsed block compares what it will save
+ * against the original markup, which catches this.
  */
 export async function checkBlockValidation(page, verbose = false) {
   const start = Date.now();
   if (verbose) log('    → Checking block validation...', 'gray');
   try {
     const errors = await page.evaluate(() => {
-      const walk = blocks => blocks.flatMap(block => [
-        ...(block.isValid === false
-          ? [{
-              blockId:          block.clientId,
-              blockName:        block.name,
-              error:            'Block validation failed',
-              validationIssues: (block.validationIssues ?? []).map(issue => {
-                try {
-                  return (issue.args ?? [])
-                    .map(a => (typeof a === 'string' ? a : JSON.stringify(a)))
-                    .join(' ');
-                } catch { return 'unknown issue'; }
-              }),
-            }]
-          : []),
-        ...walk(block.innerBlocks ?? []),
-      ]);
+      const formatIssues = issues => (issues ?? []).map(issue => {
+        try {
+          return (issue.args ?? [])
+            .map(a => (typeof a === 'string' ? a : JSON.stringify(a)))
+            .join(' ');
+        } catch { return 'unknown issue'; }
+      });
+      const validateBlock = window.wp.blocks.validateBlock;
+      const migratedIssues = block => {
+        if (!validateBlock || block.isValid !== true || block.name === 'core/missing') return null;
+        const [isValid, issues] = validateBlock(block);
+        return isValid ? null : issues;
+      };
+      const walk = blocks => blocks.flatMap(block => {
+        const migrated = migratedIssues(block);
+        return [
+          ...(block.isValid === false
+            ? [{
+                blockId:          block.clientId,
+                blockName:        block.name,
+                error:            'Block validation failed',
+                validationIssues: formatIssues(block.validationIssues),
+              }]
+            : []),
+          ...(migrated
+            ? [{
+                blockId:          block.clientId,
+                blockName:        block.name,
+                error:            'Block was migrated by a deprecation and will save different markup',
+                validationIssues: formatIssues(migrated),
+              }]
+            : []),
+          ...walk(block.innerBlocks ?? []),
+        ];
+      });
       return walk(window.wp.data.select('core/block-editor').getBlocks());
     });
     if (verbose) log(`    → Block validation complete (${Date.now() - start}ms)`, 'gray');