@impeccable/reviews 0.1.3 → 0.1.5

package/dist/ui/look.js

@@ -10,6 +10,8 @@ import { fitsTask, taskInProgress, workStarted } from '../stages.js';
  */
 export const PRODUCT = 'Impeccable for PRs';
 export const FEEDBACK = 'support@renaissance-geek.ai';
+/** How long the outro waits for a key before it closes itself (screens.ts), which its fine print says. */
+export const CLOSES_AFTER_MINUTES = 20;
 /** The box fills the terminal up to this size, then sits in the middle of it. */
 const BOX_WIDTH = 100;
 const BOX_HEIGHT = 32;
@@ -189,6 +191,8 @@ function questionPage(qv, inner, st) {
     const field = Math.min(FIELD_WIDTH, inner);
     const edged = q.hint && visibleWidth(q.hint) <= field - 6 ? q.hint : '';
     const label = q.hint && !edged ? wrapTextWithAnsi(q.hint, field - 2).map((line) => `  ${st.soft(line)}`) : [];
+    // What never goes into the field stays under it, whatever is typed.
+    const caution = q.caution && !choices ? balanced(q.caution, field).map((line) => center(st.soft(line), inner)) : [];
     const lines = (choices ?? []).map((option, i) => {
         const here = i === qv.cursor;
         const mark = q.kind === 'single' ? (here ? '●' : '○') : qv.picked.has(i) ? '[x]' : '[ ]';
@@ -199,7 +203,7 @@ function questionPage(qv, inner, st) {
         heading: q.title ?? 'A question for you',
         text: said(q.prompt, inner, st),
         rule: divider(inner, st),
-        action: choices ? [...hint, ...block(lines, inner, widest), ...after] : [...block([...label, ...fieldBox(edged, qv.field(field - 2), field, true, st)], inner, field), ...after],
+        action: choices ? [...hint, ...block(lines, inner, widest), ...after] : [...block([...label, ...fieldBox(edged, qv.field(field - 2), field, true, st)], inner, field), ...caution, ...after],
         at: choices ? hint.length + qv.cursor : label.length + 1,
         asks: true,
         ways: [['Continue', 'Enter'], ...(q.skippable ? [['Skip', 'Esc']] : [])],
@@ -261,6 +265,7 @@ function outroPage(scene, inner, st) {
             rule: divider(inner, st),
             action: pullAction(outro.link, scene.copied, inner, st),
             ways: scene.leaving ? undefined : [['Close', 'Enter']],
+            foot: closesItself(scene, inner, st),
         };
     }
     const width = Math.min(TEXT_WIDTH, inner);
@@ -272,9 +277,11 @@ function outroPage(scene, inner, st) {
         rule: divider(inner, st),
         action: [...block(notes, inner), ...(notes.length && links.length ? [''] : []), ...links, ...(outro.links.length === 1 ? [scene.copied ? center(st.soft('Copied to clipboard!'), inner) : copyWay(inner, st)] : [])],
         ways: scene.leaving ? undefined : [['Close', 'Enter']],
-        foot: outro.outcome === 'stopped' ? [center(st.faint(`Questions? Write to ${FEEDBACK}`), inner)] : undefined,
+        foot: outro.outcome === 'stopped' ? [center(st.faint(`Questions? Write to ${FEEDBACK}`), inner)] : closesItself(scene, inner, st),
     };
 }
+/** The outro's fine print that it closes on its own, until it is closing; a stopped run's foot keeps the way to write to us instead, one line either way. */
+const closesItself = (scene, inner, st) => (scene.leaving ? [] : [center(st.faint(`Closes on its own after ${CLOSES_AFTER_MINUTES} minutes.`), inner)]);
 function pageOf(f, inner) {
     const st = f.style;
     if (f.question)
@@ -291,11 +298,13 @@ function pageOf(f, inner) {
             // P still takes a pasted code on a remote shell; --help says so, the screen does not.
             const under = scene.note ?? (scene.copied ? 'Copied to clipboard!' : '');
             const link = block(urlRows(scene.link, ruleWidth(inner), st.soft, st), inner);
+            // In the action, which scrolls and keeps every line, so a short terminal still shows which checkout this approves.
+            const checkout = scene.checkout && !scene.again ? [...balanced(scene.checkout.repository, Math.min(TEXT_WIDTH, inner)).map((line) => center(st.full(line), inner)), ...said(`in ${scene.checkout.folder}`, inner, st), ''] : [];
             return {
                 heading: scene.again ? 'Sign in again' : START.heading,
                 text: said(scene.again ? AGAIN[scene.again] : 'Sign in with GitHub in your browser, then approve this repository.', inner, st),
                 rule: divider(inner, st),
-                action: [...link, ...(under ? ['', center(st.full(under), inner)] : []), ...(scene.copied === false ? ['', copyWay(inner, st)] : [])],
+                action: [...checkout, ...link, ...(under ? ['', center(st.full(under), inner)] : []), ...(scene.copied === false ? ['', copyWay(inner, st)] : [])],
             };
         }
         case 'run':

package/dist/ui/screens.js

@@ -5,7 +5,7 @@ import { copyText } from '../login.js';
 import { workStarted } from '../stages.js';
 import { mountUi } from './bridge.js';
 import { createFrameWriter, frameState } from './frames.js';
-import { drawFrame, OUTCOME, PRODUCT, palette } from './look.js';
+import { CLOSES_AFTER_MINUTES, drawFrame, OUTCOME, PRODUCT, palette } from './look.js';
 import { RunState } from './run-state.js';
 /** What the command does before a screen ends it at once (Ctrl+C before a run, or a signal): report the stop (main.ts), briefly. */
 let beforeExit = async () => { };
@@ -18,6 +18,8 @@ const TICK_MS = 80;
 const FIRST_STATUS = 'Reading the repository';
 /** A first Esc on the run screen only asks for a second one within this long. */
 const STOP_WINDOW_MS = 3000;
+/** The test drive and the outro close themselves after this long without a key, as Enter would: someone who walked away does not come back to a wizard still open. */
+const CLOSE_AFTER_MS = CLOSES_AFTER_MINUTES * 60_000;
 /** This package's version, for the corner of the frame. */
 const VERSION = JSON.parse(readFileSync(new URL('../../package.json', import.meta.url), 'utf8')).version;
 const interactive = () => Boolean(process.stdin.isTTY && process.stdout.isTTY);
@@ -337,7 +339,7 @@ class Wizard {
         if (view.kind === 'intro')
             return { kind: 'intro', note: view.note };
         if (view.kind === 'signin')
-            return { kind: 'signin', link: view.link, copied: view.copied, again: view.again, note: view.pasting ? undefined : view.note };
+            return { kind: 'signin', link: view.link, copied: view.copied, again: view.again, note: view.pasting ? undefined : view.note, checkout: view.opts.checkout };
         if (view.kind === 'pull')
             return { kind: 'pull', url: view.url, copied: view.copied };
         if (view.kind === 'outro')
@@ -484,28 +486,25 @@ async function handOver(url, hand) {
     const copied = hand.copy(url).catch(() => false);
     return (await Promise.race([copied, new Promise((r) => setTimeout(() => r(false), 1000).unref())])) === true;
 }
-/** The test drive on a screen of its own once the run has ended, before the last screen shows the setup pull request, handed over as it appears, until a key other than ↑↓ PgUp PgDn is pressed. Without a terminal there is no such screen: the summary has it. */
+/** The test drive on a screen of its own once the run has ended, before the last screen shows the setup pull request, handed over as it appears, until a key other than ↑↓ PgUp PgDn is pressed, or for 20 minutes. Without a terminal there is no such screen: the summary has it. */
 export async function showPullRequest(url, hand) {
     const screen = host();
     if (!screen)
         return;
     const copied = await handOver(url, hand);
     await new Promise((resolve) => {
-        const view = {
-            kind: 'pull',
-            url,
-            copied,
-            copy: () => hand.copy(url),
-            done: () => {
-                screen.remove(view);
-                resolve();
-            },
+        const done = () => {
+            clearTimeout(timer);
+            screen.remove(view);
+            resolve();
         };
+        const timer = setTimeout(done, CLOSE_AFTER_MS).unref();
+        const view = { kind: 'pull', url, copied, copy: () => hand.copy(url), done };
         screen.views = [];
         screen.push(view);
     });
 }
-/** The last screen: what happened, what is left, any warnings and its pull request (handed over as it appears) or the links, until a key other than ↑↓ PgUp PgDn is pressed. Its summary then stays in the scrollback. */
+/** The last screen: what happened, what is left, any warnings and its pull request (handed over as it appears) or the links, until a key other than ↑↓ PgUp PgDn is pressed, or for 20 minutes. Its summary then stays in the scrollback. */
 export async function showOutro(o, hand) {
     const screen = host();
     if (screen) {
@@ -513,17 +512,13 @@ export async function showOutro(o, hand) {
         // The link C copies: the pull request, or the one link a screen without it lists.
         const link = o.link ?? (o.links.length === 1 ? o.links[0].url : undefined);
         await new Promise((resolve) => {
-            const view = {
-                kind: 'outro',
-                outro: o,
-                leaving: false,
-                copied,
-                copy: link ? () => (hand?.copy ?? copyText)(link) : undefined,
-                done: () => {
-                    view.leaving = true;
-                    void screen.close().then(resolve);
-                },
+            const done = () => {
+                clearTimeout(timer);
+                view.leaving = true;
+                void screen.close().then(resolve);
             };
+            const timer = setTimeout(done, CLOSE_AFTER_MS).unref();
+            const view = { kind: 'outro', outro: o, leaving: false, copied, copy: link ? () => (hand?.copy ?? copyText)(link) : undefined, done };
             screen.views = [];
             screen.push(view);
         });

package/dist/vercel.js

@@ -110,7 +110,7 @@ export async function readVercelProject(vercel, link) {
     const branch = record(project.link)?.productionBranch;
     const protection = scope(project);
     const hosts = [target, ...latest].flatMap((d) => (typeof d?.url === 'string' && d.url ? [d.url.replace(/^https?:\/\//, '').toLowerCase()] : []));
-    return { production: exists ? 'exists' : 'none', ...(typeof branch === 'string' && branch ? { productionBranch: branch } : {}), protection: typeof protection === 'string' ? protection : null, deploymentHosts: new Set(hosts) };
+    return { ...(typeof project.name === 'string' && project.name ? { name: project.name } : {}), production: exists ? 'exists' : 'none', ...(typeof branch === 'string' && branch ? { productionBranch: branch } : {}), protection: typeof protection === 'string' ? protection : null, deploymentHosts: new Set(hosts) };
 }
 /**
  * The linked project before its first push: read through `vercel api`, and, with no production deployment, locked
@@ -118,15 +118,17 @@ export async function readVercelProject(vercel, link) {
  * branch it builds and Standard Protection serves production domains to anyone. A project that deploys production
  * already (live or building), or is locked already, is left as it is.
  */
-export async function prepareFirstDeployment(vercel, link) {
+export async function prepareFirstDeployment(vercel, link, lock = true) {
     const project = await readVercelProject(vercel, link);
     if (!project)
         return { production: 'unknown', locked: false, reason: 'The Vercel CLI could not read the project (vercel api): it is signed out, or this CLI has no api command.' };
-    const branch = project.productionBranch ? { productionBranch: project.productionBranch } : {};
+    const branch = { ...(project.productionBranch ? { productionBranch: project.productionBranch } : {}), ...(project.name ? { project: project.name } : {}) };
     if (project.production === 'exists')
         return { production: 'exists', ...branch };
     if (project.protection === 'all')
         return { production: 'none', locked: true, ...branch };
+    if (!lock)
+        return { production: 'none', locked: false, ...branch, reason: "Vercel's login is not in front of the project's addresses yet." };
     try {
         if (scope(await printedProject(vercel, lockProjectApi(link))) === 'all')
             return { production: 'none', locked: true, ...branch };
@@ -136,6 +138,28 @@ export async function prepareFirstDeployment(vercel, link) {
     }
     return { production: 'none', locked: false, ...branch, reason: "Vercel did not put its login in front of the project's addresses: that takes the Member role or Project Administrator." };
 }
+/**
+ * A page of the project in Vercel's dashboard: by its team and name when the run knows both, else the dashboard's link
+ * that has the person pick them.
+ */
+export function vercelProjectPage(page, team, project) {
+    return team && project ? `https://vercel.com/${encodeURIComponent(team)}/${encodeURIComponent(project)}/${page}` : `https://vercel.com/d?to=${encodeURIComponent(`/[team]/[project]/${page}`)}`;
+}
+/** Reads the project again every `wait.everyMs` until Vercel's login stands in front of every address of it, or it deploys production, or `wait.totalMs` has passed (a read that failed counts as neither): the person is locking it meanwhile. */
+export async function waitForVercelLock(vercel, link, deps) {
+    for (const end = Date.now() + deps.wait.totalMs;;) {
+        const first = await prepareFirstDeployment(vercel, link, false);
+        // A read that failed says nothing yet, so the wait goes on.
+        if (first.production === 'exists' || first.locked || Date.now() >= end || deps.signal?.aborted)
+            return first;
+        try {
+            await (deps.sleep ?? ((ms) => sleep(ms, undefined, { signal: deps.signal })))(deps.wait.everyMs);
+        }
+        catch {
+            return first;
+        }
+    }
+}
 /**
  * The hosts of the linked project's deployments while Vercel's login stands in front of every address of it, read
  * now: a Production deployment GitHub lists for a pushed branch is its preview only when it is one of these. Empty

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@impeccable/reviews",
-  "version": "0.1.3",
+  "version": "0.1.5",
   "description": "Set up a repository for Impeccable for PRs from your terminal.",
   "license": "SEE LICENSE IN LICENSE",
   "private": false,
@@ -25,8 +25,8 @@
   },
   "dependencies": {
     "@anthropic-ai/sandbox-runtime": "0.0.78",
-    "@earendil-works/pi-coding-agent": "~0.87.1",
-    "@earendil-works/pi-tui": "~0.87.1"
+    "@earendil-works/pi-coding-agent": "0.87.1",
+    "@earendil-works/pi-tui": "0.87.1"
   },
   "devDependencies": {
     "@types/node": "^22.20.4",