@impeccable/reviews 0.1.27 → 0.1.29

package/dist/ui/run-state.js

@@ -3,6 +3,22 @@ import { statusLine } from '../sync.js';
 export function statusFromEvent(event) {
     return event.type === 'message_end' ? statusLine(event.message) : null;
 }
+/**
+ * The order a task list reads in, in the terminal and on the web page alike (REN-1119): the tasks that left pending
+ * (skipped too), in the order they first did, then those still waiting, each group in the order given. A task that
+ * waits under the task in progress (Preview method while Test drive runs) never shows above it unticked (#419).
+ */
+export class TaskOrder {
+    moved = new Set();
+    sort(tasks) {
+        for (const t of tasks)
+            if (t.status !== 'pending')
+                this.moved.add(t.id);
+        const order = [...this.moved];
+        const rank = (t) => (this.moved.has(t.id) ? order.indexOf(t.id) : order.length);
+        return tasks.map((t, i) => ({ t, i })).sort((a, b) => rank(a.t) - rank(b.t) || a.i - b.i).map(({ t }) => t);
+    }
+}
 /** After this long with nothing new on screen, the status band says the run is still working. */
 const SILENCE_MS = 60_000;
 /** How long something has taken, the way the screen says it: "45 s", "2 min", "1 h 5 min". */
@@ -30,8 +46,8 @@ export class RunState {
     waiting;
     /** The tasks that have been in progress, done or failed in this run. */
     started = new Set();
-    /** The tasks that have left pending in this run (skipped too), in the order they first did: the list shows them in that order. */
-    moved = new Set();
+    /** The order the list shows the tasks in. */
+    order = new TaskOrder();
     /** When something last changed on screen: a status, the task list, an answered question. */
     changedAt;
     constructor(now = Date.now, first) {
@@ -68,15 +84,9 @@ export class RunState {
         for (const t of tasks)
             if (t.status === 'in_progress' || t.status === 'completed' || t.status === 'failed')
                 this.started.add(t.id);
-        for (const t of tasks)
-            if (t.status !== 'pending')
-                this.moved.add(t.id);
         // A task that has started never reads as not started again (#390).
         const shown = tasks.map((t) => ({ ...t, ...(t.status === 'pending' && this.started.has(t.id) ? { started: true } : {}) }));
-        // The tasks that moved on, in the order they did, then those still waiting: one that waits under the task in progress never shows above it unticked (#419).
-        const order = [...this.moved];
-        const rank = (t) => (this.moved.has(t.id) ? order.indexOf(t.id) : order.length);
-        this.tasks = shown.map((t, i) => ({ t, i })).sort((a, b) => rank(a.t) - rank(b.t) || a.i - b.i).map(({ t }) => t);
+        this.tasks = this.order.sort(shown);
         this.touch();
     }
     /** Something happened that the person saw, so the silence starts again. */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@impeccable/reviews",
-  "version": "0.1.27",
+  "version": "0.1.29",
   "description": "Set up a repository for Impeccable for PRs from your terminal.",
   "license": "SEE LICENSE IN LICENSE",
   "private": false,