@impeccable/reviews 0.1.22 → 0.1.24

package/dist/ui/look.js

@@ -9,7 +9,6 @@ import { fitsTask, taskInProgress, workStarted } from '../stages.js';
  * the box on the right. Only the middle changes from screen to screen.
  */
 export const PRODUCT = 'Impeccable for PRs';
-export const FEEDBACK = 'support@renaissance-geek.ai';
 /** How long the outro waits for a key before it closes itself (screens.ts), which its fine print says. */
 export const CLOSES_AFTER_MINUTES = 20;
 /** The box fills the terminal up to this size, then sits in the middle of it. */
@@ -80,7 +79,8 @@ function dotRows(word, max) {
 /** A paragraph of plain text wrapped to at most `max` columns: a sentence a line when each fits, else lines as even as the words allow. */
 function balanced(given, max) {
     const text = given.split(' ').map((word) => dotRows(word, max).join('\n')).join(' ');
-    const sentences = text.split(/(?<=[.!?])\s+/);
+    // A sentence ends on a mark after its last word: the "!" a warning opens with is no sentence of its own.
+    const sentences = text.split(/(?<=\S[.!?])\s+/);
     if (sentences.length > 1 && sentences.every((line) => visibleWidth(line) <= max))
         return sentences;
     const lines = wrapTextWithAnsi(text, Math.max(10, max));
@@ -194,7 +194,7 @@ function questionPage(qv, inner, st) {
             ways: [[q.confirmLabel ?? 'Continue', 'Enter'], [q.skipLabel ?? 'Skip', 'Esc']],
         };
     }
-    // One test account: both fields under the divider, each in a box with its label in the top edge, the password as dots.
+    // One account: its prompt under the title, then the hint and both fields under the divider, each field in a box with its label in the top edge, the second as dots. A test account of the app's sign-in (no fields of its own) leaves its prompt to the web page and its prompt's row blank, so its title stands alone where a one-line prompt would put the divider (#409).
     if (q.kind === 'account') {
         const width = Math.min(FIELD_WIDTH, inner);
         const label = (text) => `  ${st.soft(text)}`;
@@ -203,7 +203,7 @@ function questionPage(qv, inner, st) {
         const fields = [...fieldBox(first, qv.field(width - 2), width, qv.focus !== 1, st), ...fieldBox(second, qv.password?.() ?? '', width, qv.focus === 1, st)];
         return {
             heading: q.title ?? 'A test account',
-            text: said(q.prompt, inner, st),
+            text: q.fields ? said(q.prompt, inner, st) : [''],
             rule: divider(inner, st),
             action: [...block([...hint, ...fields], inner, width), ...note],
             at: hint.length + (qv.focus === 1 ? 4 : 1),
@@ -315,10 +315,11 @@ function outroPage(scene, inner, st) {
         rule: divider(inner, st),
         action: [...block(notes, inner), ...(notes.length && links.length ? [''] : []), ...links, ...(outro.links.length === 1 ? [scene.copied ? center(st.soft('Copied to clipboard!'), inner) : copyWay(inner, st)] : [])],
         ways: scene.leaving ? undefined : [['Close', 'Enter']],
-        foot: outro.outcome === 'stopped' ? [center(st.faint(`Questions? Write to ${FEEDBACK}`), inner)] : closesItself(scene, inner, st),
+        // A stopped run's foot is empty: no line to write to us in the closed beta (#413).
+        foot: outro.outcome === 'stopped' ? [] : closesItself(scene, inner, st),
     };
 }
-/** The outro's fine print that it closes on its own, until it is closing; a stopped run's foot keeps the way to write to us instead, one line either way. */
+/** The outro's fine print that it closes on its own, until it is closing; a stopped run's has none. */
 const closesItself = (scene, inner, st) => (scene.leaving ? [] : [center(st.faint(`Closes on its own after ${CLOSES_AFTER_MINUTES} minutes.`), inner)]);
 function pageOf(f, inner) {
     const st = f.style;
@@ -390,9 +391,9 @@ function stack(page, inner, rows, st, scroll) {
         mark = [];
     if (over() > 0)
         rule = [];
-    // Past this point a question's prompt scrolls with its field or choices, a blank row under it.
-    const lead = over() > 0 && page.asks ? [...text, ''] : [];
-    if (lead.length)
+    // Past this point a question's prompt scrolls with its field or choices, a blank row under it; an account's blank prompt row goes.
+    const lead = over() > 0 && page.asks && text.some(Boolean) ? [...text, ''] : [];
+    if (over() > 0)
         text = [];
     const action = windowed([...lead, ...page.action], page.action.length - over(), lead.length + (page.at ?? 0), scroll, inner, st);
     const parts = [mark, heading, text, rule, action, ways, foot].filter((part) => part.length);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@impeccable/reviews",
-  "version": "0.1.22",
+  "version": "0.1.24",
   "description": "Set up a repository for Impeccable for PRs from your terminal.",
   "license": "SEE LICENSE IN LICENSE",
   "private": false,