@impeccable/reviews 0.1.21 → 0.1.23

package/dist/ui/bridge.js

@@ -121,7 +121,9 @@ async function askOnStdin(q) {
     const out = process.stdout;
     if (q.kind === 'confirm') {
         out.write(`\n${q.title ? `${q.title}\n` : ''}${q.hint ? `${q.hint}\n` : ''}${q.prompt}\n`);
-        const how = `Type y to ${(q.confirmLabel ?? 'continue').toLowerCase()}, or Enter to ${(q.skipLabel ?? 'skip').toLowerCase()}:`;
+        // Lowercased after "to", but for the I of "I'll install it myself".
+        const lower = (label) => label.toLowerCase().replace(/^i(?=['\s])/, 'I');
+        const how = `Type y to ${lower(q.confirmLabel ?? 'continue')}, or Enter to ${lower(q.skipLabel ?? 'skip')}:`;
         out.write(`${how} `);
         for (let line = await nextLine(); line !== null; line = await nextLine()) {
             if (/^y(es)?$/i.test(line.trim()))
@@ -130,7 +132,7 @@ async function askOnStdin(q) {
                 return { skipped: true };
             out.write(`That is not an answer to this one. ${how} `);
         }
-        return { skipped: true };
+        return { skipped: true, closed: true };
     }
     if (q.kind === 'account') {
         // An empty username keeps the one the field would hold; an empty password skips the account.
@@ -158,5 +160,5 @@ async function askOnStdin(q) {
         out.write(`That is not an answer to this one. ${how} `);
     }
     // Nobody is there to answer.
-    return { skipped: true };
+    return { skipped: true, closed: true };
 }

package/dist/ui/look.js

@@ -80,7 +80,8 @@ function dotRows(word, max) {
 /** A paragraph of plain text wrapped to at most `max` columns: a sentence a line when each fits, else lines as even as the words allow. */
 function balanced(given, max) {
     const text = given.split(' ').map((word) => dotRows(word, max).join('\n')).join(' ');
-    const sentences = text.split(/(?<=[.!?])\s+/);
+    // A sentence ends on a mark after its last word: the "!" a warning opens with is no sentence of its own.
+    const sentences = text.split(/(?<=\S[.!?])\s+/);
     if (sentences.length > 1 && sentences.every((line) => visibleWidth(line) <= max))
         return sentences;
     const lines = wrapTextWithAnsi(text, Math.max(10, max));
@@ -349,7 +350,7 @@ function pageOf(f, inner) {
             return runPage(scene, f, inner, st);
         case 'pull':
             return {
-                heading: 'Your first review is on its way',
+                heading: scene.app ? `${scene.app}'s first review is on its way` : 'Your first review is on its way',
                 text: said(SEE_THE_REVIEW, inner, st),
                 rule: divider(inner, st),
                 action: pullAction(scene.url, scene.copied, inner, st),

package/dist/ui/screens.js

@@ -117,7 +117,7 @@ class Wizard {
         process.off('SIGHUP', this.onSignal);
         mountUi(null);
         for (const question of this.questions.splice(0))
-            question.resolve({ skipped: true });
+            question.resolve({ skipped: true, closed: true });
         // Leaves the alternate screen without copying the last frame out of it: the scrollback gets the outro's summary only.
         this.tui.stop({ preserveScreen: true });
         this.restoreConsole();
@@ -240,7 +240,7 @@ class Wizard {
         }
         this.stopAsked = 0;
         for (const question of this.questions.splice(0))
-            question.resolve({ skipped: true });
+            question.resolve({ skipped: true, closed: true });
         this.state.status('Stopping the setup');
         this.redraw();
         run.cancel();
@@ -342,7 +342,7 @@ class Wizard {
         if (view.kind === 'signin')
             return { kind: 'signin', link: view.link, copied: view.copied, again: view.again, note: view.pasting ? undefined : view.note, checkout: view.opts.checkout };
         if (view.kind === 'pull')
-            return { kind: 'pull', url: view.url, copied: view.copied };
+            return { kind: 'pull', url: view.url, ...(view.app ? { app: view.app } : {}), copied: view.copied };
         if (view.kind === 'outro')
             return { kind: 'outro', outro: view.outro, leaving: view.leaving, copied: view.copied };
         return { kind: 'run', tasks: this.state.tasks, band: this.state.band(!this.questions.length, live), wait: this.state.timer(live) };
@@ -486,8 +486,8 @@ async function handOver(url, hand) {
     const copied = hand.copy(url).catch(() => false);
     return (await Promise.race([copied, new Promise((r) => setTimeout(() => r(false), 1000).unref())])) === true;
 }
-/** The test drive on a screen of its own once the run has ended, before the last screen shows the setup pull request, handed over as it appears, until a key other than ↑↓ PgUp PgDn is pressed, or for 20 minutes. Without a terminal there is no such screen: the summary has it. */
-export async function showPullRequest(url, hand) {
+/** The test drive on a screen of its own once the run has ended, before the last screen shows the setup pull request, handed over as it appears, until a key other than ↑↓ PgUp PgDn is pressed, or for 20 minutes; on a repository with several apps, each app's in turn, named (impeccable-reviews#397). Without a terminal there is no such screen: the summary has it. */
+export async function showPullRequest(url, hand, app) {
     const screen = host();
     if (!screen)
         return;
@@ -499,7 +499,7 @@ export async function showPullRequest(url, hand) {
             resolve();
         };
         const timer = setTimeout(done, CLOSE_AFTER_MS).unref();
-        const view = { kind: 'pull', url, copied, copy: () => hand.copy(url), done };
+        const view = { kind: 'pull', url, ...(app ? { app } : {}), copied, copy: () => hand.copy(url), done };
         screen.views = [];
         screen.push(view);
     });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@impeccable/reviews",
-  "version": "0.1.21",
+  "version": "0.1.23",
   "description": "Set up a repository for Impeccable for PRs from your terminal.",
   "license": "SEE LICENSE IN LICENSE",
   "private": false,