@immugio/three-math-extensions 0.3.0 → 0.3.2

package/CHANGELOG.md

@@ -7,7 +7,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
-## [0.3.0](https://github.com/Immugio/three-math-extensions/compare/0.2.38...0.3.0)
+## [0.3.2](https://github.com/Immugio/three-math-extensions/compare/0.3.1...0.3.2)
+
+### Merged
+
+- Update GitHub Actions to latest versions [`#5`](https://github.com/Immugio/three-math-extensions/pull/5)
+
+## [0.3.1](https://github.com/Immugio/three-math-extensions/compare/0.3.0...0.3.1) - 2025-11-20
+
+### Merged
+
+- GitHub Actions - Update workflow to Node 20.x [`#4`](https://github.com/Immugio/three-math-extensions/pull/4)
+- Line2D.spec.ts - Split tests into individual test files per method being tested [`#3`](https://github.com/Immugio/three-math-extensions/pull/3)
+
+### Commits
+
+- Update eslint and fix linting errors [`718ec97`](https://github.com/Immugio/three-math-extensions/commit/718ec978cf0d79cba66f87ac2978007860edfb34)
+- Improve Line2D.joinLines robustness [`a17fd31`](https://github.com/Immugio/three-math-extensions/commit/a17fd3107768e99deb561131581822079bdab2b1)
+- Update isContinuousClosedShape types to avoid using any [`25028b7`](https://github.com/Immugio/three-math-extensions/commit/25028b7ee7b389edaae2c04493e775fd685e4a22)
+- Fix isContinuousClosedShape signature for compatibility with Line2D and Line3D [`1d569e7`](https://github.com/Immugio/three-math-extensions/commit/1d569e7b0a7ba5f92eef1ce2493589fe2a080847)
+
+## [0.3.0](https://github.com/Immugio/three-math-extensions/compare/0.2.38...0.3.0) - 2024-12-11
 
 ### Commits
 

package/cjs/Line2D.js

@@ -250,7 +250,7 @@ class Line2D {
      */
     isPointBesideLineSection(point) {
         const l2 = (((this.end.x - this.start.x) * (this.end.x - this.start.x)) + ((this.end.y - this.start.y) * (this.end.y - this.start.y)));
-        if (l2 == 0)
+        if (l2 === 0)
             return false;
         const r = (((point.x - this.start.x) * (this.end.x - this.start.x)) + ((point.y - this.start.y) * (this.end.y - this.start.y))) / l2;
         return (0 <= r) && (r <= 1);
@@ -353,23 +353,27 @@ class Line2D {
         if (lines.length < 2) {
             return lines.map(x => x.clone());
         }
-        const toProcess = lines.slice();
-        const result = [];
-        while (toProcess.length > 0) {
-            const current = toProcess.pop();
-            let joined = false;
+        // Start with cloned lines as initial result
+        const result = lines.map(x => x.clone());
+        // Keep trying to join lines until no more joins are possible
+        let joinedInLastPass = true;
+        while (joinedInLastPass) {
+            joinedInLastPass = false;
+            // Try to join each pair of lines
             for (let i = 0; i < result.length; i++) {
-                const other = result[i];
-                const joinedLine = Line2D.joinLine(current, other);
-                if (joinedLine) {
-                    result[i] = joinedLine;
-                    joined = true;
-                    break;
+                for (let j = i + 1; j < result.length; j++) {
+                    const joinedLine = Line2D.joinLine(result[i], result[j]);
+                    if (joinedLine) {
+                        // Replace the first line with the joined line and remove the second
+                        result[i] = joinedLine;
+                        result.splice(j, 1);
+                        joinedInLastPass = true;
+                        // Start over from the beginning since we modified the array
+                        i = -1;
+                        break;
+                    }
                 }
             }
-            if (!joined) {
-                result.push(current.clone());
-            }
         }
         return result;
     }
@@ -452,7 +456,7 @@ class Line2D {
      */
     distanceToPointOnInfiniteLine(point) {
         const l2 = (((this.end.x - this.start.x) * (this.end.x - this.start.x)) + ((this.end.y - this.start.y) * (this.end.y - this.start.y)));
-        if (l2 == 0)
+        if (l2 === 0)
             return Infinity;
         const s = (((this.start.y - point.y) * (this.end.x - this.start.x)) - ((this.start.x - point.x) * (this.end.y - this.start.y))) / l2;
         return Math.abs(s) * Math.sqrt(l2);
@@ -673,7 +677,7 @@ class Line2D {
                 return;
             visited.add(line);
             group.push(line);
-            lines.forEach((neighbor) => {
+            lines.forEach(neighbor => {
                 if (!visited.has(neighbor)) {
                     if (line.connectsTo(neighbor, tolerance, breakpoints)) {
                         dfs(neighbor, group);
@@ -682,7 +686,7 @@ class Line2D {
             });
         };
         const connectedLines = [];
-        lines.forEach((line) => {
+        lines.forEach(line => {
             if (!visited.has(line)) {
                 const group = [];
                 dfs(line, group);

package/cjs/Line3D.js

@@ -425,7 +425,7 @@ class Line3D extends three_1.Line3 {
                 return;
             visited.add(line);
             group.push(line);
-            lines.forEach((neighbor) => {
+            lines.forEach(neighbor => {
                 if (!visited.has(neighbor)) {
                     if (line.connectsTo(neighbor, tolerance, breakpoints)) {
                         dfs(neighbor, group);
@@ -434,7 +434,7 @@ class Line3D extends three_1.Line3 {
             });
         };
         const connectedLines = [];
-        lines.forEach((line) => {
+        lines.forEach(line => {
             if (!visited.has(line)) {
                 const group = [];
                 dfs(line, group);

package/cjs/isContinuousClosedShape.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isContinuousClosedShape = void 0;
+// This matches the signatures on Vec2 and Vec3 (for example, isNear(v: Vector2, maxDistance?: number)).
 function isContinuousClosedShape(lines, tolerance = 0) {
     if (lines.length < 3) {
         return false; // A shape needs at least 3 lines to be closed

package/eslint.config.mjs

@@ -0,0 +1,112 @@
+import react from "eslint-plugin-react";
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+import stylistic from "@stylistic/eslint-plugin";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [
+    {
+        ignores: ["cjs/", "esm/", "types/"],
+    },
+    ...compat.extends("eslint:recommended",
+        "plugin:react/recommended",
+        "plugin:@typescript-eslint/recommended"),
+    {
+        plugins: {
+            react,
+            "@typescript-eslint": typescriptEslint,
+            "@stylistic": stylistic
+        },
+
+        languageOptions: {
+            globals: {
+                ...globals.browser,
+                ...globals.jest,
+            },
+
+            parser: tsParser,
+            ecmaVersion: 11,
+            sourceType: "module",
+
+            parserOptions: {
+                ecmaFeatures: {
+                    jsx: true,
+                },
+                lib: ["esnext", "dom"]
+            },
+        },
+
+        settings: {
+            react: {
+                pragma: "dom",
+                version: "17.0"
+            },
+        },
+
+        rules: {
+            "@stylistic/indent": ["warn", 4, { "SwitchCase": 1 }],
+            "@stylistic/linebreak-style": ["error", "windows"],
+            "@stylistic/quotes": ["error", "double"],
+            "@stylistic/semi": ["error", "always"],
+            "@stylistic/no-extra-semi": ["error"],
+            "@stylistic/no-trailing-spaces": ["error"],
+            "@stylistic/no-multiple-empty-lines": ["error", { max: 1 }],
+            "@stylistic/space-in-parens": ["error", "never"],
+            "@stylistic/space-infix-ops": ["error", { int32Hint: false }],
+            "@stylistic/no-mixed-spaces-and-tabs": ["error"],
+            "@stylistic/space-before-blocks": ["error", "always"],
+            "@stylistic/function-call-spacing": ["error", "never"],
+            "@stylistic/key-spacing": ["error", { "beforeColon": false, "afterColon": true }],
+            "@stylistic/array-bracket-spacing": ["error", "never"],
+            "@stylistic/arrow-spacing": ["error", { "before": true, "after": true }],
+            "@stylistic/block-spacing": ["error", "always"],
+            "@stylistic/brace-style": ["error", "1tbs", { "allowSingleLine": true }],
+            "@stylistic/semi-spacing": ["error", { "before": false, "after": true }],
+            "@stylistic/space-before-function-paren": ["error", "never"],
+            "@stylistic/switch-colon-spacing": ["error", { "after": true, "before": false }],
+            "@stylistic/template-curly-spacing": ["error", "never"],
+            "@stylistic/type-annotation-spacing": ["error", { "after": true }],
+            "@stylistic/object-curly-spacing": ["error", "always"],
+            "@stylistic/keyword-spacing": ["error", { "before": true, "after": true }],
+            "no-undef": "error",
+            "consistent-return": "error",
+            "no-invalid-this": "error",
+            "arrow-parens": ["error", "as-needed"],
+            "eol-last": ["error", "never"],
+            "@typescript-eslint/no-inferrable-types": "off",
+            "@typescript-eslint/no-empty-interface": "off",
+            "@typescript-eslint/no-this-alias": "off",
+            "no-inv": "off",
+            "no-prototype-builtins": "off",
+            "react/react-in-jsx-scope": "off",
+            "react/no-unknown-property": "off",
+            "react/no-unescaped-entities": "off",
+            "react/jsx-key": "off",
+            "react/prop-types": "off",
+            "react/no-is-mounted": "off",
+            "@typescript-eslint/explicit-member-accessibility": ["error", {
+                "accessibility": "explicit",
+                "overrides": {
+                    "constructors": "no-public"
+                }
+            }],
+            "react/self-closing-comp": ["warn", {
+                "component": true,
+                "html": true
+            }],
+            "@typescript-eslint/explicit-module-boundary-types": "error",
+            "eqeqeq": ["error", "always"]
+        },
+    }];

package/esm/Line2D.js

@@ -247,7 +247,7 @@ export class Line2D {
      */
     isPointBesideLineSection(point) {
         const l2 = (((this.end.x - this.start.x) * (this.end.x - this.start.x)) + ((this.end.y - this.start.y) * (this.end.y - this.start.y)));
-        if (l2 == 0)
+        if (l2 === 0)
             return false;
         const r = (((point.x - this.start.x) * (this.end.x - this.start.x)) + ((point.y - this.start.y) * (this.end.y - this.start.y))) / l2;
         return (0 <= r) && (r <= 1);
@@ -350,23 +350,27 @@ export class Line2D {
         if (lines.length < 2) {
             return lines.map(x => x.clone());
         }
-        const toProcess = lines.slice();
-        const result = [];
-        while (toProcess.length > 0) {
-            const current = toProcess.pop();
-            let joined = false;
+        // Start with cloned lines as initial result
+        const result = lines.map(x => x.clone());
+        // Keep trying to join lines until no more joins are possible
+        let joinedInLastPass = true;
+        while (joinedInLastPass) {
+            joinedInLastPass = false;
+            // Try to join each pair of lines
             for (let i = 0; i < result.length; i++) {
-                const other = result[i];
-                const joinedLine = Line2D.joinLine(current, other);
-                if (joinedLine) {
-                    result[i] = joinedLine;
-                    joined = true;
-                    break;
+                for (let j = i + 1; j < result.length; j++) {
+                    const joinedLine = Line2D.joinLine(result[i], result[j]);
+                    if (joinedLine) {
+                        // Replace the first line with the joined line and remove the second
+                        result[i] = joinedLine;
+                        result.splice(j, 1);
+                        joinedInLastPass = true;
+                        // Start over from the beginning since we modified the array
+                        i = -1;
+                        break;
+                    }
                 }
             }
-            if (!joined) {
-                result.push(current.clone());
-            }
         }
         return result;
     }
@@ -449,7 +453,7 @@ export class Line2D {
      */
     distanceToPointOnInfiniteLine(point) {
         const l2 = (((this.end.x - this.start.x) * (this.end.x - this.start.x)) + ((this.end.y - this.start.y) * (this.end.y - this.start.y)));
-        if (l2 == 0)
+        if (l2 === 0)
             return Infinity;
         const s = (((this.start.y - point.y) * (this.end.x - this.start.x)) - ((this.start.x - point.x) * (this.end.y - this.start.y))) / l2;
         return Math.abs(s) * Math.sqrt(l2);
@@ -670,7 +674,7 @@ export class Line2D {
                 return;
             visited.add(line);
             group.push(line);
-            lines.forEach((neighbor) => {
+            lines.forEach(neighbor => {
                 if (!visited.has(neighbor)) {
                     if (line.connectsTo(neighbor, tolerance, breakpoints)) {
                         dfs(neighbor, group);
@@ -679,7 +683,7 @@ export class Line2D {
             });
         };
         const connectedLines = [];
-        lines.forEach((line) => {
+        lines.forEach(line => {
             if (!visited.has(line)) {
                 const group = [];
                 dfs(line, group);

package/esm/Line3D.js

@@ -422,7 +422,7 @@ export class Line3D extends Line3 {
                 return;
             visited.add(line);
             group.push(line);
-            lines.forEach((neighbor) => {
+            lines.forEach(neighbor => {
                 if (!visited.has(neighbor)) {
                     if (line.connectsTo(neighbor, tolerance, breakpoints)) {
                         dfs(neighbor, group);
@@ -431,7 +431,7 @@ export class Line3D extends Line3 {
             });
         };
         const connectedLines = [];
-        lines.forEach((line) => {
+        lines.forEach(line => {
             if (!visited.has(line)) {
                 const group = [];
                 dfs(line, group);

package/esm/isContinuousClosedShape.js

@@ -1,3 +1,4 @@
+// This matches the signatures on Vec2 and Vec3 (for example, isNear(v: Vector2, maxDistance?: number)).
 export function isContinuousClosedShape(lines, tolerance = 0) {
     if (lines.length < 3) {
         return false; // A shape needs at least 3 lines to be closed

package/package.json

@@ -1,56 +1,62 @@
 {
-  "name": "@immugio/three-math-extensions",
-  "version": "0.3.0",
-  "description": "Set of utilities for 2d and 3d line math built on top of three.js",
-  "author": "Jan Mikeska <janmikeska@gmail.com>",
-  "license": "ISC",
-  "keywords": [
-    "threejs",
-    "three",
-    "math"
-  ],
-  "bugs": {
-    "url": "https://github.com/Immugio/three-math-extensions/issues"
-  },
-  "homepage": "https://github.com/Immugio/three-math-extensions#readme",
-  "sideEffects": false,
-  "source": "src/index.ts",
-  "main": "cjs/index.js",
-  "module": "esm/index.js",
-  "types": "types/index.d.ts",
-  "auto-changelog": {
-    "commitLimit": false,
-    "template": "keepachangelog"
-  },
-  "scripts": {
-    "test": "npx jest",
-    "build:esm": "tsc",
-    "build:cjs": "tsc -p tsconfig-cjs.json",
-    "clean": "rimraf types cjs esm",
-    "build": "npm run clean && npm run build:esm && npm run build:cjs",
-    "preversion": "npm run clean && npm run build && npm run test",
-    "version": "auto-changelog -p && git add CHANGELOG.md",
-    "postversion": "git push && git push --tags"
-  },
-  "devDependencies": {
-    "@types/jest": "^29.5.11",
-    "@types/offscreencanvas": "2019.7.3",
-    "@types/three": "0.152.0",
-    "@typescript-eslint/eslint-plugin": "^6.16.0",
-    "auto-changelog": "^2.4.0",
-    "jest": "^29.7.0",
-    "rimraf": "^5.0.5",
-    "ts-jest": "^29.1.1",
-    "typedoc": "^0.25.4",
-    "typedoc-plugin-markdown": "^3.17.1",
-    "typescript": "5.3.3",
-    "eslint": "^8.56.0"
-  },
-  "peerDependencies": {
-    "three": ">=0.152.0"
-  },
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/Immugio/three-math-extensions.git"
-  }
+    "name": "@immugio/three-math-extensions",
+    "version": "0.3.2",
+    "description": "Set of utilities for 2d and 3d line math built on top of three.js",
+    "author": "Jan Mikeska <janmikeska@gmail.com>",
+    "license": "ISC",
+    "keywords": [
+        "threejs",
+        "three",
+        "math"
+    ],
+    "bugs": {
+        "url": "https://github.com/Immugio/three-math-extensions/issues"
+    },
+    "homepage": "https://github.com/Immugio/three-math-extensions#readme",
+    "sideEffects": false,
+    "source": "src/index.ts",
+    "main": "cjs/index.js",
+    "module": "esm/index.js",
+    "types": "types/index.d.ts",
+    "auto-changelog": {
+        "commitLimit": false,
+        "template": "keepachangelog"
+    },
+    "scripts": {
+        "test": "npx jest",
+        "build:esm": "tsc",
+        "build:cjs": "tsc -p tsconfig-cjs.json",
+        "clean": "rimraf types cjs esm",
+        "build": "npm run clean && npm run build:esm && npm run build:cjs",
+        "preversion": "npm run clean && npm run build && npm run test",
+        "version": "auto-changelog -p && git add CHANGELOG.md",
+        "postversion": "git push && git push --tags"
+    },
+    "devDependencies": {
+        "@eslint/eslintrc": "^3.3.1",
+        "@eslint/js": "^9.39.1",
+        "@stylistic/eslint-plugin": "^5.6.1",
+        "@types/jest": "^29.5.11",
+        "@types/offscreencanvas": "2019.7.3",
+        "@types/three": "0.152.0",
+        "@typescript-eslint/eslint-plugin": "^8.47.0",
+        "@typescript-eslint/parser": "^8.47.0",
+        "auto-changelog": "^2.5.0",
+        "eslint": "^9.39.1",
+        "eslint-plugin-react": "^7.37.5",
+        "globals": "^16.5.0",
+        "jest": "^30.2.0",
+        "rimraf": "^6.1.2",
+        "ts-jest": "^29.4.5",
+        "typedoc": "^0.28.14",
+        "typedoc-plugin-markdown": "^4.9.0",
+        "typescript": "5.3.3"
+    },
+    "peerDependencies": {
+        "three": ">=0.152.0"
+    },
+    "repository": {
+        "type": "git",
+        "url": "git+https://github.com/Immugio/three-math-extensions.git"
+    }
 }

package/src/BoundingBox.ts

@@ -1,14 +1,14 @@
 import { Vec2 } from "./Vec2";
 
 export class BoundingBox {
-  constructor(public minX: number, public maxX: number, public minY: number, public maxY: number) {
-  }
+    constructor(public minX: number, public maxX: number, public minY: number, public maxY: number) {
+    }
 
-  public equals(other: BoundingBox): boolean {
-    return this.minX === other.minX && this.maxX === other.maxX && this.minY === other.minY && this.maxY === other.maxY;
-  }
+    public equals(other: BoundingBox): boolean {
+        return this.minX === other.minX && this.maxX === other.maxX && this.minY === other.minY && this.maxY === other.maxY;
+    }
 
-  public get size(): Vec2 {
-    return new Vec2(this.maxX - this.minX, this.maxY - this.minY);
-  }
+    public get size(): Vec2 {
+        return new Vec2(this.maxX - this.minX, this.maxY - this.minY);
+    }
 }

package/src/Line2D.ts

@@ -285,7 +285,7 @@ export class Line2D {
      */
     public isPointBesideLineSection(point: Point2): boolean {
         const l2 = (((this.end.x - this.start.x) * (this.end.x - this.start.x)) + ((this.end.y - this.start.y) * (this.end.y - this.start.y)));
-        if (l2 == 0) return false;
+        if (l2 === 0) return false;
         const r = (((point.x - this.start.x) * (this.end.x - this.start.x)) + ((point.y - this.start.y) * (this.end.y - this.start.y))) / l2;
 
         return (0 <= r) && (r <= 1);
@@ -409,27 +409,29 @@ export class Line2D {
             return lines.map(x => x.clone());
         }
 
-        const toProcess = lines.slice();
-        const result: Line2D[] = [];
-
-        while (toProcess.length > 0) {
+        // Start with cloned lines as initial result
+        const result: Line2D[] = lines.map(x => x.clone());
 
-            const current = toProcess.pop();
-            let joined = false;
+        // Keep trying to join lines until no more joins are possible
+        let joinedInLastPass = true;
+        while (joinedInLastPass) {
+            joinedInLastPass = false;
 
+            // Try to join each pair of lines
             for (let i = 0; i < result.length; i++) {
-                const other = result[i];
-                const joinedLine = Line2D.joinLine(current, other);
-                if (joinedLine) {
-                    result[i] = joinedLine;
-                    joined = true;
-                    break;
+                for (let j = i + 1; j < result.length; j++) {
+                    const joinedLine = Line2D.joinLine(result[i], result[j]);
+                    if (joinedLine) {
+                        // Replace the first line with the joined line and remove the second
+                        result[i] = joinedLine;
+                        result.splice(j, 1);
+                        joinedInLastPass = true;
+                        // Start over from the beginning since we modified the array
+                        i = -1;
+                        break;
+                    }
                 }
             }
-
-            if (!joined) {
-                result.push(current.clone());
-            }
         }
 
         return result;
@@ -527,7 +529,7 @@ export class Line2D {
      */
     public distanceToPointOnInfiniteLine(point: Point2): number {
         const l2 = (((this.end.x - this.start.x) * (this.end.x - this.start.x)) + ((this.end.y - this.start.y) * (this.end.y - this.start.y)));
-        if (l2 == 0) return Infinity;
+        if (l2 === 0) return Infinity;
         const s = (((this.start.y - point.y) * (this.end.x - this.start.x)) - ((this.start.x - point.x) * (this.end.y - this.start.y))) / l2;
         return Math.abs(s) * Math.sqrt(l2);
     }
@@ -789,7 +791,7 @@ export class Line2D {
             visited.add(line);
             group.push(line);
 
-            lines.forEach((neighbor) => {
+            lines.forEach(neighbor => {
                 if (!visited.has(neighbor)) {
                     if (line.connectsTo(neighbor, tolerance, breakpoints)) {
                         dfs(neighbor, group);
@@ -800,7 +802,7 @@ export class Line2D {
 
         const connectedLines: Line2D[][] = [];
 
-        lines.forEach((line) => {
+        lines.forEach(line => {
             if (!visited.has(line)) {
                 const group: Line2D[] = [];
                 dfs(line, group);

package/src/Line3D.ts

@@ -521,7 +521,7 @@ export class Line3D extends Line3 {
             visited.add(line);
             group.push(line);
 
-            lines.forEach((neighbor) => {
+            lines.forEach(neighbor => {
                 if (!visited.has(neighbor)) {
                     if (
                         line.connectsTo(neighbor, tolerance, breakpoints)
@@ -534,7 +534,7 @@ export class Line3D extends Line3 {
 
         const connectedLines: Line3D[][] = [];
 
-        lines.forEach((line) => {
+        lines.forEach(line => {
             if (!visited.has(line)) {
                 const group: Line3D[] = [];
                 dfs(line, group);

package/src/Point3.ts

@@ -2,5 +2,4 @@ export interface Point3 {
     x: number,
     y: number,
     z: number
-}
-
+}

package/src/Polygon.ts

@@ -15,7 +15,7 @@ export class Polygon {
     }
 
     public static fromPoints(contour: Point2[], holes?: Point2[][]): Polygon {
-        return new Polygon(contour.map(p => Vec2.fromPoint(p)), holes?.map(h => h.map(p => Vec2.fromPoint(p)))        );
+        return new Polygon(contour.map(p => Vec2.fromPoint(p)), holes?.map(h => h.map(p => Vec2.fromPoint(p))));
     }
 
     public static fromSize(width: number, height: number): Polygon {
@@ -284,5 +284,4 @@ export class Polygon {
 
         return true;
     }
-}
-
+}

package/src/Vec2.ts

@@ -1,7 +1,7 @@
-import {Vector2} from "three";
-import {Vec3} from "./Vec3";
-import {Point2} from "./Point2";
-import {normalizeAngleRadians} from "./normalizeAngleRadians";
+import { Vector2 } from "three";
+import { Vec3 } from "./Vec3";
+import { Point2 } from "./Point2";
+import { normalizeAngleRadians } from "./normalizeAngleRadians";
 
 /**
  * Vec2 represents a 2D vector. It extends `Vector2` from the `threejs` library.

package/src/Vec3.ts

@@ -56,7 +56,6 @@ export class Vec3 extends Vector3 {
         return this.moveTowards(target, this.distanceTo(target) / 2);
     }
 
-
     /**
      * Adds y amount to this Vec3 instance and return this
      * @param y

package/src/isContinuousClosedShape.ts

@@ -1,7 +1,8 @@
-import { Line3D } from "./Line3D";
-import { Line2D } from "./Line2D";
+// The point type P must implement an isNear method that accepts the same point type and an optional tolerance.
+type Point<P extends { isNear(other: P, tolerance?: number): boolean }> = { isNear(other: P, tolerance?: number): boolean };
 
-export function isContinuousClosedShape<T extends Line2D | Line3D>(lines: T[], tolerance: number = 0): boolean {
+// This matches the signatures on Vec2 and Vec3 (for example, isNear(v: Vector2, maxDistance?: number)).
+export function isContinuousClosedShape<P extends Point<P>>(lines: { start: P; end: P }[], tolerance: number = 0): boolean {
     if (lines.length < 3) {
         return false; // A shape needs at least 3 lines to be closed
     }
@@ -11,7 +12,7 @@ export function isContinuousClosedShape<T extends Line2D | Line3D>(lines: T[], t
         const endCurrent = lines[i].end;
         const startNext = lines[i + 1].start;
 
-        if (!endCurrent.isNear(startNext as any, tolerance)) {
+        if (!endCurrent.isNear(startNext, tolerance)) {
             return false; // If the end of the current line and start of the next line are not close, return false
         }
     }
@@ -20,5 +21,5 @@ export function isContinuousClosedShape<T extends Line2D | Line3D>(lines: T[], t
     const endLast = lines[lines.length - 1].end;
     const startFirst = lines[0].start;
 
-    return endLast.isNear(startFirst as any, tolerance);
+    return endLast.isNear(startFirst, tolerance);
 }

package/types/isContinuousClosedShape.d.ts

@@ -1,3 +1,10 @@
-import { Line3D } from "./Line3D";
-import { Line2D } from "./Line2D";
-export declare function isContinuousClosedShape<T extends Line2D | Line3D>(lines: T[], tolerance?: number): boolean;
+type Point<P extends {
+    isNear(other: P, tolerance?: number): boolean;
+}> = {
+    isNear(other: P, tolerance?: number): boolean;
+};
+export declare function isContinuousClosedShape<P extends Point<P>>(lines: {
+    start: P;
+    end: P;
+}[], tolerance?: number): boolean;
+export {};