@immense/vue-pom-generator 1.0.67 → 1.0.68

package/RELEASE_NOTES.md

@@ -1,94 +1,34 @@
 ● ## Highlights
 
-  - **Runtime annotator metadata** – New runtime metadata collection and annotation capabilities
-  for enhanced POM generation
-  - **Accessibility audit warnings** – Automatic detection and reporting of accessibility issues
-  in Vue components
-  - **Manifest and locator descriptions** – Human-readable descriptions for generated test
-  locators and manifests
-  - **Zero runtime dependencies** – All runtime dependencies eliminated for smaller bundle size
-  and fewer supply-chain risks
-  - **Build–serve parity** – Dev mode POM generation now matches build mode behavior with
-  comprehensive regression tests
+  - Fixed file scope path checks to properly normalize paths before comparison
+  - Extracted path normalization logic into dedicated utility functions
+  - Added comprehensive test coverage for path scope validation
 
   ## Changes
 
-  **Features**
-  - Add runtime annotator metadata with Vue component detection (#27)
-  - Add accessibility audit metadata and warnings (#25)
-  - Add manifest and locator descriptions (#24)
-  - Add split Playwright POM output for improved discoverability (#12)
-  - Fail fast on unnameable wrapper handlers (#11)
+  **Bug Fixes**
+  - Normalized file scope path checks to handle platform-specific path separators and inconsistent
+   path formats (#29)
+  - Refactored path comparison logic in Vue plugin to use centralized utility functions
 
-  **Fixes**
-  - Parse TypeScript template expressions + allow submit-button fallback (#20)
-  - Avoid reparsing generated test IDs (#21)
-  - Harden local app integration (#19)
-  - Restore router DOM globals after introspection (#18)
-  - Support awaited handler wrappers (#17)
-  - Resolve Nuxt app-root dev POM clobber (#15)
-  - Guard manual releases (#16)
-  - Fail fast on dev snapshot generation errors (#6)
-  - Dev-mode POM generation parity with build mode (#5)
-  - Fix keyed POM dedupe and C# navigation returns (#4)
+  **Testing**
+  - Added `tests/path-utils-scope.test.ts` with 29 test cases for path scope validation
 
-  **Refactoring**
-  - Eliminate all runtime dependencies (#9)
-  - Rename `plugin/support` → `plugin/internal` (internal restructuring)
-
-  **Dependencies**
-  - Relax Vite peer dependency range (#13)
-
-  **Developer Experience**
-  - Add PR release-notes preview comments (#1)
+  **Code Quality**
+  - Extracted 68 lines of path utility logic from `vue-plugin.ts` to `plugin/path-utils.ts`
+  - Reduced code duplication in plugin path handling (net -29 lines in vue-plugin.ts)
 
   ## Breaking Changes
 
-  - Internal plugin structure reorganized: `plugin/support-plugins.ts` →
-  `plugin/internal-plugins.ts` and `plugin/support/*` → `plugin/internal/*`. This should not
-  affect public API users.
+  None.
 
   ## Pull Requests Included
 
-  - #27 feat: add runtime annotator metadata
-  (https://github.com/immense/vue-pom-generator/pull/27)
-  - #25 feat: add accessibility audit metadata and warnings
-  (https://github.com/immense/vue-pom-generator/pull/25)
-  - #24 feat: add manifest and locator descriptions
-  (https://github.com/immense/vue-pom-generator/pull/24)
-  - #21 fix: avoid reparsing generated test ids
-  (https://github.com/immense/vue-pom-generator/pull/21)
-  - #20 fix: parse TypeScript template expressions + allow submit-button fallback
-  (https://github.com/immense/vue-pom-generator/pull/20)
-  - #19 fix: harden local app integration (https://github.com/immense/vue-pom-generator/pull/19)
-  - #18 fix: restore router DOM globals after introspection
-  (https://github.com/immense/vue-pom-generator/pull/18)
-  - #17 fix: support awaited handler wrappers
-  (https://github.com/immense/vue-pom-generator/pull/17)
-  - #16 fix: guard manual releases (https://github.com/immense/vue-pom-generator/pull/16)
-  - #15 fix: resolve Nuxt app-root dev POM clobber
-  (https://github.com/immense/vue-pom-generator/pull/15)
-  - #13 Relax Vite peer dependency range (https://github.com/immense/vue-pom-generator/pull/13)
-  - #12 feat: add split Playwright POM output for discoverability
-  (https://github.com/immense/vue-pom-generator/pull/12)
-  - #11 feat: fail fast on unnameable wrapper handlers
-  (https://github.com/immense/vue-pom-generator/pull/11)
-  - #9 refactor(deps): eliminate all runtime dependencies
-  (https://github.com/immense/vue-pom-generator/pull/9)
-  - #8 chore: bump version to 1.0.43 (https://github.com/immense/vue-pom-generator/pull/8)
-  - #7 test: add build–serve parity regression tests
-  (https://github.com/immense/vue-pom-generator/pull/7)
-  - #6 fix: fail fast on dev snapshot generation errors
-  (https://github.com/immense/vue-pom-generator/pull/6)
-  - #5 fix: dev-mode POM generation parity with build mode
-  (https://github.com/immense/vue-pom-generator/pull/5)
-  - #4 Fix keyed POM dedupe and C# navigation returns
-  (https://github.com/immense/vue-pom-generator/pull/4)
-  - #1 Add PR release-notes preview comments (https://github.com/immense/vue-pom-generator/pull/1)
+  - #29 fix: normalize file scope path checks
+  (https://github.com/immense/vue-pom-generator/pull/29) by @dkattan
 
   ## Testing
 
-  Comprehensive test coverage added including build–serve parity regression tests (#7), class
-  generation coverage tests, generated TypeScript compilation tests, and virtual test ID tests.
-  All new features and fixes include corresponding test coverage.
+  New test suite added (`path-utils-scope.test.ts`) covering path normalization and scope
+  validation edge cases.
 

package/dist/index.cjs

@@ -3563,6 +3563,14 @@ function safeRealpath(value) {
   const resolvedParent = safeRealpath(parent);
   return resolvedParent === parent ? value : path.join(resolvedParent, path.basename(value));
 }
+function normalizeScopePath(value, pathImpl = path) {
+  return pathImpl.normalize(value);
+}
+function isNormalizedPathWithinDir(filePathAbs, dirPathAbs, pathImpl = path) {
+  const normalizedFileAbs = normalizeScopePath(filePathAbs, pathImpl);
+  const normalizedDirAbs = normalizeScopePath(dirPathAbs, pathImpl);
+  return normalizedFileAbs === normalizedDirAbs || normalizedFileAbs.startsWith(`${normalizedDirAbs}${pathImpl.sep}`);
+}
 function isPathWithinDir(filePathAbs, dirPathAbs) {
   const fileAbs = path.resolve(filePathAbs);
   const dirAbs = path.resolve(dirPathAbs);
@@ -3592,6 +3600,43 @@ function resolveComponentNameFromPath(options) {
   }
   return toPascalCase(path.parse(normalizedAbsFilename).name);
 }
+function isFileInConfiguredSourceScope(options) {
+  const { filename, projectRoot, viewsDirAbs, sourceDirs, extraRoots = [], pathImpl = path } = options;
+  if (!filename) {
+    return false;
+  }
+  const cleanFilename = filename.includes("?") ? filename.substring(0, filename.indexOf("?")) : filename;
+  const normalizedProjectRoot = normalizeScopePath(projectRoot, pathImpl);
+  const normalizedAbsFilename = normalizeScopePath(
+    pathImpl.isAbsolute(cleanFilename) ? cleanFilename : pathImpl.resolve(normalizedProjectRoot, cleanFilename),
+    pathImpl
+  );
+  if (normalizedAbsFilename.includes(`${pathImpl.sep}node_modules${pathImpl.sep}`) || normalizedAbsFilename.includes("/node_modules/")) {
+    return false;
+  }
+  const normalizedViewsDirAbs = normalizeScopePath(viewsDirAbs, pathImpl);
+  if (isNormalizedPathWithinDir(normalizedAbsFilename, normalizedViewsDirAbs, pathImpl)) {
+    return true;
+  }
+  const rootsToTry = Array.from(/* @__PURE__ */ new Set([
+    normalizedProjectRoot,
+    ...extraRoots.map((root) => normalizeScopePath(root, pathImpl))
+  ]));
+  return sourceDirs.some((dir) => {
+    return rootsToTry.some((root) => {
+      const normalizedAbsDir = normalizeScopePath(pathImpl.resolve(root, dir), pathImpl);
+      if (isNormalizedPathWithinDir(normalizedAbsFilename, normalizedAbsDir, pathImpl)) {
+        return true;
+      }
+      if (dir.startsWith("app/") && pathImpl.basename(root) === "app") {
+        const relativeDir = dir.substring(4);
+        const normalizedAbsDirAlt = normalizeScopePath(pathImpl.resolve(root, relativeDir), pathImpl);
+        return isNormalizedPathWithinDir(normalizedAbsFilename, normalizedAbsDirAlt, pathImpl);
+      }
+      return false;
+    });
+  });
+}
 let routerIntrospectionQueue = Promise.resolve();
 async function runRouterIntrospectionExclusive(fn) {
   const prev = routerIntrospectionQueue.catch(() => void 0);
@@ -9007,27 +9052,15 @@ function createVuePluginWithTestIds(options) {
       return false;
     const cleanPath = filename.includes("?") ? filename.substring(0, filename.indexOf("?")) : filename;
     const projectRoot = getProjectRoot();
-    const absFilename = path.isAbsolute(cleanPath) ? cleanPath : path.resolve(projectRoot, cleanPath);
-    if (absFilename.includes(`${path.sep}node_modules${path.sep}`) || absFilename.includes("/node_modules/"))
-      return false;
-    const viewsDirAbs = getViewsDirAbs();
-    if (absFilename.startsWith(viewsDirAbs + path.sep) || absFilename === viewsDirAbs)
-      return true;
-    const rootsToTry = [projectRoot, process.cwd()];
-    const matched = getSourceDirs().some((dir) => {
-      return rootsToTry.some((root) => {
-        const absDir = path.resolve(root, dir);
-        if (absFilename.startsWith(absDir + path.sep) || absFilename === absDir)
-          return true;
-        if (dir.startsWith("app/") && root.endsWith("/app")) {
-          const relativeDir = dir.substring(4);
-          const absDirAlt = path.resolve(root, relativeDir);
-          return absFilename.startsWith(absDirAlt + path.sep) || absFilename === absDirAlt;
-        }
-        return false;
-      });
+    const matched = isFileInConfiguredSourceScope({
+      filename,
+      projectRoot,
+      viewsDirAbs: getViewsDirAbs(),
+      sourceDirs: getSourceDirs(),
+      extraRoots: [process.cwd()]
     });
     if (cleanPath.endsWith(".vue") && !matched) {
+      const absFilename = path.normalize(path.isAbsolute(cleanPath) ? cleanPath : path.resolve(projectRoot, cleanPath));
       loggerRef.current.debug(`[isFileInScope] REJECTED: ${absFilename} (Clean: ${cleanPath})`);
     }
     return matched;