@immense/vue-pom-generator 1.0.61 → 1.0.63

package/RELEASE_NOTES.md

@@ -1,49 +1,30 @@
-● # Release Notes: v1.0.61
-
+● ```markdown
   ## Highlights
 
-  - **New accessibility audit system** to detect and warn about common ARIA and semantic HTML
-  issues during POM generation
-  - Audit signals now included in the manifest output for downstream consumption
-  - Enhanced compiler metadata utilities to extract role and label information from templates
-  - Comprehensive test coverage for the new accessibility audit features
+  - Fixed nested component POMs not being properly attached to their parent views
+  - Added comprehensive test coverage for nested component POM attachment
 
   ## Changes
 
-  ### Accessibility & Quality
-  - Added `accessibility-audit.ts` module with audit functions for detecting missing labels,
-  invalid ARIA usage, and semantic violations
-  - Integrated audit warnings into the Vite plugin pipeline with configurable severity
-  - Extended manifest generator to include `auditSignals` for each component
-
-  ### Plugin & Configuration
-  - Added `auditSeverity` option to plugin configuration (default: `"warn"`)
-  - Enhanced `ResolvedGenerationOptions` to support audit configuration
-  - Updated plugin to emit warnings when accessibility issues are detected during build
-
-  ### Compiler & Metadata
-  - Improved `compiler-metadata-utils.ts` to extract `role` and `aria-label` attributes
-  - Enhanced metadata collector to capture accessibility-related attributes
-
-  ### Documentation
-  - Updated README with information about the new accessibility audit feature
+  ### Bug Fixes
+  - Resolved issue where nested component POMs were not correctly associated with view classes
+  during generation
+  - Improved POM attachment logic in class generation module
 
   ### Testing
-  - Added comprehensive test suite in `tests/accessibility-audit.test.ts` (54 new tests)
-  - Added tests for resolved generation options
-  - Updated existing tests to accommodate new audit functionality
+  - Added 54 lines of test coverage for class generation including nested component scenarios
 
   ## Breaking Changes
 
-  None.
+  None
 
   ## Pull Requests Included
 
-  - #25 feat: add accessibility audit metadata and warnings
-  (https://github.com/immense/vue-pom-generator/pull/25) by @dkattan
+  None (direct commit to main)
 
   ## Testing
 
-  All changes include full test coverage. New test suite validates audit detection for missing
-  labels, invalid ARIA attributes, redundant roles, and other semantic issues.
+  Tests added to validate nested component POM attachment behavior. Run test suite with `npm
+  test`.
+  ```
 

package/class-generation/index.ts

@@ -24,7 +24,6 @@ import {
   isParameterizedPomPattern,
   orderPomPatternParameters,
   toCSharpPomPatternExpression,
-  toTypeScriptPomPatternExpression,
   uniquePomStringPatterns,
   type PomStringPattern,
 } from "../pom-patterns";
@@ -1604,14 +1603,57 @@ function prepareViewObjectModelClass(
     testIdAttribute,
   } = options;
 
+  const normalizeTrackedComponentRef = (value: string): string => {
+    return value.endsWith(".vue") ? value.slice(0, -4) : value;
+  };
+
+  const resolveTrackedComponentRef = (value: string): string | null => {
+    const normalizedValue = normalizeTrackedComponentRef(value);
+    if (componentHierarchyMap.has(value)) {
+      return value;
+    }
+    if (componentHierarchyMap.has(normalizedValue)) {
+      return normalizedValue;
+    }
+
+    let match: string | null = null;
+    for (const [candidateName, candidateDeps] of componentHierarchyMap.entries()) {
+      const normalizedCandidate = normalizeTrackedComponentRef(candidateName);
+      const candidateBaseName = path.parse(candidateDeps.filePath).name;
+      if (normalizedCandidate !== normalizedValue && candidateBaseName !== normalizedValue) {
+        continue;
+      }
+      if (match && match !== candidateName) {
+        return null;
+      }
+      match = candidateName;
+    }
+    return match;
+  };
+
+  const rawComponentRefsForInstances = isView
+    ? (usedComponentSet?.size ? usedComponentSet : childrenComponentSet)
+    : childrenComponentSet;
+  const componentRefsForInstances = new Set<string>();
+  for (const ref of rawComponentRefsForInstances) {
+    componentRefsForInstances.add(resolveTrackedComponentRef(ref) ?? normalizeTrackedComponentRef(ref));
+  }
+
   const hasChildComponent = (needle: string) => {
-    const haystack = usedComponentSet?.size ? usedComponentSet : childrenComponentSet;
-    for (const child of haystack) {
-      if (child === needle)
+    const normalizedNeedle = normalizeTrackedComponentRef(needle);
+    for (const child of rawComponentRefsForInstances) {
+      const resolvedChild = resolveTrackedComponentRef(child);
+      if (normalizeTrackedComponentRef(child) === normalizedNeedle)
         return true;
-      if (child === `${needle}.vue`)
+      if (resolvedChild && normalizeTrackedComponentRef(resolvedChild) === normalizedNeedle)
         return true;
-      if (child.endsWith(".vue") && child.slice(0, -4) === needle)
+      if (resolvedChild) {
+        const resolvedDeps = componentHierarchyMap.get(resolvedChild);
+        if (resolvedDeps && path.parse(resolvedDeps.filePath).name === normalizedNeedle) {
+          return true;
+        }
+      }
+      if (child === `${needle}.vue`)
         return true;
     }
     return false;
@@ -1648,10 +1690,6 @@ function prepareViewObjectModelClass(
     ? getWidgetInstancesForView(componentName, dependencies.dataTestIdSet, customPomAvailableClassIdentifiers)
     : [];
 
-  const componentRefsForInstances = isView
-    ? (usedComponentSet?.size ? usedComponentSet : childrenComponentSet)
-    : childrenComponentSet;
-
   const className = toPascalCaseLocal(componentName);
   const childInstancePropertyNames = Array.from(componentRefsForInstances)
     .filter(child => componentHierarchyMap.has(child) && componentHierarchyMap.get(child)?.dataTestIdSet.size)
@@ -1964,7 +2002,7 @@ function sliceNodeSource(source: string, node: { start?: number | null; end?: nu
 
 function getTypeAnnotationSource(
   source: string,
-  node: { typeAnnotation?: unknown },
+  node: { typeAnnotation?: object | null },
 ): string | undefined {
   const rawTypeAnnotation = node.typeAnnotation;
   if (!rawTypeAnnotation || typeof rawTypeAnnotation !== "object" || !("type" in rawTypeAnnotation) || rawTypeAnnotation.type !== "TSTypeAnnotation" || !("typeAnnotation" in rawTypeAnnotation)) {

package/dist/class-generation/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../class-generation/index.ts"],"names":[],"mappings":"AAUA,OAAO,EAAkC,oCAAoC,EAAE,MAAM,sBAAsB,CAAC;AAyC5G,OAAO,EACL,sBAAsB,EAOvB,MAAM,UAAU,CAAC;AAQlB,OAAO,EAAE,oCAAoC,EAAE,CAAC;AA2ChD,UAAU,SAAS;IACjB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAID,UAAU,mBAAmB;IAC3B,SAAS,EAAE,MAAM,CAAC;IAClB,YAAY,EAAE,MAAM,CAAC;IACrB,wBAAwB,EAAE,MAAM,EAAE,CAAC;IACnC,QAAQ,CAAC,EAAE,OAAO,GAAG,YAAY,GAAG,MAAM,GAAG,oBAAoB,CAAC;IAClE,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB;AASD,MAAM,MAAM,yBAAyB,GAAG,YAAY,GAAG,OAAO,CAAC;AAqW/D,MAAM,WAAW,oBAAoB;IACnC;;;;OAIG;IACH,MAAM,CAAC,EAAE,MAAM,CAAC;IAEhB;;;;;;;;;;;;;;;OAeG;IACH,gBAAgB,CAAC,EAAE,OAAO,GAAG,MAAM,GAAG;QAAE,MAAM,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC;IAE1D;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;;OAGG;IACH,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,gFAAgF;IAChF,mBAAmB,CAAC,EAAE,OAAO,CAAC;IAE9B;;;;;;;OAOG;IACH,sBAAsB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAEhD;;;;;OAKG;IACH,oCAAoC,CAAC,EAAE,OAAO,GAAG,OAAO,CAAC;IAEzD;;;;OAIG;IACH,oBAAoB,CAAC,EAAE,mBAAmB,EAAE,CAAC;IAE7C,yEAAyE;IACzE,eAAe,CAAC,EAAE,MAAM,CAAC;IAEzB,uDAAuD;IACvD,aAAa,CAAC,EAAE,KAAK,CAAC,IAAI,GAAG,QAAQ,CAAC,CAAC;IAEvC;;;;;OAKG;IACH,yBAAyB,CAAC,EAAE,yBAAyB,CAAC;IAEtD,6BAA6B;IAC7B,MAAM,CAAC,EAAE;QACP,SAAS,CAAC,EAAE,MAAM,CAAC;KACpB,CAAC;IAEF,6EAA6E;IAC7E,uBAAuB,CAAC,EAAE,OAAO,CAAC;IAElC,2FAA2F;IAC3F,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB,mDAAmD;IACnD,UAAU,CAAC,EAAE,YAAY,GAAG,MAAM,CAAC;IAEnC,QAAQ,CAAC,EAAE,MAAM,EAAE,CAAC;IACpB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB,oBAAoB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC;CAClD;AAsCD,wBAAsB,aAAa,CACjC,qBAAqB,EAAE,GAAG,CAAC,MAAM,EAAE,sBAAsB,CAAC,EAC1D,eAAe,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,EACpC,iBAAiB,EAAE,MAAM,EACzB,OAAO,GAAE,oBAAyB,iBAoGnC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../class-generation/index.ts"],"names":[],"mappings":"AAUA,OAAO,EAAkC,oCAAoC,EAAE,MAAM,sBAAsB,CAAC;AAwC5G,OAAO,EACL,sBAAsB,EAOvB,MAAM,UAAU,CAAC;AAQlB,OAAO,EAAE,oCAAoC,EAAE,CAAC;AA2ChD,UAAU,SAAS;IACjB,QAAQ,EAAE,MAAM,CAAC;CAClB;AAID,UAAU,mBAAmB;IAC3B,SAAS,EAAE,MAAM,CAAC;IAClB,YAAY,EAAE,MAAM,CAAC;IACrB,wBAAwB,EAAE,MAAM,EAAE,CAAC;IACnC,QAAQ,CAAC,EAAE,OAAO,GAAG,YAAY,GAAG,MAAM,GAAG,oBAAoB,CAAC;IAClE,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB;AASD,MAAM,MAAM,yBAAyB,GAAG,YAAY,GAAG,OAAO,CAAC;AAqW/D,MAAM,WAAW,oBAAoB;IACnC;;;;OAIG;IACH,MAAM,CAAC,EAAE,MAAM,CAAC;IAEhB;;;;;;;;;;;;;;;OAeG;IACH,gBAAgB,CAAC,EAAE,OAAO,GAAG,MAAM,GAAG;QAAE,MAAM,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC;IAE1D;;;OAGG;IACH,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB;;;OAGG;IACH,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,gFAAgF;IAChF,mBAAmB,CAAC,EAAE,OAAO,CAAC;IAE9B;;;;;;;OAOG;IACH,sBAAsB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAEhD;;;;;OAKG;IACH,oCAAoC,CAAC,EAAE,OAAO,GAAG,OAAO,CAAC;IAEzD;;;;OAIG;IACH,oBAAoB,CAAC,EAAE,mBAAmB,EAAE,CAAC;IAE7C,yEAAyE;IACzE,eAAe,CAAC,EAAE,MAAM,CAAC;IAEzB,uDAAuD;IACvD,aAAa,CAAC,EAAE,KAAK,CAAC,IAAI,GAAG,QAAQ,CAAC,CAAC;IAEvC;;;;;OAKG;IACH,yBAAyB,CAAC,EAAE,yBAAyB,CAAC;IAEtD,6BAA6B;IAC7B,MAAM,CAAC,EAAE;QACP,SAAS,CAAC,EAAE,MAAM,CAAC;KACpB,CAAC;IAEF,6EAA6E;IAC7E,uBAAuB,CAAC,EAAE,OAAO,CAAC;IAElC,2FAA2F;IAC3F,WAAW,CAAC,EAAE,MAAM,CAAC;IAErB,mDAAmD;IACnD,UAAU,CAAC,EAAE,YAAY,GAAG,MAAM,CAAC;IAEnC,QAAQ,CAAC,EAAE,MAAM,EAAE,CAAC;IACpB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,UAAU,CAAC,EAAE,MAAM,EAAE,CAAC;IAEtB,oBAAoB,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC;CAClD;AAsCD,wBAAsB,aAAa,CACjC,qBAAqB,EAAE,GAAG,CAAC,MAAM,EAAE,sBAAsB,CAAC,EAC1D,eAAe,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,EACpC,iBAAiB,EAAE,MAAM,EACzB,OAAO,GAAE,oBAAyB,iBAoGnC"}

package/dist/index.cjs

@@ -1802,11 +1802,12 @@ function nodeHandlerAttributeInfo(node) {
     return null;
   }
   const exp = handlerDirective.exp;
-  const source = getVueExpressionSource(exp, "content", "compiled");
-  if (!source) {
+  const transformedSource = getVueExpressionSource(exp, "content", "compiled");
+  const authorSource = getVueExpressionSource(exp, "loc", "content", "compiled");
+  if (!authorSource) {
     return null;
   }
-  const mergeKey = `handler:expr:${source}`;
+  const mergeKey = `handler:expr:${authorSource}`;
   const expr = tryGetDirectiveBabelAst(handlerDirective, {
     preferredViews: ["content", "compiled"],
     plugins: ["typescript", "jsx"],
@@ -1814,9 +1815,7 @@ function nodeHandlerAttributeInfo(node) {
     // That is fine for Vue codegen, but our semantic-name extraction needs a normal Babel parse tree.
     preferExistingAst: false
   });
-  if (!expr) {
-    return null;
-  }
+  const fallbackExpr = transformedSource !== authorSource ? tryParseBabelExpressionFromSource(authorSource, ["typescript", "jsx"]) : null;
   const isNodeType2 = (node2, type) => {
     return node2 !== null && node2.type === type;
   };
@@ -2052,59 +2051,73 @@ function nodeHandlerAttributeInfo(node) {
     const limited = parts.slice(0, 2);
     return limited.map((p) => `${toPascalCase(p.key)}${p.value}`).join("");
   };
-  const direct = getLastIdentifierFromMemberChain(expr);
-  if (direct) {
-    return { semanticNameHint: toPascalCase(direct), mergeKey };
-  }
-  if (isArrowFunctionExpressionNode(expr)) {
-    const body = expr.body;
-    const tryFromCallExpression = (call) => {
-      const resolvedCall = isAwaitExpressionNode(call) ? call.argument : call;
-      if (!isCallExpressionNode(resolvedCall)) {
-        return null;
-      }
-      const name = getLastIdentifierFromMemberChain(resolvedCall.callee);
-      if (!name) {
-        return null;
+  const tryFromCallExpression = (call) => {
+    const resolvedCall = isAwaitExpressionNode(call) ? call.argument : call;
+    if (!isCallExpressionNode(resolvedCall)) {
+      return null;
+    }
+    const name = getLastIdentifierFromMemberChain(resolvedCall.callee);
+    if (!name) {
+      return null;
+    }
+    const suffix = getStableSuffixFromCall(resolvedCall);
+    const semanticNameHint2 = suffix ? `${toPascalCase(name)}${suffix}` : toPascalCase(name);
+    return semanticNameHint2;
+  };
+  const resolveSemanticName = (candidateExpr) => {
+    if (!candidateExpr) {
+      return null;
+    }
+    const direct = getLastIdentifierFromMemberChain(candidateExpr);
+    if (direct) {
+      return toPascalCase(direct);
+    }
+    if (isArrowFunctionExpressionNode(candidateExpr)) {
+      const body = candidateExpr.body;
+      const directCall = tryFromCallExpression(body);
+      if (directCall) {
+        return directCall;
+      }
+      if (isAssignmentExpressionNode(body)) {
+        const lhs = getAssignmentTargetName(body.left);
+        if (lhs) {
+          const rhs = stableWordFromValue(body.right);
+          return `Set${toPascalCase(lhs)}${rhs ?? ""}`;
+        }
       }
-      const suffix = getStableSuffixFromCall(resolvedCall);
-      const semanticNameHint = suffix ? `${toPascalCase(name)}${suffix}` : toPascalCase(name);
-      return semanticNameHint;
-    };
-    const directCall = tryFromCallExpression(body);
-    if (directCall) {
-      return { semanticNameHint: directCall, mergeKey };
-    }
-    if (isAssignmentExpressionNode(body)) {
-      const lhs = getAssignmentTargetName(body.left);
-      if (lhs) {
-        const rhs = stableWordFromValue(body.right);
-        const semanticNameHint = `Set${toPascalCase(lhs)}${rhs ?? ""}`;
-        return { semanticNameHint, mergeKey };
-      }
-    }
-    if (isBlockStatementNode(body)) {
-      const stmts = body.body ?? [];
-      if (stmts.length > 0) {
-        const firstStmt = stmts[0];
-        if (isReturnStatementNode(firstStmt)) {
-          const fromReturn = tryFromCallExpression(firstStmt.argument ?? null);
-          if (fromReturn) {
-            return { semanticNameHint: fromReturn, mergeKey };
+      if (isBlockStatementNode(body)) {
+        const stmts = body.body ?? [];
+        if (stmts.length > 0) {
+          const firstStmt = stmts[0];
+          if (isReturnStatementNode(firstStmt)) {
+            const fromReturn = tryFromCallExpression(firstStmt.argument ?? null);
+            if (fromReturn) {
+              return fromReturn;
+            }
           }
-        }
-        if (isExpressionStatementNode(firstStmt)) {
-          const fromExpr = tryFromCallExpression(firstStmt.expression ?? null);
-          if (fromExpr) {
-            return { semanticNameHint: fromExpr, mergeKey };
+          if (isExpressionStatementNode(firstStmt)) {
+            const fromExpr = tryFromCallExpression(firstStmt.expression ?? null);
+            if (fromExpr) {
+              return fromExpr;
+            }
           }
         }
       }
+      const bodyName = getLastIdentifierFromMemberChain(body);
+      if (bodyName) {
+        return toPascalCase(bodyName);
+      }
     }
-    const bodyName = getLastIdentifierFromMemberChain(body);
-    if (bodyName) {
-      return { semanticNameHint: toPascalCase(bodyName), mergeKey };
-    }
+    return null;
+  };
+  const isVueRefValueAccess = (candidate) => {
+    return isMemberExpressionNode(candidate) && candidate.computed === false && isIdentifierNode2(candidate.property) && candidate.property.name === "value";
+  };
+  const transformedSemanticName = resolveSemanticName(expr);
+  const fallbackSemanticName = resolveSemanticName(fallbackExpr);
+  const semanticNameHint = fallbackSemanticName && transformedSource !== authorSource && isVueRefValueAccess(expr) ? fallbackSemanticName : transformedSemanticName ?? fallbackSemanticName;
+  if (semanticNameHint) {
+    return { semanticNameHint, mergeKey };
   }
   return null;
 }
@@ -5480,14 +5493,51 @@ function prepareViewObjectModelClass(componentName, dependencies, componentHiera
     customPomAttachments = [],
     testIdAttribute
   } = options;
+  const normalizeTrackedComponentRef = (value) => {
+    return value.endsWith(".vue") ? value.slice(0, -4) : value;
+  };
+  const resolveTrackedComponentRef = (value) => {
+    const normalizedValue = normalizeTrackedComponentRef(value);
+    if (componentHierarchyMap.has(value)) {
+      return value;
+    }
+    if (componentHierarchyMap.has(normalizedValue)) {
+      return normalizedValue;
+    }
+    let match = null;
+    for (const [candidateName, candidateDeps] of componentHierarchyMap.entries()) {
+      const normalizedCandidate = normalizeTrackedComponentRef(candidateName);
+      const candidateBaseName = path.parse(candidateDeps.filePath).name;
+      if (normalizedCandidate !== normalizedValue && candidateBaseName !== normalizedValue) {
+        continue;
+      }
+      if (match && match !== candidateName) {
+        return null;
+      }
+      match = candidateName;
+    }
+    return match;
+  };
+  const rawComponentRefsForInstances = isView ? usedComponentSet?.size ? usedComponentSet : childrenComponentSet : childrenComponentSet;
+  const componentRefsForInstances = /* @__PURE__ */ new Set();
+  for (const ref of rawComponentRefsForInstances) {
+    componentRefsForInstances.add(resolveTrackedComponentRef(ref) ?? normalizeTrackedComponentRef(ref));
+  }
   const hasChildComponent = (needle) => {
-    const haystack = usedComponentSet?.size ? usedComponentSet : childrenComponentSet;
-    for (const child of haystack) {
-      if (child === needle)
+    const normalizedNeedle = normalizeTrackedComponentRef(needle);
+    for (const child of rawComponentRefsForInstances) {
+      const resolvedChild = resolveTrackedComponentRef(child);
+      if (normalizeTrackedComponentRef(child) === normalizedNeedle)
         return true;
-      if (child === `${needle}.vue`)
+      if (resolvedChild && normalizeTrackedComponentRef(resolvedChild) === normalizedNeedle)
         return true;
-      if (child.endsWith(".vue") && child.slice(0, -4) === needle)
+      if (resolvedChild) {
+        const resolvedDeps = componentHierarchyMap.get(resolvedChild);
+        if (resolvedDeps && path.parse(resolvedDeps.filePath).name === normalizedNeedle) {
+          return true;
+        }
+      }
+      if (child === `${needle}.vue`)
         return true;
     }
     return false;
@@ -5511,7 +5561,6 @@ function prepareViewObjectModelClass(componentName, dependencies, componentHiera
     methodSignatures: a.flatten ? customPomMethodSignaturesByClass.get(a.className) ?? /* @__PURE__ */ new Map() : /* @__PURE__ */ new Map()
   }));
   const widgetInstances = isView ? getWidgetInstancesForView(componentName, dependencies.dataTestIdSet, customPomAvailableClassIdentifiers) : [];
-  const componentRefsForInstances = isView ? usedComponentSet?.size ? usedComponentSet : childrenComponentSet : childrenComponentSet;
   const className = toPascalCaseLocal(componentName);
   const childInstancePropertyNames = Array.from(componentRefsForInstances).filter((child) => componentHierarchyMap.has(child) && componentHierarchyMap.get(child)?.dataTestIdSet.size).map((child) => child.split(".vue")[0]);
   const blockedViewPassthroughMethodNames = new Set(