@immense/vue-pom-generator 1.0.61 → 1.0.62

package/RELEASE_NOTES.md

@@ -1,49 +1,39 @@
-● # Release Notes: v1.0.61
+● I'll examine the commits to generate accurate release notes.
 
-  ## Highlights
-
-  - **New accessibility audit system** to detect and warn about common ARIA and semantic HTML
-  issues during POM generation
-  - Audit signals now included in the manifest output for downstream consumption
-  - Enhanced compiler metadata utilities to extract role and label information from templates
-  - Comprehensive test coverage for the new accessibility audit features
+● Based on the commit details, here are the release notes for v1.0.62:
 
-  ## Changes
+  ---
 
-  ### Accessibility & Quality
-  - Added `accessibility-audit.ts` module with audit functions for detecting missing labels,
-  invalid ARIA usage, and semantic violations
-  - Integrated audit warnings into the Vite plugin pipeline with configurable severity
-  - Extended manifest generator to include `auditSignals` for each component
+  ## Highlights
 
-  ### Plugin & Configuration
-  - Added `auditSeverity` option to plugin configuration (default: `"warn"`)
-  - Enhanced `ResolvedGenerationOptions` to support audit configuration
-  - Updated plugin to emit warnings when accessibility issues are detected during build
+  - Fixed handler name preservation after Vue compiler transformations
+  - Improved fallback logic to extract semantic names from author-written source code
+  - Enhanced test coverage for handler attribute parsing edge cases
 
-  ### Compiler & Metadata
-  - Improved `compiler-metadata-utils.ts` to extract `role` and `aria-label` attributes
-  - Enhanced metadata collector to capture accessibility-related attributes
+  ## Changes
 
-  ### Documentation
-  - Updated README with information about the new accessibility audit feature
+  **Bug Fixes**
+  - Preserve original handler names when Vue compiler rewrites expressions during compilation
+  - Extract semantic names from author source (`loc.content`) rather than transformed source when
+  they differ
+  - Add fallback expression parsing to handle cases where Vue's transformation breaks Babel AST
+  parsing
 
-  ### Testing
-  - Added comprehensive test suite in `tests/accessibility-audit.test.ts` (54 new tests)
-  - Added tests for resolved generation options
-  - Updated existing tests to accommodate new audit functionality
+  **Testing**
+  - Added 38 new test cases for handler attribute transformation scenarios
+  - Improved coverage for `utils.ts` edge cases with 36 additional tests
+  - Fixed missing `SimpleExpressionNode` import in test files
 
   ## Breaking Changes
 
-  None.
+  None
 
   ## Pull Requests Included
 
-  - #25 feat: add accessibility audit metadata and warnings
-  (https://github.com/immense/vue-pom-generator/pull/25) by @dkattan
+  None (direct commits to main)
 
   ## Testing
 
-  All changes include full test coverage. New test suite validates audit detection for missing
-  labels, invalid ARIA attributes, redundant roles, and other semantic issues.
+  All changes include comprehensive test coverage. Added 75+ new test cases covering handler
+  attribute parsing, Vue compiler transformations, and semantic name extraction edge cases.
 

package/dist/index.cjs

@@ -1802,11 +1802,12 @@ function nodeHandlerAttributeInfo(node) {
     return null;
   }
   const exp = handlerDirective.exp;
-  const source = getVueExpressionSource(exp, "content", "compiled");
-  if (!source) {
+  const transformedSource = getVueExpressionSource(exp, "content", "compiled");
+  const authorSource = getVueExpressionSource(exp, "loc", "content", "compiled");
+  if (!authorSource) {
     return null;
   }
-  const mergeKey = `handler:expr:${source}`;
+  const mergeKey = `handler:expr:${authorSource}`;
   const expr = tryGetDirectiveBabelAst(handlerDirective, {
     preferredViews: ["content", "compiled"],
     plugins: ["typescript", "jsx"],
@@ -1814,9 +1815,7 @@ function nodeHandlerAttributeInfo(node) {
     // That is fine for Vue codegen, but our semantic-name extraction needs a normal Babel parse tree.
     preferExistingAst: false
   });
-  if (!expr) {
-    return null;
-  }
+  const fallbackExpr = transformedSource !== authorSource ? tryParseBabelExpressionFromSource(authorSource, ["typescript", "jsx"]) : null;
   const isNodeType2 = (node2, type) => {
     return node2 !== null && node2.type === type;
   };
@@ -2052,59 +2051,73 @@ function nodeHandlerAttributeInfo(node) {
     const limited = parts.slice(0, 2);
     return limited.map((p) => `${toPascalCase(p.key)}${p.value}`).join("");
   };
-  const direct = getLastIdentifierFromMemberChain(expr);
-  if (direct) {
-    return { semanticNameHint: toPascalCase(direct), mergeKey };
-  }
-  if (isArrowFunctionExpressionNode(expr)) {
-    const body = expr.body;
-    const tryFromCallExpression = (call) => {
-      const resolvedCall = isAwaitExpressionNode(call) ? call.argument : call;
-      if (!isCallExpressionNode(resolvedCall)) {
-        return null;
-      }
-      const name = getLastIdentifierFromMemberChain(resolvedCall.callee);
-      if (!name) {
-        return null;
+  const tryFromCallExpression = (call) => {
+    const resolvedCall = isAwaitExpressionNode(call) ? call.argument : call;
+    if (!isCallExpressionNode(resolvedCall)) {
+      return null;
+    }
+    const name = getLastIdentifierFromMemberChain(resolvedCall.callee);
+    if (!name) {
+      return null;
+    }
+    const suffix = getStableSuffixFromCall(resolvedCall);
+    const semanticNameHint2 = suffix ? `${toPascalCase(name)}${suffix}` : toPascalCase(name);
+    return semanticNameHint2;
+  };
+  const resolveSemanticName = (candidateExpr) => {
+    if (!candidateExpr) {
+      return null;
+    }
+    const direct = getLastIdentifierFromMemberChain(candidateExpr);
+    if (direct) {
+      return toPascalCase(direct);
+    }
+    if (isArrowFunctionExpressionNode(candidateExpr)) {
+      const body = candidateExpr.body;
+      const directCall = tryFromCallExpression(body);
+      if (directCall) {
+        return directCall;
+      }
+      if (isAssignmentExpressionNode(body)) {
+        const lhs = getAssignmentTargetName(body.left);
+        if (lhs) {
+          const rhs = stableWordFromValue(body.right);
+          return `Set${toPascalCase(lhs)}${rhs ?? ""}`;
+        }
       }
-      const suffix = getStableSuffixFromCall(resolvedCall);
-      const semanticNameHint = suffix ? `${toPascalCase(name)}${suffix}` : toPascalCase(name);
-      return semanticNameHint;
-    };
-    const directCall = tryFromCallExpression(body);
-    if (directCall) {
-      return { semanticNameHint: directCall, mergeKey };
-    }
-    if (isAssignmentExpressionNode(body)) {
-      const lhs = getAssignmentTargetName(body.left);
-      if (lhs) {
-        const rhs = stableWordFromValue(body.right);
-        const semanticNameHint = `Set${toPascalCase(lhs)}${rhs ?? ""}`;
-        return { semanticNameHint, mergeKey };
-      }
-    }
-    if (isBlockStatementNode(body)) {
-      const stmts = body.body ?? [];
-      if (stmts.length > 0) {
-        const firstStmt = stmts[0];
-        if (isReturnStatementNode(firstStmt)) {
-          const fromReturn = tryFromCallExpression(firstStmt.argument ?? null);
-          if (fromReturn) {
-            return { semanticNameHint: fromReturn, mergeKey };
+      if (isBlockStatementNode(body)) {
+        const stmts = body.body ?? [];
+        if (stmts.length > 0) {
+          const firstStmt = stmts[0];
+          if (isReturnStatementNode(firstStmt)) {
+            const fromReturn = tryFromCallExpression(firstStmt.argument ?? null);
+            if (fromReturn) {
+              return fromReturn;
+            }
           }
-        }
-        if (isExpressionStatementNode(firstStmt)) {
-          const fromExpr = tryFromCallExpression(firstStmt.expression ?? null);
-          if (fromExpr) {
-            return { semanticNameHint: fromExpr, mergeKey };
+          if (isExpressionStatementNode(firstStmt)) {
+            const fromExpr = tryFromCallExpression(firstStmt.expression ?? null);
+            if (fromExpr) {
+              return fromExpr;
+            }
           }
         }
       }
+      const bodyName = getLastIdentifierFromMemberChain(body);
+      if (bodyName) {
+        return toPascalCase(bodyName);
+      }
     }
-    const bodyName = getLastIdentifierFromMemberChain(body);
-    if (bodyName) {
-      return { semanticNameHint: toPascalCase(bodyName), mergeKey };
-    }
+    return null;
+  };
+  const isVueRefValueAccess = (candidate) => {
+    return isMemberExpressionNode(candidate) && candidate.computed === false && isIdentifierNode2(candidate.property) && candidate.property.name === "value";
+  };
+  const transformedSemanticName = resolveSemanticName(expr);
+  const fallbackSemanticName = resolveSemanticName(fallbackExpr);
+  const semanticNameHint = fallbackSemanticName && transformedSource !== authorSource && isVueRefValueAccess(expr) ? fallbackSemanticName : transformedSemanticName ?? fallbackSemanticName;
+  if (semanticNameHint) {
+    return { semanticNameHint, mergeKey };
   }
   return null;
 }