@immense/vue-pom-generator 1.0.58 → 1.0.59

package/README.md

@@ -69,12 +69,13 @@ That example is intentionally small, but it shows the real contract:
 The generator does not use one naming trick. It layers several signals.
 
 - **Click actions** prefer semantic handler names such as `save`, `openDetails`, or `runImport`.
+- **Click handlers are instrumented** so generated Playwright helpers can wait on deterministic `__testid_event__` runtime events.
 - **Inputs and wrapper components** prefer `v-model`, wrapper `valueAttribute`, or related model-like bindings.
 - **Native elements** also consider `id` / `name` attributes.
 - **Router links / `:to` bindings** can contribute route-based naming and typed navigation return types when the target can be resolved.
 - **Wrapper components** can be explicit (`nativeWrappers`) or inferred from simple local SFC templates.
 - **Fallback naming exists, but it is intentionally conservative.** That is why `generation.nameCollisionBehavior` exists.
-- **Wrapper-action generation fails fast by default.** The generator blocks button-like wrapper `:handler` expressions that it cannot turn into a semantic action name; set `errorBehavior: "ignore"` if you explicitly want the old permissive fallback.
+- **Wrapper-action generation fails fast.** The generator blocks button-like wrapper `:handler` expressions that it cannot turn into a semantic action name.
 
 Important limit: wrapper inference is helpful, not magical. The current implementation recursively inspects simple local SFC templates for the first inferable primitive (`input`, `textarea`, `select`, `button`, `vselect`, radio/checkbox inputs). It also recognizes some naming patterns like `*Button`. For anything more complex, configure `nativeWrappers` explicitly.
 
@@ -205,7 +206,6 @@ const pomConfig = defineVuePomGeneratorConfig({
     script: { defineModel: true, propsDestructure: true },
   },
   logging: { verbosity: "info" },
-  errorBehavior: "error",
   injection: {
     attribute: "data-testid",
     viewsDir: "src/views",
@@ -218,7 +218,7 @@ const pomConfig = defineVuePomGeneratorConfig({
       AppRadioGroup: { role: "radio", requiresOptionDataTestIdPrefix: true },
     },
     excludeComponents: ["LegacyWidget"],
-    existingIdBehavior: "preserve",
+    existingIdBehavior: "error",
   },
   generation: {
     emit: ["ts", "csharp"],
@@ -226,7 +226,7 @@ const pomConfig = defineVuePomGeneratorConfig({
       namespace: "MyProject.Tests.Generated",
     },
     outDir: "tests/playwright/__generated__",
-    nameCollisionBehavior: "suffix",
+    nameCollisionBehavior: "error",
     router: {
       entry: "src/router/index.ts",
       moduleShims: {
@@ -849,18 +849,6 @@ The sections below follow the actual `VuePomGeneratorPluginOptions` shape from `
   logging: { verbosity: "debug" }
   ```
 
-#### `errorBehavior`
-
-- **What it does:** Controls strict/error behavior for generator checks.
-- **Why it exists:** complex inline handlers can otherwise fall through to generic naming, which makes generated APIs harder to discover and review.
-- **Benefit:** fail-fast behavior is the default, while `"ignore"` or the object form let you opt back into only the permissive checks you want.
-- **Without it:** the default is `"error"`, so unsupported button-wrapper handlers stop generation instead of silently falling back.
-- **Accepted values:**
-  - `"ignore"` — keep permissive defaults for all supported checks
-  - `"error"` — enable error-on-failure behavior for all supported checks (default)
-  - `{ missingSemanticNameBehavior: "ignore" }` — opt out only of the button-wrapper semantic-name check
-- **Current scope:** this first pass is intentionally narrow. The object form currently supports `missingSemanticNameBehavior`, which targets button-like wrappers with `:handler`; value/model-driven wrappers still use their existing naming flow.
-
 ### `injection`
 
 `injection` controls compile-time test-id derivation and template rewriting.
@@ -983,7 +971,7 @@ The sections below follow the actual `VuePomGeneratorPluginOptions` shape from `
 - **What it does:** Chooses what happens when a template already has the target attribute.
 - **Why it exists:** migrations usually start from a mixed codebase with manual ids already present.
 - **Benefit:** lets you migrate gradually (`preserve`), force replacement (`overwrite`), or enforce cleanup (`error`).
-- **Without it:** default is `"preserve"`.
+- **Without it:** default is `"error"`.
 - **Current options:**
   - `"preserve"` — keep the existing attribute
   - `"overwrite"` — replace it with the generated one
@@ -1030,7 +1018,7 @@ Set `generation: false` to keep injection and `virtual:testids` but skip emitted
 - **What it does:** Controls what happens when two generated members inside the same class want the same name.
 - **Why it exists:** collisions happen in real templates, especially when multiple elements share the same handler or weak fallback signals.
 - **Benefit:** lets you decide between strictness and convenience.
-- **Without it:** the generator silently suffixes (`"suffix"`).
+- **Without it:** the generator fails fast (`"error"`).
 - **Current options:**
   - `"error"` — fail fast
   - `"warn"` — warn and suffix

package/RELEASE_NOTES.md

@@ -1,31 +1,56 @@
-● I'll fetch the actual commits and PRs between v1.0.57 and HEAD to generate accurate release
-  notes.
-
-● Based on the commit range v1.0.57..HEAD, only PR #19 is included in this release. Here are the
-  release notes:
-
-  ---
+● # Release Notes: v1.0.59
 
   ## Highlights
 
-  - Pass annotation text through generated click helpers for better test documentation
-  - Resolve Vue compiler and Nuxt kit dependencies from consuming app setups instead of the
-  plugin's own tree
-  - Centralize Playwright video dimension configuration for consistent local and CI test
-  recordings
+  - **Major refactoring** of POM generation logic for improved maintainability and reliability
+  - **Zero runtime dependencies** – all runtime dependencies eliminated
+  - **Enhanced Nuxt support** – resolved app-root dev POM clobber and improved local app
+  integration
+  - **Split Playwright POM output** – added separate output files for better discoverability
+  - **Fail-fast error handling** – added early validation for dev snapshot generation and
+  unnameable handlers
+  - **Expanded test coverage** – new build–serve parity regression tests and additional test
+  suites
 
   ## Changes
 
-  **Local integration hardening:**
-  - Generated click helpers now accept and document annotation text parameters
-  - Resolve `@vue/compiler-sfc.parse` and `@nuxt/kit` from real consuming-app setups to avoid
-  version mismatches
-  - Add centralized Playwright video dimensions configuration (`playwright-video-dimensions.json`)
-  - Add script to normalize Playwright video settings across local config and CI environments
+  **Core Generation & Architecture**
+  - Refactored POM generation logic across class-generation, method-generation, transform, and
+  utils modules
+  - Added `pom-params.ts` and `pom-patterns.ts` modules to centralize generation logic
+  - Improved routing `to-directive` handling for awaited handler wrappers
+
+  **Plugin System**
+  - Added `resolved-generation-options.ts` and `resolved-injection-options.ts` for clearer plugin
+  configuration
+  - Enhanced `create-vue-pom-generator-plugins`, build-plugin, and dev-plugin implementations
+  - Relaxed Vite peer dependency range for broader compatibility (#13)
+
+  **Bug Fixes**
+  - Fixed reparsing of generated test IDs (#21)
+  - Hardened local app integration (#19)
+  - Restored router DOM globals after introspection (#18)
+  - Resolved Nuxt app-root dev POM clobber (#15)
+  - Fixed keyed POM dedupe and C# navigation returns (#4)
 
-  **Test coverage improvements:**
-  - Add regression tests for project-local Nuxt kit loading
-  - Enhance Nuxt discovery test coverage with real-world integration scenarios
+  **Error Handling & Validation**
+  - Added fail-fast on unnameable wrapper handlers (#11)
+  - Added fail-fast on dev snapshot generation errors (#6)
+  - Guarded manual releases (#16)
+
+  **Developer Experience**
+  - Split Playwright POM output for improved discoverability (#12)
+  - Achieved dev-mode POM generation parity with build mode (#5)
+  - Added PR release-notes preview comments (#1)
+
+  **Dependencies**
+  - Eliminated all runtime dependencies (#9)
+  - Updated package-lock.json to reflect dependency changes
+
+  **Testing**
+  - Added build–serve parity regression tests (#7)
+  - Added `base-page.test.ts`, `resolved-injection-options.test.ts`, and `playwright.d.ts` fixture
+  - Expanded coverage in class-generation, transform, utils, and options tests
 
   ## Breaking Changes
 
@@ -33,15 +58,36 @@
 
   ## Pull Requests Included
 
-  - [#19](https://github.com/immense/vue-pom-generator/pull/19) fix: harden local app integration
+  - #21 fix: avoid reparsing generated test ids
+  (https://github.com/immense/vue-pom-generator/pull/21)
+  - #19 fix: harden local app integration (https://github.com/immense/vue-pom-generator/pull/19)
+  - #18 fix: restore router DOM globals after introspection
+  (https://github.com/immense/vue-pom-generator/pull/18)
+  - #17 fix: support awaited handler wrappers
+  (https://github.com/immense/vue-pom-generator/pull/17)
+  - #16 fix: guard manual releases (https://github.com/immense/vue-pom-generator/pull/16)
+  - #15 fix: resolve Nuxt app-root dev POM clobber
+  (https://github.com/immense/vue-pom-generator/pull/15)
+  - #13 Relax Vite peer dependency range (https://github.com/immense/vue-pom-generator/pull/13)
+  - #12 feat: add split Playwright POM output for discoverability
+  (https://github.com/immense/vue-pom-generator/pull/12)
+  - #11 feat: fail fast on unnameable wrapper handlers
+  (https://github.com/immense/vue-pom-generator/pull/11)
+  - #9 refactor(deps): eliminate all runtime dependencies
+  (https://github.com/immense/vue-pom-generator/pull/9)
+  - #7 test: add build–serve parity regression tests
+  (https://github.com/immense/vue-pom-generator/pull/7)
+  - #6 fix: fail fast on dev snapshot generation errors
+  (https://github.com/immense/vue-pom-generator/pull/6)
+  - #5 fix: dev-mode POM generation parity with build mode
+  (https://github.com/immense/vue-pom-generator/pull/5)
+  - #4 Fix keyed POM dedupe and C# navigation returns
+  (https://github.com/immense/vue-pom-generator/pull/4)
+  - #1 Add PR release-notes preview comments (https://github.com/immense/vue-pom-generator/pull/1)
 
   ## Testing
 
-  Validated with:
-  - `npm run lint`
-  - `npm run typecheck`
-  - `npm run build`
-  - `npm test`
-
-  All tests passing with 258 net lines added across 13 files.
+  Comprehensive test coverage expansion with new test suites for base-page,
+  resolved-injection-options, and build–serve parity. Existing test suites updated to reflect
+  refactored architecture. All tests passing.
 

package/class-generation/base-page.ts

@@ -1,5 +1,5 @@
 import type { PwLocator, PwPage } from "./playwright-types";
-import { TESTID_CLICK_EVENT_NAME, TESTID_CLICK_EVENT_STRICT_FLAG } from "../click-instrumentation";
+import { TESTID_CLICK_EVENT_NAME } from "../click-instrumentation";
 import type { TestIdClickEventDetail } from "../click-instrumentation";
 import { Callout } from "./callout";
 import type { CalloutRenderer } from "./callout";
@@ -118,6 +118,10 @@ export class BasePage {
     this.pointer = new Pointer(this.page, this.testIdAttribute, this.callout, pointerRenderer);
   }
 
+  public get screencast(): PwPage["screencast"] {
+    return this.page.screencast;
+  }
+
   private async waitForTestIdClickEventAfter(testId: string, options?: { timeoutMs?: number }): Promise<void> {
     if (!REQUIRE_CLICK_EVENT) {
       return;
@@ -135,7 +139,7 @@ export class BasePage {
     // In that scenario, the click already did its job; don't fail the test infra.
     try {
       await this.page.evaluate(
-        ({ eventName, strictFlagName, expectedTestId, timeoutMs, requireEvent, debug }) => {
+        ({ eventName, expectedTestId, timeoutMs, requireEvent, debug }) => {
           return new Promise<void>((resolve, reject) => {
             const g = globalThis;
             if (!g || typeof g.addEventListener !== "function") {
@@ -143,16 +147,6 @@ export class BasePage {
               return;
             }
 
-            // Mark strict mode in the page so the injected click wrapper can
-            // fail fast (no fallback) when instrumentation is expected.
-            if (requireEvent) {
-              try {
-                type GlobalWithFlag = typeof globalThis & { [k: string]: boolean | undefined };
-                (g as GlobalWithFlag)[strictFlagName] = true;
-              }
-              catch { /* noop */ }
-            }
-
             const cleanup = (timer: ReturnType<typeof setTimeout>, onEvent: (evt: Event) => void) => {
               clearTimeout(timer);
               try {
@@ -216,7 +210,6 @@ export class BasePage {
         },
         {
           eventName: TESTID_CLICK_EVENT_NAME,
-          strictFlagName: TESTID_CLICK_EVENT_STRICT_FLAG,
           expectedTestId: testId,
           timeoutMs,
           requireEvent,