@immense/vue-pom-generator 1.0.39 → 1.0.40

package/RELEASE_NOTES.md

@@ -1,28 +1,24 @@
-● # Release Notes: v1.0.39
+● # Release Notes - v1.0.40
 
   ## Highlights
 
-  - **Flattened helper attachments**: New capability in class generation for handling helper
-  attachments in a flattened structure
-  - **Extensive documentation updates**: README expanded with over 1,100 new lines of
-  documentation
-  - **Enhanced test coverage**: Added 89 lines of new tests for generated TypeScript compilation
-  - **PR automation**: Added release notes preview comments on pull requests
+  - Fixed keyed POM deduplication logic
+  - Fixed C# navigation return handling
+  - Added PR release-notes preview comment automation
+  - Improved test coverage with new test cases for class generation and utilities
 
   ## Changes
 
-  ### Features
-  - Add flattened helper attachments support in class generation (`class-generation/index.ts`)
-
-  ### Documentation
-  - Significantly expanded README with detailed documentation (+1,118 lines)
+  **Bug Fixes**
+  - Fixed keyed POM dedupe logic in utils
+  - Corrected C# navigation return handling in class generation
 
-  ### Testing
-  - Enhanced `tests/generated-tsc.test.ts` with additional test cases (+89 lines)
+  **Tooling & Automation**
+  - Added automated PR release-notes preview comments
 
-  ### Tooling
-  - Added PR release-notes preview comment automation
-  - Minor updates to plugin type definitions and support files
+  **Testing**
+  - Added 60+ new test cases for class generation coverage
+  - Added 50+ new test cases for utilities coverage
 
   ## Breaking Changes
 
@@ -30,11 +26,13 @@
 
   ## Pull Requests Included
 
+  - #4 Fix keyed POM dedupe and C# navigation returns
+  (https://github.com/immense/vue-pom-generator/pull/4) by @dkattan
   - #1 Add PR release-notes preview comments (https://github.com/immense/vue-pom-generator/pull/1)
    by @dkattan
 
   ## Testing
 
-  Tests updated and expanded to cover new flattened helper attachments functionality. Added 89
-  lines of test coverage in `tests/generated-tsc.test.ts`.
+  Added comprehensive test coverage with 110+ new test cases across class generation and utility
+  functions.
 

package/class-generation/index.ts

@@ -855,6 +855,7 @@ function generateAggregatedCSharpFiles(
         chunks.push("    {");
         if (pom.formattedDataTestId.includes("${") || allTestIds.length <= 1) {
           chunks.push(`        await ${locatorName}${pom.formattedDataTestId.includes("${") ? `(${args})` : ""}.ClickAsync();`);
+          chunks.push(`        return new ${target}(Page);`);
         }
         else {
           chunks.push("        Exception? lastError = null;");
@@ -876,7 +877,6 @@ function generateAggregatedCSharpFiles(
           chunks.push("        }");
           chunks.push("        throw lastError ?? new System.Exception(\"[pom] Failed to navigate using any candidate test id.\");");
         }
-        chunks.push(`        return new ${target}(Page);`);
         chunks.push("    }");
         chunks.push("");
         continue;

package/dist/index.cjs

@@ -2095,9 +2095,6 @@ Fix: either (1) include ${args.bestKeyPlaceholder} in your :${attrLabel} templat
   })();
   const tryMergeWithExistingPrimary = (candidateActionName) => {
     const mergeKey = (args.pomMergeKey ?? "").trim();
-    if (isKeyed) {
-      return false;
-    }
     const existingEntry = primaryByActionName.get(candidateActionName);
     const existingPom = existingEntry?.pom;
     if (!existingEntry || !existingPom) {
@@ -2108,6 +2105,9 @@ Fix: either (1) include ${args.bestKeyPlaceholder} in your :${attrLabel} templat
       ...existingPom.alternateFormattedDataTestIds ?? []
     ];
     const sharesSelectorIdentity = existingSelectors.includes(formattedDataTestIdForPom);
+    if (isKeyed && !sharesSelectorIdentity) {
+      return false;
+    }
     if (!mergeKey && !sharesSelectorIdentity) {
       return false;
     }
@@ -2154,6 +2154,11 @@ Fix: either (1) include ${args.bestKeyPlaceholder} in your :${attrLabel} templat
           conflicts = false;
         }
       }
+      if (conflicts && nameCollisionBehavior === "error" && tryMergeWithExistingPrimary(actionName)) {
+        methodName = candidate;
+        mergedIntoExisting = true;
+        break;
+      }
       if (conflicts && nameCollisionBehavior === "error") {
         const roleSuffix = upperFirst(normalizedRole || "Element");
         const baseNameUpper = upperFirst(baseWithSuffix);
@@ -2200,11 +2205,6 @@ Fix: either (1) include ${args.bestKeyPlaceholder} in your :${attrLabel} templat
         reservedMembers.add(actionName);
         break;
       }
-      if (nameCollisionBehavior === "error" && tryMergeWithExistingPrimary(actionName)) {
-        methodName = candidate;
-        mergedIntoExisting = true;
-        break;
-      }
       if (!collisionDetails) {
         collisionDetails = { getterName: chosenGetterName, actionName };
         collisionHint = hint || (args.semanticNameHint ?? "").trim() || null;
@@ -3781,6 +3781,7 @@ function generateAggregatedCSharpFiles(componentHierarchyMap, outDir, options =
         chunks.push("    {");
         if (pom.formattedDataTestId.includes("${") || allTestIds.length <= 1) {
           chunks.push(`        await ${locatorName}${pom.formattedDataTestId.includes("${") ? `(${args})` : ""}.ClickAsync();`);
+          chunks.push(`        return new ${target}(Page);`);
         } else {
           chunks.push("        Exception? lastError = null;");
           chunks.push(`        foreach (var testId in new[] { ${allTestIds.map(toCSharpTestIdExpression).join(", ")} })`);
@@ -3801,7 +3802,6 @@ function generateAggregatedCSharpFiles(componentHierarchyMap, outDir, options =
           chunks.push("        }");
           chunks.push('        throw lastError ?? new System.Exception("[pom] Failed to navigate using any candidate test id.");');
         }
-        chunks.push(`        return new ${target}(Page);`);
         chunks.push("    }");
         chunks.push("");
         continue;