@immense/vue-pom-generator 1.0.30 → 1.0.31

package/README.md

@@ -35,15 +35,15 @@ Exported entrypoints:
 - `injection`: how `data-testid` (or your chosen attribute) is derived/injected
 - `generation`: how Page Object Models (POMs) and Playwright helpers are generated
 
-The generator emits an aggregated output under `generation.outDir` (default `tests/playwright/generated`):
+The generator emits an aggregated output under `generation.outDir` (default `tests/playwright/__generated__`):
 
-- `tests/playwright/generated/page-object-models.g.ts` (generated; do not edit)
-- `tests/playwright/generated/index.ts` (generated stable barrel)
-- managed `.gitattributes` files alongside generated outputs so GitHub Linguist treats them as generated by default
+- `tests/playwright/__generated__/page-object-models.g.ts` (generated; do not edit)
+- `tests/playwright/__generated__/index.ts` (generated stable barrel)
+- managed `.gitattributes` files only when you emit outside `__generated__`
 
 If `generation.playwright.fixtures` is enabled, it also emits:
 
-- `tests/playwright/generated/fixtures.g.ts` (generated; do not edit)
+- `tests/playwright/__generated__/fixtures.g.ts` (generated; do not edit)
 
 ### Vite config example
 
@@ -98,8 +98,8 @@ export default defineConfig(() => {
         namespace: "MyProject.Tests.Generated",
       },
 
-      // Default: tests/playwright/generated
-      outDir: "tests/playwright/generated",
+      // Default: tests/playwright/__generated__
+      outDir: "tests/playwright/__generated__",
 
       // Controls how to handle duplicate generated member names within a single POM class.
       // - "error": fail compilation

package/RELEASE_NOTES.md

@@ -1,44 +1,57 @@
-● # Release Notes: v1.0.30
+● I need to see the actual diff content to understand what the fix addressed. Let me get the file
+  diffs:
 
-  ## Highlights
+● Let me look at specific key changes to understand what was fixed:
 
-  - Refactored wrapper search roots configuration for improved flexibility
-  - Enhanced plugin system with better type definitions and support
-  - Improved test coverage with expanded transform test cases
-  - Added CI automation for PR release note previews
+● Based on the commit and PR details, here are the release notes:
 
-  ## Changes
+  ---
 
-  ### Core Functionality
-  - Refactored wrapper search roots configuration in transform logic
-  - Enhanced transform logic with improved structure (198 additions, significant reorganization)
+  ## Highlights
 
-  ### Plugin System
-  - Updated plugin types with refined interfaces
-  - Improved Vue plugin implementation
-  - Enhanced plugin creation utilities
-  - Better dev plugin support
+  - Changed default output directory from `tests/playwright/generated` to
+  `tests/playwright/__generated__` for better convention adherence
+  - Improved `.gitattributes` generation: now skips managed entries for paths using
+  `__generated__` heuristic (GitHub Linguist auto-detects these)
+  - Enhanced slot scope key extraction logic for more robust click handler naming in generated
+  POMs
+  - Added comprehensive utility functions for analyzing assignment patterns, object destructuring,
+   and binding identifiers
+
+  ## Changes
 
-  ### Testing & Quality
-  - Expanded transform test suite with additional test cases
-  - Updated test assertions for improved coverage
+  **Output Directory Convention**
+  - Updated default `generation.outDir` to `tests/playwright/__generated__`
+  - Updated default Playwright fixtures output to use `__generated__` subdirectory
+  - `.gitattributes` entries are now only generated when using custom output directories outside
+  `__generated__`
 
-  ### Tooling & CI
-  - Added automated PR release-notes preview comments
+  **Click Handler Naming**
+  - Improved slot scope key candidate extraction with priority-based selection
+  - Added support for object destructuring patterns in slot scope analysis
+  - Enhanced fallback key expression generation for slot scoped elements
+  - Better handling of assignment patterns, rest elements, and object properties
 
-  ### Documentation
-  - Updated README with additional information
+  **Code Quality**
+  - Added test coverage for new utility functions in `class-generation-coverage.test.ts` and
+  `utils-coverage.test.ts`
+  - Expanded Babel type guards usage for more precise AST node detection
+  - Refactored slot scope analysis with dedicated helper functions
 
   ## Breaking Changes
 
-  None identified in this release.
+  - **Default output directory** changed from `tests/playwright/generated` to
+  `tests/playwright/__generated__`. If you're relying on the default, generated files will move to
+   the new location. To preserve the old behavior, explicitly set `generation.outDir:
+  "tests/playwright/generated"` in your config.
 
   ## Pull Requests Included
 
-  - #1 Add PR release-notes preview comments (https://github.com/immense/vue-pom-generator/pull/1)
-   by @dkattan
+  - [#1 Add PR release-notes preview
+  comments](https://github.com/immense/vue-pom-generator/pull/1) by @dkattan
 
   ## Testing
 
-  Existing test suite updated and expanded with new test cases in `transform.test.ts`.
+  Added test coverage for new utility functions covering class generation and slot scope analysis
+  edge cases.
 

package/class-generation/index.ts

@@ -524,6 +524,11 @@ function escapeGitAttributesPattern(value: string): string {
   return output;
 }
 
+function pathUsesGeneratedHeuristic(filePath: string): boolean {
+  const normalized = path.normalize(filePath);
+  return normalized.split(path.sep).includes("__generated__");
+}
+
 function buildManagedGitAttributesBlock(entries: string[]): string {
   return [
     GENERATED_GITATTRIBUTES_BLOCK_START,
@@ -581,6 +586,10 @@ function buildGeneratedGitAttributesFiles(generatedFilePaths: string[]): Generat
       continue;
     }
 
+    if (pathUsesGeneratedHeuristic(resolvedFilePath)) {
+      continue;
+    }
+
     const dir = path.dirname(resolvedFilePath);
     const entry = `${escapeGitAttributesPattern(path.basename(resolvedFilePath))} linguist-generated`;
     const entries = entriesByDir.get(dir) ?? new Set<string>();

package/dist/index.cjs

@@ -606,6 +606,124 @@ function getTemplateSlotScope(node) {
   }
   return null;
 }
+function isSimpleScopeIdentifier(value) {
+  return /^[A-Za-z_$][A-Za-z0-9_$]*$/.test(value);
+}
+function buildSlotScopeFallbackKeyExpression(identifier) {
+  return `${identifier}.key ?? ${identifier}.data?.id ?? ${identifier}.id ?? ${identifier}.value ?? ${identifier}`;
+}
+function tryGetBindingIdentifierName(node) {
+  if (!node) {
+    return null;
+  }
+  if (types.isIdentifier(node)) {
+    return node.name;
+  }
+  if (types.isAssignmentPattern(node)) {
+    return tryGetBindingIdentifierName(node.left);
+  }
+  if (types.isRestElement(node)) {
+    return tryGetBindingIdentifierName(node.argument);
+  }
+  return null;
+}
+function getSlotScopeObjectPropertyKeyName(node) {
+  if (types.isIdentifier(node)) {
+    return node.name;
+  }
+  if (types.isStringLiteral(node)) {
+    return node.value;
+  }
+  return null;
+}
+function tryGetSlotScopeKeyCandidate(node) {
+  if (!node) {
+    return null;
+  }
+  if (types.isIdentifier(node)) {
+    return {
+      priority: 2,
+      expression: buildSlotScopeFallbackKeyExpression(node.name)
+    };
+  }
+  if (types.isAssignmentPattern(node)) {
+    return tryGetSlotScopeKeyCandidate(node.left);
+  }
+  if (types.isRestElement(node)) {
+    return tryGetSlotScopeKeyCandidate(node.argument);
+  }
+  if (!types.isObjectPattern(node)) {
+    return null;
+  }
+  let best = null;
+  for (const property of node.properties) {
+    let candidate = null;
+    if (types.isRestElement(property)) {
+      candidate = tryGetSlotScopeKeyCandidate(property.argument);
+      if (candidate) {
+        candidate = { ...candidate, priority: Math.max(candidate.priority, 2) };
+      }
+    } else if (types.isObjectProperty(property)) {
+      const keyName = getSlotScopeObjectPropertyKeyName(property.key);
+      const bindingName = tryGetBindingIdentifierName(property.value) ?? tryGetBindingIdentifierName(property.key);
+      if (bindingName) {
+        if (keyName === "key" || bindingName === "key") {
+          candidate = {
+            priority: 0,
+            expression: bindingName
+          };
+        } else {
+          candidate = {
+            priority: keyName === "data" ? 1 : 2,
+            expression: buildSlotScopeFallbackKeyExpression(bindingName)
+          };
+        }
+      }
+    }
+    if (candidate && (!best || candidate.priority < best.priority)) {
+      best = candidate;
+    }
+  }
+  return best;
+}
+function tryGetTemplateSlotScopeKeyExpression(scope) {
+  const trimmed = scope.trim();
+  if (!trimmed) {
+    return null;
+  }
+  if (isSimpleScopeIdentifier(trimmed)) {
+    return buildSlotScopeFallbackKeyExpression(trimmed);
+  }
+  try {
+    const parsed = parser.parse(`(${trimmed}) => {}`, {
+      sourceType: "module",
+      plugins: ["typescript"]
+    });
+    const statement = parsed.program.body[0];
+    if (statement && types.isExpressionStatement(statement) && types.isArrowFunctionExpression(statement.expression)) {
+      return tryGetSlotScopeKeyCandidate(statement.expression.params[0])?.expression ?? null;
+    }
+  } catch {
+  }
+  if (trimmed.startsWith("{") && trimmed.endsWith("}")) {
+    const inner = trimmed.slice(1, -1).trim();
+    let cutIdx = -1;
+    const commaIdx = inner.indexOf(",");
+    const colonIdx = inner.indexOf(":");
+    if (commaIdx !== -1 && colonIdx !== -1) {
+      cutIdx = Math.min(commaIdx, colonIdx);
+    } else if (commaIdx !== -1) {
+      cutIdx = commaIdx;
+    } else if (colonIdx !== -1) {
+      cutIdx = colonIdx;
+    }
+    const first = (cutIdx === -1 ? inner : inner.slice(0, cutIdx)).trim();
+    if (first && isSimpleScopeIdentifier(first)) {
+      return buildSlotScopeFallbackKeyExpression(first);
+    }
+  }
+  return trimmed;
+}
 function nodeHasToDirective(node) {
   const toDirective = findDirectiveByName(node, "bind", "to");
   if (toDirective?.exp) {
@@ -681,25 +799,7 @@ function getContainedInSlotDataKeyValue(node, hierarchyMap2) {
     if (parent.type === compilerCore.NodeTypes.ELEMENT && parent.tag === "template") {
       const scope = getTemplateSlotScope(parent);
       if (scope) {
-        let key = scope.trim();
-        if (key.startsWith("{") && key.endsWith("}")) {
-          const inner = key.slice(1, -1).trim();
-          let cutIdx = -1;
-          const commaIdx = inner.indexOf(",");
-          const colonIdx = inner.indexOf(":");
-          if (commaIdx !== -1 && colonIdx !== -1) {
-            cutIdx = Math.min(commaIdx, colonIdx);
-          } else if (commaIdx !== -1) {
-            cutIdx = commaIdx;
-          } else if (colonIdx !== -1) {
-            cutIdx = colonIdx;
-          }
-          const first = (cutIdx === -1 ? inner : inner.slice(0, cutIdx)).trim();
-          if (first) {
-            key = first;
-          }
-        }
-        return key;
+        return tryGetTemplateSlotScopeKeyExpression(scope);
       }
     }
     parent = getParent(hierarchyMap2, parent);
@@ -1350,11 +1450,11 @@ function getStableClickHandlerNameFromExpression(exp) {
     return extractNameFromCallee(callee);
   }
   if (types.isAssignmentExpression(exp)) {
-    const left = exp.left;
-    if (types.isIdentifier(left))
-      return left.name;
-    if (types.isMemberExpression(left) || types.isOptionalMemberExpression(left))
-      return extractMemberPropertyName(left);
+    const left = getAssignmentTargetNameFromBabel(exp.left);
+    if (left) {
+      const right = getStableAssignmentValueSuffixFromBabel(exp.right);
+      return `Set${toPascalCase(left)}${right}`;
+    }
     return "";
   }
   if (types.isOptionalMemberExpression(exp)) {
@@ -1429,6 +1529,71 @@ function extractMemberPropertyName(member) {
   }
   return "";
 }
+function getLastIdentifierFromMemberChainBabel(node) {
+  if (!node) {
+    return "";
+  }
+  if (types.isIdentifier(node)) {
+    return node.name;
+  }
+  if (types.isMemberExpression(node) || types.isOptionalMemberExpression(node)) {
+    if (!node.computed) {
+      if (types.isIdentifier(node.property)) {
+        return node.property.name;
+      }
+    } else if (types.isStringLiteral(node.property)) {
+      return node.property.value;
+    }
+  }
+  return "";
+}
+function getAssignmentTargetNameFromBabel(node) {
+  if (!node) {
+    return "";
+  }
+  if (types.isIdentifier(node)) {
+    return node.name;
+  }
+  if (types.isMemberExpression(node) || types.isOptionalMemberExpression(node)) {
+    if (!node.computed && types.isIdentifier(node.property) && node.property.name === "value") {
+      return getLastIdentifierFromMemberChainBabel(node.object);
+    }
+    return getLastIdentifierFromMemberChainBabel(node);
+  }
+  return "";
+}
+function getStableAssignmentValueSuffixFromBabel(node) {
+  if (!node) {
+    return "";
+  }
+  if (types.isBooleanLiteral(node)) {
+    return node.value ? "True" : "False";
+  }
+  if (types.isNumericLiteral(node)) {
+    return `Value${String(node.value)}`;
+  }
+  if (types.isNullLiteral(node)) {
+    return "Null";
+  }
+  if (types.isStringLiteral(node)) {
+    const cleaned = (node.value ?? "").trim();
+    return cleaned ? toPascalCase(cleaned.slice(0, 24)) : "";
+  }
+  if (types.isTemplateLiteral(node) && node.expressions.length === 0) {
+    const value = node.quasis.map((q) => q.value?.cooked ?? "").join("").trim();
+    return value ? toPascalCase(value.slice(0, 24)) : "";
+  }
+  if (types.isMemberExpression(node) || types.isOptionalMemberExpression(node)) {
+    const name = getLastIdentifierFromMemberChainBabel(node);
+    return name ? toPascalCase(name.slice(0, 24)) : "";
+  }
+  if (types.isIdentifier(node)) {
+    const firstChar = node.name.charAt(0);
+    const isUpperAlpha = firstChar !== "" && firstChar === firstChar.toUpperCase() && firstChar !== firstChar.toLowerCase();
+    return isUpperAlpha ? toPascalCase(node.name.slice(0, 24)) : "";
+  }
+  return "";
+}
 function isCompilerGeneratedReferenceRoot(name) {
   return name.startsWith("_") || name.startsWith("$");
 }
@@ -3240,6 +3405,10 @@ function escapeGitAttributesPattern(value) {
   }
   return output;
 }
+function pathUsesGeneratedHeuristic(filePath) {
+  const normalized = path.normalize(filePath);
+  return normalized.split(path.sep).includes("__generated__");
+}
 function buildManagedGitAttributesBlock(entries) {
   return [
     GENERATED_GITATTRIBUTES_BLOCK_START,
@@ -3287,6 +3456,9 @@ function buildGeneratedGitAttributesFiles(generatedFilePaths) {
     if (path.basename(resolvedFilePath) === ".gitattributes") {
       continue;
     }
+    if (pathUsesGeneratedHeuristic(resolvedFilePath)) {
+      continue;
+    }
     const dir = path.dirname(resolvedFilePath);
     const entry = `${escapeGitAttributesPattern(path.basename(resolvedFilePath))} linguist-generated`;
     const entries = entriesByDir.get(dir) ?? /* @__PURE__ */ new Set();
@@ -6197,7 +6369,7 @@ function createVuePomGeneratorPlugins(options = {}) {
   const excludedComponents = injection.excludeComponents ?? [];
   const testIdAttribute = (injection.attribute ?? "data-testid").trim() || "data-testid";
   const existingIdBehavior = injection.existingIdBehavior ?? "preserve";
-  const outDir = (generationOptions?.outDir ?? "tests/playwright/generated").trim();
+  const outDir = (generationOptions?.outDir ?? "tests/playwright/__generated__").trim();
   const emitLanguages = generationOptions?.emit && generationOptions.emit.length ? generationOptions.emit : ["ts"];
   const nameCollisionBehavior = generationOptions?.nameCollisionBehavior ?? "suffix";
   const routerEntry = generationOptions?.router?.entry;