@immense/vue-pom-generator 1.0.26 → 1.0.28

package/RELEASE_NOTES.md

@@ -1,19 +1,27 @@
-● ## Highlights
+● # v1.0.28
 
-  - Fixed issue where radio options were incorrectly inferred as wrapper elements
-  - Added test coverage for radio option inference logic
-  - Improved PR workflow with automated release-notes preview comments
+  ## Highlights
+
+  - Fixed test ID generation to preserve simple member-expression patterns (e.g.,
+  `this.someProperty`)
+  - Added automated PR release notes preview comments via GitHub Actions workflow
+  - Enhanced test coverage for utility functions
 
   ## Changes
 
-  **Bug Fixes**
-  - Avoid inferring radio options as wrappers ([5f6d7bf])
+  ### Bug Fixes
+  - Preserve simple member-expression test IDs in transformed code
 
-  **Testing**
-  - Added test cases for utils coverage
+  ### CI/CD Improvements
+  - Added dual-strategy release notes generation via PR comments
+    - Copilot SDK-based workflow with comment upsert
+    - Copilot agentic workflow via gh-aw
+  - Release notes preview now posted automatically on PRs
 
-  **Developer Experience**
-  - Added PR release-notes preview comments (#1)
+  ### Testing
+  - Added 24+ test cases in `transform.test.ts`
+  - Added 48+ test cases in `utils-coverage.test.ts` for utility function coverage
+  - Enhanced validation of member-expression handling
 
   ## Breaking Changes
 
@@ -21,11 +29,11 @@
 
   ## Pull Requests Included
 
-  - #1 [Add PR release-notes preview
-  comments](https://github.com/immense/vue-pom-generator/pull/1) by @dkattan
+  - [#1](https://github.com/immense/vue-pom-generator/pull/1) Add PR release-notes preview
+  comments (@dkattan)
 
   ## Testing
 
-  Added 11 lines of test coverage in `tests/utils-coverage.test.ts` to verify the radio options
-  inference fix.
+  Comprehensive test coverage added for the member-expression fix with 72+ new test cases across
+  transform and utility modules.
 

package/dist/index.cjs

@@ -1429,6 +1429,25 @@ function extractMemberPropertyName(member) {
   }
   return "";
 }
+function isCompilerGeneratedReferenceRoot(name) {
+  return name.startsWith("_") || name.startsWith("$");
+}
+function tryGetPreservableDynamicReferenceExpression(node) {
+  if (!node || typeof node !== "object") {
+    return null;
+  }
+  if (types.isIdentifier(node)) {
+    return isCompilerGeneratedReferenceRoot(node.name) ? null : node.name;
+  }
+  if (!types.isMemberExpression(node) || node.computed) {
+    return null;
+  }
+  const objectExpression = tryGetPreservableDynamicReferenceExpression(node.object);
+  if (!objectExpression || !types.isIdentifier(node.property)) {
+    return null;
+  }
+  return `${objectExpression}.${node.property.name}`;
+}
 function normalizeHandlerName(name) {
   if (!name) {
     return "";
@@ -1531,6 +1550,17 @@ function tryGetExistingElementDataTestId(node, attributeName = "data-testid") {
     }
     return { value, isDynamic: false, isStaticLiteral: true };
   }
+  const preservableReference = tryGetPreservableDynamicReferenceExpression(ast);
+  if (preservableReference) {
+    return {
+      value: preservableReference,
+      isDynamic: true,
+      isStaticLiteral: false,
+      template: `\${${preservableReference}}`,
+      templateExpressionCount: 1,
+      rawExpression: preservableReference
+    };
+  }
   const raw = (simpleExp.content ?? "").trim();
   if (!raw) {
     return null;
@@ -1558,6 +1588,17 @@ function tryGetExistingElementDataTestId(node, attributeName = "data-testid") {
       const sl = ast2;
       return { value: sl.value ?? "", isDynamic: false, isStaticLiteral: true };
     }
+    const preservableReference2 = tryGetPreservableDynamicReferenceExpression(ast2);
+    if (preservableReference2) {
+      return {
+        value: preservableReference2,
+        isDynamic: true,
+        isStaticLiteral: false,
+        template: `\${${preservableReference2}}`,
+        templateExpressionCount: 1,
+        rawExpression: preservableReference2
+      };
+    }
   } catch {
   }
   return { value: raw, isDynamic: true, isStaticLiteral: false, rawExpression: raw };
@@ -1863,9 +1904,6 @@ Fix: either (1) include ${args.bestKeyPlaceholder} in your :${attrLabel} templat
   })();
   const tryMergeWithExistingPrimary = (candidateActionName) => {
     const mergeKey = (args.pomMergeKey ?? "").trim();
-    if (!mergeKey) {
-      return false;
-    }
     if (isKeyed) {
       return false;
     }
@@ -1874,7 +1912,15 @@ Fix: either (1) include ${args.bestKeyPlaceholder} in your :${attrLabel} templat
     if (!existingEntry || !existingPom) {
       return false;
     }
-    if ((existingPom.mergeKey ?? "").trim() !== mergeKey) {
+    const existingSelectors = [
+      existingPom.formattedDataTestId,
+      ...existingPom.alternateFormattedDataTestIds ?? []
+    ];
+    const sharesSelectorIdentity = existingSelectors.includes(formattedDataTestIdForPom);
+    if (!mergeKey && !sharesSelectorIdentity) {
+      return false;
+    }
+    if (mergeKey && (existingPom.mergeKey ?? "").trim() !== mergeKey && !sharesSelectorIdentity) {
       return false;
     }
     if (existingPom.nativeRole !== normalizedRole) {
@@ -4840,8 +4886,46 @@ function createTestIdTransform(componentName, componentHierarchyMap, nativeWrapp
   const normalizedViewsDirAbs = path.normalize(safeRealpath(path.resolve(viewsDirAbs)));
   const generatedMethodContentByComponent = /* @__PURE__ */ new Map();
   const lastConditionalHintByParent = /* @__PURE__ */ new WeakMap();
+  const lastConditionalMergeGroupByParent = /* @__PURE__ */ new WeakMap();
   const conditionalHintByElement = /* @__PURE__ */ new WeakMap();
   const conditionalHintByIfBranch = /* @__PURE__ */ new WeakMap();
+  const conditionalMergeGroupByElement = /* @__PURE__ */ new WeakMap();
+  const conditionalMergeGroupByElementLoc = /* @__PURE__ */ new Map();
+  const conditionalMergeGroupByIfBranch = /* @__PURE__ */ new WeakMap();
+  let conditionalMergeGroupCounter = 0;
+  const getElementLocationKey = (element) => {
+    const startOffset = element.loc?.start.offset;
+    const endOffset = element.loc?.end.offset;
+    if (typeof startOffset !== "number" || typeof endOffset !== "number") {
+      return null;
+    }
+    return `${element.tag}:${startOffset}:${endOffset}`;
+  };
+  const markConditionalMergeGroup = (nodes, mergeGroupKey) => {
+    for (const child of nodes) {
+      if (child.type === compilerCore.NodeTypes.ELEMENT) {
+        const element = child;
+        conditionalMergeGroupByElement.set(element, mergeGroupKey);
+        const elementLocationKey = getElementLocationKey(element);
+        if (elementLocationKey) {
+          conditionalMergeGroupByElementLoc.set(elementLocationKey, mergeGroupKey);
+        }
+        markConditionalMergeGroup(element.children, mergeGroupKey);
+        continue;
+      }
+      if (child.type === compilerCore.NodeTypes.IF) {
+        const ifNode = child;
+        for (const branch of ifNode.branches ?? []) {
+          markConditionalMergeGroup(branch.children, mergeGroupKey);
+        }
+        continue;
+      }
+      if (child.type === compilerCore.NodeTypes.IF_BRANCH || child.type === compilerCore.NodeTypes.FOR) {
+        const branchLike = child;
+        markConditionalMergeGroup(branchLike.children ?? [], mergeGroupKey);
+      }
+    }
+  };
   return (node, context) => {
     if (excludedComponents.includes(componentName)) {
       return;
@@ -4849,8 +4933,15 @@ function createTestIdTransform(componentName, componentHierarchyMap, nativeWrapp
     if (node.type === compilerCore.NodeTypes.IF) {
       const ifNode = node;
       const branches = ifNode.branches ?? [];
+      const mergeGroupKey = `if-group:${++conditionalMergeGroupCounter}`;
+      const ifParentKey = context?.parent ? context.parent : null;
+      if (ifParentKey) {
+        lastConditionalMergeGroupByParent.set(ifParentKey, mergeGroupKey);
+      }
       let lastHint = null;
       for (const branch of branches) {
+        conditionalMergeGroupByIfBranch.set(branch, mergeGroupKey);
+        markConditionalMergeGroup(branch.children ?? [], mergeGroupKey);
         const cond = branch.condition ?? null;
         if (!cond) {
           const hint = lastHint ? `else ${lastHint}` : "else";
@@ -4929,10 +5020,28 @@ function createTestIdTransform(componentName, componentHierarchyMap, nativeWrapp
     const bestKeyPlaceholder = isSlotKey ? `\${${bestKeyInferred}}` : bestKeyInferred;
     const bestKeyVariable = isSlotKey ? bestKeyInferred : null;
     const keyValuesOverride = tryGetContainedInStaticVForSourceLiteralValues(context);
-    const parentKey = !parentIsRoot && context?.parent ? context.parent : null;
+    const parentKey = context?.parent ? context.parent : null;
     const conditional = getConditionalDirectiveInfo(element);
     let conditionalHint = null;
+    const elementLocationKey = getElementLocationKey(element);
+    let conditionalMergeGroupKey = (elementLocationKey ? conditionalMergeGroupByElementLoc.get(elementLocationKey) ?? null : null) ?? conditionalMergeGroupByElement.get(element) ?? null;
+    if (!conditionalMergeGroupKey && context?.parent?.type === compilerCore.NodeTypes.IF_BRANCH) {
+      const branch = context.parent;
+      conditionalMergeGroupKey = conditionalMergeGroupByIfBranch.get(branch) ?? null;
+    }
     if (conditional && (conditional.kind === "if" || conditional.kind === "else-if")) {
+      if (parentKey) {
+        if (!conditionalMergeGroupKey) {
+          if (conditional.kind === "if") {
+            conditionalMergeGroupKey = `if-group:${++conditionalMergeGroupCounter}`;
+          } else {
+            conditionalMergeGroupKey = lastConditionalMergeGroupByParent.get(parentKey) ?? null;
+          }
+        }
+        if (conditionalMergeGroupKey) {
+          lastConditionalMergeGroupByParent.set(parentKey, conditionalMergeGroupKey);
+        }
+      }
       conditionalHint = tryExtractStableHintFromConditionalExpressionSource(conditional.source);
       if (conditionalHint && parentKey) {
         lastConditionalHintByParent.set(parentKey, conditionalHint);
@@ -4941,6 +5050,7 @@ function createTestIdTransform(componentName, componentHierarchyMap, nativeWrapp
       if (parentKey) {
         const previousHint = lastConditionalHintByParent.get(parentKey) ?? null;
         conditionalHint = previousHint ? `else ${previousHint}` : null;
+        conditionalMergeGroupKey = lastConditionalMergeGroupByParent.get(parentKey) ?? null;
       }
     }
     if (!conditionalHint && context?.parent?.type === compilerCore.NodeTypes.IF_BRANCH) {
@@ -5048,11 +5158,13 @@ Fix: remove the explicit ${attrLabel}, or change existingIdBehavior to "overwrit
       const nativeRole = nativeWrappers[element.tag]?.role ?? element.tag;
       const primarySemanticHint = semanticNameHint || conditionalHint || void 0;
       const alternates = nameCollisionBehavior === "error" && semanticNameHint && conditionalHint ? [`${semanticNameHint} ${conditionalHint}`] : void 0;
+      const pomMergeKey = semanticNameHint && conditionalMergeGroupKey ? `wrapper:ifgroup:${conditionalMergeGroupKey}:model:${semanticNameHint}` : void 0;
       applyResolvedDataTestIdForElement({
         preferredGeneratedValue: nativeWrappersValue,
         nativeRoleOverride: nativeRole,
         semanticNameHint: primarySemanticHint,
-        semanticNameHintAlternates: alternates
+        semanticNameHintAlternates: alternates,
+        pomMergeKey
       });
       return;
     }