@imfusion/web-ui 0.5.1-dev.5.gb4de52d7 → 0.5.1-dev.51.gad24cd6e

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (72) hide show
  1. package/README.md +156 -55
  2. package/bin/install.js +428 -0
  3. package/bin/install.test.ts +329 -0
  4. package/dist/build/vite-css-module-names/index.d.ts +20 -0
  5. package/dist/build/vite-css-module-names.js +17 -0
  6. package/dist/{code-qBbqAHK-.js → code-B83kAmnS.js} +21 -15
  7. package/dist/components/code/code.d.ts +10 -18
  8. package/dist/components/field/field.d.ts +104 -0
  9. package/dist/components/field/field.meta.d.ts +2 -0
  10. package/dist/components/field/index.d.ts +2 -0
  11. package/dist/components/fieldset/fieldset.d.ts +29 -0
  12. package/dist/components/fieldset/fieldset.meta.d.ts +2 -0
  13. package/dist/components/fieldset/index.d.ts +2 -0
  14. package/dist/index.d.ts +2 -0
  15. package/dist/index.js +4956 -4317
  16. package/dist/integrations/code-highlight/code-highlight.d.ts +8 -6
  17. package/dist/integrations/code-highlight/highlighter.d.ts +32 -3
  18. package/dist/integrations/code-highlight/language-patterns.d.ts +7 -0
  19. package/dist/integrations/code-highlight/languages/cmake.d.ts +1 -0
  20. package/dist/integrations/code-highlight/languages/cpp.d.ts +1 -0
  21. package/dist/integrations/code-highlight/languages/python.d.ts +1 -0
  22. package/dist/integrations/code-highlight.js +196 -58
  23. package/dist/integrations/image-display-options.js +1 -1
  24. package/dist/llms/gen-tokens.d.ts +7 -0
  25. package/dist/style.css +1 -1
  26. package/dist/{tabs-DqBFSqq6.js → tabs-CVp_SgBl.js} +1 -1
  27. package/package.json +39 -25
  28. package/src/docgen/doc.gen.json +341 -35
  29. package/src/llms/install-templates/AGENTS.md +34 -0
  30. package/src/llms/install-templates/codex-hooks.json +44 -0
  31. package/src/llms/install-templates/hooks/baseline-staleness.sh +17 -0
  32. package/src/llms/install-templates/hooks/session-start.sh +5 -0
  33. package/src/llms/install-templates/hooks/stop.sh +18 -0
  34. package/src/llms/install-templates/hooks/subagent-start.sh +5 -0
  35. package/src/llms/install-templates/hooks/user-prompt-submit.sh +5 -0
  36. package/src/llms/install-templates/settings.json +45 -0
  37. package/src/llms/llms.gen.txt +12 -0
  38. package/src/llms/skills/imf-web-ui/SKILL.md +13 -12
  39. package/src/llms/skills/imf-web-ui-audit/SKILL.md +119 -0
  40. package/src/llms/skills/imf-web-ui-components/SKILL.md +2 -1
  41. package/src/llms/skills/imf-web-ui-conventions/SKILL.md +57 -0
  42. package/src/llms/skills/imf-web-ui-conventions/templates/AUDIT_CHECKLIST.md +141 -0
  43. package/src/llms/skills/imf-web-ui-conventions/templates/REPORT.md +45 -0
  44. package/src/llms/skills/imf-web-ui-conventions/topics/agent-tooling.md +82 -0
  45. package/src/llms/skills/imf-web-ui-conventions/topics/assets.md +27 -0
  46. package/src/llms/skills/imf-web-ui-conventions/topics/authentication.md +65 -0
  47. package/src/llms/skills/imf-web-ui-conventions/topics/class-names.md +50 -0
  48. package/src/llms/skills/imf-web-ui-conventions/topics/components.md +101 -0
  49. package/src/llms/skills/imf-web-ui-conventions/topics/data.md +221 -0
  50. package/src/llms/skills/imf-web-ui-conventions/topics/docs-structure.md +40 -0
  51. package/src/llms/skills/imf-web-ui-conventions/topics/git.md +34 -0
  52. package/src/llms/skills/imf-web-ui-conventions/topics/library-boundary.md +33 -0
  53. package/src/llms/skills/imf-web-ui-conventions/topics/library-setup.md +26 -0
  54. package/src/llms/skills/imf-web-ui-conventions/topics/npm-project.md +53 -0
  55. package/src/llms/skills/imf-web-ui-conventions/topics/project-structure.md +44 -0
  56. package/src/llms/skills/imf-web-ui-conventions/topics/react.md +109 -0
  57. package/src/llms/skills/imf-web-ui-conventions/topics/styling.md +88 -0
  58. package/src/llms/skills/imf-web-ui-conventions/topics/testing.md +25 -0
  59. package/src/llms/skills/imf-web-ui-conventions/topics/tokens.md +7 -0
  60. package/src/llms/skills/imf-web-ui-conventions/topics/tooling.md +116 -0
  61. package/src/llms/skills/imf-web-ui-conventions/topics/typescript.md +73 -0
  62. package/src/llms/skills/imf-web-ui-conventions/topics/validation.md +62 -0
  63. package/src/llms/skills/imf-web-ui-setup/SKILL.md +67 -37
  64. package/src/llms/skills/imf-web-ui-update/SKILL.md +157 -0
  65. package/src/llms/skills/imf-web-ui-ux/SKILL.md +4 -4
  66. package/src/llms/skills/imf-web-ui-ux/references/forms.md +2 -2
  67. package/src/llms/tokens.gen.json +887 -0
  68. package/bin/install-skill.js +0 -180
  69. package/src/llms/skills/imf-web-ui-frontend-patterns/SKILL.md +0 -93
  70. package/src/llms/skills/imf-web-ui-frontend-patterns/references/code-conventions.md +0 -133
  71. package/src/llms/skills/imf-web-ui-frontend-patterns/references/react-patterns.md +0 -94
  72. package/src/llms/skills/imf-web-ui-imfusion-frontend-setup/SKILL.md +0 -201
@@ -1,180 +0,0 @@
1
- #!/usr/bin/env node
2
-
3
- // Installs the consumer skill family (../src/llms/skills/imf-web-ui*/)
4
- // into the consumer project's agent skill directories. Runs in the
5
- // CONSUMER's environment, so it may only use this package's real runtime
6
- // dependencies (@clack/prompts). Never wire this into a postinstall hook:
7
- // ambient script execution on `npm install` is a live supply-chain attack
8
- // vector — install stays an explicit, user-run command.
9
- //
10
- // The skills cross-reference each other, so they install as one bundle.
11
- // When both targets are selected, .agents/skills/ holds the real copy and
12
- // .claude/skills/ symlinks it (this repo's own convention) so the two
13
- // can't drift apart.
14
-
15
- import {
16
- cpSync,
17
- existsSync,
18
- lstatSync,
19
- mkdirSync,
20
- readdirSync,
21
- readFileSync,
22
- rmSync,
23
- symlinkSync,
24
- writeFileSync
25
- } from "node:fs";
26
- import { dirname, relative, resolve } from "node:path";
27
- import { fileURLToPath } from "node:url";
28
- import * as p from "@clack/prompts";
29
-
30
- const SKILL_PREFIX = "imf-web-ui";
31
- const VERSION_MARKER = ".imf-web-ui-skill-version.json";
32
-
33
- const here = dirname(fileURLToPath(import.meta.url));
34
- // Source is relative to THIS SCRIPT's location (inside node_modules), not
35
- // the consumer's cwd — the script is invoked from the consumer's project
36
- // root, but the skills it copies ship alongside this file in the package.
37
- const skillsRoot = resolve(here, "..", "src", "llms", "skills");
38
- const packageJson = JSON.parse(readFileSync(resolve(here, "..", "package.json"), "utf-8"));
39
- const currentVersion = packageJson.version;
40
-
41
- // Destination is relative to the consumer's project root (cwd), since
42
- // that's where their `.claude/` or `.agents/` directory lives.
43
- const projectRoot = process.cwd();
44
-
45
- const TARGETS = {
46
- claude: { label: "Claude Code", root: resolve(projectRoot, ".claude", "skills") },
47
- agents: { label: "Vendor-neutral (.agents/)", root: resolve(projectRoot, ".agents", "skills") }
48
- };
49
-
50
- function discoverSkills() {
51
- if (!existsSync(skillsRoot)) return [];
52
- return readdirSync(skillsRoot, { withFileTypes: true })
53
- .filter(entry => entry.isDirectory() && entry.name.startsWith(SKILL_PREFIX))
54
- .map(entry => entry.name)
55
- .sort();
56
- }
57
-
58
- function displayPath(absPath) {
59
- return `./${relative(projectRoot, absPath)}`;
60
- }
61
-
62
- function readInstalledVersion(dir) {
63
- const markerPath = resolve(dir, VERSION_MARKER);
64
- if (!existsSync(markerPath)) return null;
65
- try {
66
- return JSON.parse(readFileSync(markerPath, "utf-8")).version ?? null;
67
- } catch {
68
- return null;
69
- }
70
- }
71
-
72
- function writeRealCopy(sourceDir, destDir) {
73
- mkdirSync(dirname(destDir), { recursive: true });
74
- // force: true makes re-running after a version bump overwrite cleanly.
75
- cpSync(sourceDir, destDir, { recursive: true, force: true });
76
- writeFileSync(resolve(destDir, VERSION_MARKER), JSON.stringify({ version: currentVersion }, null, 2) + "\n");
77
- }
78
-
79
- function writeSymlink(linkPath, targetPath) {
80
- mkdirSync(dirname(linkPath), { recursive: true });
81
- // lstat (not existsSync, which follows symlinks) catches a broken/stale
82
- // symlink left over from a prior run, not just a real file or directory.
83
- if (lstatSync(linkPath, { throwIfNoEntry: false })) {
84
- rmSync(linkPath, { recursive: true, force: true });
85
- }
86
- symlinkSync(relative(dirname(linkPath), targetPath), linkPath);
87
- }
88
-
89
- // --target claude|agents (repeatable) selects targets without the
90
- // interactive prompt — for CI and scripted installs.
91
- function parseTargetFlags(argv) {
92
- const targets = [];
93
- for (let i = 0; i < argv.length; i++) {
94
- if (argv[i] !== "--target") continue;
95
- const value = argv[i + 1];
96
- if (!value || !(value in TARGETS)) {
97
- console.error(`--target expects one of: ${Object.keys(TARGETS).join(", ")}`);
98
- process.exit(1);
99
- }
100
- targets.push(value);
101
- i++;
102
- }
103
- return targets;
104
- }
105
-
106
- async function main() {
107
- const skills = discoverSkills();
108
- const flagTargets = parseTargetFlags(process.argv.slice(2));
109
-
110
- p.intro(`@imfusion/web-ui — install the ${SKILL_PREFIX} skills (${skills.length})`);
111
-
112
- if (skills.length === 0) {
113
- p.log.error(`No skills found at ${skillsRoot}. Reinstall @imfusion/web-ui and try again.`);
114
- p.outro("Nothing installed.");
115
- process.exitCode = 1;
116
- return;
117
- }
118
-
119
- const existingVersions = Object.values(TARGETS)
120
- .flatMap(({ root }) => skills.map(name => readInstalledVersion(resolve(root, name))))
121
- .filter(Boolean);
122
- if (existingVersions.length > 0 && existingVersions.every(v => v === currentVersion)) {
123
- p.log.info(`Already up to date (v${currentVersion}). Re-running will overwrite with the same content.`);
124
- } else if (existingVersions.some(v => v !== currentVersion)) {
125
- const from = existingVersions.find(v => v !== currentVersion);
126
- p.log.info(`Updating installed skills from v${from} to v${currentVersion}.`);
127
- }
128
-
129
- p.log.message(`Skills in this bundle:\n${skills.map(name => ` - ${name}`).join("\n")}`);
130
-
131
- let selected;
132
- if (flagTargets.length > 0) {
133
- selected = flagTargets;
134
- p.log.info(`Targets from --target flags: ${selected.join(", ")}`);
135
- } else {
136
- selected = await p.multiselect({
137
- message: "Install into which skill directory (or directories)?",
138
- options: Object.entries(TARGETS).map(([key, { label, root }]) => ({
139
- value: key,
140
- label,
141
- hint: displayPath(root)
142
- })),
143
- required: true
144
- });
145
-
146
- if (p.isCancel(selected)) {
147
- p.cancel("Cancelled — nothing installed.");
148
- return;
149
- }
150
- }
151
-
152
- const both = selected.includes("claude") && selected.includes("agents");
153
-
154
- for (const name of skills) {
155
- const sourceDir = resolve(skillsRoot, name);
156
- if (both) {
157
- // .agents/ is the canonical real copy; .claude/ aliases it via symlink.
158
- const realDir = resolve(TARGETS.agents.root, name);
159
- writeRealCopy(sourceDir, realDir);
160
- writeSymlink(resolve(TARGETS.claude.root, name), realDir);
161
- } else {
162
- for (const key of selected) {
163
- writeRealCopy(sourceDir, resolve(TARGETS[key].root, name));
164
- }
165
- }
166
- }
167
-
168
- if (both) {
169
- p.log.success(`Vendor-neutral (.agents/) -> ${displayPath(TARGETS.agents.root)}/${SKILL_PREFIX}*`);
170
- p.log.success(`Claude Code -> ${displayPath(TARGETS.claude.root)}/${SKILL_PREFIX}* (symlinks -> .agents/)`);
171
- } else {
172
- for (const key of selected) {
173
- p.log.success(`${TARGETS[key].label} -> ${displayPath(TARGETS[key].root)}/${SKILL_PREFIX}*`);
174
- }
175
- }
176
-
177
- p.outro(`Done — ${skills.length} skills installed.`);
178
- }
179
-
180
- await main();
@@ -1,93 +0,0 @@
1
- ---
2
- name: imf-web-ui-frontend-patterns
3
- description:
4
- "Raise the quality of frontend code written around @imfusion/web-ui — including quickly vibe-coded frontends. Library
5
- boundary contract (tokens, CSS layers, type derivation), component roles, state placement, effects discipline, code
6
- conventions (TypeScript, naming, file organisation, testing), and stack defaults. Load when writing wrapper components,
7
- custom UI, styling beyond the defaults, adding new files to a consumer app, or choosing a routing, data-fetching, form, or
8
- table library."
9
- ---
10
-
11
- # imf-web-ui-frontend-patterns
12
-
13
- One guard, once: **if the host project already has a convention — a styling system, a state library, a folder shape — the
14
- project wins.** These defaults fill vacuums. They are not a license to refactor a consumer codebase toward this document.
15
-
16
- Everything else below is how to build.
17
-
18
- ## Stay behind the library
19
-
20
- Never import Base UI (or any other upstream this library wraps) directly — no upstream stylesheets, no upstream components,
21
- even when upstream docs show it that way. Everything a component needs ships in `@imfusion/web-ui`. If the library is missing
22
- something upstream has, report the gap (see `imf-web-ui-components`); don't reach around it.
23
-
24
- ## Style through the sanctioned seams
25
-
26
- All library styles live in the `imf-ui.components` CSS layer, so **any plain selector you write wins** — that's the whole
27
- override contract:
28
-
29
- - Target the stable hooks: `data-imf-ui-component` attributes and your own classes/wrappers.
30
- - Never target the library's internal class names — they are generated and change without notice.
31
- - Never `!important` — if you think you need it, you're targeting the wrong thing.
32
-
33
- ## Build custom UI from tokens
34
-
35
- Anything you build that the library doesn't cover — a stat widget, a custom panel — uses `--imf-ui-*` variables for color,
36
- spacing, radius, and type instead of hardcoded values. That's what makes custom UI look native next to library components,
37
- and what keeps it correct when the theme changes. A hex code or a magic `px` next to a concept the tokens already name is a
38
- defect.
39
-
40
- ## Derive types, don't import them
41
-
42
- Prop types come from the components themselves: `React.ComponentProps<typeof Button>`. The library deliberately exports no
43
- `Props` types — don't look for them, and don't re-declare prop shapes by hand.
44
-
45
- ## Integrations own their peers
46
-
47
- Components under `@imfusion/web-ui/integrations/*` depend on optional peers (e.g. `@tanstack/highlight` for `CodeHighlight`).
48
- Add the peer explicitly to the consumer's `package.json` — never rely on hoisting.
49
-
50
- ## React patterns
51
-
52
- The full treatment — component roles with an example, state placement, effects discipline, and the react.dev sources to
53
- consult while building — lives in [references/react-patterns.md](references/react-patterns.md). Read it before writing new
54
- screens or wrappers. The core in one breath:
55
-
56
- - **Three roles.** Dumb components own how things look, layout components own arrangement, smart containers own data and
57
- logic. Styling never lives in containers.
58
- - **State lives where its truth lives.** URL → query cache → context → store → local state; walk the list, stop at the first
59
- match.
60
- - **Effects are a last resort**, and always extracted into purpose-named hooks.
61
- - **Compose, don't configure.** If a component's prop list reads like a settings page, it wanted to be two or three
62
- components.
63
-
64
- ## Everything else about the code
65
-
66
- TypeScript, naming, where files go, and what's worth testing live in
67
- [references/code-conventions.md](references/code-conventions.md). Read it when you're adding files rather than editing
68
- existing ones — that's when these choices get made and then inherited by everything after.
69
-
70
- The split between the two references: `react-patterns.md` covers **writing React** — component roles, where state lives,
71
- effects discipline, composition. `code-conventions.md` covers **the code around it** — TypeScript, JS style, naming, file
72
- layout, testing. Starting a new feature usually wants both.
73
-
74
- ## Stack defaults
75
-
76
- TanStack is the default for the tooling around web-ui, whether the app is greenfield or you're adding one screen to something
77
- that already exists. The ones you'll reach for most: **Router** (URL state, type-safe search params), **Query** (server
78
- state), **Form** (form state), and **Table** for data grids, which you pair with web-ui's styled `Table` parts
79
- (`Table.SortableHeaderCell` carries the sort glue). The suite goes wider than those four — check what exists before adding a
80
- non-TanStack dependency. This is the stack the state ladder assumes.
81
-
82
- `useState` is the right tool for local UI state, and most of it is local: whether a panel is open, which tab is active, a
83
- draft value being typed, a hover flag. Keep those in the component and don't reach for a library.
84
-
85
- The line is what the state is _for_, not how much of it there is. A library owns the layer once you find yourself rebuilding
86
- what it does: validation timing and cross-field rules (**Form**), caching and refetching (**Query**), URL as the source of
87
- truth (**Router**), sorting and pagination over rows (**Table**). web-ui ships none of that logic, and that absence is not an
88
- argument for writing it yourself. Adding the library mid-project is normal and cheap; unpicking a hand-rolled version of it
89
- later is not.
90
-
91
- For best practices and patterns within any of these libraries, go to the library's own guidance rather than working from
92
- memory: `npx @tanstack/cli` for docs. Where a project has wired up `@tanstack/intent`, use it to reach the Agent Skills its
93
- TanStack dependencies ship, and read those too.
@@ -1,133 +0,0 @@
1
- # Code conventions
2
-
3
- The ImFusion defaults for everyday code around `@imfusion/web-ui` — the parts that aren't React-specific. TypeScript, file
4
- organisation, naming, and testing. React component structure lives in [react-patterns.md](react-patterns.md); the two are
5
- read together when starting new code.
6
-
7
- These fill vacuums. Where the host project has already decided, the project wins.
8
-
9
- ## TypeScript
10
-
11
- - **`any` is forbidden.** `unknown` at a boundary you genuinely can't type, narrowed before use. An `any` that silences an
12
- error moves the failure from compile time to runtime, which is the opposite of the trade you wanted.
13
- - **Lean on inference for locals; annotate the contract.** Restating a type the compiler already knows inside a function body
14
- is a second thing to keep in sync. An **explicit return type on an exported function is worth writing**: it's the promise
15
- the module makes, it stops an internal refactor silently widening the public shape, and it makes the error surface at the
16
- function rather than at every call site.
17
- - **No temporal coupling.** Don't initialise to `null` and fill the value in later — model the states instead, so "not loaded
18
- yet" and "loaded, empty" aren't the same value.
19
- - **Avoid `as`.** A type assertion tells the compiler to stop checking exactly where checking is worth most. Fix the type.
20
- Assertions at an untyped third-party boundary are the honest exception; keep them at the boundary, not spread through call
21
- sites.
22
-
23
- **Derive types, don't duplicate them.** One source of truth, everything else follows from it:
24
-
25
- ```ts
26
- const sizes = ["sm", "md", "lg"] as const;
27
- type Size = (typeof sizes)[number];
28
-
29
- const labels: Record<Size, string> = { sm: "S", md: "M", lg: "L" }; // compiler breaks if `sizes` changes
30
- ```
31
-
32
- The same rule crosses the library boundary: prop types come from the components themselves
33
- (`React.ComponentProps<typeof Button>`), never re-declared by hand.
34
-
35
- **Function signatures.** One or two positional arguments read fine. At three or more, take a single object and destructure —
36
- call sites stop depending on argument order, and adding a parameter stops being a breaking change.
37
-
38
- ## Expressions over statements
39
-
40
- Reach for the array methods before the loop. `map`, `filter`, `find`, `some`, `every`, `flatMap`, `reduce` — each names what
41
- it's doing, where a `for` loop makes you read the body to find out.
42
-
43
- ```ts
44
- // The name is the documentation
45
- const activeNames = users.filter(u => u.isActive).map(u => u.name);
46
-
47
- // vs. a loop you have to read to understand
48
- const activeNames = [];
49
- for (const u of users) {
50
- if (u.isActive) activeNames.push(u.name);
51
- }
52
- ```
53
-
54
- The deeper reason is mutation: the method chain produces a new value, so nothing else can observe a half-built array. Prefer
55
- spreads and `structuredClone` over in-place edits, and `toSorted`/`toReversed` over `sort`/`reverse`, which mutate their
56
- receiver and have surprised everyone at least once.
57
-
58
- Two honest exceptions: a genuine early exit (`for` with `break` beats `find` returning a sentinel) and a hot loop over
59
- thousands of items where the intermediate arrays actually measure. Neither is the common case, so reach for the method first
60
- and justify the loop.
61
-
62
- Keep the chain flat. Three or four steps read well; ten want intermediate named constants, and a `reduce` doing four things
63
- at once wants to be a loop after all.
64
-
65
- ## Naming
66
-
67
- - Say what it is, not what it is made of. `useUserQuery`, not `useUserHook`. `retryDelay`, not `num`.
68
- - Booleans read as assertions: `isOpen`, `hasAccess`, `canSubmit`. A boolean called `status` will end up holding a string.
69
- - Handlers are `onX` as props, `handleX` as implementations — the prop names the event, the function names the response.
70
- - Match the vocabulary the product and the API already use. Inventing a synonym for a term the backend already named costs a
71
- translation step on every read.
72
-
73
- ## File and folder organisation
74
-
75
- Kebab-case throughout, folders and files.
76
-
77
- ```
78
- src/
79
- routes/ # TanStack Router file-based routes; routing only
80
- api/<topic>/ # <topic>.ts (queries/mutations), query-key.ts, types.ts
81
- components/ # grouped by kind of component — layouts/, primitives/, or a domain name
82
- http/ # client, error normalisation
83
- lib/ # framework-free helpers
84
- ```
85
-
86
- `api/` groups by topic: a query lives next to its key factory and its types, so a query key is never spelled out at a call
87
- site. Routes compose and don't fetch inline. Transport concerns live in `http/` and nowhere else.
88
-
89
- `components/` groups by kind — a layout component under `layouts/`, not beside a domain widget. Flat is fine while there are
90
- few; let the grouping follow what the project has rather than imposing it up front. The kinds worth separating are the
91
- component roles in [react-patterns.md](react-patterns.md): dumb components, layout components, smart containers.
92
-
93
- A component gets a folder once it has more than one file, with an `index.ts` that only re-exports:
94
-
95
- ```
96
- components/data-table/
97
- data-table.tsx
98
- data-table-row.tsx
99
- data-table.module.css
100
- index.ts
101
- ```
102
-
103
- Colocate tests, styles, and types with their subject. A file you have to hunt for in a parallel tree gets edited less
104
- carefully.
105
-
106
- ## Styling
107
-
108
- **CSS Modules by default**, colocated as `<component>.module.css`. No CSS-in-JS, no utility-class framework. Compose from
109
- `--imf-ui-*` tokens so custom UI stays consistent with library components and follows the theme; the override contract (CSS
110
- layers, `data-imf-ui-component`, never the library's generated class names) is in the parent skill.
111
-
112
- `imf-web-ui-imfusion-frontend-setup` sets up or audits this structure on an ImFusion project.
113
-
114
- ## Testing
115
-
116
- Test the **decisions**, not the rendering.
117
-
118
- - **Pure logic gets unit tests** — pricing, permissions, date math, parsing, reducers. These are cheap, fast, and the place
119
- bugs actually hide.
120
- - **Presentational components generally don't.** A component that maps props onto web-ui primitives has no logic of its own;
121
- asserting that it rendered a `<Button>` tests React, not your code.
122
- - **Behaviour a user performs gets an interaction test** — a form that validates, a flow with steps. Test it through the
123
- interface the user has (roles, labels, visible text), not through internals.
124
- - **Extract the decision out of a hook and test that.** A hook whose interesting part is a plain function is easier to test
125
- as a plain function than through a render harness. A hook that only wraps a browser API has no decision to extract.
126
-
127
- The measure isn't coverage percentage. It's whether a test failing tells you something you didn't already know.
128
-
129
- ## Formatting and linting
130
-
131
- Don't argue about it in review — the tooling decides, and it runs before the commit lands. A formatter, a linter, and a
132
- pre-commit hook wired so none of them is optional. On an ImFusion project, `imf-web-ui-imfusion-frontend-setup` carries the
133
- baseline and the setup steps.
@@ -1,94 +0,0 @@
1
- # React patterns
2
-
3
- The house defaults for the React code around `@imfusion/web-ui`, in full. The links throughout are for **you, the agent**:
4
- consult them while building — they are the authoritative source when a case here is ambiguous. Hand them to the human only if
5
- asked.
6
-
7
- ## Component roles
8
-
9
- Dumb/smart separation is standard React practice (it traces back to Dan Abramov's
10
- ["Presentational and Container Components"](https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0) and
11
- survives in [Thinking in React](https://react.dev/learn/thinking-in-react)). The house version has three roles:
12
-
13
- - **Dumb components** own how things _look_. They style and compose library primitives, receive plain data and callbacks as
14
- props, and know nothing about fetching, routing, or business logic. All non-layout styling lives here — and only here.
15
- - **Layout components** own _arrangement_ — and nothing else. `Stack`- and `Row`-based wrappers with token gaps, a page grid,
16
- a section frame. They exist because smart containers are styleless: when a container needs two panels side by side, that
17
- arrangement is a layout component, not an inline style.
18
- - **Smart containers** own how things _work_. Routes (or explicit container components) fetch data, hold orchestration logic,
19
- and wire the other two together. Zero styling — the moment a container wants CSS, extract a layout component.
20
-
21
- ```tsx
22
- // Dumb — renders what it's given
23
- function UserCard({ name, role, onEdit }: { name: string; role: string; onEdit: () => void }) {
24
- return (
25
- <Card.Root>
26
- <Card.Content>
27
- <Typo>{name}</Typo>
28
- <Chip>{role}</Chip>
29
- </Card.Content>
30
- <Card.Footer>
31
- <Button onClick={onEdit}>Edit</Button>
32
- </Card.Footer>
33
- </Card.Root>
34
- );
35
- }
36
-
37
- // Smart — knows where data comes from, renders the dumb component
38
- function UserCardContainer({ userId }: { userId: string }) {
39
- const { data } = useUserQuery(userId);
40
- const openEditor = useEditorNavigation(userId);
41
- return <UserCard name={data.name} role={data.role} onEdit={openEditor} />;
42
- }
43
- ```
44
-
45
- Why it matters here: dumb components are the layer where `@imfusion/web-ui` lives. Keeping them free of logic keeps every
46
- screen restylable, testable with plain props, and resilient to library updates. The one web-ui-specific addition: wrap
47
- `experimental` components (marked in the identity index) in a dumb component once per app even if you add nothing yet — a
48
- breaking upstream change then lands in one file instead of every call site.
49
-
50
- ## Compose, don't configure
51
-
52
- Build screen-level pieces by composing primitives (`Stack`, `Row`, `Card`, your dumb components) rather than growing one
53
- component with a dozen boolean props. If a component's prop list reads like a settings page, it wanted to be two or three
54
- components. When state must be shared between siblings, lift it to the nearest common parent —
55
- [Sharing State Between Components](https://react.dev/learn/sharing-state-between-components) — rather than syncing copies.
56
-
57
- ## Put state where its truth lives
58
-
59
- Work down this list and stop at the first match:
60
-
61
- 1. **Shareable via URL?** (filters, sort, pagination, active tab) → router search params. Back button and copied links are UX
62
- features you get for free.
63
- 2. **Comes from an API?** → the data-fetching layer's cache (e.g. TanStack Query). Never copy server data into `useState` —
64
- that's how stale-UI bugs are born.
65
- 3. **Scoped to a subtree, resets on leave?** (wizard progress) → React context.
66
- 4. **App-wide and persistent?** → a client store, and only now.
67
- 5. **Local to one component?** (input value, open/closed) → `useState`.
68
-
69
- Most frontends need far less of tier 4 than they think; tiers 1–2 usually dissolve the "we need a store" instinct. For
70
- structuring the state itself, [Choosing the State Structure](https://react.dev/learn/choosing-the-state-structure) is the
71
- reference — especially its rules on avoiding redundant and duplicated state.
72
-
73
- ## Effects: last resort, and named
74
-
75
- Before writing `useEffect`, check: derived values belong in render (or `useMemo`), responses to user actions belong in the
76
- event handler, and server synchronization belongs in the data-fetching layer. Effects are for synchronizing with systems
77
- _outside_ React. The definitive catalog of effect misuses — read it before every effect you're tempted to write — is
78
- [You Might Not Need an Effect](https://react.dev/learn/you-might-not-need-an-effect).
79
-
80
- When an effect is genuinely needed, extract it into a custom hook named for its purpose — `useSyncedScroll`,
81
- `useDocumentTitle`, `useHotkey` — never an anonymous `useEffect` block inline in a component. The name documents intent, the
82
- hook isolates the dependency array, and the component body stays declarative. Pattern reference:
83
- [Reusing Logic with Custom Hooks](https://react.dev/learn/reusing-logic-with-custom-hooks).
84
-
85
- ## Reading list
86
-
87
- Consult while building; each is the authority for its topic:
88
-
89
- - [Thinking in React](https://react.dev/learn/thinking-in-react) — decomposition and one-way data flow
90
- - [Keeping Components Pure](https://react.dev/learn/keeping-components-pure) — why dumb components stay dumb
91
- - [Choosing the State Structure](https://react.dev/learn/choosing-the-state-structure) — shaping state without duplication
92
- - [Sharing State Between Components](https://react.dev/learn/sharing-state-between-components) — lifting state
93
- - [You Might Not Need an Effect](https://react.dev/learn/you-might-not-need-an-effect) — the effect misuse catalog
94
- - [Reusing Logic with Custom Hooks](https://react.dev/learn/reusing-logic-with-custom-hooks) — named effects live here