@imenam/mcp-gui-interface 1.0.13 → 1.0.14

package/README.md

@@ -304,6 +304,8 @@ The guard refuses with a `403` JSON body `{ error }`:
 | **Host** | a `Host` header other than `localhost`, `127.0.0.1` or `::1` | DNS rebinding: a hostile domain resolving to 127.0.0.1 |
 | **Cross-site modification** | a method other than GET/HEAD/OPTIONS with `Sec-Fetch-Site` other than `same-origin`/`none`; when that header is absent, an `Origin` whose hostname is neither this machine's (hostname, interface addresses, loopback), nor the proxy's, nor in `trustedOrigins` | CSRF: a web page submitting a form or a `fetch` to the GUI |
 
+When the network interfaces cannot be listed (a systemd sandbox with `RestrictAddressFamilies` lacking `AF_NETLINK`), the guard logs a warning and does not trust this machine's IP addresses as origins; list them in `trustedOrigins` if the GUI is opened through them over plain HTTP.
+
 Requests carrying neither `Sec-Fetch-Site` nor `Origin` (curl, scripts) pass the second rule. Reads are never refused on their origin: without CORS headers, the browser does not let another site read the responses. Do not add a CORS middleware to a GUI worker.
 
 **`GuiRequestGuardOptions`**

package/dist/src/request-guard.js

@@ -20,6 +20,7 @@
  *    `trustedOrigins`. Requests without either header (curl, scripts) pass.
  */
 import os from "node:os";
+import { createLogger } from "./logger.js";
 /** Interface every GUI worker binds to. */
 export const GUI_LISTEN_HOST = "127.0.0.1";
 const LOOPBACK_HOSTNAMES = ["localhost", "127.0.0.1", "::1"];
@@ -48,6 +49,25 @@ function originHostname(origin) {
         return null;
     }
 }
+const logger = createLogger("GuiRequestGuard");
+/**
+ * Addresses of this machine's network interfaces. A sandbox that forbids
+ * netlink sockets (systemd `RestrictAddressFamilies` without `AF_NETLINK`)
+ * makes the listing fail: the addresses are then not trusted, and a warning
+ * says so.
+ */
+function interfaceAddresses() {
+    let interfaces;
+    try {
+        interfaces = os.networkInterfaces();
+    }
+    catch (error) {
+        logger.warn(`Network interfaces cannot be listed (${error instanceof Error ? error.message : String(error)}): ` +
+            "origins using this machine's IP addresses are not trusted; list them in trustedOrigins if needed.");
+        return [];
+    }
+    return Object.values(interfaces).flatMap((addresses) => (addresses ?? []).map((address) => address.address.toLowerCase()));
+}
 /**
  * Hostnames an `Origin` may carry: loopback names, this machine's hostname and
  * interface addresses, the proxy's hostname and those of `trustedOrigins`.
@@ -55,10 +75,8 @@ function originHostname(origin) {
 export function trustedOriginHostnames(options = {}) {
     const names = new Set(LOOPBACK_HOSTNAMES);
     names.add(os.hostname().toLowerCase());
-    for (const addresses of Object.values(os.networkInterfaces())) {
-        for (const address of addresses ?? [])
-            names.add(address.address.toLowerCase());
-    }
+    for (const address of interfaceAddresses())
+        names.add(address);
     const proxyUrl = options.proxyUrl ?? process.env.PROXY_URL;
     for (const origin of [proxyUrl, ...(options.trustedOrigins ?? [])]) {
         const hostname = origin ? originHostname(origin) : null;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@imenam/mcp-gui-interface",
-  "version": "1.0.13",
+  "version": "1.0.14",
   "description": "Shared library for MCP GUI lifecycle management — spawning, IPC, proxy registration, logging, request guard",
   "type": "module",
   "main": "./dist/src/index.js",
@@ -34,7 +34,7 @@
   ],
   "repository": {
     "type": "git",
-    "url": "https://github.com/Matthieu-Pesnot-Pin/mcp-gui-interface.git"
+    "url": "git+https://github.com/Matthieu-Pesnot-Pin/mcp-gui-interface.git"
   },
   "author": "Matthieu Pesnot-Pin",
   "license": "ISC",