@imagina-build/ias-cli 0.2.0 → 0.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@imagina-build/ias-cli",
-    "version": "0.2.0",
+    "version": "0.2.2",
     "description": "The command line of Imagina Application Services (IAS): ias.json, OTA updates, internal distribution and the checks of a project.",
     "type": "module",
     "bin": {

package/src/commands/update/index.mjs

@@ -18,10 +18,14 @@ import { readSecret, readSecretFile, isReference, tokenKind } from '../../secret
 
 export const PLATFORMS = ['ios', 'android'];
 
-/** The environment of the app's tools: none of this shell's EXPO_PUBLIC_* (they would go into the bundle) or secrets. */
-function appEnv() {
+/**
+ * The environment of the app's tools: none of this shell's EXPO_PUBLIC_* (they would go into the bundle) or secrets.
+ * With `tmp`, TMPDIR is a folder of this run: Metro keeps its cache in TMPDIR (metro-cache) and a cache from another
+ * run brings the paths of its folder into the bundle. The runner does the same for each build.
+ */
+function appEnv(tmp) {
   const env = Object.fromEntries(Object.entries(process.env).filter(([key]) => !/^(EXPO_PUBLIC_|OTA_|IAS_)/.test(key) && !['EXPO_TOKEN', 'NODE_ENV'].includes(key)));
-  return { ...env, CI: '1', EXPO_NO_TELEMETRY: '1' };
+  return { ...env, CI: '1', EXPO_NO_TELEMETRY: '1', ...(tmp === undefined ? {} : { TMPDIR: tmp }) };
 }
 
 /**
@@ -134,11 +138,13 @@ function copyOf(settings, ref, output) {
   run('git', ['archive', '--format=tar', '-o', join(dir, 'source.tar'), commit], { cwd: settings.projectDir });
   const app = join(dir, 'app');
   run('mkdir', [app]);
+  const tmp = join(dir, 'tmp');
+  run('mkdir', [tmp]);
   run('tar', ['-xf', join(dir, 'source.tar'), '-C', app]);
   const install = INSTALLS.find(([lockfile]) => existsSync(join(app, lockfile)));
   if (!install) throw new Error('the commit has no lockfile (package-lock.json, yarn.lock, pnpm-lock.yaml or bun.lock): the copy could not install the same dependencies');
   output.progress(`${install[1]} ${install[2][0]} in a copy of ${commit.slice(0, 10)}…`);
-  gently(install[1], install[2], { cwd: app, env: appEnv(), stdio: ['ignore', 'pipe', 'pipe'] });
+  gently(install[1], install[2], { cwd: app, env: appEnv(tmp), stdio: ['ignore', 'pipe', 'pipe'] });
   const mustContain = [];
   if (settings.envFile) {
     const envFile = join(settings.projectDir, settings.envFile);
@@ -152,11 +158,11 @@ function copyOf(settings, ref, output) {
   } else if (settings.bundleEnv.length > 0) {
     throw new Error(`${settings.names.config} lists bundleEnv but no envFile to take them from`);
   }
-  return { app, commit, mustContain };
+  return { app, tmp, commit, mustContain };
 }
 
-function runtimeVersion(cwd, platform) {
-  const output = run('npx', ['expo-updates', 'runtimeversion:resolve', '--platform', platform], { cwd, env: appEnv(), label: 'expo-updates runtimeversion:resolve' });
+function runtimeVersion(cwd, platform, tmp) {
+  const output = run('npx', ['expo-updates', 'runtimeversion:resolve', '--platform', platform], { cwd, env: appEnv(tmp), label: 'expo-updates runtimeversion:resolve' });
   return JSON.parse(output.slice(output.indexOf('{'))).runtimeVersion;
 }
 
@@ -174,13 +180,13 @@ export async function publish(settings, { ref = 'HEAD', message, platforms = PLA
   const copy = copyOf(settings, ref, output);
   const dist = join(dirname(copy.app), 'dist');
   output.progress(`exporting ${copy.commit.slice(0, 10)} (${platforms.join(', ')})…`);
-  gently('npx', ['expo', 'export', ...platforms.flatMap((platform) => ['--platform', platform]), '--output-dir', dist], { cwd: copy.app, env: appEnv(), stdio: ['ignore', 'pipe', 'pipe'] });
+  gently('npx', ['expo', 'export', ...platforms.flatMap((platform) => ['--platform', platform]), '--output-dir', dist], { cwd: copy.app, env: appEnv(copy.tmp), stdio: ['ignore', 'pipe', 'pipe'] });
   const { manifests, files } = buildManifests({
     dist,
     metadata: JSON.parse(readFileSync(join(dist, 'metadata.json'), 'utf8')),
     platforms,
-    runtimes: Object.fromEntries(platforms.map((platform) => [platform, runtimeVersion(copy.app, platform)])),
-    expoClient: JSON.parse(run('npx', ['expo', 'config', '--type', 'public', '--json'], { cwd: copy.app, env: appEnv(), label: 'expo config' })),
+    runtimes: Object.fromEntries(platforms.map((platform) => [platform, runtimeVersion(copy.app, platform, copy.tmp)])),
+    expoClient: JSON.parse(run('npx', ['expo', 'config', '--type', 'public', '--json'], { cwd: copy.app, env: appEnv(copy.tmp), label: 'expo config' })),
     assetPath: settings.assetPath,
     createdAt: new Date().toISOString(),
     mustContain: copy.mustContain,
@@ -387,6 +393,12 @@ export async function check(settings, { platforms = PLATFORMS }, output) {
   return { checks };
 }
 
+/**
+ * The URL of a file the manifest points to, asked of the server this publication went to: a manifest may name any of
+ * the hosts the server answers for (the old domain, the new one), and they all serve the same path.
+ */
+const assetOf = (url, settings) => new URL(new URL(url, settings.manifestUrl).pathname, settings.base);
+
 /**
  * Asks for the manifest as a phone would and checks the signature, the id and every file it points to. `checked`
  * holds the files already checked in this run (one per settings): the platforms share most of them. `channel` and
@@ -418,7 +430,7 @@ export async function checkServed(settings, platform, runtime, expectedId, outpu
     checked.add(asset.hash);
     // Each file once, and the bundle also without gzip.
     for (const encoding of index === 0 ? [undefined, 'identity'] : [undefined]) {
-      const answer = await download(new URL(asset.url, settings.manifestUrl), encoding ? { 'accept-encoding': encoding } : {}, output);
+      const answer = await download(assetOf(asset.url, settings), encoding ? { 'accept-encoding': encoding } : {}, output);
       if (!answer.ok) throw new Error(`${platform}: ${asset.url} answered ${answer.status}`);
       if (sha256(Buffer.from(await answer.arrayBuffer())) !== asset.hash) throw new Error(`${platform}: ${asset.url} does not match its hash`);
     }

package/src/config.mjs

@@ -163,7 +163,7 @@ function iasUpdateSettings({ dir, config }, env) {
     manifestUrl: manifestUrl.href,
     base,
     project: manifestUrl.pathname.match(MANIFEST_PATH)[1],
-    assetPath: `${new URL(base).pathname}/assets/`,
+    assetPath: `${base}/assets/`,
     keyid,
     certificate: new X509Certificate(readFileSync(certificateFile)),
     signingSource: appCertificate ? 'app.json' : 'updates.signing of ias.json',
@@ -203,7 +203,7 @@ function legacyUpdateSettings(projectDir, env) {
     manifestUrl: manifestUrl.href,
     base,
     project: manifestUrl.pathname.match(MANIFEST_PATH)[1],
-    assetPath: `${new URL(base).pathname}/assets/`,
+    assetPath: `${base}/assets/`,
     keyid: updates.codeSigningMetadata.keyid,
     certificate,
     privateKey,

package/src/ota.mjs

@@ -30,9 +30,10 @@ export function readEnvFile(path, names) {
 }
 
 /**
- * One manifest per platform from an expo export folder: the same createdAt, the runtime of each platform, relative
- * asset URLs, metadata {} (filters could make phones load an older update) and the public config as extra.expoClient.
- * Returns the manifests and the files to upload, by hash. Throws if a bundle lacks a value it must carry.
+ * One manifest per platform from an expo export folder: the same createdAt, the runtime of each platform, absolute
+ * asset URLs (the released expo-updates clients do not resolve relative ones), metadata {} (filters could make phones
+ * load an older update) and the public config as extra.expoClient. Returns the manifests and the files to upload, by
+ * hash. Throws if a bundle lacks a value it must carry.
  */
 export function buildManifests({ dist, metadata, platforms, runtimes, expoClient, assetPath, createdAt, mustContain = [] }) {
   const files = new Map();