@ilya-lesikov/pi-pi 0.12.0 → 0.12.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ilya-lesikov/pi-pi",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "description": "Pi-Pi Coding Agent: based on Pi Coding Agent, but twice as good",
   "keywords": [
     "pi-package",

package/scripts/postinstall.mjs

@@ -1,13 +1,14 @@
 // Vendor-source decision: on non-Windows we invoke the existing bash `vendor.sh` UNCHANGED so
-// Linux/CI stay byte-for-byte identical; on Windows we SKIP the bash vendor step (a documented
-// Windows limitation) and rely on the npm-pack HTML fallback below. vendor.sh is still the single
-// source used by `npm run build`/CI — this script does not fork its logic.
+// Linux/CI stay byte-for-byte identical. On Windows bash is unavailable, so we reproduce
+// vendor.sh's logic in Node (`vendorGeneratedNode`) from the same pinned sources shipped in this
+// package's tarball, then recover the prebuilt HTML via the npm-pack fallback below. vendor.sh
+// remains the single source used by `npm run build`/CI; the Node port must mirror it exactly.
 import { execFileSync, spawnSync } from "node:child_process";
-import { existsSync, mkdtempSync, rmSync, readdirSync, readFileSync, writeFileSync } from "node:fs";
+import { existsSync, mkdirSync, mkdtempSync, rmSync, readdirSync, readFileSync, writeFileSync } from "node:fs";
 import { gunzipSync } from "node:zlib";
 import { tmpdir } from "node:os";
 import { dirname, join, resolve } from "node:path";
-import { fileURLToPath } from "node:url";
+import { fileURLToPath, pathToFileURL } from "node:url";
 
 const SCRIPT_DIR = dirname(fileURLToPath(import.meta.url));
 const REPO_ROOT = resolve(SCRIPT_DIR, "..");
@@ -21,13 +22,67 @@ function fail(msg) {
 
 function runVendor() {
   if (isWindows) {
-    console.log("  ⚠ skipping plannotator vendor step on Windows (bash vendor.sh unavailable)");
+    console.log("  ⚠ bash vendor.sh unavailable on Windows — vendoring generated/ with Node fallback");
+    vendorGeneratedNode();
     return;
   }
   const res = spawnSync("bash", [join(PI_EXT_DIR, "vendor.sh")], { cwd: REPO_ROOT, stdio: "inherit" });
   if (res.status !== 0) fail(`vendor.sh failed with exit code ${res.status ?? "unknown"}`);
 }
 
+// Node port of vendor.sh: prepend the @generated header to each pinned source and rewrite the
+// server/tour imports to the flat generated/ layout. MUST stay in lockstep with vendor.sh —
+// same file lists, same header, same import rewrites — or Windows ships a divergent extension.
+export function vendorGeneratedNode(genDir = join(PI_EXT_DIR, "generated")) {
+  const PKG_ROOT = join(REPO_ROOT, "3p", "pi-plannotator", "packages");
+  const GEN = genDir;
+
+  const SHARED = [
+    "feedback-templates", "prompts", "review-core", "diff-paths", "jj-core", "vcs-core", "review-args",
+    "storage", "draft", "project", "pr-types", "pr-provider", "pr-stack", "pr-github", "pr-gitlab",
+    "checklist", "integrations-common", "repo", "reference-common", "favicon", "code-file",
+    "resolve-file", "config", "external-annotation", "agent-jobs", "worktree", "worktree-pool",
+    "html-to-markdown", "url-to-markdown", "tour", "annotate-args", "at-reference",
+    "review-workspace-node", "review-workspace", "pfm-reminder", "improvement-hooks", "code-nav",
+    "data-dir", "semantic-diff-types", "semantic-diff",
+  ];
+  const SERVER = ["agent-review-message", "codex-review", "claude-review", "path-utils"];
+  const AI = ["index", "types", "provider", "session-manager", "endpoints", "context", "base-session"];
+  const PROVIDERS = ["claude-agent-sdk", "codex-sdk", "opencode-sdk", "command-path", "pi-sdk", "pi-sdk-node", "pi-events"];
+
+  const SERVER_REWRITES = [
+    ['from "./vcs"', 'from "./review-core.js"'],
+    ['from "./pr"', 'from "./pr-provider.js"'],
+    ['from "./path-utils"', 'from "./path-utils.js"'],
+    ['from "@plannotator/shared/review-workspace"', 'from "./review-workspace.js"'],
+    ['from "@plannotator/shared/data-dir"', 'from "./data-dir"'],
+  ];
+  const TOUR_REWRITES = [
+    ['from "../vcs"', 'from "./review-core.js"'],
+    ['from "../pr"', 'from "./pr-provider.js"'],
+    ['from "../agent-review-message"', 'from "./agent-review-message.js"'],
+    ['from "@plannotator/shared/tour"', 'from "./tour.js"'],
+    ['from "@plannotator/shared/data-dir"', 'from "./data-dir"'],
+  ];
+
+  const header = (rel) => `// @generated — DO NOT EDIT. Source: ${rel}\n`;
+  const apply = (src, rewrites) => rewrites.reduce((acc, [from, to]) => acc.split(from).join(to), src);
+  const emit = (srcAbs, rel, outAbs, rewrites) => {
+    if (!existsSync(srcAbs)) fail(`vendor source missing: ${rel}`);
+    const body = readFileSync(srcAbs, "utf8");
+    writeFileSync(outAbs, header(rel) + (rewrites ? apply(body, rewrites) : body));
+  };
+
+  rmSync(GEN, { recursive: true, force: true });
+  mkdirSync(join(GEN, "ai", "providers"), { recursive: true });
+
+  for (const f of SHARED) emit(join(PKG_ROOT, "shared", `${f}.ts`), `packages/shared/${f}.ts`, join(GEN, `${f}.ts`));
+  for (const f of SERVER) emit(join(PKG_ROOT, "server", `${f}.ts`), `packages/server/${f}.ts`, join(GEN, `${f}.ts`), SERVER_REWRITES);
+  emit(join(PKG_ROOT, "server", "tour", "tour-review.ts"), "packages/server/tour/tour-review.ts", join(GEN, "tour-review.ts"), TOUR_REWRITES);
+  for (const f of AI) emit(join(PKG_ROOT, "ai", `${f}.ts`), `packages/ai/${f}.ts`, join(GEN, "ai", `${f}.ts`));
+  for (const f of PROVIDERS) emit(join(PKG_ROOT, "ai", "providers", `${f}.ts`), `packages/ai/providers/${f}.ts`, join(GEN, "ai", "providers", `${f}.ts`));
+}
+
 function htmlPresent() {
   return existsSync(join(PI_EXT_DIR, "plannotator.html")) && existsSync(join(PI_EXT_DIR, "review-editor.html"));
 }
@@ -86,8 +141,8 @@ function extractHtmlFallback() {
   }
 }
 
-runVendor();
-
-if (htmlPresent()) process.exit(0);
-
-extractHtmlFallback();
+// Skip the install-time side effects when imported by a test; only run as the lifecycle script.
+if (import.meta.url === pathToFileURL(process.argv[1] ?? "").href) {
+  runVendor();
+  if (!htmlPresent()) extractHtmlFallback();
+}

package/scripts/postinstall.test.ts

@@ -0,0 +1,60 @@
+import { execFileSync } from "node:child_process";
+import { mkdtempSync, readdirSync, readFileSync, rmSync, statSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { dirname, join, relative, resolve } from "node:path";
+import { fileURLToPath } from "node:url";
+import { describe, expect, it } from "vitest";
+import { vendorGeneratedNode } from "./postinstall.mjs";
+
+const REPO_ROOT = resolve(dirname(fileURLToPath(import.meta.url)), "..");
+const EXT_DIR = join(REPO_ROOT, "3p", "pi-plannotator", "apps", "pi-extension");
+
+function listFiles(root: string, dir: string = root): string[] {
+  const out: string[] = [];
+  for (const name of readdirSync(dir)) {
+    const full = join(dir, name);
+    if (statSync(full).isDirectory()) out.push(...listFiles(root, full));
+    else out.push(relative(root, full));
+  }
+  return out.sort();
+}
+
+// The Node port in postinstall.mjs reproduces vendor.sh for the Windows install path, where bash
+// is unavailable. If the two ever diverge (a file added to vendor.sh's lists, a changed header or
+// import rewrite), Windows silently ships a different extension than Linux/CI. This asserts they
+// produce byte-for-byte identical generated/ trees. Bash-only, so skipped where it is absent.
+describe("vendorGeneratedNode mirrors vendor.sh", () => {
+  const hasBash = (() => {
+    try {
+      execFileSync("bash", ["--version"], { stdio: "ignore" });
+      return true;
+    } catch {
+      return false;
+    }
+  })();
+
+  it.skipIf(!hasBash)("produces a byte-for-byte identical generated/ tree", () => {
+    const tmp = mkdtempSync(join(tmpdir(), "vendor-parity-"));
+    try {
+      // vendor.sh writes generated/ next to itself (gitignored, reproducible); snapshot it.
+      execFileSync("bash", ["vendor.sh"], { cwd: EXT_DIR, stdio: "ignore" });
+      const bashDir = join(EXT_DIR, "generated");
+
+      const nodeDir = join(tmp, "generated");
+      vendorGeneratedNode(nodeDir);
+
+      const bashFiles = listFiles(bashDir);
+      const nodeFiles = listFiles(nodeDir);
+      expect(bashFiles.length).toBeGreaterThan(0);
+      expect(nodeFiles).toEqual(bashFiles);
+
+      for (const rel of bashFiles) {
+        expect(readFileSync(join(nodeDir, rel), "utf8"), `content mismatch: ${rel}`).toBe(
+          readFileSync(join(bashDir, rel), "utf8"),
+        );
+      }
+    } finally {
+      rmSync(tmp, { recursive: true, force: true });
+    }
+  });
+});