@ilya-lesikov/pi-pi 0.1.0

package/extensions/orchestrator/validate-artifacts.ts

@@ -0,0 +1,272 @@
+type ValidationResult = { ok: true } | { ok: false; errors: string[] };
+
+const USER_REQUEST_REQUIRED_SECTIONS = ["Problem", "Constraints"] as const;
+const USER_REQUEST_ALLOWED_SECTIONS = ["Problem", "Constraints"] as const;
+const RESEARCH_REQUIRED_SECTIONS = ["Affected Code", "Architecture Context", "Constraints & Edge Cases"] as const;
+const RESEARCH_ALLOWED_SECTIONS = ["Affected Code", "Architecture Context", "Constraints & Edge Cases", "Open Questions"] as const;
+const PLAN_REQUIRED_SECTIONS = ["Scope", "Checklist"] as const;
+const PLAN_ALLOWED_SECTIONS = ["Scope", "Checklist", "Blockers"] as const;
+const PLACEHOLDER_PATTERNS = /^(?:[-*.…—]|tbd|todo|n\/a|na|none|\.{2,})$/i;
+
+function splitLines(content: string): string[] {
+  return content.split(/\r?\n/);
+}
+
+function getH1(content: string): { line: number; text: string } | null {
+  const lines = splitLines(content);
+  for (let i = 0; i < lines.length; i += 1) {
+    const match = lines[i]?.match(/^\s*#\s+(.+?)\s*$/);
+    if (match) {
+      return { line: i + 1, text: match[1] };
+    }
+  }
+  return null;
+}
+
+function getFirstHeading(content: string): { level: number; line: number; text: string } | null {
+  const lines = splitLines(content);
+  for (let i = 0; i < lines.length; i += 1) {
+    const match = lines[i]?.match(/^\s*(#{1,6})\s+(.+?)\s*$/);
+    if (match) {
+      return { level: match[1].length, line: i + 1, text: match[2] };
+    }
+  }
+  return null;
+}
+
+function normalizeH2Name(raw: string, allowedNames: readonly string[]): string {
+  const trimmed = raw.replace(/:$/, "");
+  for (const name of allowedNames) {
+    if (trimmed === name || trimmed.startsWith(name + ":") || trimmed.startsWith(name + " ")) {
+      return name;
+    }
+  }
+  return raw;
+}
+
+function parseH2Sections(content: string, allowedNames?: readonly string[]): Array<{ name: string; line: number; start: number; end: number }> {
+  const lines = splitLines(content);
+  const sections: Array<{ name: string; line: number; start: number; end: number }> = [];
+
+  for (let i = 0; i < lines.length; i += 1) {
+    const match = lines[i]?.match(/^\s*##\s+(.+?)\s*$/);
+    if (match) {
+      const rawName = match[1];
+      const name = allowedNames ? normalizeH2Name(rawName, allowedNames) : rawName;
+      sections.push({
+        name,
+        line: i + 1,
+        start: i + 1,
+        end: lines.length,
+      });
+    }
+  }
+
+  for (let i = 0; i < sections.length; i += 1) {
+    const next = sections[i + 1];
+    sections[i]!.end = next ? next.line - 1 : lines.length;
+  }
+
+  return sections;
+}
+
+function sectionBody(content: string, section: { line: number; end: number }): string {
+  const lines = splitLines(content);
+  return lines.slice(section.line, section.end).join("\n");
+}
+
+function isPlaceholderContent(text: string): boolean {
+  const trimmed = text.trim();
+  return trimmed.length === 0 || PLACEHOLDER_PATTERNS.test(trimmed);
+}
+
+function hasNonEmptySectionBody(content: string, section: { line: number; end: number }): boolean {
+  const body = sectionBody(content, section).trim();
+  return !isPlaceholderContent(body);
+}
+
+function firstH2Line(content: string): number | null {
+  const lines = splitLines(content);
+  for (let i = 0; i < lines.length; i += 1) {
+    if (/^\s*##\s+.+$/.test(lines[i] ?? "")) {
+      return i + 1;
+    }
+  }
+  return null;
+}
+
+function formatSectionList(sections: readonly string[], optional: readonly string[] = []): string {
+  const required = sections.map((s) => `## ${s}`);
+  const optionalParts = optional.map((s) => `## ${s} (optional)`);
+  return [...required, ...optionalParts].join(", ");
+}
+
+export function validateUserRequest(content: string): ValidationResult {
+  const errors: string[] = [];
+  const h1 = getH1(content);
+  const firstHeading = getFirstHeading(content);
+  const expectedSections = formatSectionList(USER_REQUEST_REQUIRED_SECTIONS);
+
+  if (!firstHeading) {
+    errors.push("Missing required heading: # User Request. Expected first heading: # User Request");
+  } else if (firstHeading.level !== 1 || firstHeading.text !== "User Request") {
+    errors.push(
+      `First heading is '${"#".repeat(firstHeading.level)} ${firstHeading.text}' on line ${firstHeading.line}. Expected first heading: # User Request`,
+    );
+  }
+
+  const sections = parseH2Sections(content, USER_REQUEST_ALLOWED_SECTIONS);
+  const sectionMap = new Map(sections.map((s) => [s.name, s]));
+
+  for (const section of sections) {
+    if (!USER_REQUEST_ALLOWED_SECTIONS.includes(section.name as (typeof USER_REQUEST_ALLOWED_SECTIONS)[number])) {
+      errors.push(`Unexpected section: ## ${section.name}. Expected sections: ${expectedSections}`);
+    }
+  }
+
+  for (const sectionName of USER_REQUEST_REQUIRED_SECTIONS) {
+    if (!sectionMap.has(sectionName)) {
+      errors.push(`Missing required section: ## ${sectionName}. Expected sections: ${expectedSections}`);
+    }
+  }
+
+  const problem = sectionMap.get("Problem");
+  if (problem && !hasNonEmptySectionBody(content, problem)) {
+    errors.push("Section ## Problem is empty. Expected non-empty problem description.");
+  }
+
+  const constraints = sectionMap.get("Constraints");
+  if (constraints && !hasNonEmptySectionBody(content, constraints)) {
+    errors.push("Section ## Constraints is empty. Expected non-empty constraints.");
+  }
+
+  if (h1 && h1.text === "User Request") {
+    const lines = splitLines(content);
+    const start = h1.line;
+    const firstH2 = firstH2Line(content);
+    const endExclusive = firstH2 ? firstH2 - 1 : lines.length;
+    const distillation = lines.slice(start, endExclusive).join("\n").trim();
+    if (isPlaceholderContent(distillation)) {
+      errors.push(
+        "Distillation is missing between # User Request and the first ## section. Expected 1-3 non-empty sentences.",
+      );
+    }
+  }
+
+  return errors.length > 0 ? { ok: false, errors } : { ok: true };
+}
+
+export function validateResearch(content: string): ValidationResult {
+  const errors: string[] = [];
+  const expectedSections = formatSectionList(RESEARCH_REQUIRED_SECTIONS, ["Open Questions"]);
+  const sections = parseH2Sections(content, RESEARCH_ALLOWED_SECTIONS);
+  const sectionMap = new Map(sections.map((s) => [s.name, s]));
+
+  for (const section of sections) {
+    if (!RESEARCH_ALLOWED_SECTIONS.includes(section.name as (typeof RESEARCH_ALLOWED_SECTIONS)[number])) {
+      errors.push(`Unexpected section: ## ${section.name}. Expected sections: ${expectedSections}`);
+    }
+  }
+
+  for (const sectionName of RESEARCH_REQUIRED_SECTIONS) {
+    const section = sectionMap.get(sectionName);
+    if (!section) {
+      errors.push(`Missing required section: ## ${sectionName}. Expected sections: ${expectedSections}`);
+      continue;
+    }
+    if (!hasNonEmptySectionBody(content, section)) {
+      errors.push(`Section ## ${sectionName} is empty. Expected non-empty content.`);
+    }
+  }
+
+  return errors.length > 0 ? { ok: false, errors } : { ok: true };
+}
+
+export function validatePlan(content: string): ValidationResult {
+  const errors: string[] = [];
+  const h1 = getH1(content);
+  const firstHeading = getFirstHeading(content);
+  const expectedSections = formatSectionList(PLAN_REQUIRED_SECTIONS, ["Blockers"]);
+
+  if (!firstHeading) {
+    errors.push("Missing required heading: # Plan. Expected first heading: # Plan");
+  } else if (firstHeading.level !== 1 || firstHeading.text !== "Plan") {
+    errors.push(
+      `First heading is '${"#".repeat(firstHeading.level)} ${firstHeading.text}' on line ${firstHeading.line}. Expected first heading: # Plan`,
+    );
+  }
+
+  const sections = parseH2Sections(content, PLAN_ALLOWED_SECTIONS);
+  const sectionMap = new Map(sections.map((s) => [s.name, s]));
+
+  for (const section of sections) {
+    if (!PLAN_ALLOWED_SECTIONS.includes(section.name as (typeof PLAN_ALLOWED_SECTIONS)[number])) {
+      errors.push(`Unexpected section: ## ${section.name}. Expected sections: ${expectedSections}`);
+    }
+  }
+
+  for (const sectionName of PLAN_REQUIRED_SECTIONS) {
+    if (!sectionMap.has(sectionName)) {
+      errors.push(`Missing required section: ## ${sectionName}. Expected sections: ${expectedSections}`);
+    }
+  }
+
+  const scope = sectionMap.get("Scope");
+  if (scope && !hasNonEmptySectionBody(content, scope)) {
+    errors.push("Section ## Scope is empty. Expected 2-4 lines summarizing scope and constraints.");
+  }
+
+  const lines = splitLines(content);
+  const checklistMatches: Array<{ line: number; text: string }> = [];
+
+  const checklistSection = sectionMap.get("Checklist");
+  if (checklistSection) {
+    const sectionLines = lines.slice(checklistSection.line, checklistSection.end);
+    for (let i = 0; i < sectionLines.length; i += 1) {
+      const line = sectionLines[i] ?? "";
+      if (/^\s*- \[(?: |x|X)\]/.test(line)) {
+        const globalLine = checklistSection.line + i + 1;
+        checklistMatches.push({ line: globalLine, text: line.trim() });
+
+        let hasDoneWhen = /done when\s*:/i.test(line);
+        if (!hasDoneWhen) {
+          for (let j = i + 1; j < sectionLines.length; j += 1) {
+            const nextLine = sectionLines[j] ?? "";
+            if (/^\s*- \[(?: |x|X)\]/.test(nextLine) || nextLine.trim() === "") break;
+            if (/done when\s*:/i.test(nextLine)) {
+              hasDoneWhen = true;
+              break;
+            }
+          }
+        }
+
+        if (!hasDoneWhen) {
+          errors.push(`Checklist item on line ${globalLine} missing 'Done when:' clause: '${line.trim()}'`);
+        }
+      }
+    }
+  }
+
+  if (checklistMatches.length === 0) {
+    errors.push(
+      "Checklist has no items. Expected at least one checklist item matching '- [ ]' or '- [x]' with 'Done when:' clause.",
+    );
+  }
+
+  return errors.length > 0 ? { ok: false, errors } : { ok: true };
+}
+
+export function validateArtifact(content: string): ValidationResult {
+  const errors: string[] = [];
+  const firstHeading = getFirstHeading(content);
+
+  if (!firstHeading) {
+    errors.push("Missing required heading: # <Title>. Artifact must start with a top-level heading.");
+  } else if (firstHeading.level !== 1) {
+    errors.push(
+      `First heading is '${"#".repeat(firstHeading.level)} ${firstHeading.text}' on line ${firstHeading.line}. Expected a top-level heading: # <Title>`,
+    );
+  }
+
+  return errors.length > 0 ? { ok: false, errors } : { ok: true };
+}

package/extensions/orchestrator/vendor.d.ts

@@ -0,0 +1,26 @@
+declare module "proper-lockfile" {
+  interface LockOptions {
+    stale?: number;
+    update?: number;
+    retries?: number | { retries: number; minTimeout?: number; maxTimeout?: number };
+    realpath?: boolean;
+    lockfilePath?: string;
+    onCompromised?: (err: Error) => void;
+  }
+
+  interface CheckOptions {
+    stale?: number;
+    realpath?: boolean;
+    lockfilePath?: string;
+  }
+
+  function lock(file: string, options?: LockOptions): Promise<() => Promise<void>>;
+  function lockSync(file: string, options?: LockOptions): () => void;
+  function unlock(file: string, options?: LockOptions): Promise<void>;
+  function unlockSync(file: string, options?: LockOptions): void;
+  function check(file: string, options?: CheckOptions): Promise<boolean>;
+  function checkSync(file: string, options?: CheckOptions): boolean;
+
+  export { lock, lockSync, unlock, unlockSync, check, checkSync };
+  export default { lock, lockSync, unlock, unlockSync, check, checkSync };
+}

package/package.json

@@ -0,0 +1,73 @@
+{
+  "name": "@ilya-lesikov/pi-pi",
+  "version": "0.1.0",
+  "description": "Pi-Pi Coding Agent: based on Pi Coding Agent, but twice as good",
+  "keywords": [
+    "pi-package",
+    "pi",
+    "coding-agent",
+    "orchestration"
+  ],
+  "license": "Apache-2.0",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/ilya-lesikov/pi-pi.git"
+  },
+  "files": [
+    "extensions/",
+    "3p/pi-subagents/src/",
+    "3p/pi-subagents/package.json",
+    "3p/pi-tasks/src/",
+    "3p/pi-tasks/package.json",
+    "3p/pi-lsp/extensions/",
+    "3p/pi-lsp/package.json",
+    "3p/pi-ask-user/index.ts",
+    "3p/pi-ask-user/single-select-layout.ts",
+    "3p/pi-ask-user/package.json",
+    "3p/pi-plannotator/apps/pi-extension/",
+    "3p/pi-plannotator/packages/shared/",
+    "3p/pi-plannotator/packages/server/",
+    "3p/pi-plannotator/packages/ai/",
+    "3p/pi-plannotator/package.json",
+    "scripts/",
+    "AGENTS.md"
+  ],
+  "scripts": {
+    "postinstall": "bash scripts/postinstall.sh",
+    "test": "vitest run --exclude '3p/**'",
+    "test:watch": "vitest --exclude '3p/**'"
+  },
+  "pi": {
+    "extensions": [
+      "./extensions/orchestrator",
+      "./3p/pi-subagents/src/index.ts",
+      "./3p/pi-tasks/src/index.ts",
+      "./3p/pi-lsp/extensions/lsp",
+      "./3p/pi-ask-user",
+      "./3p/pi-plannotator/apps/pi-extension"
+    ]
+  },
+  "dependencies": {
+    "@joplin/turndown-plugin-gfm": "^1.0.64",
+    "@pierre/diffs": "^1.2.0",
+    "effect": "^3.0.0",
+    "minimatch": "^10.0.0",
+    "proper-lockfile": "^4.1.2",
+    "turndown": "^7.2.0",
+    "typebox": "^1.0.0"
+  },
+  "peerDependencies": {
+    "@earendil-works/pi-ai": "*",
+    "@earendil-works/pi-coding-agent": "*",
+    "@earendil-works/pi-tui": "*",
+    "@sinclair/typebox": "*"
+  },
+  "devDependencies": {
+    "@earendil-works/pi-ai": "^0.75.5",
+    "@earendil-works/pi-coding-agent": "^0.75.5",
+    "@earendil-works/pi-tui": "^0.75.5",
+    "@sinclair/typebox": "^0.34.0",
+    "typescript": "^5.8.0",
+    "vitest": "^4.1.4"
+  }
+}

package/scripts/postinstall.sh

@@ -0,0 +1,18 @@
+#!/usr/bin/env bash
+set -euo pipefail
+cd "$(dirname "$0")/.."
+
+bash 3p/pi-plannotator/apps/pi-extension/vendor.sh
+
+PI_EXT_DIR="3p/pi-plannotator/apps/pi-extension"
+if [ -f "$PI_EXT_DIR/plannotator.html" ] && [ -f "$PI_EXT_DIR/review-editor.html" ]; then
+  exit 0
+fi
+
+TMPDIR=$(mktemp -d)
+trap 'rm -rf "$TMPDIR"' EXIT
+
+npm pack @plannotator/pi-extension --pack-destination "$TMPDIR" --silent 2>/dev/null
+tar -xzf "$TMPDIR"/*.tgz -C "$TMPDIR"
+cp "$TMPDIR/package/plannotator.html" "$PI_EXT_DIR/plannotator.html"
+cp "$TMPDIR/package/review-editor.html" "$PI_EXT_DIR/review-editor.html"