@iloveagents/foundry-web-ui 0.3.1 → 0.4.0

package/src/lib/__tests__/ag-ui-adapter.test.ts

@@ -1,279 +0,0 @@
-/**
- * Adapter shim regression tests.
- *
- * The shim is a generator-driven assistant-ui `ChatModelAdapter` wrapping
- * `@iloveagents/foundry-agent`'s `AGUIRunner`. The contract under test:
- *   - Every intermediate yield carries `status: { type: "running" }`.
- *   - The FINAL yield settles the message so the bubble unsticks (the
- *     previous adapter left it `running` and it got stuck loading — PR #116):
- *     `{ type: "complete", reason: "stop" }` on success, or
- *     `{ type: "incomplete", reason: "error", error }` on RUN_ERROR so the
- *     UI shows a visible error instead of a silent empty bubble.
- *   - `content` is cumulative — every yield holds the full content array,
- *     not deltas (assistant-ui v0.12 contract).
- */
-
-import { describe, expect, it, vi, beforeEach } from "vitest";
-import type { RunnerEvent } from "@iloveagents/foundry-agent";
-
-const appStoreMock = vi.hoisted(() => ({
-  agentState: {
-    contextItems: [] as Array<Record<string, unknown>>,
-    navigation: { contextInstructions: null as string | null },
-  },
-  consumedMessageIds: [] as string[],
-}));
-
-const runMock = vi.fn();
-const runnerMock = vi.fn().mockImplementation(() => ({
-  threadId: "thread-1",
-  state: {},
-  run: runMock,
-}));
-
-vi.mock("@iloveagents/foundry-agent", () => ({
-  AGUIRunner: function AGUIRunnerCtor(...args: unknown[]) {
-    return runnerMock(...args);
-  },
-  clientToolRegistry: {
-    getState: () => ({
-      isRegistered: (name: string) => name.startsWith("ui_"),
-      executeTool: async () => "{}",
-      getActiveSchemas: () => [],
-    }),
-  },
-  streamingStatusStore: {
-    getState: () => ({ setStreamingStatus: () => {} }),
-  },
-}));
-
-vi.mock("@iloveagents/foundry-agent/msal", () => ({
-  tokenFetch: globalThis.fetch,
-}));
-
-vi.mock("../app-store.ts", () => ({
-  useAppStore: {
-    getState: () => ({
-      markThreadActive: () => {},
-      getAgentState: () => appStoreMock.agentState,
-      consumeContextForMessage: (messageId: string) => {
-        appStoreMock.consumedMessageIds.push(messageId);
-      },
-    }),
-  },
-}));
-
-vi.mock("../dev-store.ts", () => ({
-  useDevStore: {
-    getState: () => ({
-      captureRequest: () => {},
-      addToolCall: () => {},
-      updateToolCall: () => {},
-    }),
-  },
-}));
-
-import { AGUIAdapterSDK } from "../ag-ui-adapter.ts";
-
-function makeRunInput() {
-  return {
-    messages: [
-      { id: "u-1", role: "user" as const, content: [{ type: "text" as const, text: "hi" }] },
-    ],
-    abortSignal: undefined as AbortSignal | undefined,
-  };
-}
-
-describe("AGUIAdapterSDK", () => {
-  beforeEach(() => {
-    runMock.mockReset();
-    runnerMock.mockClear();
-    appStoreMock.agentState = {
-      contextItems: [],
-      navigation: { contextInstructions: null },
-    };
-    appStoreMock.consumedMessageIds = [];
-  });
-
-  it("yields a terminal complete after a text-only run", async () => {
-    runMock.mockImplementation(async function* (): AsyncGenerator<RunnerEvent> {
-      yield { type: "turn-started" };
-      yield { type: "request-sent", input: {} };
-      yield { type: "run-started" };
-      yield { type: "text-delta", delta: "hello" };
-      yield { type: "text-message-end" };
-      yield { type: "run-finished" };
-      yield { type: "streaming-status", status: { status: "idle" } };
-    });
-
-    const adapter = new AGUIAdapterSDK();
-    const out: Array<{ status: unknown; content: unknown }> = [];
-    for await (const r of adapter.run(makeRunInput())) {
-      out.push({ status: r.status, content: r.content });
-    }
-
-    expect(out.length).toBeGreaterThan(0);
-    expect(out[out.length - 1].status).toEqual({ type: "complete", reason: "stop" });
-  });
-
-  it("yields a terminal complete after a multi-turn client-tool follow-up", async () => {
-    // Reproduces the regression from PR #116 review: the previous shim
-    // kept yielding `status: running` after the final run-finished because
-    // the `needsFollowUp` check stayed true once a client tool resolved.
-    runMock.mockImplementation(async function* (): AsyncGenerator<RunnerEvent> {
-      // Turn 1 — agent calls client-side ui_navigate, runner executes locally.
-      yield { type: "turn-started" };
-      yield { type: "request-sent", input: {} };
-      yield { type: "run-started" };
-      yield { type: "tool-call-start", id: "tc-1", name: "ui_navigate", isClientSide: true };
-      yield { type: "tool-call-args", id: "tc-1", delta: '{"path":"/foo"}' };
-      yield {
-        type: "tool-call-end",
-        id: "tc-1",
-        args: '{"path":"/foo"}',
-        result: { status: "success" },
-      };
-      yield { type: "run-finished" };
-      // Turn 2 — agent acks with text after follow-up.
-      yield { type: "turn-started" };
-      yield { type: "request-sent", input: {} };
-      yield { type: "run-started" };
-      yield { type: "text-delta", delta: "Done" };
-      yield { type: "text-message-end" };
-      yield { type: "run-finished" };
-      yield { type: "streaming-status", status: { status: "idle" } };
-    });
-
-    const adapter = new AGUIAdapterSDK();
-    const out: ChatModelRunResultLike[] = [];
-    for await (const r of adapter.run(makeRunInput())) {
-      out.push({ status: r.status, content: r.content });
-    }
-
-    expect(out.length).toBeGreaterThan(0);
-
-    // Every intermediate yield is "running".
-    for (const r of out.slice(0, -1)) {
-      expect(r.status).toEqual({ type: "running" });
-    }
-
-    // The FINAL yield is complete (the regression: previously stuck on running).
-    expect(out[out.length - 1].status).toEqual({ type: "complete", reason: "stop" });
-
-    // Content is cumulative — the final yield carries both the resolved
-    // tool-call and the text from turn 2.
-    const finalContent = out[out.length - 1].content as Array<{
-      type: string;
-      toolCallId?: string;
-      text?: string;
-    }>;
-    expect(finalContent.find((p) => p.type === "tool-call")?.toolCallId).toBe("tc-1");
-    expect(finalContent.find((p) => p.type === "text")?.text).toBe("Done");
-  });
-
-  it("settles run-error as incomplete/error so the UI shows it (does not throw)", async () => {
-    runMock.mockImplementation(async function* (): AsyncGenerator<RunnerEvent> {
-      yield { type: "turn-started" };
-      yield { type: "request-sent", input: {} };
-      yield { type: "run-started" };
-      yield { type: "run-error", message: "boom" };
-      yield { type: "streaming-status", status: { status: "idle" } };
-    });
-
-    const adapter = new AGUIAdapterSDK();
-    const out: ChatModelRunResultLike[] = [];
-    // On RUN_ERROR the adapter settles the message as incomplete/error
-    // (NOT a silent complete/stop) so assistant-ui's <MessagePrimitive.Error>
-    // renders a visible, retryable error. It must still settle via a
-    // terminal yield rather than throw — an unhandled throw re-introduces
-    // the stuck-running regression (message abandoned mid-run).
-    for await (const r of adapter.run(makeRunInput())) {
-      out.push({ status: r.status, content: r.content });
-    }
-
-    expect(out[out.length - 1].status).toEqual({
-      type: "incomplete",
-      reason: "error",
-      error: "boom",
-    });
-  });
-
-  it("forwards app context items through the native AG-UI context field", async () => {
-    appStoreMock.agentState = {
-      navigation: { contextInstructions: null },
-      contextItems: [
-        {
-          type: "ref",
-          refType: "block",
-          refId: "entity-1:block-2",
-          preview: "A selected table cell",
-          targetPath: "$.blocks[?(@.id=='block-2')].rows[0].cells[1]",
-          sourcePage: "/spaces/entity-1#block-block-2",
-        },
-      ],
-    };
-    runMock.mockImplementation(async function* (): AsyncGenerator<RunnerEvent> {});
-
-    const adapter = new AGUIAdapterSDK();
-    for await (const _ of adapter.run(makeRunInput())) {
-      // Drain the adapter.
-    }
-
-    expect(runMock).toHaveBeenCalledTimes(1);
-    expect(runMock.mock.calls[0][0].context).toEqual([
-      {
-        description:
-          "Selected block atom. Use targetPath as the exact edit target when the user asks to modify, rewrite, or transform selected content.",
-        value: JSON.stringify(appStoreMock.agentState.contextItems[0]),
-      },
-    ]);
-    expect(appStoreMock.consumedMessageIds).toEqual(["u-1"]);
-  });
-
-  it("describes typed JSON ref targets without losing the stable ref handle", async () => {
-    appStoreMock.agentState = {
-      navigation: { contextInstructions: null },
-      contextItems: [
-        {
-          type: "ref",
-          label: "Page Instructions · Test Page",
-          refType: "entity-field",
-          refId: "entity-1:instructions.agent_instructions",
-          preview: "Current: old\nProposed: new",
-          targetPath: "$.instructions.agent_instructions",
-          target: {
-            kind: "json-field",
-            path: "$.instructions.agent_instructions",
-            label: "Page Instructions",
-            scope: "entity-field",
-            containerId: "entity-1",
-            containerLabel: "Test Page",
-            currentValue: "old",
-            proposedValue: "new",
-            changeIds: ["change-1"],
-          },
-          sourcePage: "/spaces/entity-1",
-        },
-      ],
-    };
-    runMock.mockImplementation(async function* (): AsyncGenerator<RunnerEvent> {});
-
-    const adapter = new AGUIAdapterSDK();
-    for await (const _ of adapter.run(makeRunInput())) {
-      // Drain the adapter.
-    }
-
-    expect(runMock.mock.calls[0][0].context).toEqual([
-      {
-        description:
-          "Selected entity-field Page Instructions. Use targetPath as the exact JSON edit target when the user asks to modify, rewrite, or transform this reference.",
-        value: JSON.stringify(appStoreMock.agentState.contextItems[0]),
-      },
-    ]);
-  });
-});
-
-interface ChatModelRunResultLike {
-  status: unknown;
-  content: unknown;
-}

package/src/lib/__tests__/app-store.test.ts

@@ -1,405 +0,0 @@
-import { beforeEach, describe, expect, it } from "vitest";
-import { useAppStore } from "../app-store";
-
-const reset = () =>
-  useAppStore.setState({
-    threadActive: false,
-    currentPage: "/chat",
-    navContext: {
-      group: null,
-      groupDescription: null,
-      groupMeta: {},
-      label: "Chat",
-      description: null,
-      meta: {},
-      contextInstructions: null,
-    },
-    selectedItemId: null,
-    content: {},
-    highlights: [],
-    contextItems: [],
-    sentContext: {},
-  });
-const store = () => useAppStore.getState();
-
-const ephemeralItem = (label = "hello", sourcePage = "panel") => ({
-  type: "selection" as const,
-  label,
-  payload: { kind: "text" as const, text: label },
-  sourcePage,
-  persistence: "ephemeral" as const,
-});
-
-const persistentItem = (label = "pinned", sourcePage = "panel") => ({
-  type: "selection" as const,
-  label,
-  payload: { kind: "text" as const, text: label },
-  sourcePage,
-  persistence: "persistent" as const,
-});
-
-const pageItem = (path = "/workspace", label = "Form") => ({
-  type: "page" as const,
-  label,
-  payload: { kind: "page" as const, path, label },
-  sourcePage: path,
-  persistence: "persistent" as const,
-});
-
-const refItem = (refId = "entity-1:block-1", preview = "Introduction") => ({
-  type: "ref" as const,
-  label: preview,
-  payload: { kind: "ref" as const, refType: "block", refId, preview },
-  sourcePage: "/spaces/entity-1",
-  persistence: "persistent" as const,
-});
-
-const scopedRefItem = (
-  selectionScope: "block" | "text" | "atom",
-  preview = "Introduction",
-  targetPath?: string,
-) => ({
-  type: "ref" as const,
-  label: preview,
-  payload: {
-    kind: "ref" as const,
-    refType: "block",
-    refId: "entity-1:block-1",
-    preview,
-    meta: {
-      selectionScope,
-      ...(targetPath ? { targetPath } : {}),
-    },
-  },
-  sourcePage: "/spaces/entity-1#block-block-1",
-  persistence: selectionScope === "block" ? ("persistent" as const) : ("ephemeral" as const),
-});
-
-describe("app-store", () => {
-  beforeEach(reset);
-
-  describe("addContextItem", () => {
-    it("adds an item with generated id and createdAt", () => {
-      store().addContextItem(ephemeralItem());
-      expect(store().contextItems).toHaveLength(1);
-      expect(store().contextItems[0]).toMatchObject({
-        label: "hello",
-        sourcePage: "panel",
-        type: "selection",
-        persistence: "ephemeral",
-      });
-      expect(store().contextItems[0].id).toBeTruthy();
-      expect(store().contextItems[0].createdAt).toBeGreaterThan(0);
-    });
-
-    it("deduplicates by label + sourcePage", () => {
-      store().addContextItem(ephemeralItem("same", "src"));
-      store().addContextItem(ephemeralItem("same", "src"));
-      expect(store().contextItems).toHaveLength(1);
-    });
-
-    it("allows same label from different sources", () => {
-      store().addContextItem(ephemeralItem("same", "src-a"));
-      store().addContextItem(ephemeralItem("same", "src-b"));
-      expect(store().contextItems).toHaveLength(2);
-    });
-
-    it("caps at 10 items", () => {
-      for (let i = 0; i < 11; i++) {
-        store().addContextItem(ephemeralItem(`text-${i}`));
-      }
-      expect(store().contextItems).toHaveLength(10);
-    });
-
-    it("deduplicates page items by path", () => {
-      store().addContextItem(pageItem("/workspace", "Form"));
-      store().addContextItem(pageItem("/workspace", "Form copy"));
-      expect(store().contextItems).toHaveLength(1);
-    });
-
-    it("allows page items with different paths", () => {
-      store().addContextItem(pageItem("/workspace"));
-      store().addContextItem(pageItem("/documents"));
-      expect(store().contextItems).toHaveLength(2);
-    });
-
-    it("deduplicates ref items by refId", () => {
-      store().addContextItem(refItem("e1:b1", "Intro"));
-      store().addContextItem(refItem("e1:b1", "Intro copy"));
-      expect(store().contextItems).toHaveLength(1);
-    });
-
-    it("allows scoped refs for the same block alongside the durable block ref", () => {
-      store().addContextItem(scopedRefItem("block", "Whole block"));
-      store().addContextItem(scopedRefItem("text", "Specific phrase"));
-      store().addContextItem(
-        scopedRefItem("atom", "Table cell", "$.blocks[?(@.id=='block-1')].rows[0].cells[0]"),
-      );
-      expect(store().contextItems).toHaveLength(3);
-    });
-
-    it("deduplicates scoped refs by their actual scope key", () => {
-      store().addContextItem(scopedRefItem("text", "Specific phrase"));
-      store().addContextItem(scopedRefItem("text", "Specific phrase"));
-      store().addContextItem(
-        scopedRefItem("atom", "Table cell", "$.blocks[?(@.id=='block-1')].rows[0].cells[0]"),
-      );
-      store().addContextItem(
-        scopedRefItem("atom", "Updated table cell", "$.blocks[?(@.id=='block-1')].rows[0].cells[0]"),
-      );
-      expect(store().contextItems).toHaveLength(2);
-    });
-
-    it("allows ref items with different refIds", () => {
-      store().addContextItem(refItem("e1:b1"));
-      store().addContextItem(refItem("e1:b2"));
-      expect(store().contextItems).toHaveLength(2);
-    });
-
-    it("truncates label longer than 500 chars", () => {
-      const longLabel = "a".repeat(600);
-      store().addContextItem(ephemeralItem(longLabel));
-      expect(store().contextItems[0].label).toHaveLength(503);
-      expect(store().contextItems[0].label.endsWith("...")).toBe(true);
-    });
-  });
-
-  describe("removeContextItem", () => {
-    it("removes by id, leaves others", () => {
-      store().addContextItem(ephemeralItem("a"));
-      store().addContextItem(ephemeralItem("b"));
-      const idToRemove = store().contextItems[0].id;
-      store().removeContextItem(idToRemove);
-      expect(store().contextItems).toHaveLength(1);
-      expect(store().contextItems[0].label).toBe("b");
-    });
-  });
-
-  describe("consumeContextForMessage", () => {
-    it("keeps persistent items, removes ephemeral", () => {
-      store().addContextItem(persistentItem("pinned"));
-      store().addContextItem(ephemeralItem("temp"));
-      const snapshot = store().consumeContextForMessage("msg-1");
-
-      expect(snapshot).toHaveLength(2);
-      expect(store().contextItems).toHaveLength(1);
-      expect(store().contextItems[0].label).toBe("pinned");
-      expect(store().sentContext["msg-1"]).toHaveLength(2);
-    });
-
-    it("returns empty array without side effects when no items", () => {
-      const snapshot = store().consumeContextForMessage("msg-1");
-      expect(snapshot).toEqual([]);
-      expect(store().sentContext).toEqual({});
-    });
-  });
-
-  describe("clearAllContext", () => {
-    it("resets items and sentContext", () => {
-      store().addContextItem(ephemeralItem("a"));
-      store().consumeContextForMessage("msg-1");
-      store().addContextItem(ephemeralItem("b"));
-      store().clearAllContext();
-      expect(store().contextItems).toHaveLength(0);
-      expect(store().sentContext).toEqual({});
-    });
-  });
-
-  describe("promoteContextItem", () => {
-    it("changes ephemeral to persistent", () => {
-      store().addContextItem(ephemeralItem("temp"));
-      const id = store().contextItems[0].id;
-      store().promoteContextItem(id);
-      expect(store().contextItems[0].persistence).toBe("persistent");
-    });
-  });
-
-  describe("navContext", () => {
-    it("setNavContext updates navigation context", () => {
-      store().setNavContext({
-        group: "Contracts",
-        groupDescription: "Contract workspace",
-        groupMeta: { orgId: "org-1" },
-        label: "Acme NDA",
-        description: "Review NDA terms",
-        meta: { contractId: "123" },
-        contextInstructions: null,
-      });
-      expect(store().navContext.group).toBe("Contracts");
-      expect(store().navContext.groupMeta).toEqual({ orgId: "org-1" });
-      expect(store().navContext.label).toBe("Acme NDA");
-      expect(store().navContext.meta).toEqual({ contractId: "123" });
-    });
-  });
-
-  describe("setCurrentPage", () => {
-    it("clears ephemeral context on navigation", () => {
-      store().addContextItem(ephemeralItem("temp"));
-      store().addContextItem(persistentItem("pinned"));
-      store().setCurrentPage("/workspace");
-      expect(store().contextItems).toHaveLength(1);
-      expect(store().contextItems[0].label).toBe("pinned");
-    });
-
-    it("does not clear when navigating to the same page", () => {
-      store().addContextItem(ephemeralItem("temp"));
-      store().setCurrentPage("/chat"); // same as default
-      expect(store().contextItems).toHaveLength(1);
-    });
-  });
-
-  describe("content", () => {
-    it("updates individual fields", () => {
-      store().updateContentField("title", "My Draft");
-      store().updateContentField("priority", "high");
-      expect(store().content).toEqual({ title: "My Draft", priority: "high" });
-    });
-
-    it("clearContent resets to empty", () => {
-      store().updateContentField("title", "test");
-      store().clearContent();
-      expect(store().content).toEqual({});
-    });
-  });
-
-  describe("highlights", () => {
-    it("adds and removes highlights", () => {
-      store().addHighlight("field-1");
-      store().addHighlight("field-2");
-      expect(store().highlights).toEqual(["field-1", "field-2"]);
-
-      store().removeHighlight("field-1");
-      expect(store().highlights).toEqual(["field-2"]);
-    });
-
-    it("deduplicates highlights", () => {
-      store().addHighlight("field-1");
-      store().addHighlight("field-1");
-      expect(store().highlights).toHaveLength(1);
-    });
-  });
-
-  describe("getAgentState", () => {
-    it("returns correct projection with navigation context", () => {
-      store().setCurrentPage("/workspace");
-      store().setNavContext({
-        group: "Pages",
-        groupDescription: null,
-        groupMeta: {},
-        label: "Workspace",
-        description: "Collaborate on drafts",
-        meta: {},
-        contextInstructions: null,
-      });
-      store().setSelectedItemId("doc-1");
-      store().updateContentField("title", "Test");
-      store().addHighlight("field-1");
-      store().addContextItem(persistentItem("ctx"));
-
-      const projection = store().getAgentState();
-      expect(projection).toEqual({
-        navigation: {
-          group: "Pages",
-          groupDescription: null,
-          groupMeta: {},
-          page: "/workspace",
-          label: "Workspace",
-          description: "Collaborate on drafts",
-          meta: {},
-          contextInstructions: null,
-        },
-        selectedItemId: "doc-1",
-        content: { title: "Test" },
-        highlights: ["field-1"],
-        contextItems: [
-          {
-            type: "selection",
-            label: "ctx",
-            text: "ctx",
-            sourcePage: "panel",
-          },
-        ],
-      });
-    });
-
-    it("includes navigation metadata", () => {
-      store().setNavContext({
-        group: "Contracts",
-        groupDescription: "Contract workspace",
-        groupMeta: { orgId: "org-1" },
-        label: "Acme NDA",
-        description: "Review NDA",
-        meta: { contractId: "123", type: "nda" },
-        contextInstructions: null,
-      });
-      store().setCurrentPage("/contracts/123");
-
-      const projection = store().getAgentState();
-      expect(projection.navigation.meta).toEqual({ contractId: "123", type: "nda" });
-      expect(projection.navigation.groupMeta).toEqual({ orgId: "org-1" });
-      expect(projection.navigation.group).toBe("Contracts");
-    });
-
-    it("compacts reference target values within the documented context limit", () => {
-      const longValue = "x".repeat(2_001);
-
-      store().addContextItem({
-        type: "ref",
-        label: "Long field",
-        sourcePage: "/spaces/entity-1",
-        persistence: "ephemeral",
-        payload: {
-          kind: "ref",
-          refType: "entity-field",
-          refId: "entity-1",
-          target: {
-            path: "$.instructions.page",
-            label: "Page Instructions",
-            currentValue: longValue,
-            proposedValue: longValue,
-          },
-        },
-      });
-
-      const projection = store().getAgentState();
-      const target = projection.contextItems[0].target as {
-        currentValue: string;
-        proposedValue: string;
-      };
-
-      expect(target.currentValue).toHaveLength(2_000);
-      expect(target.currentValue.endsWith("...")).toBe(true);
-      expect(target.proposedValue).toHaveLength(2_000);
-      expect(target.proposedValue.endsWith("...")).toBe(true);
-    });
-  });
-
-  describe("resetAll", () => {
-    it("resets all state to defaults", () => {
-      store().markThreadActive();
-      store().setNavContext({
-        group: "Contracts",
-        groupDescription: "test",
-        groupMeta: { orgId: "1" },
-        label: "Acme",
-        description: "test",
-        meta: { id: "1" },
-        contextInstructions: null,
-      });
-      store().setSelectedItemId("doc-1");
-      store().updateContentField("title", "test");
-      store().addHighlight("field-1");
-      store().addContextItem(ephemeralItem("temp"));
-
-      store().resetAll();
-
-      expect(store().threadActive).toBe(false);
-      expect(store().navContext.group).toBeNull();
-      expect(store().navContext.label).toBe("Chat");
-      expect(store().selectedItemId).toBeNull();
-      expect(store().content).toEqual({});
-      expect(store().highlights).toEqual([]);
-      expect(store().contextItems).toEqual([]);
-    });
-  });
-});