@ikunin/sprintpilot 2.2.23 → 2.2.25

package/_Sprintpilot/bin/autopilot.js

@@ -1461,22 +1461,21 @@ function cmdStart(opts) {
     );
   }
   if (profile.lint_enabled) {
-    // Same honesty pattern as parallel_stories. Config is parsed; no
-    // state-machine integration yet. Users on lint_enabled=true would
-    // otherwise assume lint runs post-DEV_GREEN — it doesn't.
+    // v2.2.24: lint_enabled wires verifyDevGreen → post-green-gates.js
+    // (lint-changed + lint-test-pitfalls + ci-parity scan). lint_blocking
+    // governs whether a failed gate halts the autopilot or passes
+    // through with a warning. The v2.2.23 "not wired" warning is gone —
+    // lint runs for real now.
     ledger.append(
       {
         kind: 'state_transition',
         detail: {
-          lint_experimental_warning:
-            'git.lint.enabled=true: config is read into the typed Profile but the state machine has no LINT_CHECK phase yet. Lint enforcement (per-language linters, blocking/non-blocking gate, output_limit) is tracked for v2.3.0+. Until then, bake lint into your test command (bmad-dev-story GREEN phase will catch failures).',
+          lint_enabled: true,
+          lint_blocking: !!profile.lint_blocking,
         },
       },
       { projectRoot },
     );
-    process.stderr.write(
-      '[autopilot] WARN git.lint.enabled=true but no LINT_CHECK phase exists yet (planned for v2.3.0). Bake lint into your test command for now.\n',
-    );
   }
 
   // Worktree health check — once per session, after lock acquire so we
@@ -1647,7 +1646,7 @@ function cmdRecord(opts) {
     profile.enabled === false && stateMachine.shouldSkipVerifyWhenGitDisabled(runtime.phase);
   let verifyResult;
   if (signal.status === 'success' && !isGitDisabledPhase) {
-    verifyResult = verifyMod.verify(runtime, signal.output, { projectRoot });
+    verifyResult = verifyMod.verify(runtime, signal.output, { projectRoot, profile });
     ledger.append(
       { kind: 'verify_result', phase: runtime.phase, ok: verifyResult.ok, issues: verifyResult.issues || [] },
       { projectRoot },
@@ -1656,7 +1655,7 @@ function cmdRecord(opts) {
     verifyResult = verifyMod.verifyWithOverride(
       runtime,
       signal.output || {},
-      { projectRoot },
+      { projectRoot, profile },
       signal.evidence || {},
     );
     ledger.append(

package/_Sprintpilot/lib/orchestrator/verify.js

@@ -164,6 +164,54 @@ function autoDetectTestFiles(ctx, baseBranch) {
   return out;
 }
 
+// Invoke scripts/post-green-gates.js when profile.lint_enabled is true.
+// Returns null when:
+//   - profile.lint_enabled is false / absent (feature opt-out)
+//   - the script is missing (partial install)
+//   - projectRoot is unset
+// Returns { failed: bool, summary?: string } on a real run.
+//
+// The script's contract: exit 0 = all gates pass, exit !=0 = at least
+// one gate failed. JSON report on stdout when invoked with --json (we
+// pass that flag). Failure summary captured for the issue message.
+function runPostGreenGates(ctx) {
+  if (!ctx || !ctx.profile || !ctx.profile.lint_enabled) return null;
+  if (!ctx.projectRoot) return null;
+  const scriptRel = nodePath.join('_Sprintpilot', 'scripts', 'post-green-gates.js');
+  const scriptAbs = nodePath.join(ctx.projectRoot, scriptRel);
+  let fs;
+  try {
+    fs = ctx.fs || nodeFs;
+    if (!fs.existsSync(scriptAbs)) return null;
+  } catch {
+    return null;
+  }
+  const cp = require('node:child_process');
+  try {
+    const r = cp.spawnSync(
+      'node',
+      [scriptAbs, '--json', '--project-root', ctx.projectRoot],
+      { encoding: 'utf8', stdio: ['ignore', 'pipe', 'pipe'], timeout: 120_000 },
+    );
+    if (r.status === 0) return { failed: false };
+    // Try to extract a brief summary from the JSON output. Fall back
+    // to the exit code if parsing fails.
+    let summary = `exit ${r.status}`;
+    try {
+      const parsed = JSON.parse(r.stdout || '{}');
+      if (parsed && parsed.failed_gate) summary = `failed_gate=${parsed.failed_gate}`;
+      if (parsed && parsed.first_issue) summary += `: ${parsed.first_issue}`;
+    } catch {
+      /* keep exit-code summary */
+    }
+    return { failed: true, summary };
+  } catch (_e) {
+    // Script crashed (e.g. ENOENT for node). Treat as non-failing —
+    // the lint phase should not gate the autopilot on its own bugs.
+    return null;
+  }
+}
+
 // Probe the underlying git state to confirm a STORY_DONE signal whose
 // `git_steps_completed` flag was omitted. Returns true iff:
 //   - commit_sha resolves locally (git cat-file -e <sha>)
@@ -227,6 +275,7 @@ function verify(state, signalOutput, context) {
     runner: (context && context.runner) || null,
     projectRoot: (context && context.projectRoot) || '.',
     augmented: (context && context.augmented) || null,
+    profile: (context && context.profile) || null,
   };
   const out = signalOutput || {};
   // Effective state: fall forward to signal.output for identity fields
@@ -275,15 +324,27 @@ function verifyCreateStory(state, _out, ctx) {
     const override = ctx.augmented || {};
     const ackMissingFm = override && override.acknowledge_missing_front_matter === true;
     if (!fm && !ackMissingFm) issues.push('story file missing YAML front-matter');
-    // AC presence — look for "## Acceptance Criteria" section with at least one bullet.
-    if (text && !/##\s+Acceptance Criteria[\s\S]*?\n-\s+/.test(text)) {
+    // AC presence — look for an Acceptance Criteria section with at
+    // least one list entry. Accepts:
+    //   - heading levels ##, ###, #### (BMad standard is ##; some templates
+    //     nest AC under Dev Notes which would use ###)
+    //   - "Acceptance Criteria" / "Acceptance criteria" / "AC" (the abbr
+    //     appears in some templates)
+    //   - bullet markers `-` or `*` or numbered `1.` / `1)` lists
+    if (
+      text &&
+      !/#{2,4}\s+(?:Acceptance Criteria|Acceptance criteria|AC)\b[\s\S]*?\n[ \t]*(?:[-*]|\d+[.)])\s+\S/i.test(
+        text,
+      )
+    ) {
       issues.push('Acceptance Criteria section missing or empty');
     }
     // Tasks/Subtasks section with at least one task checkbox — required by
     // BMad bookkeeping. `bmad-create-story` produces unchecked `[ ]`
     // entries; `bmad-dev-story` flips them to `[x]`. If neither is present,
-    // dev-story will have nothing to check off.
-    if (text && !/##\s+Tasks(?:\s*\/\s*Subtasks)?[\s\S]*?(?:\[ \]|\[x\])/i.test(text)) {
+    // dev-story will have nothing to check off. Accept heading levels
+    // ## / ### / #### (templates sometimes nest Tasks under Dev Notes).
+    if (text && !/#{2,4}\s+Tasks(?:\s*\/\s*Subtasks)?[\s\S]*?(?:\[ \]|\[x\])/i.test(text)) {
       issues.push(
         'Tasks (or Tasks/Subtasks) section with at least one `[ ]` or `[x]` checkbox missing',
       );
@@ -381,6 +442,20 @@ function verifyDevGreen(state, out, ctx) {
       issues.push('tests_run must be a positive number (per AGENTS.md test-result format)');
     }
   }
+  // Post-GREEN gates: lint-changed + lint-test-pitfalls + ci-parity scan.
+  // Composed pipeline lives in scripts/post-green-gates.js. Only fires
+  // when profile.lint_enabled === true. Blocking vs non-blocking
+  // governed by profile.lint_blocking. Pre-2.2.24 the script existed
+  // and was documented as "called by the orchestrator after GREEN
+  // verify" but nothing actually invoked it.
+  const lintResult = runPostGreenGates(ctx);
+  if (lintResult) {
+    if (lintResult.failed && (ctx.profile && ctx.profile.lint_blocking)) {
+      issues.push(
+        `post-green-gates failed (lint_blocking=true): ${lintResult.summary || 'see ledger detail'}`,
+      );
+    }
+  }
   return { ok: issues.length === 0, issues };
 }
 

package/_Sprintpilot/manifest.yaml

@@ -1,6 +1,6 @@
 addon:
   name: sprintpilot
-  version: 2.2.23
+  version: 2.2.25
   description: Sprintpilot — autopilot and multi-agent addon for BMad Method (git workflow, parallel agents, autonomous story execution)
   bmad_compatibility: ">=6.2.0"
   modules:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ikunin/sprintpilot",
-  "version": "2.2.23",
+  "version": "2.2.25",
   "description": "Sprintpilot — autopilot and multi-agent addon for BMad Method v6: git workflow, parallel agents, autonomous story execution",
   "license": "Apache-2.0",
   "repository": {