@ikuma.cloud/pix-mcp 0.0.2 → 0.0.3

package/README.md

@@ -4,28 +4,17 @@ A small Pi MCP adapter: discover tools, load their schemas on demand, then call
 those tools natively. No scripting engine or model-provider-specific API is
 required.
 
-**Read [CONTRIBUTING.md](../../CONTRIBUTING.md) before making changes.**
+## Usage
 
-## Development
-
-From the repository root:
-
-```sh
-mise run mcp:dev
-mise run test --project pix-mcp
-mise run check
-```
-
-The development task runs from `packages/mcp` and disables other extensions so
-another MCP adapter cannot collide with the `mcp` tool or flags. Pass arguments
-through the task, for example:
+To load this package in an existing Pi installation:
 
 ```sh
-mise run mcp:dev --mcp-config /absolute/path/to/mcp.json
+pi -e /absolute/path/to/pix/packages/mcp
 ```
 
-For an existing Pi installation, load this package with
-`pi --no-extensions -e /absolute/path/to/pix/packages/mcp`.
+Disable any other MCP adapter that would collide with the `mcp` tool or flags,
+but keep any permission-control extensions enabled. Review the configuration
+and trust requirements below before connecting servers.
 
 ## Configuration and trust
 
@@ -61,8 +50,7 @@ contact remote services. Configuration trust is not an OS sandbox.
       "description": "Issue tracking tools",
       "timeout": 960000,
       "startupTimeoutMs": 30000,
-      "catalogTimeoutMs": 30000,
-      "approve": true
+      "catalogTimeoutMs": 30000
     }
   }
 }
@@ -91,7 +79,6 @@ URLs, and HTTP headers.
 | `description` | Discovery extension: optional summary, truncated to 500 characters |
 | `startupTimeoutMs` | pix extension: complete connection/initialization handshake deadline; default 30000 |
 | `catalogTimeoutMs` | pix extension: complete catalog snapshot deadline, including all pages; default 30000 |
-| `approve` | pix policy: require confirmation for every invocation, default `true` |
 | `disabled` | Skip the server's value validation and environment expansion when `true`; unknown fields are still errors |
 
 `command`, `args`, `cwd`, `env` values, `url`, and `headers` values expand `${VAR}`
@@ -118,14 +105,14 @@ reports that no valid servers remain. Disabled entries are omitted, not reported
 as failed connections. Correct the file and reload Pi to retry.
 
 Configuration trust still applies before any valid server is started or its
-metadata exposed. Per-call approval remains independent of configuration errors.
+metadata exposed.
 
 ### Deadlines and migration
 
 All three deadline fields accept integers from 1 through 2,147,483,647 milliseconds
 (Node's timer-safe maximum). Each defaults independently to 30 seconds. Setting
 `"timeout": 960000` permits a 16-minute tool call without lengthening startup or
-discovery. The call clock starts after invocation approval and connection startup;
+discovery. The call clock starts after connection startup;
 progress does not reset it. Catalog deadlines cover all pages of one snapshot;
 a subsequent list-change refresh starts a new deadline.
 
@@ -146,14 +133,22 @@ Upstream proxies and servers may still impose their own limits.
 The 120-second call ceiling is removed. This is a configuration migration, not a
 promise to finish a remote operation within its deadline.
 
-### Invocation approval
+### Tool-call control
+
+Like Pi's built-in tools, loaded MCP tools execute without adapter-specific
+permission prompts in both interactive and headless sessions. Native calls pass
+through Pi's normal `tool_call` and `tool_result` hooks. For approvals or access
+policies, install a Pi extension that handles `tool_call` so it can manage MCP
+and other tools together. Server annotations do not bypass those hooks.
+Configuration trust above is separate: it authorizes startup, not individual calls.
 
-Tool invocation requires confirmation independently of config trust. In headless
-mode, calls fail closed unless the reviewed configuration explicitly sets
-`"approve": false` for that server. Native calls still pass through Pi's normal
-tool hooks. Server annotations never grant permission. Child stderr and raw SDK
-errors are not printed because they can contain credentials; debug a failing
-server separately in a trusted environment.
+**Migration from 0.0.2:** Remove the server-level `approve` field. Entries that
+still contain it are rejected with migration guidance rather than silently
+ignoring an existing policy. If you relied on `approve: true`, configure an
+external permission extension before removing it.
+
+Child stderr and raw SDK errors are not printed because they can contain
+credentials; debug a failing server separately in a trusted environment.
 
 ## Discovery and execution
 
@@ -180,10 +175,9 @@ Selection is tied to the current schema fingerprint: use `search`/`load`, not
 Pi's generic tool-name toggles, to enable a native MCP tool.
 
 Native names include a readable server/tool prefix and a deterministic hash to
-avoid normalization collisions. Independent, preapproved native calls can run
-concurrently. Calls requiring confirmation run sequentially to avoid overlapping
-approval dialogs. Discovered tools stay active until session shutdown or a server
-catalog change.
+avoid normalization collisions. Independent native calls can run concurrently;
+permission extensions must coordinate any shared approval UI. Discovered tools
+stay active until session shutdown or a server catalog change.
 Changed and removed definitions are withdrawn; changed tools require loading
 again. Unsupported input schemas or metadata, name collisions, and task-only
 tools are counted as `unsupportedTools` in discovery results. An unsupported
@@ -237,5 +231,6 @@ OAuth, legacy SSE transport, MCP prompts/resources APIs, sampling, elicitation,
 MCP apps, task execution, semantic search, scripting, config UI, and persistent
 catalog caching. Use a fuller adapter when those capabilities are required.
 
-Tests use local stdio/HTTP fixture servers and isolated Pi configuration, without
-model requests or personal credentials.
+## Contributing
+
+Read [CONTRIBUTING.md](CONTRIBUTING.md) before making changes.

package/mcp.schema.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json-schema.org/draft/2020-12/schema",
   "title": "pix-mcp configuration",
-  "description": "A Claude-style connection subset with pix-specific approval and lifecycle options. Environment expansion and HTTP URL/header validation also occur at runtime.",
+  "description": "A Claude-style connection subset with pix-specific discovery and lifecycle options. Environment expansion and HTTP URL/header validation also occur at runtime.",
   "type": "object",
   "required": ["mcpServers"],
   "additionalProperties": false,
@@ -43,11 +43,6 @@
           "$ref": "#/$defs/timeout",
           "description": "pix extension: one complete catalog snapshot, including all pages."
         },
-        "approve": {
-          "type": "boolean",
-          "default": true,
-          "description": "pix extension: require confirmation for every tool invocation."
-        },
         "disabled": { "const": false }
       }
     },
@@ -108,7 +103,6 @@
         "timeout": true,
         "startupTimeoutMs": true,
         "catalogTimeoutMs": true,
-        "approve": true,
         "disabled": { "type": "boolean" }
       },
       "if": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ikuma.cloud/pix-mcp",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "publishConfig": {
     "access": "public"
   },

package/src/config.ts

@@ -9,7 +9,6 @@ export interface CommonServer {
   timeout: number;
   startupTimeoutMs: number;
   catalogTimeoutMs: number;
-  approve: boolean;
 }
 export type ServerConfig = CommonServer &
   (
@@ -133,6 +132,11 @@ function parseServer(
       "timeoutMs",
       "Removed; use timeout for tool calls, startupTimeoutMs for initialization, and catalogTimeoutMs for discovery (milliseconds).",
     );
+  if (Object.hasOwn(server, "approve"))
+    invalid(
+      "approve",
+      "Removed; delete approve and use a Pi tool_call extension for permission controls.",
+    );
   const allowed = new Set([
     "type",
     "command",
@@ -145,7 +149,6 @@ function parseServer(
     "timeout",
     "startupTimeoutMs",
     "catalogTimeoutMs",
-    "approve",
     "disabled",
   ]);
   if (Object.keys(server).some((key) => !allowed.has(key)))
@@ -156,8 +159,6 @@ function parseServer(
   if (server.disabled !== undefined && typeof server.disabled !== "boolean")
     invalid("disabled", "Expected a boolean.");
   if (server.disabled === true) return undefined;
-  if (server.approve !== undefined && typeof server.approve !== "boolean")
-    invalid("approve", "Expected a boolean.");
   const common: CommonServer = {
     name,
     description:
@@ -167,7 +168,6 @@ function parseServer(
     timeout: timeout(server.timeout, "timeout"),
     startupTimeoutMs: timeout(server.startupTimeoutMs, "startupTimeoutMs"),
     catalogTimeoutMs: timeout(server.catalogTimeoutMs, "catalogTimeoutMs"),
-    approve: server.approve !== false,
   };
   const type =
     server.type === undefined && server.command !== undefined

package/src/index.ts

@@ -250,46 +250,22 @@ export default function mcp(pi: ExtensionAPI) {
             description:
               tool.description || `Call ${tool.name} on ${config.name}.`,
             parameters,
-            // Approval dialogs share Pi's UI. Only preapproved calls may overlap.
-            executionMode: config.approve ? "sequential" : "parallel",
-            async execute(_id, params, signal, _onUpdate, ctx) {
+            executionMode: "parallel",
+            async execute(_id, params, signal) {
               current(owner);
               signal?.throwIfAborted();
-              const verify = () => {
-                current(owner);
-                if (
-                  owner.entries.get(item.name)?.fingerprint !==
-                    item.fingerprint ||
-                  owner.loaded.get(item.name) !== item.fingerprint ||
-                  !pi.getActiveTools().includes(item.name)
-                ) {
-                  throw new Error(
-                    "MCP tool is unavailable or changed. Discover it again.",
-                  );
-                }
-              };
-              verify();
-              if (!validator.Check(params))
-                throw new Error("Arguments do not match the MCP input schema.");
-              if (config.approve) {
-                if (!ctx.hasUI)
-                  throw new Error(
-                    "MCP approval required. Use an interactive session or explicitly set approve:false for this trusted server.",
-                  );
-                const input = JSON.stringify(params, null, 2);
-                if (input.length > 8000)
-                  throw new Error(
-                    "MCP arguments are too large for the approval dialog.",
-                  );
-                const allowed = await ctx.ui.confirm(
-                  `Call ${config.name}/${tool.name}?`,
-                  input,
-                  signal ? { signal } : undefined,
+              if (
+                owner.entries.get(item.name)?.fingerprint !==
+                  item.fingerprint ||
+                owner.loaded.get(item.name) !== item.fingerprint ||
+                !pi.getActiveTools().includes(item.name)
+              ) {
+                throw new Error(
+                  "MCP tool is unavailable or changed. Discover it again.",
                 );
-                if (!allowed) throw new Error("MCP tool call denied.");
               }
-              signal?.throwIfAborted();
-              verify();
+              if (!validator.Check(params))
+                throw new Error("Arguments do not match the MCP input schema.");
               const connection = owner.connections.get(config.name);
               if (!connection) throw new Error("MCP connection unavailable.");
               const result = await connection.call(