@ijfw/install 1.1.2 → 1.1.3

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog -- @ijfw/install
 
+## [1.1.3] -- 2026-04-21
+
+Windows "it just works" fix + Windows CI gate.
+
+### Windows npx path finally works
+
+- **`install.js` now resolves `bash.exe` via `git.exe`'s install root** instead of requiring `bash` on PATH. Git for Windows installs `bash.exe` at `C:\Program Files\Git\bin\bash.exe` but by default does **not** add that dir to PATH, so the previous `hasBin('bash')` preflight always failed -- even on a perfectly-functional Git for Windows install. New `findBash()` helper mirrors `install.ps1`'s `Resolve-GitBash`: walks `where git` output to find the sibling bash.exe, falls back to `Program Files\Git\{bin,usr/bin}\bash.exe`, and only errors if nothing lands.
+- `runInstallScript` now calls the resolved `bash.exe` path directly instead of bare `"bash"`, so the child process spawns cleanly on Windows without PATH manipulation.
+- Error message when git is missing on Windows now leads with a single `winget install --id Git.Git` command, drops the PS1 `irm | iex` fallback (Windows Defender heuristically blocks that pattern), and tells the user to reopen PowerShell before rerunning so the PATH refresh picks up.
+- Error message when git is present but bash.exe cannot be located points at the expected path and gives a one-line remediation.
+
+### Windows CI gate (new)
+
+- `.github/workflows/windows-smoke.yml`. Runs on every push and PR on `windows-latest`. Checks: install.js loads, `findBash()` returns a live path, installer clones + runs `scripts/install.sh` against a scratch IJFW_HOME with `IJFW_CUSTOM_DIR=1`, writes the expected files. Catches the 1.1.2 regression at source -- a Windows publish that would have shipped a broken `npx` entry point now fails CI before it reaches main.
+
+### Internal
+
+- `mcp-server/package.json` bumped 1.1.2 -> 1.1.3 to stay in lockstep with the installer.
+
+### Notes for upgraders
+
+- No behavioral change for macOS or Linux users. `findBash()` returns `"bash"` on non-Windows hosts where PATH is reliable.
+- No config-schema changes. `~/.codex/hooks.json` stays on the 1.1.2 nested map schema.
+
 ## [1.1.2] -- 2026-04-21
 
 Reach + bug fixes. Two new platforms (Hermes + Wayland), deep installer repairs uncovered by live-platform testing, cross-platform sync of new behavioral rules. Ships with a full end-to-end smoke harness at `scripts/e2e-smoke.sh` that now has to pass before any future release.

package/dist/install.js

@@ -3,7 +3,7 @@
 // src/install.js
 import { spawnSync } from "node:child_process";
 import { existsSync as existsSync2, rmSync, mkdirSync as mkdirSync2, realpathSync, renameSync as renameSync2 } from "node:fs";
-import { resolve, join as join2 } from "node:path";
+import { resolve, join as join2, dirname as dirname2 } from "node:path";
 import { homedir as homedir2, platform } from "node:os";
 import { fileURLToPath } from "node:url";
 
@@ -151,10 +151,20 @@ function preflight() {
   const issues = [];
   const [major] = process.versions.node.split(".").map(Number);
   if (major < 18) issues.push(`IJFW needs Node >=18 -- current: ${process.versions.node}. Upgrade Node, then retry.`);
-  if (!hasBin("git")) issues.push("IJFW needs git on PATH -- install git (https://git-scm.com), then retry.");
-  if (!hasBin("bash")) {
+  if (!hasBin("git")) {
     if (platform() === "win32") {
-      issues.push("IJFW on Windows needs Git Bash. Install Git for Windows (https://git-scm.com/download/win), or run the PowerShell installer: irm https://raw.githubusercontent.com/TheRealSeanDonahoe/ijfw/main/installer/src/install.ps1 | iex");
+      issues.push(
+        "IJFW needs Git for Windows (it bundles git + bash). One command:\n    winget install --id Git.Git -e --source winget --accept-source-agreements --accept-package-agreements\n  Then close this PowerShell window, open a fresh one, and rerun:\n    npx -p @ijfw/install ijfw-install"
+      );
+    } else {
+      issues.push("IJFW needs git on PATH -- install git (https://git-scm.com), then retry.");
+    }
+  }
+  if (!findBash()) {
+    if (platform() === "win32") {
+      issues.push(
+        "IJFW could not locate bash.exe. Git for Windows installs it at\n    C:\\Program Files\\Git\\bin\\bash.exe\n  If you installed Git elsewhere, add its bin\\ to PATH and rerun.\n  Missing Git entirely? winget install --id Git.Git -e --source winget"
+      );
     } else {
       issues.push("IJFW needs bash on PATH -- install bash, then retry.");
     }
@@ -165,6 +175,32 @@ function hasBin(bin) {
   const res = spawnSync(bin, ["--version"], { stdio: "ignore" });
   return res.status === 0 || res.status === null ? res.error ? false : true : false;
 }
+function findBash() {
+  if (hasBin("bash") && platform() !== "win32") return "bash";
+  if (platform() !== "win32") return hasBin("bash") ? "bash" : null;
+  const whereGit = spawnSync("where", ["git"], { encoding: "utf8" });
+  if (whereGit.status === 0) {
+    const gitPath = (whereGit.stdout || "").split(/\r?\n/)[0].trim();
+    if (gitPath && existsSync2(gitPath)) {
+      const gitDir = dirname2(gitPath);
+      const gitRoot = dirname2(gitDir);
+      const candidates = [
+        join2(gitDir, "bash.exe"),
+        join2(gitRoot, "bin", "bash.exe"),
+        join2(gitRoot, "usr", "bin", "bash.exe")
+      ];
+      for (const c of candidates) if (existsSync2(c)) return c;
+    }
+  }
+  for (const c of [
+    "C:\\Program Files\\Git\\bin\\bash.exe",
+    "C:\\Program Files\\Git\\usr\\bin\\bash.exe",
+    "C:\\Program Files (x86)\\Git\\bin\\bash.exe",
+    "C:\\Program Files (x86)\\Git\\usr\\bin\\bash.exe"
+  ]) if (existsSync2(c)) return c;
+  if (hasBin("bash")) return "bash";
+  return null;
+}
 function resolveTarget(opt) {
   if (opt.dir) return resolve(opt.dir);
   if (process.env.IJFW_HOME) return resolve(process.env.IJFW_HOME);
@@ -224,7 +260,11 @@ function runInstallScript(dir) {
     IJFW_HOME: dir,
     IJFW_CUSTOM_DIR: isCustomDir
   };
-  const r = spawnSync("bash", ["scripts/install.sh"], { cwd: dir, stdio: "inherit", env });
+  const bashExe = findBash();
+  if (!bashExe) {
+    throw new Error("IJFW could not locate bash (preflight should have caught this -- file an issue).");
+  }
+  const r = spawnSync(bashExe, ["scripts/install.sh"], { cwd: dir, stdio: "inherit", env });
   if (r.status !== 0) throw new Error(`IJFW platform config step did not complete (exit ${r.status}) -- run ijfw doctor to see what to fix.`);
 }
 async function main() {
@@ -282,5 +322,6 @@ if (isDirectRun()) {
   });
 }
 export {
+  findBash,
   resolveBranchOrTag
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ijfw/install",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "One-command installer for IJFW -- the AI efficiency layer. One install, every AI coding agent, zero config.",
   "type": "module",
   "bin": {
@@ -18,7 +18,7 @@
     "LICENSE"
   ],
   "scripts": {
-    "build": "rm -rf docs && mkdir -p docs/guide && cp ../docs/GUIDE.md docs/GUIDE.md && cp -r ../docs/guide/assets docs/guide/assets && esbuild src/install.js src/uninstall.js src/ijfw.js --bundle --platform=node --target=node18 --outdir=dist --format=esm --banner:js='#!/usr/bin/env node' && chmod +x dist/install.js dist/uninstall.js dist/ijfw.js",
+    "build": "node scripts/build.js",
     "test": "node --test test.js",
     "preflight": "node dist/ijfw.js preflight",
     "pack:check": "npm pack --dry-run",