@ijfw/install 1.1.1 → 1.1.3

package/CHANGELOG.md

@@ -1,5 +1,86 @@
 # Changelog -- @ijfw/install
 
+## [1.1.3] -- 2026-04-21
+
+Windows "it just works" fix + Windows CI gate.
+
+### Windows npx path finally works
+
+- **`install.js` now resolves `bash.exe` via `git.exe`'s install root** instead of requiring `bash` on PATH. Git for Windows installs `bash.exe` at `C:\Program Files\Git\bin\bash.exe` but by default does **not** add that dir to PATH, so the previous `hasBin('bash')` preflight always failed -- even on a perfectly-functional Git for Windows install. New `findBash()` helper mirrors `install.ps1`'s `Resolve-GitBash`: walks `where git` output to find the sibling bash.exe, falls back to `Program Files\Git\{bin,usr/bin}\bash.exe`, and only errors if nothing lands.
+- `runInstallScript` now calls the resolved `bash.exe` path directly instead of bare `"bash"`, so the child process spawns cleanly on Windows without PATH manipulation.
+- Error message when git is missing on Windows now leads with a single `winget install --id Git.Git` command, drops the PS1 `irm | iex` fallback (Windows Defender heuristically blocks that pattern), and tells the user to reopen PowerShell before rerunning so the PATH refresh picks up.
+- Error message when git is present but bash.exe cannot be located points at the expected path and gives a one-line remediation.
+
+### Windows CI gate (new)
+
+- `.github/workflows/windows-smoke.yml`. Runs on every push and PR on `windows-latest`. Checks: install.js loads, `findBash()` returns a live path, installer clones + runs `scripts/install.sh` against a scratch IJFW_HOME with `IJFW_CUSTOM_DIR=1`, writes the expected files. Catches the 1.1.2 regression at source -- a Windows publish that would have shipped a broken `npx` entry point now fails CI before it reaches main.
+
+### Internal
+
+- `mcp-server/package.json` bumped 1.1.2 -> 1.1.3 to stay in lockstep with the installer.
+
+### Notes for upgraders
+
+- No behavioral change for macOS or Linux users. `findBash()` returns `"bash"` on non-Windows hosts where PATH is reliable.
+- No config-schema changes. `~/.codex/hooks.json` stays on the 1.1.2 nested map schema.
+
+## [1.1.2] -- 2026-04-21
+
+Reach + bug fixes. Two new platforms (Hermes + Wayland), deep installer repairs uncovered by live-platform testing, cross-platform sync of new behavioral rules. Ships with a full end-to-end smoke harness at `scripts/e2e-smoke.sh` that now has to pass before any future release.
+
+### New platforms
+
+- **Hermes** (`hermes/`): MCP registration in `~/.hermes/config.yaml`, `HERMES.md` context file, 19 IJFW skills dropped into `~/.hermes/skills/ijfw-*` in agentskills.io format. Python CLI (`hermes` command).
+- **Wayland** (`wayland/`): same shape. MCP registration in `~/.wayland/config.yaml`, `WAYLAND.md` context file, skills bundle in `~/.wayland/skills/ijfw-*`. Python CLI (`wayland` command).
+- `scripts/install.sh` gains a `merge_yaml_mcp` helper (prefers python3+PyYAML for parser-safe merge; sentinel-anchored fallback if PyYAML isn't available).
+- Default target list expands to 8: `claude codex gemini cursor windsurf copilot hermes wayland`. `is_live` and `pretty_name` updated to match.
+
+### Installer repairs (high -- announcement blockers)
+
+- **Bug A: platform-config writes now respect `IJFW_CUSTOM_DIR`.** The 1.1.2 prep pass only guarded sibling links and bin wiring. The `~/.claude/settings.json`, `~/.codex/`, `~/.gemini/`, `~/.codeium/windsurf/` merges were still running during scratch installs and clobbering real user configs with scratch paths. Every platform case block now short-circuits early when `IJFW_CUSTOM_DIR=1`, prints a single "real platform config left untouched" line, and still classifies the platform as live/standby for the summary banner.
+- **Bug B: Codex `hooks.json` schema migrated to the current nested format.** Codex CLI 0.120+ rejects both the legacy `{"hooks":[...]}` object-wrapper and the bare-array shape this release started with. Authoritative schema (per `codex-rs/hooks/src/engine/config.rs`): `{"hooks": {EventName: [MatcherGroup]}}` where each MatcherGroup is `{matcher?, hooks: [{type: "command", command, timeout?, ...}]}`. Installer writer now emits this shape, absorbs either legacy shape on read, drops the non-existent `AfterAgent` event, renames `script` to `command`, and adds the `"type": "command"` discriminator.
+- **Bug C: `suppress_unstable_features_warning = true` is now written to `~/.codex/config.toml`.** Stops the "under-development features enabled: codex_hooks" banner on every Codex startup.
+- **Self-loop guards now canonicalize `$HOME`.** On macOS `/var/folders` is a symlink to `/private/var/folders`; the `cd -P` used for `REPO_ROOT` resolved that, but `$HOME` did not, so the `PLUGIN_SRC == PLUGIN_DST` and `MCP_SRC == MCP_DST` comparisons missed the equal case and created recursive self-symlinks ("too many levels of symbolic links" on next access). Installer now computes `HOME_REAL="$(cd -P "$HOME" && pwd)"` once and uses it for all self-loop comparisons.
+- **`C_RED` variable declared.** Previously only initialized on interactive TTYs; a failing post-install gate in a non-TTY context (CI, harness, `npx` capture) would crash the installer with `C_RED: unbound variable` under `set -u`. Declared in both branches of the color-init block.
+
+### Behavioral additions (synced across Claude / Codex / Gemini / Cursor / Windsurf / Copilot / Hermes / Wayland / universal where relevant)
+
+- `ijfw-core` and platform rules-files: explicit banned openers ("Great question", "You're absolutely right", "Excellent idea", "I'd be happy to") and a sharpened two-strikes session-reset rule that asks the user to start a fresh session with a tighter prompt rather than burning context on a third failed attempt.
+- `ijfw-debug`: new Step 6 templating the two-strikes reset with a memory-store call so lessons inherit forward without context noise.
+- `ijfw-verify`: opens with "Plausibility is not correctness." Every claim must trace to a command output, test pass, or manual verification.
+- `ijfw-workflow` Quick FRAME: five concrete goal-rewrite examples ("Add validation" -> "Write tests for invalid inputs..."). Vague asks must surface the gap rather than silently proceed.
+- `ijfw-memory-audit`: pruning question added ("Would removing this rule cause the agent to make a mistake?") so memory stays sharp instead of bloated.
+- `ijfw-critique`: refactor reframe ("Knowing everything I know now, what would the elegant solution look like?") for breaking frame on non-trivial decisions.
+
+### End-to-end smoke harness
+
+- New `scripts/e2e-smoke.sh`. Two modes, both must pass:
+  1. **Scratch-guard check** -- runs installer with `IJFW_CUSTOM_DIR=1` pointed at a throwaway dir, verifies zero drift across 10 real-home config paths (hashes before and after). Catches any future Bug A regression.
+  2. **Canonical isolated-HOME install** -- runs installer with `HOME=$(mktemp -d)`, parses every platform's written config against its expected schema (Codex nested hooks, Gemini JSON, YAML for Hermes/Wayland, etc.), completes the MCP `initialize + tools/list` handshake, and fails loudly on any mismatch.
+- 13 gates total. Harness must be green before any future `npm publish`.
+
+### Uninstaller
+
+- `installer/src/uninstall.js:removeCodexHooks` now handles all three hook-file shapes we have ever shipped (bare array, legacy `{hooks:[...]}` object-wrapper, current nested-map). Uninstall works regardless of which version the user last installed.
+- New `removeYamlMcpEntry` helper (python3+PyYAML preferred, regex fallback). Cleans `~/.hermes/config.yaml` and `~/.wayland/config.yaml`, removes skill dirs and context files for both new platforms.
+- `cleanPlatforms()` comment updated: "all 8 platforms".
+
+### Installer scope-leak fixes (carried from 1.1.2 prep)
+
+- `scripts/install.sh` now respects `IJFW_CUSTOM_DIR` from `install.js`. Custom-dir installs (`--dir <scratch>`) skip user-home mutations: no sibling links into `~/.ijfw/`, no bin symlinks into `~/.local/bin/`, no `.mcp.json` patching of the real plugin, no `~/.claude/plugins/cache/ijfw` invalidation. Default canonical install behavior unchanged.
+- Self-loop guard: when `PLUGIN_SRC == PLUGIN_DST` (install dir is the canonical home and source happens to live there), the symlink step is skipped instead of creating a recursive `~/.ijfw/claude -> ~/.ijfw/claude` loop.
+- `installer/src/uninstall.js`: `uninstall --dir <scratch>` now leaves `~/.codex/`, `~/.gemini/`, `~/.codeium/windsurf/` configs and skill dirs alone. Only canonical uninstalls (`~/.ijfw`) clean platform configs.
+
+### Dynamic version strings
+
+- `mcp-server/src/server.js` and `mcp-server/src/dashboard-server.js` now read version from `mcp-server/package.json` at module load instead of hardcoding. MCP `serverInfo` and `/api/health` always match the shipped version.
+
+### Internal
+
+- `mcp-server/package.json` bumped from 1.1.0 to 1.1.2 (was lagging two minor cycles).
+- `.gitattributes`: added LF normalization rules (carried from 1.1.1).
+- Banner on successful install now says "8 platforms" instead of "7".
+
 ## [1.1.1] -- 2026-04-19
 
 Docs and discoverability.

package/dist/install.js

@@ -3,7 +3,7 @@
 // src/install.js
 import { spawnSync } from "node:child_process";
 import { existsSync as existsSync2, rmSync, mkdirSync as mkdirSync2, realpathSync, renameSync as renameSync2 } from "node:fs";
-import { resolve, join as join2 } from "node:path";
+import { resolve, join as join2, dirname as dirname2 } from "node:path";
 import { homedir as homedir2, platform } from "node:os";
 import { fileURLToPath } from "node:url";
 
@@ -151,10 +151,20 @@ function preflight() {
   const issues = [];
   const [major] = process.versions.node.split(".").map(Number);
   if (major < 18) issues.push(`IJFW needs Node >=18 -- current: ${process.versions.node}. Upgrade Node, then retry.`);
-  if (!hasBin("git")) issues.push("IJFW needs git on PATH -- install git (https://git-scm.com), then retry.");
-  if (!hasBin("bash")) {
+  if (!hasBin("git")) {
     if (platform() === "win32") {
-      issues.push("IJFW on Windows needs Git Bash. Install Git for Windows (https://git-scm.com/download/win), or run the PowerShell installer: irm https://raw.githubusercontent.com/TheRealSeanDonahoe/ijfw/main/installer/src/install.ps1 | iex");
+      issues.push(
+        "IJFW needs Git for Windows (it bundles git + bash). One command:\n    winget install --id Git.Git -e --source winget --accept-source-agreements --accept-package-agreements\n  Then close this PowerShell window, open a fresh one, and rerun:\n    npx -p @ijfw/install ijfw-install"
+      );
+    } else {
+      issues.push("IJFW needs git on PATH -- install git (https://git-scm.com), then retry.");
+    }
+  }
+  if (!findBash()) {
+    if (platform() === "win32") {
+      issues.push(
+        "IJFW could not locate bash.exe. Git for Windows installs it at\n    C:\\Program Files\\Git\\bin\\bash.exe\n  If you installed Git elsewhere, add its bin\\ to PATH and rerun.\n  Missing Git entirely? winget install --id Git.Git -e --source winget"
+      );
     } else {
       issues.push("IJFW needs bash on PATH -- install bash, then retry.");
     }
@@ -165,6 +175,32 @@ function hasBin(bin) {
   const res = spawnSync(bin, ["--version"], { stdio: "ignore" });
   return res.status === 0 || res.status === null ? res.error ? false : true : false;
 }
+function findBash() {
+  if (hasBin("bash") && platform() !== "win32") return "bash";
+  if (platform() !== "win32") return hasBin("bash") ? "bash" : null;
+  const whereGit = spawnSync("where", ["git"], { encoding: "utf8" });
+  if (whereGit.status === 0) {
+    const gitPath = (whereGit.stdout || "").split(/\r?\n/)[0].trim();
+    if (gitPath && existsSync2(gitPath)) {
+      const gitDir = dirname2(gitPath);
+      const gitRoot = dirname2(gitDir);
+      const candidates = [
+        join2(gitDir, "bash.exe"),
+        join2(gitRoot, "bin", "bash.exe"),
+        join2(gitRoot, "usr", "bin", "bash.exe")
+      ];
+      for (const c of candidates) if (existsSync2(c)) return c;
+    }
+  }
+  for (const c of [
+    "C:\\Program Files\\Git\\bin\\bash.exe",
+    "C:\\Program Files\\Git\\usr\\bin\\bash.exe",
+    "C:\\Program Files (x86)\\Git\\bin\\bash.exe",
+    "C:\\Program Files (x86)\\Git\\usr\\bin\\bash.exe"
+  ]) if (existsSync2(c)) return c;
+  if (hasBin("bash")) return "bash";
+  return null;
+}
 function resolveTarget(opt) {
   if (opt.dir) return resolve(opt.dir);
   if (process.env.IJFW_HOME) return resolve(process.env.IJFW_HOME);
@@ -216,8 +252,19 @@ function cloneOrPull(dir, branch) {
 function runInstallScript(dir) {
   const script = join2(dir, "scripts", "install.sh");
   if (!existsSync2(script)) throw new Error(`IJFW install script not found at ${script} -- re-run the installer to restore it.`);
-  const env = { ...process.env, IJFW_NONINTERACTIVE: process.env.CI ? "1" : process.env.IJFW_NONINTERACTIVE ?? "" };
-  const r = spawnSync("bash", ["scripts/install.sh"], { cwd: dir, stdio: "inherit", env });
+  const canonicalDir = join2(homedir2(), ".ijfw");
+  const isCustomDir = resolve(dir) !== canonicalDir ? "1" : "0";
+  const env = {
+    ...process.env,
+    IJFW_NONINTERACTIVE: process.env.CI ? "1" : process.env.IJFW_NONINTERACTIVE ?? "",
+    IJFW_HOME: dir,
+    IJFW_CUSTOM_DIR: isCustomDir
+  };
+  const bashExe = findBash();
+  if (!bashExe) {
+    throw new Error("IJFW could not locate bash (preflight should have caught this -- file an issue).");
+  }
+  const r = spawnSync(bashExe, ["scripts/install.sh"], { cwd: dir, stdio: "inherit", env });
   if (r.status !== 0) throw new Error(`IJFW platform config step did not complete (exit ${r.status}) -- run ijfw doctor to see what to fix.`);
 }
 async function main() {
@@ -253,7 +300,7 @@ async function main() {
     console.log(`  marketplace registered in ${settingsPath}`);
   }
   console.log("");
-  console.log("IJFW now active across 7 platforms -- one memory layer, all your AIs, zero config.");
+  console.log("IJFW now active across 8 platforms -- one memory layer, all your AIs, zero config.");
   console.log("  Run `ijfw demo` to see the Trident in action.");
   console.log("  Run `ijfw doctor` to confirm which auditors are reachable.");
   console.log("  Privacy: everything stays local. See NO_TELEMETRY.md.");
@@ -275,5 +322,6 @@ if (isDirectRun()) {
   });
 }
 export {
+  findBash,
   resolveBranchOrTag
 };

package/dist/uninstall.js

@@ -4,6 +4,7 @@
 import { existsSync as existsSync2, rmSync, cpSync, mkdtempSync, readFileSync as readFileSync2, writeFileSync as writeFileSync2, readdirSync } from "node:fs";
 import { resolve, join as join2 } from "node:path";
 import { homedir as homedir2, tmpdir } from "node:os";
+import { spawnSync } from "node:child_process";
 
 // src/marketplace.js
 import { readFileSync, writeFileSync, renameSync, existsSync, mkdirSync } from "node:fs";
@@ -156,12 +157,74 @@ function removeCodexHooks(p) {
   } catch {
     return false;
   }
-  if (!Array.isArray(doc.hooks)) return false;
-  const before = doc.hooks.length;
-  doc.hooks = doc.hooks.filter((h) => !h._ijfw);
-  if (doc.hooks.length === before) return false;
+  if (Array.isArray(doc)) {
+    const before = doc.length;
+    const after = doc.filter((h) => !(h && h._ijfw));
+    if (after.length === before) return false;
+    backupFile(p);
+    writeFileSync2(p, JSON.stringify(after, null, 2) + "\n");
+    return true;
+  }
+  if (!doc || typeof doc !== "object" || !doc.hooks) return false;
+  if (doc.hooks && typeof doc.hooks === "object" && !Array.isArray(doc.hooks)) {
+    let changed = false;
+    for (const ev of Object.keys(doc.hooks)) {
+      const groups = doc.hooks[ev];
+      if (!Array.isArray(groups)) continue;
+      const before = groups.length;
+      doc.hooks[ev] = groups.filter((g) => {
+        if (!g || !Array.isArray(g.hooks)) return true;
+        return !g.hooks.some((h) => h && h._ijfw);
+      });
+      if (doc.hooks[ev].length !== before) changed = true;
+    }
+    if (!changed) return false;
+    backupFile(p);
+    writeFileSync2(p, JSON.stringify(doc, null, 2) + "\n");
+    return true;
+  }
+  if (Array.isArray(doc.hooks)) {
+    const before = doc.hooks.length;
+    doc.hooks = doc.hooks.filter((h) => !(h && h._ijfw));
+    if (doc.hooks.length === before) return false;
+    backupFile(p);
+    writeFileSync2(p, JSON.stringify(doc, null, 2) + "\n");
+    return true;
+  }
+  return false;
+}
+function removeYamlMcpEntry(p) {
+  if (!existsSync2(p)) return false;
+  const raw = readFileSync2(p, "utf8");
+  if (!/\bijfw-memory\b/.test(raw)) return false;
+  const py = spawnSync("python3", ["-c", `
+import sys, yaml
+p = sys.argv[1]
+with open(p) as f: raw = f.read()
+doc = yaml.safe_load(raw) if raw.strip() else {}
+if not isinstance(doc, dict): sys.exit(2)
+srv = doc.get("mcp_servers")
+if not isinstance(srv, dict) or "ijfw-memory" not in srv: sys.exit(3)
+del srv["ijfw-memory"]
+if not srv: del doc["mcp_servers"]
+with open(p + ".tmp", "w") as f:
+    yaml.safe_dump(doc, f, sort_keys=False, default_flow_style=False)
+import os; os.replace(p + ".tmp", p)
+`, p], { encoding: "utf8" });
+  if (py.status === 0) {
+    backupFile(p);
+    return true;
+  }
+  const stripped = raw.replace(
+    /^  ijfw-memory:\n(?:    .*\n)*(?:# IJFW-MCP-END ijfw-memory\n)?/m,
+    ""
+  ).replace(
+    /# IJFW-MCP-BEGIN ijfw-memory\n(?:.*\n)*?# IJFW-MCP-END ijfw-memory\n/,
+    ""
+  );
+  if (stripped === raw) return false;
   backupFile(p);
-  writeFileSync2(p, JSON.stringify(doc, null, 2) + "\n");
+  writeFileSync2(p, stripped);
   return true;
 }
 function removeIjfwSkills(dir) {
@@ -205,6 +268,26 @@ function cleanPlatforms() {
   }
   const vscodeMcp = join2(".vscode", "mcp.json");
   if (removeJsonMcpEntry(vscodeMcp)) removed.push(".vscode/mcp.json  (removed ijfw-memory)");
+  if (removeYamlMcpEntry(join2(HOME, ".hermes", "config.yaml"))) {
+    removed.push("~/.hermes/config.yaml  (removed ijfw-memory)");
+  }
+  const hermesSkills = removeIjfwSkills(join2(HOME, ".hermes", "skills"));
+  if (hermesSkills > 0) removed.push(`~/.hermes/skills/ijfw-*  (removed ${hermesSkills} skill dirs)`);
+  const hermesMd = join2(HOME, ".hermes", "HERMES.md");
+  if (existsSync2(hermesMd)) {
+    rmSync(hermesMd, { force: true });
+    removed.push("~/.hermes/HERMES.md");
+  }
+  if (removeYamlMcpEntry(join2(HOME, ".wayland", "config.yaml"))) {
+    removed.push("~/.wayland/config.yaml  (removed ijfw-memory)");
+  }
+  const waylandSkills = removeIjfwSkills(join2(HOME, ".wayland", "skills"));
+  if (waylandSkills > 0) removed.push(`~/.wayland/skills/ijfw-*  (removed ${waylandSkills} skill dirs)`);
+  const waylandMd = join2(HOME, ".wayland", "WAYLAND.md");
+  if (existsSync2(waylandMd)) {
+    rmSync(waylandMd, { force: true });
+    removed.push("~/.wayland/WAYLAND.md");
+  }
   return removed;
 }
 function resolveTarget(opt) {
@@ -238,17 +321,23 @@ async function main() {
       console.log("  memory/ was not present; nothing to preserve");
     }
   }
-  if (!opts.noMarketplace) {
+  const canonicalDir = join2(HOME, ".ijfw");
+  const isCanonical = target === canonicalDir;
+  if (isCanonical && !opts.noMarketplace) {
     const settingsPath = claudeSettingsPath();
     if (existsSync2(settingsPath)) {
       unmergeMarketplace(settingsPath);
       console.log(`  marketplace removed from ${settingsPath}`);
     }
   }
-  const cleaned = cleanPlatforms();
-  if (cleaned.length > 0) {
-    console.log("  platform configs cleaned:");
-    for (const line of cleaned) console.log(`    ${line}`);
+  if (isCanonical) {
+    const cleaned = cleanPlatforms();
+    if (cleaned.length > 0) {
+      console.log("  platform configs cleaned:");
+      for (const line of cleaned) console.log(`    ${line}`);
+    }
+  } else {
+    console.log(`  custom-dir uninstall (${target}) -- platform configs in your real home left untouched.`);
   }
   console.log("\nIJFW uninstalled. Thanks for trying it.");
   process.exit(0);

package/docs/GUIDE.md

@@ -1,5 +1,5 @@
 <p align="center">
-  <img src="https://github.com/TheRealSeanDonahoe/ijfw/releases/download/v1.1.0/ijfw-hero.png" alt="IJFW" width="100%"/>
+  <img src="https://github.com/TheRealSeanDonahoe/ijfw/releases/download/v1.1.1/ijfw-hero.png" alt="IJFW" width="100%"/>
 </p>
 
 # The IJFW Guide

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ijfw/install",
-  "version": "1.1.1",
+  "version": "1.1.3",
   "description": "One-command installer for IJFW -- the AI efficiency layer. One install, every AI coding agent, zero config.",
   "type": "module",
   "bin": {
@@ -18,7 +18,7 @@
     "LICENSE"
   ],
   "scripts": {
-    "build": "rm -rf docs && mkdir -p docs/guide && cp ../docs/GUIDE.md docs/GUIDE.md && cp -r ../docs/guide/assets docs/guide/assets && esbuild src/install.js src/uninstall.js src/ijfw.js --bundle --platform=node --target=node18 --outdir=dist --format=esm --banner:js='#!/usr/bin/env node' && chmod +x dist/install.js dist/uninstall.js dist/ijfw.js",
+    "build": "node scripts/build.js",
     "test": "node --test test.js",
     "preflight": "node dist/ijfw.js preflight",
     "pack:check": "npm pack --dry-run",