@ihazz/bitrix24 1.1.1 → 1.1.2

package/tests/group-access.test.ts

@@ -1,340 +0,0 @@
-import { describe, it, expect, vi } from 'vitest';
-import {
-  buildGroupMatchKeys,
-  checkGroupAccessPassive,
-  checkGroupAccessWithPairing,
-  normalizeGroupAllowList,
-  normalizeGroupEntry,
-  resolveGroupAccess,
-} from '../src/group-access.js';
-import type { PluginRuntime, ChannelPairingAdapter } from '../src/runtime.js';
-
-function makeMockRuntime(storeAllowFrom: string[] = []): PluginRuntime {
-  return {
-    config: { loadConfig: () => ({}) },
-    channel: {
-      routing: { resolveAgentRoute: vi.fn() },
-      reply: {
-        finalizeInboundContext: vi.fn(),
-        dispatchReplyWithBufferedBlockDispatcher: vi.fn(),
-      },
-      session: { recordInboundSession: vi.fn() },
-      pairing: {
-        readAllowFromStore: vi.fn().mockResolvedValue(storeAllowFrom),
-        upsertPairingRequest: vi.fn().mockResolvedValue({ code: 'ABCD1234', created: true }),
-        buildPairingReply: vi.fn(),
-      },
-    },
-    logging: { getChildLogger: () => ({ info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() }) },
-  } as unknown as PluginRuntime;
-}
-
-const mockAdapter: ChannelPairingAdapter = {
-  idLabel: 'bitrix24UserId',
-  normalizeAllowEntry: (entry) => entry,
-};
-
-describe('group-access helpers', () => {
-  it('normalizes numeric and dialog group ids', () => {
-    expect(normalizeGroupEntry(' 208 ')).toBe('208');
-    expect(normalizeGroupEntry(' Chat208 ')).toBe('chat208');
-  });
-
-  it('normalizes and deduplicates group allowlist entries', () => {
-    expect(normalizeGroupAllowList(['208', 'chat208', '208'])).toEqual(['208', 'chat208']);
-  });
-
-  it('builds group match keys from dialogId and chatId', () => {
-    expect(buildGroupMatchKeys({ dialogId: 'chat208', chatId: '208' })).toEqual(['chat208', '208']);
-  });
-});
-
-describe('resolveGroupAccess', () => {
-  it('defaults to webhookUser and mention-required groups', () => {
-    expect(resolveGroupAccess({
-      config: {},
-      dialogId: 'chat208',
-      chatId: '208',
-    })).toMatchObject({
-      groupPolicy: 'webhookUser',
-      requireMention: true,
-      groupAllowed: true,
-      senderAllowFrom: [],
-      watch: [],
-    });
-  });
-
-  it('matches explicit group config before wildcard', () => {
-    const result = resolveGroupAccess({
-      config: {
-        groupPolicy: 'webhookUser',
-        groups: {
-          '*': { requireMention: true },
-          chat208: { groupPolicy: 'open', requireMention: false, allowFrom: ['42'] },
-        },
-      },
-      dialogId: 'chat208',
-      chatId: '208',
-    });
-
-    expect(result.groupPolicy).toBe('open');
-    expect(result.requireMention).toBe(false);
-    expect(result.senderAllowFrom).toEqual(['42']);
-    expect(result.matchedGroupKey).toBe('chat208');
-  });
-
-  it('resolves watch rules from matched group config', () => {
-    const result = resolveGroupAccess({
-      config: {
-        groups: {
-          chat208: {
-            watch: [
-              { userId: 'bitrix24:77', topics: ['секрет', 'важно'], mode: 'notifyOwnerDm' },
-            ],
-          },
-        },
-      },
-      dialogId: 'chat208',
-      chatId: '208',
-    });
-
-    expect(result.watch).toEqual([
-      { userId: '77', topics: ['секрет', 'важно'], mode: 'notifyOwnerDm' },
-    ]);
-  });
-
-  it('preserves wildcard watch sender ids for any-user matching', () => {
-    const result = resolveGroupAccess({
-      config: {
-        groups: {
-          chat208: {
-            watch: [
-              { userId: '*', topics: ['авария'] },
-            ],
-          },
-        },
-      },
-      dialogId: 'chat208',
-      chatId: '208',
-    });
-
-    expect(result.watch).toEqual([
-      { userId: '*', topics: ['авария'], mode: 'reply' },
-    ]);
-  });
-
-  it('merges explicit group watch rules before wildcard watch rules', () => {
-    const result = resolveGroupAccess({
-      config: {
-        groups: {
-          '*': {
-            watch: [
-              { userId: '*', topics: ['авария'], mode: 'notifyOwnerDm' },
-            ],
-          },
-          chat208: {
-            watch: [
-              { userId: '77', topics: ['секрет'] },
-            ],
-          },
-        },
-      },
-      dialogId: 'chat208',
-      chatId: '208',
-    });
-
-    expect(result.watch).toEqual([
-      { userId: '77', topics: ['секрет'], mode: 'reply' },
-      { userId: '*', topics: ['авария'], mode: 'notifyOwnerDm' },
-    ]);
-  });
-
-  it('matches numeric chat id after dialog id lookup misses', () => {
-    const result = resolveGroupAccess({
-      config: {
-        groups: {
-          '208': { groupPolicy: 'open', requireMention: false },
-          '*': { groupPolicy: 'webhookUser', requireMention: true },
-        },
-      },
-      dialogId: 'chat208',
-      chatId: '208',
-    });
-
-    expect(result.groupPolicy).toBe('open');
-    expect(result.requireMention).toBe(false);
-    expect(result.matchedGroupKey).toBe('208');
-  });
-
-  it('falls back to wildcard group config when no exact match exists', () => {
-    const result = resolveGroupAccess({
-      config: {
-        groups: {
-          '*': { groupPolicy: 'allowlist', requireMention: false, allowFrom: ['42'] },
-        },
-      },
-      dialogId: 'chat615',
-      chatId: '615',
-    });
-
-    expect(result.groupPolicy).toBe('allowlist');
-    expect(result.requireMention).toBe(false);
-    expect(result.senderAllowFrom).toEqual(['42']);
-    expect(result.matchedGroupKey).toBe('*');
-  });
-
-  it('treats explicit group override as allowed even when top-level group allowlist is present', () => {
-    const result = resolveGroupAccess({
-      config: {
-        groupAllowFrom: ['chat300'],
-        groups: {
-          chat208: { groupPolicy: 'open' },
-        },
-      },
-      dialogId: 'chat208',
-      chatId: '208',
-    });
-
-    expect(result.groupAllowed).toBe(true);
-  });
-});
-
-describe('checkGroupAccessWithPairing', () => {
-  it('reports pairing passively without creating a request', async () => {
-    const runtime = makeMockRuntime();
-    const result = await checkGroupAccessPassive({
-      senderId: '99',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: { groupPolicy: 'pairing' },
-      runtime,
-      accountId: 'default',
-    });
-
-    expect(result).toBe('pairing');
-    expect(runtime.channel.pairing.upsertPairingRequest).not.toHaveBeenCalled();
-  });
-
-  it('allows any sender in open mode', async () => {
-    const runtime = makeMockRuntime();
-    const result = await checkGroupAccessWithPairing({
-      senderId: '77',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: { groupPolicy: 'open' },
-      runtime,
-      accountId: 'default',
-      pairingAdapter: mockAdapter,
-    });
-
-    expect(result).toBe('allow');
-  });
-
-  it('allows only webhook owner in webhookUser mode', async () => {
-    const runtime = makeMockRuntime();
-    const result = await checkGroupAccessWithPairing({
-      senderId: '42',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: {
-        groupPolicy: 'webhookUser',
-        webhookUrl: 'https://test.bitrix24.com/rest/42/token/',
-      },
-      runtime,
-      accountId: 'default',
-      pairingAdapter: mockAdapter,
-    });
-
-    expect(result).toBe('allow');
-  });
-
-  it('uses merged top-level and per-group allowFrom in allowlist mode', async () => {
-    const runtime = makeMockRuntime();
-    const allowed = await checkGroupAccessWithPairing({
-      senderId: '42',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: {
-        groupPolicy: 'allowlist',
-        allowFrom: ['7'],
-        groups: {
-          chat208: { allowFrom: ['42'] },
-        },
-      },
-      runtime,
-      accountId: 'default',
-      pairingAdapter: mockAdapter,
-    });
-
-    const denied = await checkGroupAccessWithPairing({
-      senderId: '99',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: {
-        groupPolicy: 'allowlist',
-        allowFrom: ['7'],
-        groups: {
-          chat208: { allowFrom: ['42'] },
-        },
-      },
-      runtime,
-      accountId: 'default',
-      pairingAdapter: mockAdapter,
-    });
-
-    expect(allowed).toBe('allow');
-    expect(denied).toBe('deny');
-  });
-
-  it('creates pairing request for unknown sender in group pairing mode', async () => {
-    const runtime = makeMockRuntime();
-    const result = await checkGroupAccessWithPairing({
-      senderId: '99',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: { groupPolicy: 'pairing' },
-      runtime,
-      accountId: 'default',
-      pairingAdapter: mockAdapter,
-    });
-
-    expect(result).toBe('pairing');
-    expect(runtime.channel.pairing.upsertPairingRequest).toHaveBeenCalled();
-  });
-
-  it('denies groups outside configured group allowlist', async () => {
-    const runtime = makeMockRuntime();
-    const result = await checkGroupAccessWithPairing({
-      senderId: '42',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: {
-        groupPolicy: 'open',
-        groupAllowFrom: ['chat300'],
-      },
-      runtime,
-      accountId: 'default',
-      pairingAdapter: mockAdapter,
-    });
-
-    expect(result).toBe('deny');
-  });
-
-  it('allows groups listed by numeric chat id in top-level group allowlist', async () => {
-    const runtime = makeMockRuntime();
-    const result = await checkGroupAccessWithPairing({
-      senderId: '42',
-      dialogId: 'chat208',
-      chatId: '208',
-      config: {
-        groupPolicy: 'open',
-        groupAllowFrom: ['208'],
-      },
-      runtime,
-      accountId: 'default',
-      pairingAdapter: mockAdapter,
-    });
-
-    expect(result).toBe('allow');
-  });
-});

package/tests/history-cache.test.ts

@@ -1,117 +0,0 @@
-import { describe, it, expect } from 'vitest';
-import { HistoryCache } from '../src/history-cache.js';
-
-describe('HistoryCache', () => {
-  it('keeps only the newest entries up to the per-key limit', () => {
-    const cache = new HistoryCache();
-
-    cache.append({
-      key: 'chat:1',
-      limit: 2,
-      entry: { messageId: '1', sender: 'A', body: 'first' },
-    });
-    cache.append({
-      key: 'chat:1',
-      limit: 2,
-      entry: { messageId: '2', sender: 'A', body: 'second' },
-    });
-    cache.append({
-      key: 'chat:1',
-      limit: 2,
-      entry: { messageId: '3', sender: 'A', body: 'third' },
-    });
-
-    expect(cache.get('chat:1')).toEqual([
-      { messageId: '2', sender: 'A', body: 'second' },
-      { messageId: '3', sender: 'A', body: 'third' },
-    ]);
-  });
-
-  it('finds entries by message id', () => {
-    const cache = new HistoryCache();
-    cache.append({
-      key: 'chat:1',
-      limit: 10,
-      entry: { messageId: '55', sender: 'A', body: 'hello' },
-    });
-
-    expect(cache.findByMessageId('chat:1', '55')).toMatchObject({
-      messageId: '55',
-      body: 'hello',
-    });
-    expect(cache.findByMessageId('chat:1', '99')).toBeUndefined();
-  });
-
-  it('evicts oldest keys when cache exceeds maxKeys', () => {
-    const cache = new HistoryCache({ maxKeys: 2 });
-    cache.append({
-      key: 'chat:1',
-      limit: 10,
-      entry: { messageId: '1', sender: 'A', body: 'one' },
-    });
-    cache.append({
-      key: 'chat:2',
-      limit: 10,
-      entry: { messageId: '2', sender: 'B', body: 'two' },
-    });
-    cache.append({
-      key: 'chat:3',
-      limit: 10,
-      entry: { messageId: '3', sender: 'C', body: 'three' },
-    });
-
-    expect(cache.size()).toBe(2);
-    expect(cache.get('chat:1')).toEqual([]);
-    expect(cache.get('chat:2')).toHaveLength(1);
-    expect(cache.get('chat:3')).toHaveLength(1);
-  });
-
-  it('stores and lists conversation metadata for history keys', () => {
-    const cache = new HistoryCache();
-
-    cache.append({
-      key: 'default:chat520',
-      limit: 10,
-      entry: { messageId: '1', sender: 'Alice', body: 'hello' },
-      meta: {
-        dialogId: 'chat520',
-        chatId: '520',
-        chatName: 'Чат зеленый 17',
-        chatType: 'chat',
-        isGroup: true,
-        lastActivityAt: 1,
-      },
-    });
-
-    expect(cache.listConversations()).toEqual([
-      {
-        key: 'default:chat520',
-        dialogId: 'chat520',
-        chatId: '520',
-        chatName: 'Чат зеленый 17',
-        chatType: 'chat',
-        isGroup: true,
-        lastActivityAt: 1,
-      },
-    ]);
-  });
-
-  it('does not append duplicate entries with the same message id to one history key', () => {
-    const cache = new HistoryCache();
-
-    cache.append({
-      key: 'chat:1',
-      limit: 10,
-      entry: { messageId: '55', sender: 'A', body: 'hello', eventScope: 'bot' },
-    });
-    cache.append({
-      key: 'chat:1',
-      limit: 10,
-      entry: { messageId: '55', sender: 'A', body: 'hello', eventScope: 'user' },
-    });
-
-    expect(cache.get('chat:1')).toEqual([
-      { messageId: '55', sender: 'A', body: 'hello', eventScope: 'bot' },
-    ]);
-  });
-});

package/tests/i18n.test.ts

@@ -1,90 +0,0 @@
-import { describe, it, expect } from 'vitest';
-import {
-  accessApproved,
-  accessDenied,
-  groupPairingPending,
-  resolveLocale,
-  welcomeMessage,
-  onboardingMessage,
-  ownerAndAllowedUsersOnly,
-  personalBotOwnerOnly,
-  watchOwnerDmNotice,
-} from '../src/i18n.js';
-
-describe('i18n welcome messages', () => {
-  it('resolves locale to two-letter lowercase code', () => {
-    expect(resolveLocale('RU')).toBe('ru');
-    expect(resolveLocale('en_US')).toBe('en');
-    expect(resolveLocale(undefined)).toBe('en');
-  });
-
-  it('returns localized Russian welcome message', () => {
-    expect(welcomeMessage('ru', 'OpenClaw')).toContain('OpenClaw готов к работе');
-  });
-
-  it('falls back to English welcome message for unknown locale', () => {
-    expect(welcomeMessage('zz', 'OpenClaw')).toBe(
-      'OpenClaw is ready. Send a message or choose a command below.',
-    );
-  });
-
-  it('returns pairing onboarding message when dmPolicy is pairing', () => {
-    expect(onboardingMessage('ru', 'OpenClaw', 'pairing')).toContain('код привязки');
-    expect(onboardingMessage('en', 'OpenClaw', 'pairing')).toContain('pairing code');
-  });
-
-  it('returns localized personal bot access denied message', () => {
-    expect(personalBotOwnerOnly('ru')).toContain('Писать ему может только владелец');
-    expect(personalBotOwnerOnly('en')).toContain('Only the bot owner can message it');
-  });
-
-  it('returns localized access approved message', () => {
-    expect(accessApproved('ru')).toBe('Доступ к боту подтвержден.');
-    expect(accessApproved('en')).toBe('Access to the bot has been approved.');
-  });
-
-  it('returns localized owner and allowlist access denied message', () => {
-    expect(ownerAndAllowedUsersOnly('ru')).toContain('пользователям с подтвержденным доступом');
-    expect(ownerAndAllowedUsersOnly('en')).toContain('approved access');
-  });
-
-  it('returns localized generic access denied message', () => {
-    expect(accessDenied('ru')).toContain('нет доступа');
-    expect(accessDenied('en')).toContain('do not have access');
-  });
-
-  it('returns localized group pairing pending message', () => {
-    expect(groupPairingPending('ru')).toContain('сначала нужно подтвердить доступ');
-    expect(groupPairingPending('en')).toContain('access must be approved first');
-  });
-
-  it('returns localized owner watch DM notification message', () => {
-    expect(watchOwnerDmNotice('ru', {
-      chatRef: '[URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL]',
-      topicsRef: '[b]секрет[/b]',
-    })).toBe('Сработало правило отслеживания в чате [URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL]. Совпавшие темы: [b]секрет[/b]');
-    expect(watchOwnerDmNotice('en', {
-      chatRef: '[URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL]',
-      topicsRef: '[b]secret[/b]',
-    })).toBe('A watch rule was triggered in chat [URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL]. Matched topics: [b]secret[/b]');
-    expect(watchOwnerDmNotice('de', {
-      chatRef: '[URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL]',
-      topicsRef: '[b]geheim[/b]',
-    })).toBe('Eine Beobachtungsregel wurde im Chat [URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL] ausgeloest. Zugeordnete Themen: [b]geheim[/b]');
-    expect(watchOwnerDmNotice('zz', {
-      chatRef: '[URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL]',
-      topicsRef: '[b]secret[/b]',
-    })).toBe('A watch rule was triggered in chat [URL=/online/?IM_DIALOG=chat520&IM_MESSAGE=710]Green Chat 15[/URL]. Matched topics: [b]secret[/b]');
-
-    expect(watchOwnerDmNotice('ru', {
-      chatRef: '[URL=/online/?IM_DIALOG=10&IM_MESSAGE=31671]Сергей Рыжиков[/URL]',
-      topicsRef: '[b]авария[/b]',
-      sourceKind: 'dm',
-    })).toBe('Сработало правило отслеживания в личном чате с [URL=/online/?IM_DIALOG=10&IM_MESSAGE=31671]Сергей Рыжиков[/URL]. Совпавшие темы: [b]авария[/b]');
-  expect(watchOwnerDmNotice('en', {
-      chatRef: '[URL=/online/?IM_DIALOG=10&IM_MESSAGE=31671]Sergey Ryzhikov[/URL]',
-      topicsRef: '[b]incident[/b]',
-      sourceKind: 'dm',
-    })).toBe('A watch rule was triggered in a direct chat with [URL=/online/?IM_DIALOG=10&IM_MESSAGE=31671]Sergey Ryzhikov[/URL]. Matched topics: [b]incident[/b]');
-  });
-});