@ihazz/bitrix24 0.1.3

package/tests/config.test.ts

@@ -0,0 +1,86 @@
+import { describe, it, expect } from 'vitest';
+import { getConfig, isConfigured, listAccountIds, resolveAccount } from '../src/config.js';
+
+const mockCfg = {
+  channels: {
+    bitrix24: {
+      webhookUrl: 'https://test.bitrix24.com/rest/1/abc123/',
+      botName: 'TestBot',
+      dmPolicy: 'open',
+      accounts: {
+        portal2: {
+          webhookUrl: 'https://portal2.bitrix24.com/rest/1/xyz789/',
+          botName: 'Portal2Bot',
+        },
+      },
+    },
+  },
+};
+
+describe('getConfig', () => {
+  it('returns default config', () => {
+    const cfg = getConfig(mockCfg);
+    expect(cfg.webhookUrl).toBe('https://test.bitrix24.com/rest/1/abc123/');
+    expect(cfg.botName).toBe('TestBot');
+  });
+
+  it('returns account-specific config', () => {
+    const cfg = getConfig(mockCfg, 'portal2');
+    expect(cfg.webhookUrl).toBe('https://portal2.bitrix24.com/rest/1/xyz789/');
+    expect(cfg.botName).toBe('Portal2Bot');
+  });
+
+  it('returns empty config when no bitrix24 section', () => {
+    const cfg = getConfig({});
+    expect(cfg).toEqual({});
+  });
+
+  it('returns default config when account not found', () => {
+    const cfg = getConfig(mockCfg, 'nonexistent');
+    expect(cfg.webhookUrl).toBe('https://test.bitrix24.com/rest/1/abc123/');
+  });
+});
+
+describe('isConfigured', () => {
+  it('returns true when webhookUrl is set', () => {
+    expect(isConfigured(mockCfg)).toBe(true);
+  });
+
+  it('returns false when no config', () => {
+    expect(isConfigured({})).toBe(false);
+  });
+});
+
+describe('listAccountIds', () => {
+  it('lists default and named accounts', () => {
+    const ids = listAccountIds(mockCfg);
+    expect(ids).toContain('default');
+    expect(ids).toContain('portal2');
+    expect(ids).toHaveLength(2);
+  });
+
+  it('returns empty when no config', () => {
+    expect(listAccountIds({})).toEqual([]);
+  });
+});
+
+describe('resolveAccount', () => {
+  it('resolves default account', () => {
+    const acct = resolveAccount(mockCfg);
+    expect(acct.accountId).toBe('default');
+    expect(acct.configured).toBe(true);
+    expect(acct.enabled).toBe(true);
+  });
+
+  it('resolves named account', () => {
+    const acct = resolveAccount(mockCfg, 'portal2');
+    expect(acct.accountId).toBe('portal2');
+    expect(acct.configured).toBe(true);
+    expect(acct.config.webhookUrl).toBe('https://portal2.bitrix24.com/rest/1/xyz789/');
+  });
+
+  it('handles missing config gracefully', () => {
+    const acct = resolveAccount({}, 'missing');
+    expect(acct.configured).toBe(false);
+  });
+});

package/tests/dedup.test.ts

@@ -0,0 +1,50 @@
+import { describe, it, expect, afterEach } from 'vitest';
+import { Dedup } from '../src/dedup.js';
+
+describe('Dedup', () => {
+  let dedup: Dedup;
+
+  afterEach(() => {
+    dedup?.destroy();
+  });
+
+  it('returns false for first occurrence', () => {
+    dedup = new Dedup();
+    expect(dedup.isDuplicate(123)).toBe(false);
+  });
+
+  it('returns true for second occurrence', () => {
+    dedup = new Dedup();
+    dedup.isDuplicate(123);
+    expect(dedup.isDuplicate(123)).toBe(true);
+  });
+
+  it('handles string IDs', () => {
+    dedup = new Dedup();
+    expect(dedup.isDuplicate('abc')).toBe(false);
+    expect(dedup.isDuplicate('abc')).toBe(true);
+  });
+
+  it('tracks different IDs independently', () => {
+    dedup = new Dedup();
+    expect(dedup.isDuplicate(1)).toBe(false);
+    expect(dedup.isDuplicate(2)).toBe(false);
+    expect(dedup.isDuplicate(1)).toBe(true);
+    expect(dedup.isDuplicate(2)).toBe(true);
+  });
+
+  it('reports size correctly', () => {
+    dedup = new Dedup();
+    expect(dedup.size).toBe(0);
+    dedup.isDuplicate(1);
+    dedup.isDuplicate(2);
+    expect(dedup.size).toBe(2);
+  });
+
+  it('cleans up on destroy', () => {
+    dedup = new Dedup();
+    dedup.isDuplicate(1);
+    dedup.destroy();
+    expect(dedup.size).toBe(0);
+  });
+});

package/tests/fixtures/onimbotjoinchat.json

@@ -0,0 +1,48 @@
+{
+  "event": "ONIMBOTJOINCHAT",
+  "event_handler_id": 27,
+  "data": {
+    "BOT": {
+      "2081": {
+        "access_token": "bot_token_test_abc123",
+        "expires": 1771448424,
+        "scope": "imbot,im,disk",
+        "domain": "test.bitrix24.com",
+        "client_endpoint": "https://test.bitrix24.com/rest/",
+        "member_id": "test_member_id_123",
+        "user_id": 2081,
+        "client_id": "local.test123.app",
+        "application_token": "app_token_test_xyz",
+        "BOT_ID": 2081,
+        "BOT_CODE": "openclaw"
+      }
+    },
+    "PARAMS": {
+      "CHAT_TYPE": "P",
+      "MESSAGE_TYPE": "P",
+      "BOT_ID": 2081,
+      "USER_ID": 1,
+      "DIALOG_ID": "1",
+      "LANGUAGE": "ru"
+    },
+    "USER": {
+      "ID": 1,
+      "NAME": "Test User",
+      "FIRST_NAME": "Test",
+      "LAST_NAME": "User",
+      "WORK_POSITION": "Developer",
+      "GENDER": "M"
+    }
+  },
+  "ts": 1771444000,
+  "auth": {
+    "access_token": "user_token_test_def456",
+    "expires": 1771448424,
+    "scope": "imbot",
+    "domain": "test.bitrix24.com",
+    "client_endpoint": "https://test.bitrix24.com/rest/",
+    "member_id": "test_member_id_123",
+    "user_id": 1,
+    "application_token": "app_token_test_xyz"
+  }
+}

package/tests/fixtures/onimbotmessageadd-file.json

@@ -0,0 +1,86 @@
+{
+  "event": "ONIMBOTMESSAGEADD",
+  "event_handler_id": 27,
+  "data": {
+    "BOT": {
+      "2081": {
+        "access_token": "bot_token_test_abc123",
+        "expires": 1771448424,
+        "scope": "imbot,im,disk",
+        "domain": "test.bitrix24.com",
+        "client_endpoint": "https://test.bitrix24.com/rest/",
+        "member_id": "test_member_id_123",
+        "user_id": 2081,
+        "client_id": "local.test123.app",
+        "application_token": "app_token_test_xyz",
+        "BOT_ID": 2081,
+        "BOT_CODE": "openclaw"
+      }
+    },
+    "PARAMS": {
+      "MESSAGE": "",
+      "TEMPLATE_ID": "e9c8e294-test-5678",
+      "MESSAGE_TYPE": "P",
+      "FROM_USER_ID": 1,
+      "DIALOG_ID": "1",
+      "TO_CHAT_ID": 40985,
+      "TO_USER_ID": 2081,
+      "MESSAGE_ID": 492035,
+      "CHAT_TYPE": "P",
+      "LANGUAGE": "ru",
+      "PLATFORM_CONTEXT": "web",
+      "PARAMS": {
+        "FILE_ID": [94611]
+      },
+      "FILES": {
+        "94611": {
+          "id": 94611,
+          "chatId": 40985,
+          "date": "2026-02-21T10:27:08+03:00",
+          "type": "file",
+          "name": "document.txt",
+          "extension": "txt",
+          "size": 101,
+          "image": 0,
+          "status": "done",
+          "progress": 100,
+          "authorId": 1,
+          "authorName": "Test User",
+          "urlPreview": "",
+          "urlShow": "https://test.bitrix24.com/disk/showFile/94611/",
+          "urlDownload": "https://test.bitrix24.com/disk/downloadFile/94611/",
+          "viewerAttrs": {
+            "viewer": "",
+            "viewerType": "code",
+            "src": "https://test.bitrix24.com/disk/viewer/94611/",
+            "objectId": 94611,
+            "title": "document.txt"
+          }
+        }
+      }
+    },
+    "USER": {
+      "ID": 1,
+      "NAME": "Test User",
+      "FIRST_NAME": "Test",
+      "LAST_NAME": "User",
+      "WORK_POSITION": "Developer",
+      "GENDER": "M",
+      "IS_BOT": "N",
+      "IS_CONNECTOR": "N",
+      "IS_NETWORK": "N",
+      "IS_EXTRANET": "N"
+    }
+  },
+  "ts": 1771444900,
+  "auth": {
+    "access_token": "user_token_test_def456",
+    "expires": 1771448424,
+    "scope": "imbot",
+    "domain": "test.bitrix24.com",
+    "client_endpoint": "https://test.bitrix24.com/rest/",
+    "member_id": "test_member_id_123",
+    "user_id": 1,
+    "application_token": "app_token_test_xyz"
+  }
+}

package/tests/fixtures/onimbotmessageadd-text.json

@@ -0,0 +1,59 @@
+{
+  "event": "ONIMBOTMESSAGEADD",
+  "event_handler_id": 27,
+  "data": {
+    "BOT": {
+      "2081": {
+        "access_token": "bot_token_test_abc123",
+        "expires": 1771448424,
+        "scope": "imbot,im,disk",
+        "domain": "test.bitrix24.com",
+        "client_endpoint": "https://test.bitrix24.com/rest/",
+        "member_id": "test_member_id_123",
+        "user_id": 2081,
+        "client_id": "local.test123.app",
+        "application_token": "app_token_test_xyz",
+        "BOT_ID": 2081,
+        "BOT_CODE": "openclaw"
+      }
+    },
+    "PARAMS": {
+      "MESSAGE": "Hello, how are you?",
+      "TEMPLATE_ID": "ea602c80-test-1234",
+      "MESSAGE_TYPE": "P",
+      "FROM_USER_ID": 1,
+      "DIALOG_ID": "1",
+      "TO_CHAT_ID": 40985,
+      "AUTHOR_ID": 1,
+      "TO_USER_ID": 2081,
+      "MESSAGE_ID": 490659,
+      "CHAT_TYPE": "P",
+      "LANGUAGE": "ru",
+      "PLATFORM_CONTEXT": "web",
+      "CHAT_USER_COUNT": 2
+    },
+    "USER": {
+      "ID": 1,
+      "NAME": "Test User",
+      "FIRST_NAME": "Test",
+      "LAST_NAME": "User",
+      "WORK_POSITION": "Developer",
+      "GENDER": "M",
+      "IS_BOT": "N",
+      "IS_CONNECTOR": "N",
+      "IS_NETWORK": "N",
+      "IS_EXTRANET": "N"
+    }
+  },
+  "ts": 1771444824,
+  "auth": {
+    "access_token": "user_token_test_def456",
+    "expires": 1771448424,
+    "scope": "imbot",
+    "domain": "test.bitrix24.com",
+    "client_endpoint": "https://test.bitrix24.com/rest/",
+    "member_id": "test_member_id_123",
+    "user_id": 1,
+    "application_token": "app_token_test_xyz"
+  }
+}

package/tests/fixtures/onimcommandadd.json

@@ -0,0 +1,45 @@
+{
+  "event": "ONIMCOMMANDADD",
+  "event_handler_id": 27,
+  "data": {
+    "COMMAND": {
+      "53": {
+        "access_token": "bot_token_test_abc123",
+        "BOT_ID": 2081,
+        "BOT_CODE": "openclaw",
+        "COMMAND": "help",
+        "COMMAND_ID": 53,
+        "COMMAND_PARAMS": "",
+        "COMMAND_CONTEXT": "TEXTAREA",
+        "MESSAGE_ID": 490667
+      }
+    },
+    "PARAMS": {
+      "MESSAGE": "/help",
+      "FROM_USER_ID": 1,
+      "DIALOG_ID": "1",
+      "TO_CHAT_ID": 40985,
+      "MESSAGE_ID": 490667,
+      "CHAT_TYPE": "P"
+    },
+    "USER": {
+      "ID": 1,
+      "NAME": "Test User",
+      "FIRST_NAME": "Test",
+      "LAST_NAME": "User",
+      "WORK_POSITION": "Developer",
+      "GENDER": "M"
+    }
+  },
+  "ts": 1771445000,
+  "auth": {
+    "access_token": "user_token_test_def456",
+    "expires": 1771448424,
+    "scope": "imbot",
+    "domain": "test.bitrix24.com",
+    "client_endpoint": "https://test.bitrix24.com/rest/",
+    "member_id": "test_member_id_123",
+    "user_id": 1,
+    "application_token": "app_token_test_xyz"
+  }
+}

package/tests/inbound-handler.test.ts

@@ -0,0 +1,161 @@
+import { describe, it, expect, vi, afterEach } from 'vitest';
+import { InboundHandler, normalizeMessageEvent } from '../src/inbound-handler.js';
+import type { B24MessageEvent, B24MsgContext, B24BotEntry } from '../src/types.js';
+
+// Import fixtures
+import textFixture from './fixtures/onimbotmessageadd-text.json';
+import fileFixture from './fixtures/onimbotmessageadd-file.json';
+import joinFixture from './fixtures/onimbotjoinchat.json';
+import commandFixture from './fixtures/onimcommandadd.json';
+
+const silentLogger = {
+  info: () => {},
+  warn: () => {},
+  error: () => {},
+  debug: () => {},
+};
+
+describe('InboundHandler', () => {
+  let handler: InboundHandler;
+
+  afterEach(() => {
+    handler?.destroy();
+  });
+
+  it('dispatches text message events', async () => {
+    const onMessage = vi.fn();
+    handler = new InboundHandler({
+      config: { dmPolicy: 'open' },
+      logger: silentLogger,
+      onMessage,
+    });
+
+    const result = await handler.handleWebhook(textFixture);
+    expect(result).toBe(true);
+    expect(onMessage).toHaveBeenCalledOnce();
+
+    const ctx = onMessage.mock.calls[0][0] as B24MsgContext;
+    expect(ctx.channel).toBe('bitrix24');
+    expect(ctx.text).toBe('Hello, how are you?');
+    expect(ctx.senderId).toBe('1');
+    expect(ctx.senderName).toBe('Test User');
+    expect(ctx.chatId).toBe('1');
+    expect(ctx.isDm).toBe(true);
+    expect(ctx.isGroup).toBe(false);
+    expect(ctx.botToken).toBe('bot_token_test_abc123');
+    expect(ctx.userToken).toBe('user_token_test_def456');
+  });
+
+  it('deduplicates messages', async () => {
+    const onMessage = vi.fn();
+    handler = new InboundHandler({
+      config: { dmPolicy: 'open' },
+      logger: silentLogger,
+      onMessage,
+    });
+
+    await handler.handleWebhook(textFixture);
+    await handler.handleWebhook(textFixture);
+
+    expect(onMessage).toHaveBeenCalledOnce();
+  });
+
+  it('respects access control', async () => {
+    const onMessage = vi.fn();
+    handler = new InboundHandler({
+      config: { dmPolicy: 'allowlist', allowFrom: ['99'] },
+      logger: silentLogger,
+      onMessage,
+    });
+
+    await handler.handleWebhook(textFixture);
+    expect(onMessage).not.toHaveBeenCalled();
+  });
+
+  it('dispatches join chat events', async () => {
+    const onJoinChat = vi.fn();
+    handler = new InboundHandler({
+      config: { dmPolicy: 'open' },
+      logger: silentLogger,
+      onJoinChat,
+    });
+
+    const result = await handler.handleWebhook(joinFixture);
+    expect(result).toBe(true);
+    expect(onJoinChat).toHaveBeenCalledOnce();
+  });
+
+  it('dispatches command events', async () => {
+    const onCommand = vi.fn();
+    handler = new InboundHandler({
+      config: { dmPolicy: 'open' },
+      logger: silentLogger,
+      onCommand,
+    });
+
+    const result = await handler.handleWebhook(commandFixture);
+    expect(result).toBe(true);
+    expect(onCommand).toHaveBeenCalledOnce();
+  });
+
+  it('returns false for unknown event types', async () => {
+    handler = new InboundHandler({
+      config: { dmPolicy: 'open' },
+      logger: silentLogger,
+    });
+
+    const result = await handler.handleWebhook({ event: 'UNKNOWN_EVENT' });
+    expect(result).toBe(false);
+  });
+
+  it('returns false for missing event type', async () => {
+    handler = new InboundHandler({
+      config: { dmPolicy: 'open' },
+      logger: silentLogger,
+    });
+
+    const result = await handler.handleWebhook({});
+    expect(result).toBe(false);
+  });
+});
+
+describe('normalizeMessageEvent', () => {
+  it('normalizes a text message event', () => {
+    const event = textFixture as unknown as B24MessageEvent;
+    const botEntry = Object.values(event.data.BOT)[0] as B24BotEntry;
+    const ctx = normalizeMessageEvent(event, botEntry);
+
+    expect(ctx.channel).toBe('bitrix24');
+    expect(ctx.senderId).toBe('1');
+    expect(ctx.senderName).toBe('Test User');
+    expect(ctx.senderFirstName).toBe('Test');
+    expect(ctx.chatId).toBe('1');
+    expect(ctx.chatInternalId).toBe('40985');
+    expect(ctx.messageId).toBe('490659');
+    expect(ctx.text).toBe('Hello, how are you?');
+    expect(ctx.isDm).toBe(true);
+    expect(ctx.isGroup).toBe(false);
+    expect(ctx.media).toEqual([]);
+    expect(ctx.platform).toBe('web');
+    expect(ctx.language).toBe('ru');
+    expect(ctx.botId).toBe(2081);
+    expect(ctx.memberId).toBe('test_member_id_123');
+    expect(ctx.clientEndpoint).toBe('https://test.bitrix24.com/rest/');
+  });
+
+  it('normalizes a file message event', () => {
+    const event = fileFixture as unknown as B24MessageEvent;
+    const botEntry = Object.values(event.data.BOT)[0] as B24BotEntry;
+    const ctx = normalizeMessageEvent(event, botEntry);
+
+    expect(ctx.text).toBe('');
+    expect(ctx.media).toHaveLength(1);
+    expect(ctx.media[0]).toEqual({
+      id: '94611',
+      name: 'document.txt',
+      extension: 'txt',
+      size: 101,
+      type: 'file',
+    });
+  });
+});

package/tests/message-utils.test.ts

@@ -0,0 +1,123 @@
+import { describe, it, expect } from 'vitest';
+import { markdownToBbCode, splitMessage, buildKeyboard } from '../src/message-utils.js';
+
+describe('markdownToBbCode', () => {
+  it('converts bold **text**', () => {
+    expect(markdownToBbCode('This is **bold** text')).toBe('This is [B]bold[/B] text');
+  });
+
+  it('converts bold __text__', () => {
+    expect(markdownToBbCode('This is __bold__ text')).toBe('This is [B]bold[/B] text');
+  });
+
+  it('converts italic *text*', () => {
+    expect(markdownToBbCode('This is *italic* text')).toBe('This is [I]italic[/I] text');
+  });
+
+  it('converts italic _text_', () => {
+    expect(markdownToBbCode('This is _italic_ text')).toBe('This is [I]italic[/I] text');
+  });
+
+  it('converts strikethrough ~~text~~', () => {
+    expect(markdownToBbCode('This is ~~deleted~~ text')).toBe('This is [S]deleted[/S] text');
+  });
+
+  it('converts inline code', () => {
+    expect(markdownToBbCode('Use `console.log`')).toBe('Use [CODE]console.log[/CODE]');
+  });
+
+  it('converts code blocks', () => {
+    const md = '```js\nconst x = 1;\n```';
+    const expected = '[CODE]const x = 1;\n[/CODE]';
+    expect(markdownToBbCode(md)).toBe(expected);
+  });
+
+  it('converts links [text](url)', () => {
+    expect(markdownToBbCode('[Google](https://google.com)'))
+      .toBe('[URL=https://google.com]Google[/URL]');
+  });
+
+  it('converts blockquotes', () => {
+    expect(markdownToBbCode('> This is a quote')).toBe('>>This is a quote');
+  });
+
+  it('handles mixed formatting', () => {
+    const input = '**Bold** and *italic* with `code`';
+    const expected = '[B]Bold[/B] and [I]italic[/I] with [CODE]code[/CODE]';
+    expect(markdownToBbCode(input)).toBe(expected);
+  });
+
+  it('preserves plain text', () => {
+    expect(markdownToBbCode('Hello world')).toBe('Hello world');
+  });
+});
+
+describe('splitMessage', () => {
+  it('returns single chunk for short messages', () => {
+    expect(splitMessage('Hello')).toEqual(['Hello']);
+  });
+
+  it('splits long messages at newlines', () => {
+    const text = 'Line 1\nLine 2\nLine 3';
+    const chunks = splitMessage(text, 10);
+    expect(chunks.length).toBeGreaterThan(1);
+    expect(chunks.join('\n')).toBe(text);
+  });
+
+  it('splits at limit when no newline found', () => {
+    const text = 'A'.repeat(30);
+    const chunks = splitMessage(text, 10);
+    expect(chunks.length).toBe(3);
+    expect(chunks.join('')).toBe(text);
+  });
+
+  it('handles exactly maxLen text', () => {
+    const text = 'A'.repeat(100);
+    expect(splitMessage(text, 100)).toEqual([text]);
+  });
+});
+
+describe('buildKeyboard', () => {
+  it('builds a single row keyboard', () => {
+    const kb = buildKeyboard([
+      [{ text: 'Yes', command: 'answer', commandParams: 'yes' }],
+    ]);
+    expect(kb).toHaveLength(1);
+    expect(kb[0]).toHaveLength(1);
+    expect(kb[0][0].TEXT).toBe('Yes');
+    expect(kb[0][0].COMMAND).toBe('answer');
+    expect(kb[0][0].COMMAND_PARAMS).toBe('yes');
+  });
+
+  it('builds multi-row keyboard', () => {
+    const kb = buildKeyboard([
+      [
+        { text: 'Yes', command: 'answer', commandParams: 'yes' },
+        { text: 'No', command: 'answer', commandParams: 'no' },
+      ],
+      [{ text: 'More info', link: 'https://example.com', fullWidth: true }],
+    ]);
+    expect(kb).toHaveLength(2);
+    expect(kb[0]).toHaveLength(2);
+    expect(kb[1]).toHaveLength(1);
+    expect(kb[1][0].LINK).toBe('https://example.com');
+    expect(kb[1][0].DISPLAY).toBe('LINE');
+  });
+
+  it('applies default colors', () => {
+    const kb = buildKeyboard([[{ text: 'Click' }]]);
+    expect(kb[0][0].BG_COLOR).toBe('#29619b');
+    expect(kb[0][0].TEXT_COLOR).toBe('#fff');
+  });
+
+  it('applies custom colors', () => {
+    const kb = buildKeyboard([[{ text: 'Click', bgColor: '#333', textColor: '#eee' }]]);
+    expect(kb[0][0].BG_COLOR).toBe('#333');
+    expect(kb[0][0].TEXT_COLOR).toBe('#eee');
+  });
+
+  it('sets BLOCK=Y when disableAfterClick is true', () => {
+    const kb = buildKeyboard([[{ text: 'Once', command: 'once', disableAfterClick: true }]]);
+    expect(kb[0][0].BLOCK).toBe('Y');
+  });
+});