@ignix-social/editor 0.1.11 → 0.1.14

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ignix-social/editor",
-  "version": "0.1.11",
+  "version": "0.1.14",
   "description": "Ignix Editor: render HTML video compositions (reels, edits, clips) on your own computer. Based on HyperFrames.",
   "license": "Apache-2.0",
   "type": "module",

package/src/analysis/review.mjs

@@ -40,6 +40,20 @@ const SILENCE_DB = -45;
 // ~250 px de arriba ni los ~450 de abajo.
 const SAFE = { x0: 0.12, x1: 0.88, y0: 0.13, y1: 0.765 };
 
+/**
+ * Lo que cambia en un vídeo HORIZONTAL (YouTube, 2026-10-06): su manual pide un cambio cada
+ * ~3-5 s (no 1-1,5), subtítulos abajo del todo y ~0,8 s de aire al cambiar de capítulo.
+ * Calibrado con un youtuber que Fran da por bueno (36 min, 2026-10-06): plano al 89 %, quietud
+ * máxima 4,1 s, 8 cortes/min y ~26 pausas naturales de 1-2 s al hablar → los huecos avisan desde
+ * 2,5 s, y «sin efectos» no se dice (bajo una voz continua no se distinguen).
+ */
+const WIDE = {
+  stillFailSec: 6,
+  gapWarnSec: 2.5,
+  captionBand: { y0: 0.8, y1: 0.98 },
+  safe: { x0: 0.05, x1: 0.95, y0: 0.06, y1: 0.92 },
+};
+
 function gray(rgb, n) {
   const g = new Uint8Array(n);
   for (let i = 0; i < n; i++) g[i] = (rgb[i * 3] * 77 + rgb[i * 3 + 1] * 150 + rgb[i * 3 + 2] * 29) >> 8;
@@ -70,12 +84,12 @@ function background(rgb, w, h) {
 }
 
 /** Qué parte de la zona segura ocupa algo distinto del fondo (0..1). */
-export function fillOf(rgb, w, h) {
+export function fillOf(rgb, w, h, safe = SAFE) {
   const [br, bg, bb] = background(rgb, w, h);
-  const x0 = Math.round(SAFE.x0 * w);
-  const x1 = Math.round(SAFE.x1 * w);
-  const y0 = Math.round(SAFE.y0 * h);
-  const y1 = Math.round(SAFE.y1 * h);
+  const x0 = Math.round(safe.x0 * w);
+  const x1 = Math.round(safe.x1 * w);
+  const y0 = Math.round(safe.y0 * h);
+  const y1 = Math.round(safe.y1 * h);
   let on = 0;
   let n = 0;
   for (let y = y0; y < y1; y++) {
@@ -129,6 +143,9 @@ const r1 = (x) => Math.round(x * 10) / 10;
 export async function reviewVideo({ ffmpeg, ffprobe, path, log = () => {} }) {
   const info = probe(ffprobe, path);
   if (!info.hasVideo || !(info.duration > 0)) throw new Error(`${path} has no video`);
+  const wide = info.width > info.height;
+  const band = wide ? WIDE.captionBand : CAPTION_BAND;
+  const stillFail = wide ? WIDE.stillFailSec : STILL_FAIL_SEC;
   const steps = [];
   const fills = [];
   let prev = null;
@@ -143,14 +160,14 @@ export async function reviewVideo({ ffmpeg, ffprobe, path, log = () => {} }) {
       const n = f.w * f.h;
       const g = gray(f.rgb, n);
       if (prev) {
-        const c0 = Math.round(CAPTION_BAND.y0 * f.h) * f.w;
-        const c1 = Math.round(CAPTION_BAND.y1 * f.h) * f.w;
+        const c0 = Math.round(band.y0 * f.h) * f.w;
+        const c1 = Math.round(band.y1 * f.h) * f.w;
         let c = 0;
         for (let i = 0; i < n; i++) if ((i < c0 || i >= c1) && Math.abs(g[i] - prev[i]) > 16) c++;
         steps.push({ t: f.t, frac: c / (n - (c1 - c0)) });
       }
       prev = g;
-      if (k++ % 5 === 0) fills.push(fillOf(f.rgb, f.w, f.h));
+      if (k++ % 5 === 0) fills.push(fillOf(f.rgb, f.w, f.h, wide ? WIDE.safe : SAFE));
     },
   });
   const windowSec = 0.05;
@@ -159,11 +176,11 @@ export async function reviewVideo({ ffmpeg, ffprobe, path, log = () => {} }) {
   const m = await measureVideo({ ffmpeg, ffprobe, path, log: () => {} }).catch(() => null);
 
   // La última quietud, si llega al final, es la tarjeta de cierre: se le deja más.
-  const stills = stillRuns(steps, STILL_FAIL_SEC).filter(
+  const stills = stillRuns(steps, stillFail).filter(
     (s) => !(info.duration - s.end < 0.3 && s.end - s.start < END_HOLD_SEC),
   );
   const fill = fills.length ? fills.reduce((a, b) => a + b, 0) / fills.length : null;
-  const gaps = db ? speechGaps(db, windowSec, GAP_WARN_SEC) : [];
+  const gaps = db ? speechGaps(db, windowSec, wide ? WIDE.gapWarnSec : GAP_WARN_SEC) : [];
   const movingShare = steps.length ? steps.filter((s) => s.frac >= MOVE_FRAC).length / steps.length : null;
 
   const issues = [];
@@ -172,14 +189,14 @@ export async function reviewVideo({ ffmpeg, ffprobe, path, log = () => {} }) {
       level: info.duration > LONG_SEC ? 'warn' : 'fail',
       code: 'still',
       at: [r1(s.start), r1(s.end)],
-      text: `Nothing on the stage moves from ${r1(s.start)} s to ${r1(s.end)} s (${r1(s.end - s.start)} s; captions alone do not count). Add a camera move, an element entering or a highlight at least every 1-1.5 s.`,
+      text: `Nothing on the stage moves from ${r1(s.start)} s to ${r1(s.end)} s (${r1(s.end - s.start)} s; captions alone do not count). Add a camera move, an element entering or a highlight at least every ${wide ? '3-5' : '1-1.5'} s.`,
     });
   }
   if (fill !== null && fill < FILL_WARN) {
     issues.push({
       level: fill < FILL_FAIL ? 'fail' : 'warn',
       code: 'empty_frame',
-      text: `The frame is mostly empty: only ${Math.round(fill * 100)} % of the safe area has something on it. Make the stage (phone, screen, card, image) about 85 % of the safe column's width and most of its height.`,
+      text: `The frame is mostly empty: only ${Math.round(fill * 100)} % of the safe area has something on it. ${wide ? 'Make the scene fill the frame (full-frame scenes, footage, big recreated screens).' : 'Make the stage (phone, screen, card, image) about 85 % of the safe column\'s width and most of its height.'}`,
     });
   }
   for (const gp of gaps) {
@@ -187,7 +204,7 @@ export async function reviewVideo({ ffmpeg, ffprobe, path, log = () => {} }) {
       level: 'warn',
       code: 'speech_gap',
       at: [r1(gp.start), r1(gp.end)],
-      text: `${r1(gp.end - gp.start)} s of silence between two voice lines at ${r1(gp.start)} s. Lay the lines back to back (≤ 0.3 s).`,
+      text: `${r1(gp.end - gp.start)} s of silence between two voice lines at ${r1(gp.start)} s. ${wide ? 'Cut the pause, or keep it only where it lands a point or changes chapter.' : 'Lay the lines back to back (≤ 0.3 s).'}`,
     });
   }
   // Calibrado con los reels de Fran (2026-10-06): todos los buenos cortan 3,5-10 veces por
@@ -196,7 +213,7 @@ export async function reviewVideo({ ffmpeg, ffprobe, path, log = () => {} }) {
     issues.push({ level: 'warn', code: 'no_cuts', text: 'No real change of scene anywhere: it plays as one slow sequence of fades. Change scene with cuts or quick whips, and move a camera inside each scene.' });
   }
   const sfx = m?.audio?.sound?.sfxPerMinute;
-  if (sfx === 0 && info.duration > 8) {
+  if (sfx === 0 && info.duration > 8 && !wide) {
     issues.push({ level: 'warn', code: 'no_sfx', text: 'No sound effect is heard. A 20 s reel usually needs 4-8, on the moments that matter (hook, scene change, the key click or reveal, the CTA).' });
   }
   return {

package/src/creator/job.mjs

@@ -8,11 +8,13 @@
 //   → <dir>/video.mp4 (composición) o <dir>/t<n>_<k>.jpg (miniaturas)
 //
 // Informa por stdout con líneas JSON cerradas: progress {stage, fraction}, verified
-// {durationSec, width, height, audio}, output {file}, done, error {code}. SIGTERM, o perder
+// {durationSec, width, height, audio}, reviewed {ready, issues: [{level, code, at?}]} (0.1.12),
+// output {file}, done, error {code}. SIGTERM, o perder
 // el proceso padre, cancela.
-import { spawnSync } from 'node:child_process';
+import { spawn, spawnSync } from 'node:child_process';
 import { existsSync, lstatSync, mkdirSync, mkdtempSync, readFileSync, renameSync, rmSync } from 'node:fs';
-import { basename, isAbsolute, join, relative } from 'node:path';
+import { basename, dirname, isAbsolute, join, relative } from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { HOME, ensureTool } from '../binaries.mjs';
 import { renderProject } from '../engine.mjs';
 import { probe } from '../analysis/media.mjs';
@@ -124,6 +126,9 @@ async function composition(job, inputs, signal, browser, workers) {
     const info = probe(ffprobe, out);
     if (!info.hasVideo || info.duration <= 0) fail('verify_failed');
     emit({ t: 'verified', durationSec: +info.duration.toFixed(3), width: info.width, height: info.height, audio: info.hasAudio });
+    if (signal.aborted) fail('cancelled');
+    const reviewed = await reviewOf(out, signal);
+    if (reviewed) emit(reviewed);
     renameSync(out, join(job, 'video.mp4'));
   } finally {
     rmSync(dir, { recursive: true, force: true });
@@ -131,6 +136,46 @@ async function composition(job, inputs, signal, browser, workers) {
   }
 }
 
+const CLI = join(dirname(fileURLToPath(import.meta.url)), '..', '..', 'bin', 'ignix-editor.mjs');
+const ISSUE_CODES = new Set(['still', 'empty_frame', 'speech_gap', 'no_cuts', 'no_sfx']);
+
+/**
+ * La misma revisión que hace `render` (quietud, plano vacío, huecos de voz, cortes, efectos), en
+ * un proceso aparte: carga onnxruntime, y este proceso termina con process.exit, que con
+ * onnxruntime cargado lo tumba. Si la revisión no puede correr, el vídeo sale igual, sin ella.
+ * Solo códigos y segundos: los textos los pone Creator en el idioma de quien lo usa.
+ */
+function reviewOf(file, signal) {
+  if (signal.aborted) return Promise.resolve(null);
+  return new Promise((resolve) => {
+    const p = spawn(process.execPath, [CLI, 'review', file, '--json'], { stdio: ['ignore', 'pipe', 'pipe'] });
+    let out = '';
+    let err = '';
+    p.stdout.on('data', (d) => (out += d));
+    p.stderr.on('data', (d) => (err = (err + d).slice(-400)));
+    const stop = () => p.kill('SIGKILL');
+    const timer = setTimeout(stop, 180_000);
+    signal.addEventListener('abort', stop, { once: true });
+    const finish = () => {
+      clearTimeout(timer);
+      signal.removeEventListener('abort', stop);
+      try {
+        const rv = JSON.parse(out);
+        const issues = (rv.issues ?? [])
+          .filter((i) => ISSUE_CODES.has(i.code) && (i.level === 'fail' || i.level === 'warn'))
+          .slice(0, 20)
+          .map((i) => ({ level: i.level, code: i.code, ...(Array.isArray(i.at) ? { at: [+i.at[0], +i.at[1]] } : {}) }));
+        resolve({ t: 'reviewed', ready: rv.ready === true, issues });
+      } catch {
+        if (!signal.aborted) process.stderr.write(`review skipped: ${err.trim()}\n`);
+        resolve(null);
+      }
+    };
+    p.on('close', finish);
+    p.on('error', finish);
+  });
+}
+
 export async function creatorJob(argv) {
   const at = (k) => {
     const i = argv.indexOf(k);