@ifecodes/backend-template 1.1.7 → 1.1.9

package/bin/lib/readme-generator.js

@@ -1,13 +1,26 @@
-import fs from "fs";
-import path from "path";
-
 export const generateReadme = (config, serviceName = null) => {
   const { projectType, mode, features = [], auth, sanitizedName } = config;
   const isMicroservice = projectType === "microservice";
-  
+  const isTypeScript = config.language === "typescript";
+  const languageLabel = isTypeScript ? "TypeScript" : "JavaScript";
+  const monolithFileExt = isTypeScript ? "ts" : "js";
+
+  const getServices = () =>
+    config.allServices && config.allServices.length
+      ? config.allServices
+      : ["gateway", "health-service", ...(auth ? ["auth-service"] : [])];
+
+  const getPort = (services, serviceName, index) =>
+    serviceName === "gateway"
+      ? 4000
+      : 4001 +
+        services.filter(
+          (service, serviceIndex) =>
+            service !== "gateway" && serviceIndex < index,
+        ).length;
+
   let readme = `# ${serviceName || sanitizedName}\n\n`;
-  
-  // Description
+
   if (isMicroservice && serviceName) {
     readme += `A microservice for ${sanitizedName}.\n\n`;
   } else if (isMicroservice) {
@@ -15,77 +28,77 @@ export const generateReadme = (config, serviceName = null) => {
   } else {
     readme += `A monolithic backend API application.\n\n`;
   }
-  
-  // Architecture
+
   readme += `## Architecture\n\n`;
   if (isMicroservice) {
+    const servicesList = getServices();
     readme += `- **Type**: Microservice\n`;
     readme += `- **Deployment**: ${mode === "docker" ? "Docker" : "PM2"}\n`;
     readme += `- **Gateway**: Port 4000 (main entry point)\n`;
     readme += `- **Services**:\n`;
-    const servicesList = (config.allServices && config.allServices.length)
-      ? config.allServices
-      : ["gateway", "health-service", ...(auth ? ["auth-service"] : [])];
-    servicesList.forEach((service, idx) => {
-      const isGateway = service === "gateway";
-      const port = isGateway
-        ? 4000
-        : 4001 + servicesList.filter((s) => s !== "gateway" && servicesList.indexOf(s) < idx).length;
+    servicesList.forEach((service, index) => {
       const pretty = service
         .split("-")
-        .map((w) => w.charAt(0).toUpperCase() + w.slice(1))
+        .map((word) => word.charAt(0).toUpperCase() + word.slice(1))
         .join(" ");
-      readme += `  - ${pretty} (port ${port})\n`;
+      readme += `  - ${pretty} (port ${getPort(servicesList, service, index)})\n`;
     });
     readme += `\n`;
   } else {
     readme += `- **Type**: Monolith API\n`;
     readme += `- **Port**: 4000 (default)\n\n`;
   }
-  
-  // Tech Stack
+
   readme += `## Tech Stack\n\n`;
   readme += `- **Runtime**: Node.js\n`;
-  readme += `- **Language**: TypeScript\n`;
+  readme += `- **Language**: ${languageLabel}\n`;
   readme += `- **Framework**: Express.js\n`;
   if (auth) readme += `- **Database**: MongoDB (Mongoose)\n`;
-  
+
   if (features.length > 0 || auth) {
     readme += `- **Features**:\n`;
     if (features.includes("cors")) readme += `  - CORS\n`;
-    if (features.includes("helmet")) readme += `  - Helmet (Security headers)\n`;
+    if (features.includes("helmet"))
+      readme += `  - Helmet (Security headers)\n`;
     if (features.includes("rate-limit")) readme += `  - Rate Limiting\n`;
     if (features.includes("morgan")) readme += `  - Morgan (HTTP logging)\n`;
     if (auth) readme += `  - Authentication (JWT)\n`;
   }
   readme += `\n`;
-  
-  // Getting Started
+
   readme += `## Getting Started\n\n`;
   readme += `### Prerequisites\n\n`;
   readme += `- Node.js (v18 or higher)\n`;
   readme += `- npm or yarn\n`;
   if (auth) readme += `- MongoDB\n`;
-  if (isMicroservice && mode === "docker") readme += `- Docker & Docker Compose\n`;
-  if (isMicroservice && mode === "nodocker") readme += `- PM2 (\`npm install -g pm2\`)\n`;
+  if (isMicroservice && mode === "docker")
+    readme += `- Docker & Docker Compose\n`;
+  if (isMicroservice && mode === "nodocker")
+    readme += `- PM2 (\`npm install -g pm2\`)\n`;
   readme += `\n`;
-  
-  // Installation
+
   readme += `### Installation\n\n`;
   readme += `1. Clone the repository\n`;
   readme += `\`\`\`bash\n`;
   readme += `cd ${sanitizedName}\n`;
   readme += `\`\`\`\n\n`;
-  
+
   if (isMicroservice) {
+    const servicesList = getServices();
     readme += `2. Install dependencies for all services\n`;
     readme += `\`\`\`bash\n`;
     readme += `# Install root dependencies (Husky)\n`;
     readme += `npm install\n\n`;
     readme += `# Install dependencies for each service\n`;
-    readme += `cd services/gateway && npm install && cd ../..\n`;
-    readme += `cd services/health-service && npm install && cd ../..\n`;
-    if (auth) readme += `cd services/auth-service && npm install && cd ../..\n`;
+    servicesList.forEach((service) => {
+      if (
+        service === "gateway" ||
+        service === "health-service" ||
+        service === "auth-service"
+      ) {
+        readme += `cd services/${service} && npm install && cd ../..\n`;
+      }
+    });
     readme += `\`\`\`\n\n`;
   } else {
     readme += `2. Install dependencies\n`;
@@ -93,8 +106,7 @@ export const generateReadme = (config, serviceName = null) => {
     readme += `npm install\n`;
     readme += `\`\`\`\n\n`;
   }
-  
-  // Environment Variables
+
   readme += `3. Set up environment variables\n`;
   if (isMicroservice) {
     readme += `\`\`\`bash\n`;
@@ -106,14 +118,12 @@ export const generateReadme = (config, serviceName = null) => {
     readme += `cp .env.example .env\n`;
     readme += `\`\`\`\n\n`;
   }
-  
+
   if (auth) {
     readme += `4. Configure your MongoDB connection and JWT secret in the \`.env\` file${isMicroservice ? "s" : ""}\n\n`;
   }
-  
-  // Running the Application
+
   readme += `## Running the Application\n\n`;
-  
   if (isMicroservice && mode === "docker") {
     readme += `### With Docker\n\n`;
     readme += `\`\`\`bash\n`;
@@ -141,122 +151,102 @@ export const generateReadme = (config, serviceName = null) => {
     readme += `\`\`\`bash\n`;
     readme += `npm run dev\n`;
     readme += `\`\`\`\n\n`;
-    readme += `### Production\n\n`;
-    readme += `\`\`\`bash\n`;
-    readme += `npm run build\n`;
-    readme += `npm start\n`;
-    readme += `\`\`\`\n\n`;
+    if (isTypeScript) {
+      readme += `### Production\n\n`;
+      readme += `\`\`\`bash\n`;
+      readme += `npm run build\n`;
+      readme += `npm start\n`;
+      readme += `\`\`\`\n\n`;
+    }
   }
-  
-  // API Endpoints
+
   readme += `## API Endpoints\n\n`;
-  
   if (isMicroservice) {
+    const servicesList = getServices();
     readme += `All requests go through the API Gateway at \`http://localhost:4000\`\n\n`;
-
     readme += `### Gateway Endpoints\n`;
     readme += `- **GET** \`/\` - API information and available endpoints\n`;
-    readme += `- **GET** \`/health\` - Gateway health check\n`;
-
+    readme += `- **GET** \`/health\` - Gateway health check\n\n`;
     readme += `### Health Service (Proxied through Gateway)\n`;
     readme += `- **GET** \`/api/v1/health\` - Service health check with system metrics\n`;
     readme += `  - Returns: status, uptime, timestamp, memory usage\n\n`;
-
     if (auth) {
       readme += `### Auth Service (Proxied through Gateway)\n`;
       readme += `- **POST** \`/api/v1/auth/register\` - Register a new user\n`;
       readme += `- **POST** \`/api/v1/auth/login\` - Login user\n\n`;
     }
-    
+
     readme += `### Direct Service Access (Development Only)\n`;
-    const directServices = (config.allServices && config.allServices.length)
-      ? config.allServices
-      : ["gateway", "health-service", ...(auth ? ["auth-service"] : [])];
-    directServices.forEach((service) => {
-      const isGateway = service === "gateway";
-      const port = isGateway
-        ? 4000
-        : 4001 + directServices.filter((s) => s !== "gateway" && directServices.indexOf(s) < directServices.indexOf(service)).length;
-      const basePath = isGateway ? `` : `/api/v1`;
+    servicesList.forEach((service, index) => {
+      const port = getPort(servicesList, service, index);
+      const basePath = service === "gateway" ? `` : `/api/v1`;
       readme += `- **${service}**: \`http://localhost:${port}${basePath}\`\n`;
     });
     readme += `\n`;
 
-    readme += "### Example Requests\n";
-    readme += "```bash\n";
-    readme += "# Gateway info\n";
-    readme += "curl http://localhost:4000/\n\n";
-    readme += "# Gateway health\n";
-    readme += "curl http://localhost:4000/health\n\n";
+    readme += `### Example Requests\n`;
+    readme += `\`\`\`bash\n`;
+    readme += `# Gateway info\n`;
+    readme += `curl http://localhost:4000/\n\n`;
+    readme += `# Gateway health\n`;
+    readme += `curl http://localhost:4000/health\n\n`;
 
-    // Direct access examples for non-gateway services
-    const exampleServices = (config.allServices && config.allServices.length)
-      ? config.allServices
-      : ["gateway", "health-service", ...(auth ? ["auth-service"] : [])];
-    exampleServices.forEach((service) => {
-      if (service === "gateway") return; // gateway already covered
-      const port = service === "gateway" ? 4000 : 4001 + exampleServices.filter((s) => s !== "gateway" && exampleServices.indexOf(s) < exampleServices.indexOf(service)).length;
+    servicesList.forEach((service, index) => {
+      if (service === "gateway") return;
+      const port = getPort(servicesList, service, index);
       readme += `# ${service} (direct access)\n`;
       readme += `curl http://localhost:${port}/api/v1/health\n\n`;
     });
 
-    if (auth && exampleServices.includes("auth-service")) {
-      const authPort = 4001 + exampleServices.filter((s) => s !== "gateway" && exampleServices.indexOf(s) < exampleServices.indexOf("auth-service")).length;
-      readme += "# Auth requests (through gateway)\n";
+    if (auth && servicesList.includes("auth-service")) {
+      const authPort = getPort(
+        servicesList,
+        "auth-service",
+        servicesList.indexOf("auth-service"),
+      );
+      readme += `# Auth requests (through gateway)\n`;
       readme += `curl -X POST http://localhost:4000/api/v1/auth/register \\\n+  -H "Content-Type: application/json" \\\n+  -d '{"username":"testuser","password":"password123"}'\n\n`;
       readme += `curl -X POST http://localhost:4000/api/v1/auth/login \\\n+  -H "Content-Type: application/json" \\\n+  -d '{"username":"testuser","password":"password123"}'\n\n`;
       readme += `# Auth requests (direct access)\n`;
       readme += `curl -X POST http://localhost:${authPort}/api/v1/auth/register \\\n+  -H "Content-Type: application/json" \\\n+  -d '{"username":"testuser","password":"password123"}'\n\n`;
       readme += `curl -X POST http://localhost:${authPort}/api/v1/auth/login \\\n+  -H "Content-Type: application/json" \\\n+  -d '{"username":"testuser","password":"password123"}'\n\n`;
     }
-
-    readme += "```\n\n";
-    
+    readme += `\`\`\`\n\n`;
   } else {
     readme += `Base URL: \`http://localhost:4000\`\n\n`;
     readme += `- **GET** \`/\` - Root endpoint (API info)\n`;
     readme += `- **GET** \`/api/v1/health\` - Health check\n\n`;
-    
     if (auth) {
       readme += `### Authentication\n`;
       readme += `- **POST** \`/api/v1/auth/register\` - Register a new user\n`;
       readme += `- **POST** \`/api/v1/auth/login\` - Login user\n\n`;
     }
 
-    // Example requests for monolith
-    readme += "### Example Requests\n";
-    readme += "```bash\n";
-    readme += "# Root info\n";
-    readme += "curl http://localhost:4000/\n\n";
-    readme += "# Health check\n";
-    readme += "curl http://localhost:4000/api/v1/health\n\n";
+    readme += `### Example Requests\n`;
+    readme += `\`\`\`bash\n`;
+    readme += `# Root info\n`;
+    readme += `curl http://localhost:4000/\n\n`;
+    readme += `# Health check\n`;
+    readme += `curl http://localhost:4000/api/v1/health\n\n`;
     if (auth) {
-      readme += "# Register user\n";
-      readme += `curl -X POST http://localhost:4000/api/v1/auth/register \\\n`;
-      readme += `  -H \"Content-Type: application/json\" \\\n`;
-      readme += `  -d '{"username":"testuser","password":"password123"}'\n\n`;
-      readme += "# Login user\n";
-      readme += `curl -X POST http://localhost:4000/api/v1/auth/login \\\n`;
-      readme += `  -H \"Content-Type: application/json\" \\\n`;
-      readme += `  -d '{"username":"testuser","password":"password123"}'\n\n`;
+      readme += `# Register user\n`;
+      readme += `curl -X POST http://localhost:4000/api/v1/auth/register \\\n+  -H "Content-Type: application/json" \\\n+  -d '{"username":"testuser","password":"password123"}'\n\n`;
+      readme += `# Login user\n`;
+      readme += `curl -X POST http://localhost:4000/api/v1/auth/login \\\n+  -H "Content-Type: application/json" \\\n+  -d '{"username":"testuser","password":"password123"}'\n\n`;
     }
-    readme += "```\n\n";
+    readme += `\`\`\`\n\n`;
   }
-  
-  // Project Structure
+
   readme += `## Project Structure\n\n`;
   readme += `\`\`\`\n`;
-  
   if (isMicroservice) {
+    const servicesList = getServices();
     readme += `${sanitizedName}/\n`;
     readme += `├── shared/              # Shared utilities across services\n`;
-    readme += `│   ├── config/         # Database, environment configs\n`;
-    readme += `│   └── utils/          # Logger, error handlers\n`;
+    readme += `│   ├── config/          # Database, environment configs\n`;
+    readme += `│   └── utils/           # Logger, error handlers\n`;
     readme += `├── services/\n`;
-    const projectServices = (config.allServices && config.allServices.length)
-      ? config.allServices
-      : ["gateway", "health-service", ...(auth ? ["auth-service"] : [])];
-    projectServices.forEach((service) => {
+    servicesList.forEach((service) => {
       readme += `│   ├── ${service}/\n`;
     });
     readme += `├── ${mode === "docker" ? "docker-compose.yml" : "pm2.config.js"}\n`;
@@ -273,16 +263,15 @@ export const generateReadme = (config, serviceName = null) => {
     readme += `│   │       └── health/ # Health check\n`;
     if (auth) readme += `│   ├── models/         # Database models\n`;
     readme += `│   ├── utils/          # Utility functions\n`;
-    readme += `│   ├── app.ts          # Express app setup\n`;
-    readme += `│   ├── routes.ts       # Route definitions\n`;
-    readme += `│   └── server.ts       # Server entry point\n`;
+    readme += `│   ├── app.${monolithFileExt}          # Express app setup\n`;
+    readme += `│   ├── routes.${monolithFileExt}       # Route definitions\n`;
+    readme += `│   └── server.${monolithFileExt}       # Server entry point\n`;
     readme += `├── .husky/             # Git hooks\n`;
     readme += `├── package.json\n`;
-    readme += `└── tsconfig.json\n`;
+    if (isTypeScript) readme += `└── tsconfig.json\n`;
   }
   readme += `\`\`\`\n\n`;
-  
-  // Scripts
+
   readme += `## Available Scripts\n\n`;
   if (isMicroservice) {
     if (mode === "docker") {
@@ -297,18 +286,27 @@ export const generateReadme = (config, serviceName = null) => {
     }
   } else {
     readme += `- \`npm run dev\` - Start development server with hot reload\n`;
-    readme += `- \`npm run build\` - Build for production\n`;
+    if (isTypeScript) readme += `- \`npm run build\` - Build for production\n`;
     readme += `- \`npm start\` - Start production server\n`;
     readme += `- \`npm run lint\` - Run ESLint\n`;
     readme += `- \`npm run format\` - Run Prettier\n`;
   }
   readme += `\n`;
-  
-  // Environment Variables
+
   readme += `## Environment Variables\n\n`;
   readme += `| Variable | Description | Default |\n`;
-  readme += `|----------|-------------|---------||\n`;
-  readme += `| \`PORT\` | Server port | \`4000\` |\n`;
+  readme += `| --- | --- | --- |\n`;
+  if (isMicroservice) {
+    const envServices = getServices();
+    envServices.forEach((service, index) => {
+      const port = getPort(envServices, service, index);
+      const envVarName = `${service.toUpperCase().replace(/-/g, "_")}_PORT`;
+      const description = `${service.replace(/-/g, " ")} service port`;
+      readme += `| \`${envVarName}\` | ${description} | \`${port}\` |\n`;
+    });
+  } else {
+    readme += `| \`PORT\` | Server port | \`4000\` |\n`;
+  }
   readme += `| \`NODE_ENV\` | Environment | \`development\` |\n`;
   if (features.includes("cors")) {
     readme += `| \`ALLOWED_ORIGIN\` | CORS allowed origin | \`http://localhost:3000\` |\n`;
@@ -318,18 +316,14 @@ export const generateReadme = (config, serviceName = null) => {
     readme += `| \`JWT_SECRET\` | JWT secret key | - |\n`;
   }
   readme += `\n`;
-  
-  // Scaffold attribution
-  readme += `\n`;
+
   readme += `## About this Scaffold\n\n`;
   readme += `This project was generated using the @ifecodes/backend-template scaffold. `;
-  readme += `You can recreate or customize this scaffold using the CLI: \n\n`;
+  readme += `You can recreate or customize this scaffold using the CLI:\n\n`;
   readme += `- Run without installing (recommended): \`npx ifecodes-template\`\n`;
   readme += `- Install globally: \`npm i -g @ifecodes/backend-template\` and run \`ifecodes-template\`\n\n`;
 
-  // License
-  readme += `## License\n\n`;
-  readme += `MIT\n`;
+  readme += `## License\n\nMIT\n`;
 
   return readme;
 };

package/bin/lib/service-setup.js

@@ -36,26 +36,31 @@ export const setupService = async (
   // Detect file extension (ts or js)
   const ext = getFileExtension(serviceRoot);
 
-  // Remove workspace-level config files from service (they should live at root)
-  try {
-    const serviceConfigFiles = [
-      ".prettierrc",
-      ".prettierignore",
-      ".eslintrc.json",
-      "eslint.config.js",
-      "husky",
-    ];
-    for (const f of serviceConfigFiles) {
-      const p = path.join(serviceRoot, f);
-      if (fs.existsSync(p)) {
-        // Remove file or directory
-        const stat = fs.statSync(p);
-        if (stat.isDirectory()) fs.rmSync(p, { recursive: true, force: true });
-        else fs.rmSync(p, { force: true });
+  // Remove workspace-level config files from service only in microservice mode (they should live at root)
+  // (monolith projects keep these files at project root)
+  if (res.projectType === "microservice" || res.isInMicroserviceProject) {
+    try {
+      const serviceConfigFiles = [
+        ".prettierrc",
+        ".prettierignore",
+        ".eslintrc.json",
+        "eslint.config.js",
+        ".husky",
+        "husky",
+      ];
+      for (const f of serviceConfigFiles) {
+        const p = path.join(serviceRoot, f);
+        if (fs.existsSync(p)) {
+          // Remove file or directory
+          const stat = fs.statSync(p);
+          if (stat.isDirectory())
+            fs.rmSync(p, { recursive: true, force: true });
+          else fs.rmSync(p, { force: true });
+        }
       }
+    } catch (err) {
+      // Non-fatal
     }
-  } catch (err) {
-    // Non-fatal
   }
 
   // Ensure service-level gitignore is renamed immediately after template copy

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ifecodes/backend-template",
-  "version": "1.1.7",
+  "version": "1.1.9",
   "description": "Production-ready Express + TypeScript/JavaScript backend generator with optional features and microservice support",
   "bin": {
     "ifecodes-template": "bin/cli.js"

package/template/base/js/.env.example

@@ -1,5 +1,5 @@
-PORT=4000
-NODE_ENV=development
-/*__ALLOWED_ORIGIN_ENV__*/
-/*__MONGO_URI_ENV__*/
-/*__JWT_SECRET_ENV__*/
+PORT=4000
+NODE_ENV=development
+/*__ALLOWED_ORIGIN_ENV__*/
+/*__MONGO_URI_ENV__*/
+/*__JWT_SECRET_ENV__*/

package/template/base/js/.husky/pre-commit

@@ -3,11 +3,5 @@ set -e
 echo "Checking format (prettier)..."
 npm run check-format
 
-echo "Running TypeScript type-check..."
-npx tsc --noEmit
-
 echo "Checking lint..."
-npm run lint -- --max-warnings=0
-
-echo "Building project..."
-npm run build
+npm run lint -- --max-warnings=0

package/template/base/js/src/app.js

@@ -1,5 +1,6 @@
 const express = require("express");
 const router = require("./routes");
+const { errorHandler } = require("./middlewares");
 /*__IMPORTS__*/
 
 const app = express();
@@ -12,4 +13,6 @@ app.use(express.json());
 // Connect routes
 app.use(router);
 
+app.use(errorHandler);
+
 module.exports = app;

package/template/base/js/src/config/db.js

@@ -1,8 +1,8 @@
-// MongoDB connection will be added here when authentication is enabled
-const connectDB = async () => {
-  // Database connection placeholder
-};
-
-module.exports = {
-  connectDB,
-};
+// MongoDB connection will be added here when authentication is enabled
+const connectDB = async () => {
+  // Database connection placeholder
+};
+
+module.exports = {
+  connectDB,
+};

package/template/base/js/src/config/env.js

@@ -1,14 +1,14 @@
-const dotenv = require("dotenv");
-dotenv.config();
-
-const ENV = {
- PORT: process.env.PORT,
-  /*__ALLOWED_ORIGIN__*/
-  NODE_ENV: process.env.NODE_ENV,
-  /*__MONGO_URI__*/
-  /*__JWT_SECRET__*/
-};
-
-module.exports = {
-  ENV,
-};
+const dotenv = require("dotenv");
+dotenv.config();
+
+const ENV = {
+ PORT: process.env.PORT,
+  /*__ALLOWED_ORIGIN__*/
+  NODE_ENV: process.env.NODE_ENV,
+  /*__MONGO_URI__*/
+  /*__JWT_SECRET__*/
+};
+
+module.exports = {
+  ENV,
+};

package/template/base/js/src/config/index.js

@@ -1,7 +1,7 @@
-const { connectDB } = require("./db");
-const { ENV } = require("./env");
-
-module.exports = {
-  connectDB,
-  ENV,
-};
+const { connectDB } = require("./db");
+const { ENV } = require("./env");
+
+module.exports = {
+  connectDB,
+  ENV,
+};

package/template/base/js/src/middlewares/error-handler.middleware.js

@@ -0,0 +1,19 @@
+const { HttpError } = require("../utils");
+
+const errorHandler = (err, _, res, __) => {
+  if (err instanceof HttpError) {
+    return res.status(err.status).json({
+      status: "error",
+      message: err.message,
+    });
+  }
+
+  return res.status(500).json({
+    status: "error",
+    message: "Internal Server Error",
+  });
+};
+
+module.exports = {
+  errorHandler,
+};

package/template/base/js/src/middlewares/index.js

@@ -1,9 +1,11 @@
-const methodNotAllowedHandler = require("./method-not-allowed.middleware");
-const { notFound } = require("./not-found.middleware");
-const { rootHandler } = require("./root.middleware");
-
-module.exports = {
-  methodNotAllowedHandler,
-  notFound,
-  rootHandler,
-};
+const methodNotAllowedHandler = require("./method-not-allowed.middleware");
+const { notFound } = require("./not-found.middleware");
+const { rootHandler } = require("./root.middleware");
+const { errorHandler } = require("./error-handler.middleware");
+
+module.exports = {
+  methodNotAllowedHandler,
+  notFound,
+  rootHandler,
+  errorHandler,
+};

package/template/base/js/src/middlewares/method-not-allowed.middleware.js

@@ -1,13 +1,13 @@
-const methodNotAllowed = (allowedMethods) => (req, res, next) => {
-  if (!allowedMethods.includes(req.method)) {
-    res.set("Allow", allowedMethods.join(", "));
-    return res.status(405).json({
-      status: "error",
-      message: `Method ${req.method} not allowed for ${req.originalUrl}`,
-      allowed: allowedMethods,
-    });
-  }
-  next();
-};
-
-module.exports = methodNotAllowed;
+const methodNotAllowed = (allowedMethods) => (req, res, next) => {
+  if (!allowedMethods.includes(req.method)) {
+    res.set("Allow", allowedMethods.join(", "));
+    return res.status(405).json({
+      status: "error",
+      message: `Method ${req.method} not allowed for ${req.originalUrl}`,
+      allowed: allowedMethods,
+    });
+  }
+  next();
+};
+
+module.exports = methodNotAllowed;