@ifc-lite/viewer 1.27.0 → 1.28.1

package/src/lib/llm/script-edit-ops.ts

@@ -456,6 +456,29 @@ export function applyScriptEditOperations(params: {
     return { ok: true, content, selection, revision, appliedOpIds, changes, status: 'ok' };
   }
 
+  if (operations.length > 1 && operations.some((op) => op.type === 'replaceAll')) {
+    const diagnostic = createPatchDiagnostic(
+      'patch_semantic_error',
+      'A replaceAll edit must be the only operation in its batch; it cannot be combined with positional ops.',
+      'error',
+      {
+        failureKind: 'mixed_repair_scopes',
+        fixHint:
+          'Emit replaceAll on its own, or use only positional ops (insert/replaceRange/append) in one batch.',
+      },
+    );
+    return {
+      ok: false,
+      content: params.content,
+      selection: params.selection,
+      revision,
+      appliedOpIds: [],
+      status: 'semantic_error',
+      error: diagnostic.message,
+      diagnostic,
+    };
+  }
+
   if (params.intent === 'repair') {
     const metadataError = validateRepairBatchMetadata(operations);
     if (metadataError) {

package/src/lib/llm/stream-client.ts

@@ -139,7 +139,14 @@ export async function readSseStream(
         if (!line.startsWith('data: ')) continue;
         const data = line.slice(6);
         if (data === '[DONE]') continue;
-        try { onEvent(data); } catch { /* skip malformed */ }
+        try {
+          onEvent(data);
+        } catch (err) {
+          // Malformed JSON payloads are expected and skipped, but a genuine
+          // callback failure (onChunk/onUsageInfo/logCacheHit/fullText) would
+          // otherwise be silently dropped — surface it for diagnosability.
+          console.debug('[sse] skipped event', err);
+        }
       }
     }
   };

package/src/lib/search/result-export.ts

@@ -33,9 +33,15 @@ function cellToString(v: unknown): string {
 }
 
 /** RFC-4180-style escaping: quote any cell containing comma, quote, or
- *  newline; double-up embedded quotes inside the wrapped cell. */
+ *  newline; double-up embedded quotes inside the wrapped cell. Also
+ *  neutralises spreadsheet formula triggers (CWE-1236) so user/model-
+ *  controlled cell values are treated as text on open. */
 function escapeCsvCell(raw: string): string {
   if (raw.length === 0) return '';
+  // CWE-1236: neutralise spreadsheet formula triggers in the leading
+  // position. Prefixing first ensures the needsQuotes check below still
+  // wraps values that also contain comma/quote/newline.
+  if (/^[=+\-@\t\r]/.test(raw)) raw = `'${raw}`;
   const needsQuotes = raw.includes(',') || raw.includes('"') || raw.includes('\n') || raw.includes('\r');
   if (!needsQuotes) return raw;
   return `"${raw.replace(/"/g, '""')}"`;

package/src/sdk/adapters/export-adapter.ts

@@ -108,7 +108,12 @@ export function resolveVisibilityFilterSets(
  * double-quotes, or newlines.
  */
 function escapeCsv(value: string, sep: string): string {
-  if (value.includes(sep) || value.includes('"') || value.includes('\n')) {
+  // Neutralize spreadsheet formula injection (CWE-1236): a leading
+  // =, +, -, @, TAB or CR makes a cell execute as a formula in Excel/
+  // LibreOffice/Sheets. IFC values are attacker-controllable, so prefix
+  // such cells with an apostrophe.
+  if (/^[=+\-@\t\r]/.test(value)) value = `'${value}`;
+  if (value.includes(sep) || value.includes('"') || value.includes('\n') || value.includes('\r')) {
     return `"${value.replace(/"/g, '""')}"`;
   }
   return value;

package/src/services/cacheService.ts

@@ -3,16 +3,11 @@
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
 /**
- * Platform-agnostic cache service
- * Dynamically loads the appropriate cache implementation based on platform:
- * - Tauri (desktop): Uses native filesystem via desktop-cache.ts
- * - Web: Uses IndexedDB via ifc-cache.ts
+ * Cache service — IndexedDB-backed cache (ifc-cache.ts) for the web build.
  *
  * Extracted from useIfc.ts for reusability and testability
  */
 
-import { isTauri } from '../utils/ifcConfig.js';
-
 // ============================================================================
 // Types
 // ============================================================================
@@ -65,29 +60,18 @@ export interface ICacheService {
 let cacheService: ICacheService | null = null;
 
 /**
- * Get the cache service for the current platform
- * Lazily loads the appropriate implementation
+ * Get the cache service.
+ * Lazily loads the IndexedDB implementation.
  */
 export async function getCacheService(): Promise<ICacheService> {
   if (cacheService) return cacheService;
 
-  if (isTauri()) {
-    // Desktop: Use Tauri native filesystem
-    const mod = await import('./desktop-cache.js');
-    cacheService = {
-      getCached: mod.getCached,
-      setCached: mod.setCached,
-      deleteCached: mod.deleteCached,
-    };
-  } else {
-    // Web: Use IndexedDB
-    const mod = await import('./ifc-cache.js');
-    cacheService = {
-      getCached: mod.getCached,
-      setCached: mod.setCached,
-      deleteCached: mod.deleteCached,
-    };
-  }
+  const mod = await import('./ifc-cache.js');
+  cacheService = {
+    getCached: mod.getCached,
+    setCached: mod.setCached,
+    deleteCached: mod.deleteCached,
+  };
 
   return cacheService;
 }

package/src/services/desktop-export.ts

@@ -2,34 +2,8 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-import { IfcParser, type IfcDataStore } from '@ifc-lite/parser';
+import { type IfcDataStore } from '@ifc-lite/parser';
 import { getViewerStoreApi } from '@/store';
-import { toast } from '@/components/ui/toast';
-import { readNativeFile } from '@/services/file-dialog';
-
-const exportHydrationByModel = new Map<string, Promise<IfcDataStore | null>>();
-
-function isDesktopRuntime(): boolean {
-  // `globalThis` and `Window` aren't structurally compatible per TS, so
-  // route through `unknown` first — the cast is intentional.
-  const win = globalThis as unknown as Window & { __TAURI_INTERNALS__?: { invoke?: unknown } };
-  return typeof win.__TAURI_INTERNALS__?.invoke === 'function';
-}
-
-function hasFullStepSource(dataStore: IfcDataStore | null | undefined): dataStore is IfcDataStore {
-  return Boolean(dataStore?.source?.length && dataStore.entityIndex?.byId?.size);
-}
-
-function toExactArrayBuffer(bytes: Uint8Array): ArrayBuffer {
-  if (
-    bytes.buffer instanceof ArrayBuffer
-    && bytes.byteOffset === 0
-    && bytes.byteLength === bytes.buffer.byteLength
-  ) {
-    return bytes.buffer;
-  }
-  return bytes.slice().buffer;
-}
 
 export async function ensureModelExportReady(modelId: string): Promise<IfcDataStore | null> {
   const store = getViewerStoreApi();
@@ -44,36 +18,5 @@ export async function ensureModelExportReady(modelId: string): Promise<IfcDataSt
     return null;
   }
 
-  if (hasFullStepSource(model.ifcDataStore)) {
-    return model.ifcDataStore;
-  }
-
-  if (!isDesktopRuntime() || !model.nativeMetadata?.filePath) {
-    return model.ifcDataStore;
-  }
-
-  const pending = exportHydrationByModel.get(modelId);
-  if (pending) {
-    return pending;
-  }
-
-  const hydrationPromise = (async () => {
-    toast.info(`Preparing ${model.name} for IFC export...`);
-    const bytes = await readNativeFile(model.nativeMetadata!.filePath);
-    const parser = new IfcParser();
-    const hydratedStore = await parser.parseColumnar(toExactArrayBuffer(bytes));
-
-    store.getState().updateModel(modelId, {
-      ifcDataStore: hydratedStore,
-      schemaVersion: hydratedStore.schemaVersion,
-      metadataLoadState: 'complete',
-    });
-
-    return hydratedStore;
-  })().finally(() => {
-    exportHydrationByModel.delete(modelId);
-  });
-
-  exportHydrationByModel.set(modelId, hydrationPromise);
-  return hydrationPromise;
+  return model.ifcDataStore;
 }

package/src/services/file-dialog.ts

@@ -2,151 +2,17 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-type InvokeFn = <T>(cmd: string, args?: Record<string, unknown>) => Promise<T>;
-
-export interface NativeFileHandle {
-  path: string;
-  name: string;
-  size: number;
-  modifiedMs?: number | null;
-}
-
 export interface GenericFileDialogOptions {
   title?: string;
   filters?: Array<{ name: string; extensions: string[] }>;
 }
 
-async function loadInvokeFromTauriModule(): Promise<InvokeFn | null> {
-  try {
-    const core = await import('@tauri-apps/api/core');
-    return typeof core.invoke === 'function' ? core.invoke as InvokeFn : null;
-  } catch {
-    return null;
-  }
-}
-
-async function loadDialogModule(): Promise<{
-  open: (options?: {
-    multiple?: boolean;
-    directory?: boolean;
-    filters?: Array<{ name: string; extensions: string[] }>;
-    title?: string;
-  }) => Promise<string | string[] | null>;
-} | null> {
-  try {
-    return await import('@tauri-apps/plugin-dialog');
-  } catch {
-    return null;
-  }
-}
-
-async function loadFsModule(): Promise<{
-  stat: (path: string) => Promise<{ size: number }>;
-} | null> {
-  try {
-    return await import('@tauri-apps/plugin-fs');
-  } catch {
-    return null;
-  }
-}
-
-async function getInvoke(): Promise<InvokeFn> {
-  const win = globalThis as unknown as { __TAURI_INTERNALS__?: { invoke: InvokeFn } };
-  if (win.__TAURI_INTERNALS__?.invoke) {
-    return win.__TAURI_INTERNALS__.invoke;
-  }
-  const moduleInvoke = await loadInvokeFromTauriModule();
-  if (moduleInvoke) {
-    return moduleInvoke;
-  }
-  throw new Error('Tauri API not available');
-}
-
-export async function openIfcFileDialog(): Promise<NativeFileHandle | null> {
-  try {
-    const invoke = await getInvoke();
-    return await invoke<NativeFileHandle | null>('open_ifc_file');
-  } catch {
-    // Expected in browser builds — fall through to plugin fallback, then browser file input.
-  }
-
-  try {
-    const dialog = await loadDialogModule();
-    const fs = await loadFsModule();
-    if (!dialog || !fs) {
-      return null;
-    }
-
-    const selected = await dialog.open({
-      multiple: false,
-      directory: false,
-      title: 'Open IFC, Mesh or Point Cloud File',
-      filters: [
-        { name: 'IFC Files', extensions: ['ifc', 'ifczip', 'ifcxml', 'ifcx'] },
-        { name: 'Mesh Files', extensions: ['glb'] },
-        { name: 'Point Clouds', extensions: ['las', 'laz', 'ply', 'pcd', 'e57'] },
-        { name: 'All Files', extensions: ['*'] },
-      ],
-    });
-    if (!selected || Array.isArray(selected)) {
-      return null;
-    }
-
-    const metadata = await fs.stat(selected);
-    const normalizedPath = selected.toString();
-    const pathSegments = normalizedPath.split(/[\\/]/);
-    const name = pathSegments[pathSegments.length - 1] || 'unknown.ifc';
-
-    return {
-      path: normalizedPath,
-      name,
-      size: metadata.size,
-    };
-  } catch {
-    // No Tauri plugin available — caller falls back to browser <input type="file">.
-    return null;
-  }
-}
-
-export async function readNativeFile(path: string): Promise<Uint8Array> {
-  try {
-    const invoke = await getInvoke();
-    const bytes = await invoke<number[]>('read_native_file', { path });
-    return Uint8Array.from(bytes);
-  } catch (error) {
-    console.warn('[FileDialog] Falling back to plugin-fs read for native file:', error);
-    const fs = await import('@tauri-apps/plugin-fs');
-    return fs.readFile(path);
-  }
-}
-
-export async function openGenericFileDialog(options: GenericFileDialogOptions = {}): Promise<File | null> {
-  try {
-    const dialog = await loadDialogModule();
-    if (!dialog) {
-      return null;
-    }
-
-    const selected = await dialog.open({
-      multiple: false,
-      directory: false,
-      title: options.title,
-      filters: options.filters,
-    });
-    if (!selected || Array.isArray(selected)) {
-      return null;
-    }
-
-    const normalizedPath = selected.toString();
-    const bytes = await readNativeFile(normalizedPath);
-    const pathSegments = normalizedPath.split(/[\\/]/);
-    const name = pathSegments[pathSegments.length - 1] || 'document';
-    // Slice to a fresh ArrayBuffer view — TS5+ narrows `Uint8Array` to
-    // `Uint8Array<ArrayBufferLike>` which `BlobPart` doesn't accept.
-    const blobPart = new Uint8Array(bytes.buffer, bytes.byteOffset, bytes.byteLength).slice();
-    return new File([blobPart], name, { type: 'application/octet-stream' });
-  } catch (error) {
-    console.warn('[FileDialog] Failed to open generic native file dialog:', error);
-    return null;
-  }
+/**
+ * Browser-only build: there is no native OS file dialog, so this resolves to
+ * `null` and callers fall back to a browser `<input type="file">`. (ifc-lite no
+ * longer ships a desktop app; third parties building their own desktop shell on
+ * the published packages supply native file access in their own host layer.)
+ */
+export async function openGenericFileDialog(_options: GenericFileDialogOptions = {}): Promise<null> {
+  return null;
 }

package/src/store/constants.ts

@@ -222,6 +222,29 @@ export function getPersistedTypeVisibility(): TypeVisibility {
   };
 }
 
+/**
+ * The 3D view mode for the Model/Types switch (#957 follow-up).
+ *   'model' — show placed occurrences (the default; the building as designed).
+ *   'types' — show the type-library shapes (each IfcTypeProduct's
+ *             RepresentationMap at its MappingOrigin), hiding occurrences.
+ * Orphan type geometry (a type with no occurrence, e.g. annex-E showcase files)
+ * shows in BOTH modes since it is the only geometry the file has.
+ */
+export type TypeViewMode = 'model' | 'types';
+
+export const TYPE_VIEW_MODE_STORAGE_KEY = 'ifc-lite-type-view-mode';
+export const TYPE_VIEW_MODE_DEFAULT: TypeViewMode = 'model';
+
+/** Resolve the persisted Model/Types view mode (read fresh, like type visibility). */
+export function getPersistedTypeViewMode(): TypeViewMode {
+  if (typeof window === 'undefined') return TYPE_VIEW_MODE_DEFAULT;
+  try {
+    return localStorage.getItem(TYPE_VIEW_MODE_STORAGE_KEY) === 'types' ? 'types' : 'model';
+  } catch {
+    return TYPE_VIEW_MODE_DEFAULT;
+  }
+}
+
 // ============================================================================
 // Data Defaults
 // ============================================================================

package/src/store/globalId.ts

@@ -44,23 +44,17 @@ export function fromGlobalIdFromModels(
   models: ReverseModelMapLike,
   globalId: number,
 ): EntityRef | undefined {
-  if (models.size <= 1) {
-    const firstModelId = models.keys().next().value;
-    if (firstModelId) {
-      return {
-        modelId: firstModelId,
-        expressId: globalId,
-      };
-    }
-    return {
-      modelId: 'legacy',
-      expressId: globalId,
-    };
+  // No models loaded — legacy single-store fallback (expressId === globalId).
+  if (models.size === 0) {
+    return { modelId: 'legacy', expressId: globalId };
   }
 
+  // Resolve through every model by its offset range, regardless of count.
+  // For a true single model with idOffset 0 this still yields expressId === globalId.
+  // The `>= 0` boundary matches the canonical resolveGlobalIdFromModels (modelSlice.ts).
   for (const [modelId, model] of models.entries()) {
     const localExpressId = globalId - model.idOffset;
-    if (localExpressId > 0 && localExpressId <= model.maxExpressId) {
+    if (localExpressId >= 0 && localExpressId <= model.maxExpressId) {
       return {
         modelId,
         expressId: localExpressId,
@@ -68,6 +62,14 @@ export function fromGlobalIdFromModels(
     }
   }
 
+  // Single-model graceful fallback: if exactly one model and the offset
+  // range check missed (e.g. overlay-allocated id above maxExpressId),
+  // still return that model with the offset-corrected id rather than undefined.
+  if (models.size === 1) {
+    const [modelId, model] = models.entries().next().value!;
+    return { modelId, expressId: globalId - model.idOffset };
+  }
+
   return undefined;
 }
 

package/src/store/index.ts

@@ -34,10 +34,10 @@ import { createListSlice, type ListSlice } from './slices/listSlice.js';
 import { createPinboardSlice, type PinboardSlice } from './slices/pinboardSlice.js';
 import { createLensSlice, type LensSlice } from './slices/lensSlice.js';
 import { createClashSlice, type ClashSlice } from './slices/clashSlice.js';
+import { createCompareSlice, type CompareSlice } from './slices/compareSlice.js';
 import { createScriptSlice, type ScriptSlice } from './slices/scriptSlice.js';
 import { createChatSlice, type ChatSlice } from './slices/chatSlice.js';
 import { createCesiumSlice, type CesiumSlice } from './slices/cesiumSlice.js';
-import { createDesktopEntitlementSlice, type DesktopEntitlementSlice } from './slices/desktopEntitlementSlice.js';
 import { createScheduleSlice, type ScheduleSlice } from './slices/scheduleSlice.js';
 import { createPlaybackSlice, type PlaybackSlice } from './slices/playbackSlice.js';
 import { createOverlaySlice, type OverlaySlice } from './slices/overlaySlice.js';
@@ -50,7 +50,7 @@ import { createPointCloudSlice, type PointCloudSlice, POINT_CLOUD_DEFAULTS } fro
 import { invalidateVisibleBasketCache } from './basketVisibleSet.js';
 
 // Import constants for reset function
-import { CAMERA_DEFAULTS, SECTION_PLANE_DEFAULTS, UI_DEFAULTS, getPersistedTypeVisibility } from './constants.js';
+import { CAMERA_DEFAULTS, SECTION_PLANE_DEFAULTS, UI_DEFAULTS, getPersistedTypeVisibility, getPersistedTypeViewMode } from './constants.js';
 
 // Re-export types for consumers
 export type * from './types.js';
@@ -85,13 +85,13 @@ export type { PinboardSlice } from './slices/pinboardSlice.js';
 
 // Re-export Lens types
 export type { LensSlice, Lens, LensRule, LensCriteria } from './slices/lensSlice.js';
+export type { CompareSlice, CompareResult } from './slices/compareSlice.js';
 
 // Re-export Script types
 export type { ScriptSlice } from './slices/scriptSlice.js';
 
 // Re-export Chat types
 export type { ChatSlice } from './slices/chatSlice.js';
-export type { DesktopEntitlementSlice } from './slices/desktopEntitlementSlice.js';
 
 // Re-export Cesium types
 export type { CesiumSlice, CesiumDataSource, CesiumPlacementDraft } from './slices/cesiumSlice.js';
@@ -131,10 +131,10 @@ export type ViewerState = LoadingSlice &
   PinboardSlice &
   LensSlice &
   ClashSlice &
+  CompareSlice &
   ScriptSlice &
   ChatSlice &
   CesiumSlice &
-  DesktopEntitlementSlice &
   ScheduleSlice &
   PlaybackSlice &
   OverlaySlice &
@@ -155,7 +155,7 @@ export type ViewerState = LoadingSlice &
      * the right panel. Routed through by the toolbar, command palette, and the
      * BCF overlay so every entry point behaves identically.
      */
-    openWorkspacePanel: (panel: 'bcf' | 'ids' | 'lens' | 'clash' | 'extensions') => void;
+    openWorkspacePanel: (panel: 'bcf' | 'ids' | 'lens' | 'clash' | 'compare' | 'extensions') => void;
   };
 
 /**
@@ -182,10 +182,10 @@ const createViewerStore = () => create<ViewerState>()((...args) => ({
   ...createPinboardSlice(...args),
   ...createLensSlice(...args),
   ...createClashSlice(...args),
+  ...createCompareSlice(...args),
   ...createScriptSlice(...args),
   ...createChatSlice(...args),
   ...createCesiumSlice(...args),
-  ...createDesktopEntitlementSlice(...args),
   ...createScheduleSlice(...args),
   ...createPlaybackSlice(...args),
   ...createOverlaySlice(...args),
@@ -211,6 +211,8 @@ const createViewerStore = () => create<ViewerState>()((...args) => ({
       // Selection (multi-model)
       selectedEntity: null,
       selectedEntitiesSet: new Set(),
+      selectedEntities: [],
+      selectedModelId: null,
 
       // Visibility (legacy)
       hiddenEntities: new Set(),
@@ -219,6 +221,7 @@ const createViewerStore = () => create<ViewerState>()((...args) => ({
       // Re-read persisted toggles on every file load so a new model never
       // reverts the user's visibility choices (e.g. "Show Annotations").
       typeVisibility: getPersistedTypeVisibility(),
+      typeViewMode: getPersistedTypeViewMode(),
 
       // Visibility (multi-model)
       hiddenEntitiesByModel: new Map(),
@@ -235,6 +238,14 @@ const createViewerStore = () => create<ViewerState>()((...args) => ({
       pendingColorUpdates: null,
       pendingMeshColorUpdates: null,
 
+      // Compare (#924): drop any stale diff result — it references models by
+      // id and the loaded set is changing. Keep panel visibility + A/B/scope
+      // choices (UI prefs); the user re-runs against the new set.
+      compareResult: null,
+      compareSelectedKey: null,
+      compareRunning: false,
+      compareError: null,
+
       // Hover/Context
       hoverState: { entityId: null, screenX: 0, screenY: 0 },
       contextMenu: { isOpen: false, entityId: null, screenX: 0, screenY: 0 },
@@ -316,6 +327,7 @@ const createViewerStore = () => create<ViewerState>()((...args) => ({
         scale: 100,
         useSymbolicRepresentations: false,
         showIfcAnnotations: true,
+        showConstructionProjection: false,
       },
       // Graphic overrides (keep presets, reset active and custom)
       activePresetId: 'preset-3d-colors',
@@ -460,6 +472,7 @@ const createViewerStore = () => create<ViewerState>()((...args) => ({
       idsPanelVisible: panel === 'ids',
       lensPanelVisible: panel === 'lens',
       clashPanelVisible: panel === 'clash',
+      comparePanelVisible: panel === 'compare',
       extensionsPanelVisible: panel === 'extensions',
       rightPanelCollapsed: false,
     });

package/src/store/slices/cesiumSlice.ts

@@ -108,8 +108,15 @@ const STORAGE_KEY_DATA_SOURCE = 'ifc-lite:cesium-data-source';
  * Default Cesium ion token provided at build time.
  * Set via VITE_CESIUM_ION_TOKEN in .env or CI environment.
  * This means users never need to configure a token manually.
+ *
+ * NOTE: `import.meta.env` is undefined under the Vitest/Node test runner (the
+ * Vite define plugin doesn't run there), so this module-top-level read would
+ * crash with "Cannot read properties of undefined" — every viewer test imports
+ * the store, which imports this slice. The optional chaining on `.env` keeps the
+ * read safe in that environment. `import.meta.env` is typed via vite-env.d.ts so
+ * no `as any` cast is needed. Do NOT drop the optional chaining.
  */
-const DEFAULT_ION_TOKEN: string = (import.meta as any).env?.VITE_CESIUM_ION_TOKEN ?? '';
+const DEFAULT_ION_TOKEN: string = import.meta.env?.VITE_CESIUM_ION_TOKEN ?? '';
 
 function loadFromStorage(key: string, fallback: string): string {
   try {

package/src/store/slices/compareSlice.ts

@@ -0,0 +1,96 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
+
+/**
+ * Model-comparison panel state (issue #924). Holds the panel's UI state, the
+ * A/B model selection, the data-vs-geometry scope, and the last `@ifc-lite/diff`
+ * result. The orchestration (building per-entity fingerprints from each model's
+ * `IfcDataStore` + geometry hashes, running `diffModels`, applying the 3D
+ * colour/visibility overlay) lives in the `useCompare` hook — this slice is
+ * deliberately dumb, mirroring `clashSlice` + `useClash`.
+ */
+
+import type { StateCreator } from 'zustand';
+import type { DiffScope, ModelDiff } from '@ifc-lite/diff';
+import type { CompareRef } from '@/lib/compare/buildFingerprints';
+
+/** A completed comparison: the engine result plus the A/B context it ran on. */
+export interface CompareResult {
+  /** Federation model id chosen as the base (version A). */
+  baseModelId: string;
+  /** Federation model id chosen as the head (version B). */
+  headModelId: string;
+  /** Display name of the base model. */
+  baseName: string;
+  /** Display name of the head model. */
+  headName: string;
+  /** The scope the diff was computed with. */
+  scope: DiffScope;
+  /** True when a compared model carries no geometry hashes (loaded outside the
+   *  WASM mesh path), so geometry-scope changes can't be detected. */
+  geometryUnavailable: boolean;
+  /** The engine output — entries keyed by GlobalId, with per-entity refs. */
+  diff: ModelDiff<CompareRef>;
+}
+
+export interface CompareSlice {
+  comparePanelVisible: boolean;
+  /** Selected base (A) / head (B) federation model ids. */
+  compareBaseModelId: string | null;
+  compareHeadModelId: string | null;
+  /** What counts as a change: data, geometry, or both. */
+  compareScope: DiffScope;
+  /** Whether unchanged elements are drawn (ghosted) or hidden. */
+  compareShowUnchanged: boolean;
+  /** Last comparison result (null when idle / not yet run). */
+  compareResult: CompareResult | null;
+  compareRunning: boolean;
+  compareError: string | null;
+  /** GlobalId of the entry focused in the list (for highlight). */
+  compareSelectedKey: string | null;
+
+  setComparePanelVisible: (visible: boolean) => void;
+  toggleComparePanel: () => void;
+  setCompareBaseModelId: (id: string | null) => void;
+  setCompareHeadModelId: (id: string | null) => void;
+  setCompareScope: (scope: DiffScope) => void;
+  setCompareShowUnchanged: (show: boolean) => void;
+  setCompareResult: (result: CompareResult | null) => void;
+  setCompareRunning: (running: boolean) => void;
+  setCompareError: (error: string | null) => void;
+  setCompareSelectedKey: (key: string | null) => void;
+  /** Clear the run result + selection; keeps the A/B + scope choices. */
+  clearCompare: () => void;
+}
+
+export const createCompareSlice: StateCreator<CompareSlice, [], [], CompareSlice> = (set) => ({
+  comparePanelVisible: false,
+  compareBaseModelId: null,
+  compareHeadModelId: null,
+  compareScope: 'both',
+  compareShowUnchanged: false,
+  compareResult: null,
+  compareRunning: false,
+  compareError: null,
+  compareSelectedKey: null,
+
+  setComparePanelVisible: (comparePanelVisible) => set({ comparePanelVisible }),
+  toggleComparePanel: () => set((s) => ({ comparePanelVisible: !s.comparePanelVisible })),
+  setCompareBaseModelId: (compareBaseModelId) => set({ compareBaseModelId }),
+  setCompareHeadModelId: (compareHeadModelId) => set({ compareHeadModelId }),
+  setCompareScope: (compareScope) => set({ compareScope }),
+  setCompareShowUnchanged: (compareShowUnchanged) => set({ compareShowUnchanged }),
+  setCompareResult: (compareResult) => set({ compareResult }),
+  setCompareRunning: (compareRunning) => set({ compareRunning }),
+  setCompareError: (compareError) => set({ compareError }),
+  setCompareSelectedKey: (compareSelectedKey) => set({ compareSelectedKey }),
+
+  clearCompare: () =>
+    set({
+      compareResult: null,
+      compareRunning: false,
+      compareError: null,
+      compareSelectedKey: null,
+    }),
+});