@ifc-lite/viewer 1.18.0 → 1.19.0

package/.turbo/turbo-build.log

@@ -1,10 +1,10 @@
 
-> @ifc-lite/viewer@1.18.0 build /home/runner/work/ifc-lite/ifc-lite/apps/viewer
+> @ifc-lite/viewer@1.19.0 build /home/runner/work/ifc-lite/ifc-lite/apps/viewer
 > vite build
 
 vite v5.4.21 building for production...
 transforming...
-✓ 4152 modules transformed.
+✓ 4187 modules transformed.
 ../../node_modules/.pnpm/protobufjs@8.0.0/node_modules/protobufjs/dist/minimal/protobuf.js (662:18): Use of eval in "../../node_modules/.pnpm/protobufjs@8.0.0/node_modules/protobufjs/dist/minimal/protobuf.js" is strongly discouraged as it poses security risks and may cause issues with minification.
 rendering chunks...
 [plugin:vite:reporter] [plugin vite:reporter] 
@@ -14,10 +14,12 @@ rendering chunks...
 (!) /home/runner/work/ifc-lite/ifc-lite/apps/viewer/src/components/viewer/selectionHandlers.ts is dynamically imported by /home/runner/work/ifc-lite/ifc-lite/apps/viewer/src/hooks/useKeyboardShortcuts.ts but also statically imported by /home/runner/work/ifc-lite/ifc-lite/apps/viewer/src/components/viewer/useMouseControls.ts, dynamic import will not move module into another chunk.
 
 computing gzip size...
-dist/index.html                                         3.66 kB │ gzip:     1.23 kB
-dist/assets/geometry.worker-xHHy-9DV.js                42.60 kB
+dist/index.html                                         3.66 kB │ gzip:     1.22 kB
+dist/assets/geometry.worker-DQEZB2rB.js                42.60 kB
+dist/assets/index-XwKzDuw6.js                          54.12 kB
+dist/assets/decode-worker-Collf_X_.js                  56.14 kB
 dist/assets/emscripten-module-NWak2PoB.wasm           518.88 kB
-dist/assets/ifc-lite_bg-ADjKXSms.wasm               1,050.82 kB
+dist/assets/ifc-lite_bg-4yUkDRD8.wasm               1,059.81 kB
 dist/assets/emscripten-module-CGIn_cMh.wasm         1,070.86 kB
 dist/assets/emscripten-module-DYvzWiHh.wasm         1,561.30 kB
 dist/assets/arrow2_bg-4Y7xYo54.wasm                 5,000.39 kB
@@ -25,32 +27,32 @@ computing gzip size...
 dist/assets/emscripten-module-BTRCZGcB.wasm         6,623.52 kB
 dist/assets/esbuild-Cpd5nU_H.wasm                  13,524.82 kB
 dist/assets/cesium-ADbP7waU.css                        24.30 kB │ gzip:     5.49 kB
-dist/assets/index-COnQRuqY.css                        227.78 kB │ gzip:    33.44 kB
+dist/assets/index-0XpVr_S5.css                        227.87 kB │ gzip:    33.45 kB
 dist/assets/tauri-dialog-stub-r7Wksg7o.js               0.05 kB │ gzip:     0.07 kB
 dist/assets/esbuild-COv63sf-.js                         0.06 kB │ gzip:     0.08 kB
 dist/assets/tauri-core-stub-D8Fa-u43.js                 0.11 kB │ gzip:     0.12 kB
 dist/assets/tauri-fs-stub-BdeRC7aK.js                   0.13 kB │ gzip:     0.13 kB
-dist/assets/basketViewActivator-Cm1QEk_R.js             1.13 kB │ gzip:     0.60 kB
+dist/assets/basketViewActivator-RZy5c3Td.js             1.13 kB │ gzip:     0.60 kB
 dist/assets/event-DIOks52T.js                           1.42 kB │ gzip:     0.66 kB
-dist/assets/wasm-bridge-DyfBSB8z.js                     1.66 kB │ gzip:     0.80 kB
+dist/assets/wasm-bridge-CAYCUHbE.js                     1.66 kB │ gzip:     0.80 kB
 dist/assets/ifc-cache-BAN4vcd4.js                       2.77 kB │ gzip:     0.94 kB
 dist/assets/ffi-DlhRHxHv.js                             6.14 kB │ gzip:     0.98 kB
 dist/assets/lens-CSASnhAL.js                            9.07 kB │ gzip:     2.81 kB
 dist/assets/emscripten-module.browser-CY5t0Vfq.js      12.70 kB │ gzip:     5.09 kB
-dist/assets/native-bridge-SHXiQwFW.js                  18.70 kB │ gzip:     3.80 kB
+dist/assets/native-bridge-CpBeOPQa.js                  18.70 kB │ gzip:     3.80 kB
 dist/assets/parquet-CEXmQNRO.js                        29.67 kB │ gzip:     6.89 kB
-dist/assets/server-client-ncOQVNso.js                  31.43 kB │ gzip:     7.06 kB
+dist/assets/server-client-BB6cMAXE.js                  31.43 kB │ gzip:     7.05 kB
 dist/assets/bcf-DOG9_WPX.js                            40.76 kB │ gzip:    12.67 kB
 dist/assets/ids-DQ5jY0E8.js                            57.15 kB │ gzip:    12.98 kB
 dist/assets/browser-C5TFR7sH.js                        67.65 kB │ gzip:    18.94 kB
 dist/assets/drawing-2d-DoxKMqbO.js                     71.45 kB │ gzip:    20.98 kB
 dist/assets/zip-DBEtpeu6.js                            97.03 kB │ gzip:    30.09 kB
 dist/assets/arrow-CZ5kQ26f.js                         208.84 kB │ gzip:    50.09 kB
-dist/assets/sandbox-jez21HtV.js                       384.96 kB │ gzip:    62.02 kB
+dist/assets/sandbox-Baez7n-t.js                       385.25 kB │ gzip:    62.52 kB
 dist/assets/maplibre-gl-CGLcoNXc.js                 1,046.19 kB │ gzip:   282.97 kB
-dist/assets/exporters-B_OBqIyD.js                   2,889.87 kB │ gzip:   157.97 kB
+dist/assets/exporters-BraHBeoi.js                   2,914.25 kB │ gzip:   163.62 kB
 dist/assets/epsg-index.generated-BjJrt_0S.js        4,284.21 kB │ gzip:   440.44 kB
-dist/assets/index-BKq-M3Mk.js                       5,258.30 kB │ gzip:   949.82 kB
+dist/assets/index-BOi3BuUI.js                       5,341.23 kB │ gzip:   964.43 kB
 dist/assets/cesium-DUOzBlqv.js                      5,543.11 kB │ gzip: 1,373.81 kB
 [vite-plugin-static-copy] Copied 4 items.
-✓ built in 55.14s
+✓ built in 1m

package/.turbo/turbo-typecheck.log

@@ -1,4 +1,4 @@
 
-> @ifc-lite/viewer@1.18.0 typecheck /home/runner/work/ifc-lite/ifc-lite/apps/viewer
+> @ifc-lite/viewer@1.19.0 typecheck /home/runner/work/ifc-lite/ifc-lite/apps/viewer
 > tsc --noEmit
 

package/CHANGELOG.md

@@ -1,5 +1,441 @@
 # @ifc-lite/viewer
 
+## 1.19.0
+
+### Minor Changes
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - E57 reader (subset) + clear errors when users drop unsupported formats.
+
+  **E57 (ASTM E2807-11) reader.**
+
+  - 48-byte FileHeader parser (`ASTM-E57` magic + xmlPhysicalOffset/Length
+    - pageSize).
+  - Page-CRC stripping: every 1024-byte physical page ends with 4 bytes
+    of CRC32-C; we strip them to get the logical view that XML offsets
+    reference. CRCs aren't validated (faster + still correct on
+    well-formed files).
+  - XML parser via `DOMParser` walks `e57Root → data3D → vectorChild` and
+    extracts each scan's record count, binary fileOffset, and prototype
+    fields.
+  - Binary section decoder walks DataPackets, reads bytestream length
+    table, decodes uncompressed Float32 / Float64 cartesianX/Y/Z plus
+    optional Float colors and Integer u8 colorRed/Green/Blue.
+  - ScaledIntegerNode encoding throws a clear error so the host can guide
+    the user to a Float-encoded export.
+
+  **Drop UX.** Dropping a file we can't load (Recap `.rwp/.rwi/.rwcx/.dmt`,
+  `.skp`, `.zip`, Faro `.fls`, ASCII `.pts/.xyz`) now shows an
+  explanatory toast describing what the format is and what to do
+  (typically: "export to E57 / LAS / PLY"). Previously the drop was
+  silently rejected.
+
+  **File picker** accepts `.e57` in browser drop, the native dialog, and
+  the recent-files command palette.
+
+  7 new pointcloud unit tests cover the FileHeader parser, page-CRC
+  stripping (full pages and partial trailing page), the binary packet
+  walker on a hand-built single-packet scan with Float64 cartesianX/Y/Z
+
+  - uint8 RGB, and the ScaledInteger error path.
+
+  Tests: 48 pointcloud unit tests pass, full repo typecheck (24/24),
+  test suite green (22 runs), viewer Vite build emits decode-worker
+  chunk correctly.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Fix LAZ loading + add PLY / PCD as standalone formats; sliders feel
+  responsive on first contact.
+
+  **LAZ silently failed to load.** `laz-perf` is shipped as CommonJS,
+  which Vite/webpack wrap under `.default` differently across builds.
+  The previous probe only checked `lazPerf.createLazPerf` and
+  `lazPerf.default` (as a function), so all real-world LAZ loads threw
+  "could not find createLazPerf factory". The probe now walks four
+  candidate shapes (named export, `default.createLazPerf`, `default` as
+  function, namespace-as-function) and reports the visible keys when
+  none match.
+
+  **PLY + PCD now load directly.** Two new streaming sources backed by
+  the existing format decoders:
+
+  - `PlyStreamingSource` — ASCII + binary little/big-endian, optional
+    RGB (uchar) + intensity. Header probe (64 KB) + whole-file decode.
+  - `PcdStreamingSource` — wraps `decodePcd` (already supported PCD
+    ASCII / binary / binary_compressed via inline LZF).
+
+  Both use stride downsampling for the host's 25M-point cap.
+
+  **Format detection** sniffs `.ply` (magic "ply"), `.pcd` (`# .P` or
+  `.PCD` token), and the existing `.las/.laz` paths.
+
+  **File picker** accepts `.ply` and `.pcd` in browser drop, the native
+  dialog, and the recent-files command palette.
+
+  **Slider UX.** Default size mode is now `fixed-px` (was `attenuated`).
+  The previous default felt inert because the slider in `attenuated` mode
+  is the upper _cap_ on adaptive sizing — at typical wide views the
+  projected world-radius sat well below the cap, so dragging the slider
+  1↔20 px never engaged. `fixed-px` always uses the slider value, and
+  "Auto" is one click away when users want adaptive behaviour.
+
+  **Worker URL fix.** `worker-client.ts` now imports
+  `./decode-worker.ts` (matching geometry's pattern) so Vite's worker
+  plugin resolves through the source-alias path. The package's build
+  script post-rewrites that to `.js` for dist consumers.
+
+  Tests: 41 pointcloud unit tests pass (7 new for PLY ascii/binary +
+  header probe + truncation), full repo typecheck (24/24), full test
+  suite (22 runs green), viewer Vite build emits the decode-worker
+  chunk correctly.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Phases 1–4 of point cloud loading.
+
+  - **LAS streaming** (`.las` files) — header parser + per-point record decoder
+    for ASPRS Point Data Formats 0–10, with auto-detection of "8-bit RGB
+    in u16 channels" producers and on-the-fly rescaling.
+  - **LAZ streaming** (`.laz` files) — wraps `laz-perf` (Apache-2.0) as a
+    runtime dep, decoded inside a Web Worker so the main thread stays
+    responsive.
+  - **Streaming pipeline** — Blob-backed byte source, decode worker with a
+    postMessage protocol that ships chunks back as transferable typed-array
+    buffers, host-side controller that paces decode, applies a 25M-point
+    memory cap with stride downsampling, and reports progress / completion.
+  - **Renderer streaming API** — `Renderer.beginPointCloudStream`,
+    `appendPointCloudChunk`, `endPointCloudStream`, `removePointCloudAsset`,
+    `setPointCloudOptions`. Streamed assets coexist with IFCx-derived
+    assets in separate ownership buckets so `setPointClouds` doesn't clobber
+    active streams.
+  - **Color modes** — `rgb` / `classification` (ASPRS palette) / `intensity` /
+    `height` (cool-warm ramp) / `fixed`. Per-point classification + intensity
+    travel through the GPU vertex layout and the WGSL shader picks the
+    channel based on the active mode uniform.
+  - **Viewer integration** — file picker accepts `.las,.laz` (browser drop +
+    native dialog), a small bottom-left panel exposes the color modes when
+    point clouds are loaded, and the federation registry's `modelIndex`
+    flows through streaming ingest for multi-model picking parity.
+
+  GPU-based point picking is deferred to a follow-up; clicks on points
+  return null and don't crash existing mesh selection.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Point cloud rendering quality: splat pipeline + Eye-Dome Lighting.
+
+  The 1-pixel `point-list` rendering looked great from far away but turned
+  into a halftone screen as you zoomed in — `point-list` topology has no
+  `gl_PointSize` equivalent in WebGPU, so density was fixed in screen space.
+
+  This swaps the pipeline for instanced 6-vertex quad splats and adds a
+  post-pass EDL for depth perception.
+
+  **Splat pipeline**
+
+  - `topology: 'triangle-list'`, vertex buffer `stepMode: 'instance'`,
+    6 verts emitted per source point. Vertex shader picks a corner from
+    `vertex_index` and inflates clip-space position by the active size.
+  - Three size modes:
+    - `fixed-px` — every splat is N pixels (1..20)
+    - `adaptive-world` — splat covers a world-space radius, projected each
+      frame; closer = bigger
+    - `attenuated` (default) — adaptive but clamped to [1, N] px so splats
+      stay visible at far plane and don't blow up to half the screen up close
+  - Round shape: fragment discards corners outside the unit disc, so splats
+    render as discs not squares.
+
+  **Eye-Dome Lighting**
+
+  - New `EdlPass` runs after the existing PostProcessor. Samples 4 (low) or
+    8 (high) neighbouring depths at radius R px, computes mean log-depth-
+    diff, darkens by `1 - exp(-300 * meanLog * strength)`. ~9 texture taps
+    per pixel. Only active when point clouds are loaded.
+  - Reverse-Z aware (`max(0, log(centre) - log(neighbour))`), early-out at
+    the far plane.
+
+  **UI**
+
+  - `PointCloudPanel` gains size-mode buttons, a 1–20 px slider, a 1–100 mm
+    world-radius slider (visible in adaptive/attenuated modes), and an EDL
+    toggle with a 0–3 strength slider.
+  - New `pointCloudSlice` fields: `pointCloudSizeMode`, `pointCloudPointSize`,
+    `pointCloudWorldRadius`, `pointCloudRoundShape`, `pointCloudEdlEnabled`,
+    `pointCloudEdlStrength`. Slice clamps numeric ranges.
+
+  Renderer API additions: `setEdlOptions({enabled, strength, radiusPx,
+highQuality})`. `setPointCloudOptions` now also accepts `sizeMode`,
+  `worldRadius`, `roundShape`.
+
+### Patch Changes
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Three Codex review fixes on the streaming ingest path.
+
+  **Streamed point cloud assets leaked across model removal.** The
+  renderer handle returned from `beginPointCloudStream` was discarded,
+  and streamed nodes are intentionally outside the IFCx
+  `setPointClouds` bucket, so removing a model left the GPU buffers
+  allocated for the rest of the session. `FederatedModel` now carries
+  an optional `pointCloudHandleId`; both ingest sites populate it; a
+  new `usePointCloudLifecycle` hook diffs the model map on every
+  change and frees handles for models that disappear.
+
+  **Double cleanup on ingest failure.** The outer `try/catch` in both
+  ingest sites called `removePointCloudAsset` + `incCount(-1)`, but
+  `ingestPointCloud`'s `onError` already does the same before
+  rethrowing. The duplicate cleanup pushed the asset counter negative
+  and caused a "remove twice" warning. The outer `catch` now only
+  handles store / UI state.
+
+  **PCD header probe.** The streaming source used the file's reported
+  size as the upper bound for the header probe; on truncated files
+  that walked off the end with a confusing error. Capped the probe at
+  4 KiB so malformed PCD headers fail with a clear "header > 4 KiB"
+  message.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Fix two regressions that prevented point clouds from rendering in the viewer:
+
+  1. **IFCx samples extracted zero points.** The entity extractor required
+     `bsi::ifc::class` on every node before assigning an `expressId`, but the
+     buildingSMART Point*Cloud*\*.ifcx fixtures place `pcd::base64` /
+     `points::array` / `points::base64` on nodes that carry only USD
+     `xformop`. Those nodes now also become first-class entities (synthetic
+     `IfcGeographicElement` type) so the point cloud extractor can emit
+     them. Added regression assertions in `verify-dist-hello-wall.mjs`.
+
+  2. **`.las` / `.laz` files were silently ignored on single-file load.**
+     The drop / picker single-file path goes through `useIfcLoader.loadFile`,
+     which only branched on `ifcx` / `glb` / `ifc`. Added the LAS/LAZ branch
+     there and wired it into the streaming ingest. Camera fit-to-view now
+     triggers from `usePointCloudSync` for points-only scenes (the geometry
+     streaming hook bails out early when there are no meshes).
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Fix `TypeError: entities.getTypeName is not a function` when picking a
+  point on a streamed point cloud (LAS / LAZ / PLY / PCD / E57).
+
+  The synthetic `IfcDataStore` that `pointCloudIngest.ts` builds for
+  point-cloud-only models stubbed `entities` with only a handful of
+  methods (`getId`, `getType`, `getName`, `getGlobalId`) and used method
+  names that don't match the real `EntityTable` interface. Picking
+  selects the synthetic expressId, which routes through the regular
+  property / hover / properties-panel pipeline — that pipeline calls
+  `entities.getTypeName`, `entities.getTypeEnum`,
+  `properties.getForEntity`, etc., and crashed on the missing
+  `getTypeName`.
+
+  `emptyDataStore()` now produces a stub that matches the real shape:
+
+  - `entities`: `count=1`, `expressId=Uint32Array([id])`, `typeEnum`,
+    plus `getTypeName` → `'IfcGeographicElement'`, `getName` → file
+    name, `getGlobalId` → `pointcloud-<id>`, and `getTypeEnum`,
+    `getByType`, `hasGeometry`, `getExpressIdByGlobalId`,
+    `getGlobalIdMap` covered.
+  - `properties`: real `PropertyTable` shape — `entityIndex`,
+    `psetIndex`, `propIndex`, `getForEntity`, `getPropertyValue`,
+    `findByProperty` (all empty / no-op).
+  - `quantities` / `relationships`: matching empty stubs.
+  - `entityIndex.byType` includes `IFCGEOGRAPHICELEMENT → [id]` so type
+    filters resolve.
+
+  `emptyDataStore` now takes the synthetic `expressId` and `fileName` so
+  the stub round-trips real data instead of `undefined`.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Round 3 of point cloud fixes — correctness gaps that block multi-model
+  sessions and silent rendering stalls.
+
+  **Federation relabel for streamed point clouds.**
+  `ingestPointCloud` now emits a synthetic entry on
+  `geometryResult.pointClouds`. Without this, `useIfcFederation`'s
+  `idOffset` fold + `relabelPointCloudAsset` call never fired for
+  LAS/LAZ/PLY/PCD/E57 streams, so picked `expressId`s for streamed
+  assets collided across federated models.
+
+  **Sync-throw cleanup.** Wrap `streamPointCloud()` in `try/catch`
+  inside `ingestPointCloud`. The renderer asset and asset-count
+  increment happen before the worker spins up, so a sync throw during
+  validation/worker setup used to leak both. We now `removePointCloudAsset`
+
+  - `onCountChange(-1)` before re-throwing.
+
+  **`setPointClouds()` shrinks bounds correctly.** The replace path
+  called `expandModelBoundsForPointClouds` (grow-only). Reloading IFCx
+  with a smaller scan kept stale extents until `clear`. Switched to
+  `recomputeModelBounds()` so bounds re-baseline from current state.
+
+  **`requestRender()` after every mutation.** `appendPointCloudChunk`,
+  `setPointCloudOptions`, `setEdlOptions`, `setPointClouds`,
+  `addPointClouds`, `clearPointClouds`, `removePointCloudAsset`,
+  `endPointCloudStream` now schedule a frame. Previously streamed
+  chunks could sit invisible until an unrelated camera move triggered
+  the next render.
+
+  **Worker cancel race.** `worker-client.next()` now re-checks
+  `signal.aborted` after `await session.send()`. A chunk that won the
+  race against `cancel()` would otherwise still call `onChunk` after
+  the host returned to the caller.
+
+  **Multi-scan E57 rejection.** `parseE57Xml` now records `hasPose` per
+  Data3D entry. `decodeE57` rejects multi-scan files where any entry
+  carries a `<pose>` element, with a clear "registered multi-scan;
+  re-export as merged" error. Previously such files silently
+  concatenated in scan-local space and rendered misaligned.
+
+  Verified: 62 pointcloud unit tests (1 new for pose flag), full repo
+  typecheck (24/24), viewer Vite build green.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Address CodeRabbit + Codex review feedback on PR #608.
+
+  Critical visual / correctness fixes:
+
+  - Point splats rendered ~2× too large because the shader treated the
+    user-facing `pointSizePx` (diameter) as the splat radius. Fixed in
+    both the live splat shader and the picker shader so click targets
+    match the rendered disc.
+  - Routed every detected point-cloud format (`ply`, `pcd`, `e57`) through
+    the streaming ingest in both `useIfcLoader` (single-file drop) and
+    `useIfcFederation` (multi-file). Previously only `las/laz` got the
+    pointcloud branch; `ply/pcd/e57` fell through into the IFC STEP path.
+  - Federation: applied `idOffset` to `geometryResult.pointClouds` too so
+    multi-pointcloud-model loads don't collide on local `expressId`.
+  - `expressId` defaulted to `1` on every ingest, so multiple inline LAS
+    loads collided. Now uses a process-local synthetic counter.
+  - E57 integer color channels are commonly u16 (0..65535); reader was
+    forcing u8 reads, distorting RGB. Now picks element width from the
+    declared min/max range.
+  - PCD `applyStride` preserved positions + colors but dropped intensity
+    and classification, so those color modes silently broke on files
+    past the 25M-point downsample cap.
+  - Inline `uploadAssetToGpu` forwards `intensities` + `classifications`
+    (added to `PointCloudAsset.chunk` shape).
+  - Model bounds recomputed after `removePointCloudAsset` /
+    `clearPointClouds` — previously stayed oversized, breaking
+    fit-to-view and section sliders.
+  - `usePointCloudLifecycle` disposes a model's GPU asset when the model
+    stays in the store but its `pointCloudHandleId` changes (re-stream of
+    the same file used to leak the old handle).
+  - `resetViewerState` now clears the point-cloud slice runtime fields so
+    loading a new file doesn't inherit the previous file's color mode /
+    size / EDL state.
+
+  Correctness / robustness:
+
+  - `streamPointCloud`'s host now closes the source on probe + onOpen
+    failures (single try/finally wrapping the whole open-and-decode
+    flow), so worker-backed sources don't leak the decoder on parse
+    errors or aborts.
+  - `worker-client.close()` clears cached `info`; subsequent `open()`
+    actually re-opens instead of returning stale info next to a null
+    `sourceId`.
+  - `LasStreamingSource.open()` and `LazStreamingSource.open()` are
+    atomic on failure: state is committed only after every step
+    succeeds, so a retry rerruns the probe + RGB-scale detection
+    cleanly. LAZ also frees malloc'd wasm pointers in the catch path.
+  - PLY decoder rejects files where `vertex` isn't the first element
+    (decoder reads from `header.bodyOffset`; non-leading vertex would
+    silently produce garbage).
+  - `decodePointsArray` validates each `colors[i]` is a `[r,g,b]` triple
+    before indexing, so malformed schemas fail with a clear message.
+  - `useIfcLoader` LAS/LAZ/PLY/PCD/E57 branch is guarded by
+    `loadSessionRef` on both error and success paths so a newer load can
+    replace an in-flight one without overwriting the newer model state;
+    stale renderer handle is freed.
+
+  Critical webhook fixes:
+
+  - `ViewportOverlays.tsx` had three imports between executable code;
+    hoisted them above the `const isDesktop = isTauri()` declaration.
+  - `edl-pass.ts` used `0u` for `texture_depth_multisampled_2d`'s
+    `sample_index`; WGSL spec requires `i32`.
+  - `pcd.test.ts` switched from `__dirname` to
+    `fileURLToPath(import.meta.url)` so it works outside vitest's
+    CommonJS-compat shim.
+
+  UX polish:
+
+  - `PointCloudPanel` toggle buttons expose `aria-pressed` so screen
+    readers announce the active option.
+  - `pointCloudSlice` setters reject `NaN`/`Infinity` (Math.min/max
+    passes them through unchanged).
+  - `BlobByteSource.read` clamps a negative `start` to `0`.
+  - File-dialog filters split GLB out of the IFC bucket into a "Mesh
+    Files" group.
+
+  The flattenMatrix transpose flagged in the review is actually correct
+  for USD's row-major-with-translation-in-row-3 convention (verified by
+  inspecting the Point_Cloud_S1 sample's transform; the rendered scan is
+  at the right world position). Added a clarifying comment so future
+  reviewers don't reach for the wrong fix.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Round 2 of CodeRabbit review fixes — correctness + robustness.
+
+  P1 (real correctness):
+
+  - Federation: streamed point clouds now get the post-`idOffset` global
+    expressId in picking output. New `Renderer.relabelPointCloudAsset()`
+    updates a per-asset uniform (`flags.x`) the shader prefers over the
+    per-vertex attribute, so federation is just a metadata write — no
+    GPU buffer rewrite. `useIfcFederation.addModel` calls it after the
+    pointClouds offset is applied.
+  - Section-plane range now folds in `pointCloudRenderer.getBounds()`, so
+    pure point-cloud scenes don't fall through to `[-100, 100]` and mixed
+    scenes don't clip points outside a smaller mesh-only range.
+  - `recomputeModelBounds()` now recomputes from scratch (mesh baseline +
+    current pc bounds) instead of growing-only. Previously, removing one
+    of several point clouds left stale oversized extents until every
+    point cloud was gone.
+  - `streamPointCloud` validates `chunkSize > 0` upfront; `LasStreamingSource`
+    and `LazStreamingSource` reject `maxPoints <= 0`. Prevents
+    zero-progress decode loops from accidental misuse.
+  - E57 merge uses `some()` instead of `every()`; mixed-attribute files
+    no longer drop colour/intensity for the whole merged cloud just
+    because one scan lacks the channel.
+  - E57 intensity is now allocated for `Integer`-encoded prototypes too
+    (was silently dropped); `ScaledInteger` throws a clear error.
+
+  P2 (robustness):
+
+  - `xml-mini` rejects truncated input — unclosed elements throw instead
+    of silently returning a partial tree.
+  - `worker-client.next()` now sends a `kind: 'abort'` to the worker when
+    the signal fires mid-flight. Previously cancel returned to the caller
+    while the worker kept decoding.
+  - `decodePointsArray` rejects empty arrays (was producing ±Infinity
+    bbox); `decodePointsBase64` rejects empty strings (no silent
+    downgrade to uncoloured cloud).
+  - `transformPositionsZUpToYUp` guards against zero / non-finite
+    homogeneous `w` (malformed `usd::xformop` matrices).
+
+  P3 (polish):
+
+  - `POINT_CLOUD_DEFAULTS` is now an exported constant shared by the
+    slice initializer and `resetViewerState`, so the two paths can't
+    drift.
+  - Replaced `as any` cast around `AbortSignal.any` with a typed
+    intersection.
+  - Doc comment on `pointCloudSizeMode` now matches the actual default
+    (`fixed-px`).
+
+  Verified: 61 pointcloud unit tests pass, full repo typecheck (24/24),
+  test suite green (22 runs), viewer Vite build emits decode-worker
+  chunk correctly.
+
+- [#608](https://github.com/louistrue/ifc-lite/pull/608) [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1) Thanks [@louistrue](https://github.com/louistrue)! - Streaming point clouds (LAS / LAZ / PLY / PCD / E57) now arrive in
+  the renderer's Y-up convention, matching the IFCx ingest path.
+
+  Without this, scans rendered rotated 90° onto their side because the
+  renderer is Y-up internally and LIDAR / surveying formats store data
+  Z-up by convention. The IFCx path applied the swap inside
+  `pointcloud-extractor.ts`; the streaming path went straight from the
+  worker's decoded chunk into `appendPointCloudChunk`, skipping the
+  swap.
+
+  `ingestPointCloud` now wraps `onChunk` to re-orient positions and
+  bbox before forwarding to the renderer:
+  Z-up: X=right, Y=forward, Z=up
+  Y-up: X=right, Y=up, Z=back (negate Y to keep right-hand rule)
+
+  Mirrors the geometry / pointcloud extractors' existing handling.
+
+- Updated dependencies [[`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1), [`0b8c860`](https://github.com/louistrue/ifc-lite/commit/0b8c860d3e13c8b498c515854db74e0850ce59f1)]:
+  - @ifc-lite/pointcloud@0.2.0
+  - @ifc-lite/renderer@1.18.0
+  - @ifc-lite/geometry@1.17.0
+  - @ifc-lite/parser@2.3.0
+
 ## 1.18.0
 
 ### Minor Changes

package/dist/assets/{basketViewActivator-Cm1QEk_R.js → basketViewActivator-RZy5c3Td.js}

@@ -1 +1 @@
-import{u as o}from"./index-BKq-M3Mk.js";import"./cesium-DUOzBlqv.js";import"./arrow-CZ5kQ26f.js";import"./exporters-B_OBqIyD.js";import"./bcf-DOG9_WPX.js";import"./zip-DBEtpeu6.js";import"./sandbox-jez21HtV.js";import"./lens-CSASnhAL.js";import"./drawing-2d-DoxKMqbO.js";import"./server-client-ncOQVNso.js";import"./ids-DQ5jY0E8.js";const n=700;function v(s){const e=o.getState(),i=e.basketViews.find(t=>t.id===s);if(i){if(e.setDrawing2D(null),e.setDrawing2DPanelVisible(!1),e.updateDrawing2DDisplayOptions({show3DOverlay:!1}),e.clearEntitySelection(),e.restoreBasketEntities(i.entityRefs,s),i.viewpoint){const t=i.transitionMs??n;e.cameraCallbacks.applyViewpoint?.(i.viewpoint,!0,t)}if(i.section){const t=i.section;o.setState({sectionPlane:{...t.plane},drawing2DPanelVisible:!1}),t.plane.enabled?(e.activeTool!=="section"&&e.setSuppressNextSection2DPanelAutoOpen(!0),e.setActiveTool("section")):e.activeTool==="section"&&e.setActiveTool("select")}else{const t=o.getState().sectionPlane;o.setState({sectionPlane:{...t,enabled:!1}}),e.activeTool==="section"&&e.setActiveTool("select")}}}export{v as activateBasketViewFromStore};
+import{u as o}from"./index-BOi3BuUI.js";import"./cesium-DUOzBlqv.js";import"./arrow-CZ5kQ26f.js";import"./exporters-BraHBeoi.js";import"./bcf-DOG9_WPX.js";import"./zip-DBEtpeu6.js";import"./sandbox-Baez7n-t.js";import"./lens-CSASnhAL.js";import"./drawing-2d-DoxKMqbO.js";import"./server-client-BB6cMAXE.js";import"./ids-DQ5jY0E8.js";const n=700;function v(s){const e=o.getState(),i=e.basketViews.find(t=>t.id===s);if(i){if(e.setDrawing2D(null),e.setDrawing2DPanelVisible(!1),e.updateDrawing2DDisplayOptions({show3DOverlay:!1}),e.clearEntitySelection(),e.restoreBasketEntities(i.entityRefs,s),i.viewpoint){const t=i.transitionMs??n;e.cameraCallbacks.applyViewpoint?.(i.viewpoint,!0,t)}if(i.section){const t=i.section;o.setState({sectionPlane:{...t.plane},drawing2DPanelVisible:!1}),t.plane.enabled?(e.activeTool!=="section"&&e.setSuppressNextSection2DPanelAutoOpen(!0),e.setActiveTool("section")):e.activeTool==="section"&&e.setActiveTool("select")}else{const t=o.getState().sectionPlane;o.setState({sectionPlane:{...t,enabled:!1}}),e.activeTool==="section"&&e.setActiveTool("select")}}}export{v as activateBasketViewFromStore};