@ifc-lite/renderer 1.50.0 → 2.0.0

package/dist/index.js

@@ -8,7 +8,7 @@ export { WebGPUDevice } from './device.js';
 export { RenderPipeline } from './pipeline.js';
 export { Camera } from './camera.js';
 export { pickFitPolicy } from './camera-fit-policy.js';
-export { Scene } from './scene.js';
+// `Scene` is NOT exported: an exported class republishes every method `SceneContents` above just froze.
 export { Picker } from './picker.js';
 export { MathUtils } from './math.js';
 // The orthonormal camera basis `MathUtils.lookAt` renders through, exposed so
@@ -19,7 +19,7 @@ export { MathUtils } from './math.js';
 // is the same situation from outside it).
 export { viewBasis } from './math.js';
 export { SectionPlaneRenderer } from './section-plane.js';
-export { Section2DOverlayRenderer } from './section-2d-overlay.js';
+// `Section2DOverlayRenderer` is NOT exported: `Renderer.setLineOverlay` and the section cap drive it from inside. Its types below stay published.
 // IfcAnnotation overlay pipelines (3D world-space). Self-contained — caller
 // passes a GPUDevice + presentation format and invokes `.render(pass, viewProj)`
 // from inside an RGBA-blended pass. See packages/renderer/src/symbolic-overlay-pipelines.ts.
@@ -30,14 +30,13 @@ export { SymbolicTextAtlas } from './symbolic-text-atlas.js';
 // holds the styling primitives shared with the store and UI.
 export { DEFAULT_CAP_STYLE, HATCH_PATTERN_IDS } from './section-cap-style.js';
 export { planeBasis, nearestCardinalAxis } from './section-plane-basis.js';
+export { LINE_OVERLAY_CHANNELS } from './section-2d-overlay.js';
 export { Raycaster } from './raycaster.js';
 export { SnapDetector, SnapType } from './snap-detector.js';
 export { BVH } from './bvh.js';
 export { FederationRegistry, federationRegistry } from './federation-registry.js';
 export * from './types.js';
 export { resolveEnvironment, deriveSkyGradient, packEnvironmentUniforms, ENVIRONMENT_UNIFORM_SIZE, } from './environment.js';
-// Extracted manager classes
-export { PickingManager } from './picking-manager.js';
 export { resolveContributionThresholdPx, projectedAabbRadiusPx } from './contribution-cull.js';
 export { chunkCellKey, bucketBaseKeyFor, DEFAULT_CHUNK_CELL_SIZE } from './chunk-grid.js';
 export { selectEvictions, MIN_EVICTION_AGE_FRAMES } from './residency.js';
@@ -71,6 +70,7 @@ import { RenderPipeline } from './pipeline.js';
 import { Camera } from './camera.js';
 import { Scene } from './scene.js';
 import { Picker } from './picker.js';
+import { reportableItemId } from './pick-resolve.js';
 import { MathUtils, viewBasis } from './math.js';
 import { FrustumUtils } from '@ifc-lite/spatial';
 import { VisualEnhancementResolver } from './visual-enhancement.js';
@@ -1283,6 +1283,11 @@ export class Renderer {
         this.scene.addMesh({
             expressId: meshData.expressId,
             modelIndex: meshData.modelIndex, // Preserve modelIndex for multi-model selection
+            // Source item, so a pick can report it (#2985) — via the shared rule,
+            // so this and the CPU raycaster cannot answer one click two ways.
+            // In-tree callers pre-split merged pieces (Scene.getMeshDataPieces
+            // drops the field incidentally); this is public, so it owns the rule.
+            geometryItemId: reportableItemId(meshData, meshData.expressId),
             vertexBuffer,
             indexBuffer,
             indexCount: meshData.indices.length,
@@ -3042,18 +3047,6 @@ export class Renderer {
     invalidateBVHCache() {
         this.raycastEngine.invalidateBVHCache();
     }
-    /**
-     * Get the raycaster instance (for advanced usage)
-     */
-    getRaycaster() {
-        return this.raycastEngine.getRaycaster();
-    }
-    /**
-     * Get the snap detector instance (for advanced usage)
-     */
-    getSnapDetector() {
-        return this.raycastEngine.getSnapDetector();
-    }
     /**
      * Clear all caches (call when geometry changes)
      */
@@ -3113,6 +3106,7 @@ export class Renderer {
     getCamera() {
         return this.camera;
     }
+    /** MEASURED external surface, not the 4400-line `Scene`: widening `SceneContents` is a published-API decision, not a detail — see `scene-contents.ts`. */
     getScene() {
         return this.scene;
     }
@@ -3156,63 +3150,32 @@ export class Renderer {
         this.overlays.setOverlayLineColor(color);
     }
     /**
-     * Upload pre-lifted 3D line-list vertices for the standalone annotation
-     * overlay. Each segment is `[x1, y1, z1, x2, y2, z2]` in world space.
-     * The overlay is drawn regardless of whether a section plane is active.
-     * Pass an empty Float32Array to clear.
-     */
-    uploadAnnotationLines3D(vertices) {
-        this.overlays.uploadAnnotationLines3D(vertices);
-    }
-    /**
-     * Clear the standalone annotation line overlay.
-     */
-    clearAnnotationLines3D() {
-        this.overlays.clearAnnotationLines3D();
-    }
-    /**
-     * Upload IfcAlignment centerline segments as a flat [x,y,z,x,y,z,...]
-     * line-list in world space. Rendered as thin lines (not a ribbon mesh)
-     * to match IfcGrid / IfcAnnotation. Pass an empty Float32Array to clear.
-     */
-    uploadAlignmentLines3D(vertices) {
-        this.overlays.uploadAlignmentLines3D(vertices);
-    }
-    /** Clear the alignment centerline overlay. */
-    clearAlignmentLines3D() {
-        this.overlays.clearAlignmentLines3D();
-    }
-    /**
-     * Upload structural-grid (IfcGridAxis) segments as a flat [x,y,z,x,y,z,...]
-     * line-list in world space (issue #967). Rendered as thin lines, mirroring
-     * the alignment overlay. Pass an empty Float32Array to clear.
+     * Set one standalone 3D line overlay, or clear it by passing `null`.
      *
-     * Unlike alignment, grids do NOT expand model bounds: they're behind a
-     * visibility toggle, so toggling them on must not reframe the camera (and
-     * grid axes routinely extend past the model envelope).
-     */
-    uploadGridLines3D(vertices) {
-        this.overlays.uploadGridLines3D(vertices);
-    }
-    /** Clear the structural-grid overlay. */
-    clearGridLines3D() {
-        this.overlays.clearGridLines3D();
-    }
-    /**
-     * Upload the DXF reference-layer's line paths as a flat
-     * [x,y,z,x,y,z,...] line-list in world space (issue #2043, follow-up to
-     * the 2D-only DXF underlay from #1782/#1929). Mirrors
-     * `uploadGridLines3D`: a dedicated buffer so 3D DXF visibility is
-     * independent of the 2D underlay's own toggle, and does NOT expand
-     * model bounds/reframe the camera on upload — it's behind its own
-     * visibility toggle, like grid axes. Pass an empty Float32Array to clear.
+     * `vertices` is a flat world-space line-list — `[x1,y1,z1, x2,y2,z2, …]`,
+     * one segment per six floats. The vertices are already lifted to world
+     * space, so these overlays draw whether or not a section plane is active.
+     * A trailing partial segment is dropped rather than rejecting the array.
+     * An empty array clears too, but `null` skips building the pipelines.
+     *
+     * Every channel is an independent buffer with its own visibility, so
+     * setting one leaves the other three untouched. All four share the colour
+     * set by {@link setOverlayLineColor}; label colour is per-text via
+     * `SymbolicTextInput.color` on `uploadAnnotationTexts3D`.
+     *
+     * The channels differ in exactly one way — whether they grow the scene
+     * bounds. `annotation` (#653) and `alignment` DO: a file holding only them
+     * has no IfcProduct meshes to frame, so Home / fit-to-view would have
+     * nothing to aim at and the near/far range would clip the lines away.
+     * `grid` (IfcGridAxis, #967) and `dxf` (the DXF reference layer, #2043) do
+     * NOT: they are reference layers that routinely extend past the model
+     * envelope, so growing the bounds would reframe the camera whenever one
+     * was ticked on. The rule is "does this content DEFINE the model's
+     * extent", NOT "is it behind a visibility toggle" — annotations sit behind
+     * `ifcAnnotationsVisible` too.
      */
-    uploadDxfLines3D(vertices) {
-        this.overlays.uploadDxfLines3D(vertices);
-    }
-    /** Clear the 3D DXF reference-layer overlay. */
-    clearDxfLines3D() {
-        this.overlays.clearDxfLines3D();
+    setLineOverlay(channel, vertices) {
+        this.overlays.setLineOverlay(channel, vertices);
     }
     /**
      * Show (or clear) the clash-overlap box: the wireframe AABB of a focused
@@ -3266,7 +3229,10 @@ export class Renderer {
         return this.overlays.hasSection2DOverlay();
     }
     /**
-     * Get render pipeline (for batching)
+     * Get render pipeline (for batching). DELIBERATELY NOT NARROWED, unlike
+     * `getScene()`: the measurement found ZERO external
+     * `RenderPipeline` members — all 12 call sites pass the handle straight
+     * back into a `SceneContents` upload method typed for the real class.
      */
     getPipeline() {
         return this.pipeline;
@@ -3308,7 +3274,11 @@ export class Renderer {
      *
      * Returning null instead routes into the `if (!device) return` check that
      * every call site already has, so a lost device degrades to "stop
-     * uploading" rather than an uncaught throw. See `isDeviceLost()` /
+     * uploading" rather than an uncaught throw.
+     *
+     * DELIBERATELY NOT NARROWED, unlike `getScene()`: the one external
+     * `GPUDevice` member measured is `queue`; every other call site
+     * hands the device back to a `SceneContents` method. See `isDeviceLost()` /
      * `onDeviceLost()` for the recovery contract.
      */
     getGPUDevice() {