@icgio/icg-exchanges 1.40.50 → 1.41.0

package/lib/exchanges/gate.js

@@ -10,6 +10,7 @@ const ExchangeBase = require('./exchange-base.js')
 
 const { error_codes } = require('../error_codes.json')
 const { utils, rate_limiter: Limiter } = require('@icgio/icg-utils')
+const { fetch_split_windows, sort_history_rows } = ExchangeBase.history_utils
 
 function pre_process_pair(pair) {
   let [cur, quote_cur] = utils.parse_pair(pair)
@@ -663,41 +664,55 @@ module.exports = class Gate extends ExchangeBase {
   }
   get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
     let get_history_trades_base = (pair, start_time_in_ms, end_time_in_ms, cb) => {
-      let params = {
-        currency_pair: pre_process_pair(pair),
-        from: parseInt(start_time_in_ms / 1000),
-        limit: 1000,
-        to: parseInt(end_time_in_ms / 1000),
-      }
       let [api_key, secret_key] = this.api_secret_key
-      let timestamp = parseInt(Date.now() / 1000)
-      let path = '/api/v4/spot/my_trades'
-      let sign = get_signature_gatev4('GET', path, params, secret_key, timestamp)
-      let options = get_options(api_key, timestamp, sign)
-      let url = 'https://api.gateio.ws' + path + '?' + qs.stringify(params)
-      needle.get(url, options, (err, res, body) => {
-        if (body && Array.isArray(body)) {
-          let trades = body.map((trade) => {
-            return {
-              order_id: trade.order_id,
-              pair,
-              type: trade.side,
-              price: parseFloat(trade.price),
-              amount: parseFloat(trade.amount),
-              total: parseFloat(trade.price) * parseFloat(trade.amount),
-              close_time: new Date(parseInt(trade.create_time_ms)),
-              fees: {
-                [post_process_cur(trade.fee_currency)]: parseFloat(trade.fee),
-              },
-            }
-          })
-
-          cb({ success: true, body: trades })
-        } else if (body) {
-          cb({ success: false, error: error_codes.other, body })
-        } else {
-          cb({ success: false, error: error_codes.timeout })
-        }
+      ;(async () => {
+        const rows = await fetch_split_windows({
+          start_ms: start_time_in_ms,
+          stop_ms: end_time_in_ms,
+          initial_window_ms: Math.max(end_time_in_ms - start_time_in_ms, 60 * 1000),
+          page_limit: 1000,
+          fetch_window: async (window_start_ms, window_stop_ms) =>
+            await new Promise((resolve, reject) => {
+              let params = {
+                currency_pair: pre_process_pair(pair),
+                from: parseInt(window_start_ms / 1000),
+                limit: 1000,
+                to: parseInt(window_stop_ms / 1000),
+              }
+              let timestamp = parseInt(Date.now() / 1000)
+              let path = '/api/v4/spot/my_trades'
+              let sign = get_signature_gatev4('GET', path, params, secret_key, timestamp)
+              let options = get_options(api_key, timestamp, sign)
+              let url = 'https://api.gateio.ws' + path + '?' + qs.stringify(params)
+              needle.get(url, options, (err, res, body) => {
+                if (body && Array.isArray(body)) {
+                  resolve(
+                    body.map((trade) => ({
+                      order_id: trade.order_id,
+                      pair,
+                      type: trade.side,
+                      price: parseFloat(trade.price),
+                      amount: parseFloat(trade.amount),
+                      total: parseFloat(trade.price) * parseFloat(trade.amount),
+                      close_time: new Date(parseInt(trade.create_time_ms)),
+                      fees: {
+                        [post_process_cur(trade.fee_currency)]: parseFloat(trade.fee),
+                      },
+                      role: trade.role,
+                    })),
+                  )
+                } else if (body) {
+                  reject({ error: error_codes.other, body })
+                } else {
+                  reject({ error: error_codes.timeout })
+                }
+              })
+            }),
+        })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(merged) })
+      })().catch((error) => {
+        cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
       })
     }
     this.private_limiter.process(get_history_trades_base, pair, start_time_in_ms, end_time_in_ms, cb)

package/lib/exchanges/gemini.js

@@ -422,6 +422,7 @@ module.exports = class Gemini extends ExchangeBase {
         await sleep(250)
       }
       trades = sort_history_rows(filter_history_in_range(trades, start_time_in_ms, end_time_in_ms))
+      trades = utils.merge_trades_with_same_id(trades)
       cb({ success: true, body: trades })
     })().catch((error) => cb(error))
   }

package/lib/exchanges/hashkey.js

@@ -532,6 +532,7 @@ module.exports = class Hashkey extends ExchangeBase {
         delay_ms: 250,
       })
       trades = sort_history_rows(filter_history_in_range(trades, start_time_in_ms, end_time_in_ms))
+      trades = utils.merge_trades_with_same_id(trades)
       cb({ success: true, body: trades })
     })().catch((error) => cb(error))
   }

package/lib/exchanges/hashkeyglobal.js

@@ -520,6 +520,7 @@ module.exports = class Hashkeyglobal extends ExchangeBase {
         delay_ms: 250,
       })
       trades = sort_history_rows(filter_history_in_range(trades, start_time_in_ms, end_time_in_ms))
+      trades = utils.merge_trades_with_same_id(trades)
       cb({ success: true, body: trades })
     })().catch((error) => cb(error))
   }

package/lib/exchanges/hitbtc.js

@@ -6,6 +6,7 @@ const needle = require('needle')
 const ExchangeWs = require('./exchange-ws.js')
 
 const ExchangeBase = require('./exchange-base.js')
+const { fetch_split_windows, sort_history_rows } = ExchangeBase.history_utils
 
 const { error_codes } = require('../error_codes.json')
 const { utils, rate_limiter: Limiter } = require('@icgio/icg-utils')
@@ -651,34 +652,50 @@ module.exports = class Hitbtc extends ExchangeBase {
     })
   }
   get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
-    let from = new Date(start_time_in_ms).toISOString(),
-      end = new Date(end_time_in_ms).toISOString()
-    let params = {
-      from: from,
-      symbol: pre_process_pair(pair),
-      till: end,
-    }
-    let url = `https://api.hitbtc.com/api/3/spot/history/trade?` + qs.stringify(params)
-    this.private_limiter.process(needle.get, url, get_signature_hitbtc(this.api_secret_key), (err, res, body) => {
-      if (body && Array.isArray(body) && body[0]) {
-        let result = body.map((o) => {
-          return {
-            order_id: o.client_order_id.toString(),
-            pair: post_process_pair(o.symbol),
-            type: o.side,
-            price: parseFloat(o.price),
-            amount: parseFloat(o.quantity),
-            total: parseFloat(o.price) * parseFloat(o.quantity),
-            close_time: new Date(o.timestamp),
-          }
+    let get_history_trades_base = (pair, start_time_in_ms, end_time_in_ms, cb) => {
+      ;(async () => {
+        const rows = await fetch_split_windows({
+          start_ms: start_time_in_ms,
+          stop_ms: end_time_in_ms,
+          initial_window_ms: Math.max(end_time_in_ms - start_time_in_ms, 60 * 1000),
+          page_limit: 1000,
+          fetch_window: async (window_start_ms, window_stop_ms) =>
+            await new Promise((resolve, reject) => {
+              let params = {
+                from: new Date(window_start_ms).toISOString(),
+                symbol: pre_process_pair(pair),
+                till: new Date(window_stop_ms).toISOString(),
+                limit: 1000,
+              }
+              let url = `https://api.hitbtc.com/api/3/spot/history/trade?` + qs.stringify(params)
+              needle.get(url, get_signature_hitbtc(this.api_secret_key), (err, res, body) => {
+                if (body && Array.isArray(body)) {
+                  resolve(
+                    body.map((o) => ({
+                      order_id: o.client_order_id.toString(),
+                      pair: post_process_pair(o.symbol),
+                      type: o.side,
+                      price: parseFloat(o.price),
+                      amount: parseFloat(o.quantity),
+                      total: parseFloat(o.price) * parseFloat(o.quantity),
+                      close_time: new Date(o.timestamp),
+                    })),
+                  )
+                } else if (body) {
+                  reject({ error: error_codes.other, body })
+                } else {
+                  reject({ error: error_codes.timeout })
+                }
+              })
+            }),
         })
-        cb({ success: true, body: result })
-      } else if (body) {
-        cb({ success: false, error: error_codes.other, body })
-      } else {
-        cb({ success: false, error: error_codes.timeout })
-      }
-    })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(merged) })
+      })().catch((error) => {
+        cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
+      })
+    }
+    this.private_limiter.process(get_history_trades_base, pair, start_time_in_ms, end_time_in_ms, cb)
   }
   // get_all_trades_ws (timeframe_in_ms, cb) {
   //

package/lib/exchanges/hkbitex.js

@@ -557,9 +557,7 @@ module.exports = class Hkbitex extends ExchangeBase {
     }
     this.private_limiter.process(get_trades_base, pair, timeframe_in_ms, cb)
   }
-  get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
-    this._get_history_trades_via_timeframe(pair, start_time_in_ms, end_time_in_ms, cb)
-  }
+  // get_history_trades — not implemented, no native absolute-window endpoint
   static get_precision(cb) {
     let price_precision = {},
       amount_precision = {}

package/lib/exchanges/htx.js

@@ -515,7 +515,7 @@ module.exports = class Htx extends ExchangeBase {
                 price: parseFloat(t.price),
                 amount: parseFloat(t['filled-amount']),
                 total: parseFloat(t['filled-amount']) * parseFloat(t.price),
-                open_time: new Date(t['created-at']),
+                close_time: new Date(t['created-at']),
                 fees: {
                   [post_process_cur(t['fee-currency'])]: parseFloat(t['filled-fees']),
                 },
@@ -525,7 +525,7 @@ module.exports = class Htx extends ExchangeBase {
               if (trade_id != null) trade.trade_id = trade_id.toString()
               return trade
             })
-            .filter((t) => t.open_time > new Date() - timeframe_in_ms)
+            .filter((t) => t.close_time > new Date() - timeframe_in_ms)
           trades = utils.merge_trades_with_same_id(trades)
           cb({ success: true, body: trades })
         } else if (body && body.status === 'error' && body['err-code'] === 'api-signature-not-valid') {
@@ -607,7 +607,8 @@ module.exports = class Htx extends ExchangeBase {
               })
             }),
         })
-        cb({ success: true, body: sort_history_rows(rows) })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(merged) })
       })().catch((error) => {
         cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
       })

package/lib/exchanges/indodax.js

@@ -391,9 +391,7 @@ module.exports = class Indodax extends ExchangeBase {
     }
     this.private_limiter.process(get_trades_base, pair, cb)
   }
-  get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
-    this._get_history_trades_via_timeframe(pair, start_time_in_ms, end_time_in_ms, cb)
-  }
+  // get_history_trades — not implemented, no native absolute-window endpoint
   static get_min_amount(cb) {
     let min_quote_cur_amount = {}
     needle.get('https://indodax.com/api/pairs', (err, res, body) => {

package/lib/exchanges/kraken.js

@@ -393,6 +393,7 @@ module.exports = class Kraken extends ExchangeBase {
       }
       trades = trades.filter((trade) => trade.pair === pair)
       trades = sort_history_rows(filter_history_in_range(trades, start_time_in_ms, end_time_in_ms))
+      trades = utils.merge_trades_with_same_id(trades)
       cb({ success: true, body: trades })
     })().catch((error) => cb(error))
   }

package/lib/exchanges/kucoin.js

@@ -602,7 +602,8 @@ module.exports = class Kucoin extends ExchangeBase {
             if (current_page < total_pages && trades.length > 0) {
               fetch_page(current_page + 1, all_trades)
             } else {
-              cb({ success: true, body: dedupe_history_trades(all_trades) })
+              all_trades = utils.merge_trades_with_same_id(dedupe_history_trades(all_trades))
+              cb({ success: true, body: all_trades })
             }
           } else if (body && body.code === '429000') {
             cb({ success: false, error: error_codes.service_unavailable, body })

package/lib/exchanges/lbank.js

@@ -670,7 +670,8 @@ module.exports = class Lbank extends ExchangeBase {
             await sleep(50)
           }
         }
-        cb({ success: true, body: sort_history_rows(filter_history_in_range(rows, start_time_in_ms, end_time_in_ms)) })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(filter_history_in_range(merged, start_time_in_ms, end_time_in_ms)) })
       })().catch((error) => {
         cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
       })

package/lib/exchanges/mexc.js

@@ -567,7 +567,8 @@ module.exports = class Mexc extends ExchangeBase {
               })
             }),
         })
-        cb({ success: true, body: sort_history_rows(rows) })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(merged) })
       })().catch((error) => {
         cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
       })

package/lib/exchanges/okx.js

@@ -11,6 +11,7 @@ const ExchangeWs = require('./exchange-ws.js')
 const { error_codes } = require('../error_codes.json')
 
 const { utils, rate_limiter: Limiter } = require('@icgio/icg-utils')
+const { fetch_split_windows, sort_history_rows } = ExchangeBase.history_utils
 
 let base_url = 'https://www.okx.com'
 
@@ -652,41 +653,57 @@ module.exports = class Okx extends ExchangeBase {
     this.private_limiter.process(get_all_trades_base, timeframe_in_ms, cb, 2)
   }
   get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
-    let [api_key, secret_key] = this.api_secret_key
     let get_history_trades_base = (pair, start_time_in_ms, end_time_in_ms, cb) => {
-      let params = {
-        instId: pre_process_pair(pair),
-        instType: 'SPOT',
-        begin: start_time_in_ms,
-        end: end_time_in_ms,
-      }
-      let path = '/api/v5/trade/fills-history?' + qs.stringify(params)
-      let options = get_options(api_key, secret_key, this.passphrase, 'GET', path, '')
-      needle.get(base_url + path, options, (err, res, body) => {
-        body = parse_body(body)
-        if (body && body.code === '0' && body.data) {
-          let trades = body.data.map((t) => ({
-            order_id: t.ordId.toString(),
-            ...(t.billId != null ? { trade_id: t.billId.toString() } : {}),
-            pair: post_process_pair(t.instId),
-            type: t.side,
-            price: parseFloat(t.fillPx),
-            amount: parseFloat(t.fillSz),
-            total: parseFloat(t.fillPx) * parseFloat(t.fillSz),
-            close_time: new Date(parseInt(t.ts)),
-            fees: {
-              [post_process_cur(t.feeCcy)]: -parseFloat(t.fee),
-            },
-          }))
-          trades = utils.merge_trades_with_same_id(trades)
-          cb({ success: true, body: trades })
-        } else if (body && (body.code === '50026' || body.code === '50001')) {
-          cb({ success: false, error: error_codes.service_unavailable, body })
-        } else if (body) {
-          cb({ success: false, error: error_codes.other, body })
-        } else {
-          cb({ success: false, error: error_codes.timeout })
-        }
+      let [api_key, secret_key] = this.api_secret_key
+      ;(async () => {
+        const rows = await fetch_split_windows({
+          start_ms: start_time_in_ms,
+          stop_ms: end_time_in_ms,
+          initial_window_ms: Math.max(end_time_in_ms - start_time_in_ms, 60 * 1000),
+          page_limit: 100,
+          fetch_window: async (window_start_ms, window_stop_ms) =>
+            await new Promise((resolve, reject) => {
+              let params = {
+                instId: pre_process_pair(pair),
+                instType: 'SPOT',
+                begin: window_start_ms,
+                end: window_stop_ms,
+              }
+              let path = '/api/v5/trade/fills-history?' + qs.stringify(params)
+              let options = get_options(api_key, secret_key, this.passphrase, 'GET', path, '')
+              needle.get(base_url + path, options, (err, res, body) => {
+                body = parse_body(body)
+                if (body && body.code === '0' && body.data) {
+                  resolve(
+                    body.data.map((t) => ({
+                      order_id: t.ordId.toString(),
+                      ...(t.billId != null ? { trade_id: t.billId.toString() } : {}),
+                      pair: post_process_pair(t.instId),
+                      type: t.side,
+                      price: parseFloat(t.fillPx),
+                      amount: parseFloat(t.fillSz),
+                      total: parseFloat(t.fillPx) * parseFloat(t.fillSz),
+                      close_time: new Date(parseInt(t.ts)),
+                      fees: {
+                        [post_process_cur(t.feeCcy)]: -parseFloat(t.fee),
+                      },
+                      role: t.execType === 'M' ? 'maker' : 'taker',
+                    })),
+                  )
+                } else if (body && (body.code === '50026' || body.code === '50001')) {
+                  reject({ error: error_codes.service_unavailable, body })
+                } else if (body) {
+                  reject({ error: error_codes.other, body })
+                } else {
+                  reject({ error: error_codes.timeout })
+                }
+              })
+            }),
+        })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(merged) })
+      })().catch((error) => {
+        cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
       })
     }
     this.private_limiter.process(get_history_trades_base, pair, start_time_in_ms, end_time_in_ms, cb)

package/lib/exchanges/phemex.js

@@ -7,6 +7,7 @@ const needle = require('needle')
 const ExchangeWs = require('./exchange-ws.js')
 
 const ExchangeBase = require('./exchange-base.js')
+const { fetch_split_windows, sort_history_rows } = ExchangeBase.history_utils
 
 const { error_codes } = require('../error_codes.json')
 
@@ -1169,37 +1170,52 @@ module.exports = class Phemex extends ExchangeBase {
   get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
     let get_history_trades_base = (pair, start_time_in_ms, end_time_in_ms, cb) => {
       let [api_key, secret_key] = this.api_secret_key
-      let params = {
-        symbol: pre_process_pair(pair),
-        limit: 200,
-        start: start_time_in_ms,
-        end: end_time_in_ms,
-      }
-      let path = '/api-data/spots/trades'
-      let options = get_options(api_key, secret_key, path, params, '')
-      let url = base_url + path + '?' + qs.stringify(params)
-      needle.get(url, options, (err, res, body) => {
-        body = parse_body(body)
-        if (body && body.code === 0 && body.data && Array.isArray(body.data.rows)) {
-          let trades = body.data.rows.map((t) => ({
-            order_id: t.orderID.toString(),
-            pair,
-            type: t.side.toLowerCase(),
-            price: t.execPriceEp / price_scale_factor(pair),
-            amount: t.execBaseQtyEv / amount_scale_factor(pair),
-            total: t.execQuoteQtyEv / price_scale_factor(pair),
-            close_time: new Date(t.transactTimeNs / 1e6),
-            fees: {
-              [post_process_cur(t.quoteCurrency)]: parseFloat(t.execFeeEv) / price_scale_factor(pair),
-            },
-          }))
-          trades = utils.merge_trades_with_same_id(trades)
-          cb({ success: true, body: trades })
-        } else if (body) {
-          cb({ success: false, error: error_codes.other, body })
-        } else {
-          cb({ success: false, error: error_codes.timeout })
-        }
+      ;(async () => {
+        const rows = await fetch_split_windows({
+          start_ms: start_time_in_ms,
+          stop_ms: end_time_in_ms,
+          initial_window_ms: Math.max(end_time_in_ms - start_time_in_ms, 60 * 1000),
+          page_limit: 200,
+          fetch_window: async (window_start_ms, window_stop_ms) =>
+            await new Promise((resolve, reject) => {
+              let params = {
+                symbol: pre_process_pair(pair),
+                limit: 200,
+                start: window_start_ms,
+                end: window_stop_ms,
+              }
+              let path = '/api-data/spots/trades'
+              let options = get_options(api_key, secret_key, path, params, '')
+              let url = base_url + path + '?' + qs.stringify(params)
+              needle.get(url, options, (err, res, body) => {
+                body = parse_body(body)
+                if (body && body.code === 0 && body.data && Array.isArray(body.data.rows)) {
+                  resolve(
+                    body.data.rows.map((t) => ({
+                      order_id: t.orderID.toString(),
+                      pair,
+                      type: t.side.toLowerCase(),
+                      price: t.execPriceEp / price_scale_factor(pair),
+                      amount: t.execBaseQtyEv / amount_scale_factor(pair),
+                      total: t.execQuoteQtyEv / price_scale_factor(pair),
+                      close_time: new Date(t.transactTimeNs / 1e6),
+                      fees: {
+                        [post_process_cur(t.quoteCurrency)]: parseFloat(t.execFeeEv) / price_scale_factor(pair),
+                      },
+                    })),
+                  )
+                } else if (body) {
+                  reject({ error: error_codes.other, body })
+                } else {
+                  reject({ error: error_codes.timeout })
+                }
+              })
+            }),
+        })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(merged) })
+      })().catch((error) => {
+        cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
       })
     }
     this.private_limiter.process(get_history_trades_base, pair, start_time_in_ms, end_time_in_ms, cb)

package/lib/exchanges/poloniex.js

@@ -7,6 +7,7 @@ const needle = require('needle')
 
 const ExchangeBase = require('./exchange-base.js')
 const ExchangeWs = require('./exchange-ws.js')
+const { fetch_split_windows, sort_history_rows } = ExchangeBase.history_utils
 
 const { error_codes } = require('../error_codes.json')
 const { utils, rate_limiter: Limiter } = require('@icgio/icg-utils')
@@ -442,33 +443,48 @@ module.exports = class Poloniex extends ExchangeBase {
   }
   get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
     let get_history_trades_base = (pair, start_time_in_ms, end_time_in_ms, cb) => {
-      let path = '/trades',
-        params = {
-          startTime: start_time_in_ms,
-          symbols: pre_process_pair(pair),
-          endTime: end_time_in_ms,
-        }
-      let options = get_options('GET', path, params, this.api_secret_key)
-      let url = base_url + path + '?' + qs.stringify(params)
-      needle.get(url, options, (err, res, body) => {
-        if (body && Array.isArray(body)) {
-          let result = (body = body.map((trade) => {
-            return {
-              order_id: trade.orderId,
-              pair: post_process_pair(trade.symbol),
-              type: trade.side.toLowerCase(),
-              price: parseFloat(trade.price),
-              amount: parseFloat(trade.quantity),
-              total: parseFloat(trade.price) * parseFloat(trade.quantity),
-              close_time: new Date(trade.createTime),
-            }
-          }))
-          cb({ success: true, body: result })
-        } else if (body) {
-          cb({ success: false, error: error_codes.other, body })
-        } else {
-          cb({ success: false, error: error_codes.timeout })
-        }
+      ;(async () => {
+        const rows = await fetch_split_windows({
+          start_ms: start_time_in_ms,
+          stop_ms: end_time_in_ms,
+          initial_window_ms: Math.max(end_time_in_ms - start_time_in_ms, 60 * 1000),
+          page_limit: 500,
+          fetch_window: async (window_start_ms, window_stop_ms) =>
+            await new Promise((resolve, reject) => {
+              let path = '/trades',
+                params = {
+                  startTime: window_start_ms,
+                  symbols: pre_process_pair(pair),
+                  endTime: window_stop_ms,
+                  limit: 500,
+                }
+              let options = get_options('GET', path, params, this.api_secret_key)
+              let url = base_url + path + '?' + qs.stringify(params)
+              needle.get(url, options, (err, res, body) => {
+                if (body && Array.isArray(body)) {
+                  resolve(
+                    body.map((trade) => ({
+                      order_id: trade.orderId,
+                      pair: post_process_pair(trade.symbol),
+                      type: trade.side.toLowerCase(),
+                      price: parseFloat(trade.price),
+                      amount: parseFloat(trade.quantity),
+                      total: parseFloat(trade.price) * parseFloat(trade.quantity),
+                      close_time: new Date(trade.createTime),
+                    })),
+                  )
+                } else if (body) {
+                  reject({ error: error_codes.other, body })
+                } else {
+                  reject({ error: error_codes.timeout })
+                }
+              })
+            }),
+        })
+        const merged = utils.merge_trades_with_same_id(rows)
+        cb({ success: true, body: sort_history_rows(merged) })
+      })().catch((error) => {
+        cb({ success: false, error: error?.error || error_codes.other, body: error?.body })
       })
     }
     this.private_limiter.process(get_history_trades_base, pair, start_time_in_ms, end_time_in_ms, cb)

package/lib/exchanges/swft.js

@@ -416,9 +416,7 @@ module.exports = class Swft extends ExchangeBase {
     }
     this.private_limiter.process(get_trades_base, pair, timeframe_in_ms, cb)
   }
-  get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
-    this._get_history_trades_via_timeframe(pair, start_time_in_ms, end_time_in_ms, cb)
-  }
+  // get_history_trades — not implemented, no native absolute-window endpoint
   // get_all_deposits(timeframe_in_ms, cb) {
   //
   // }

package/lib/exchanges/upbit.js

@@ -429,6 +429,7 @@ module.exports = class Upbit extends ExchangeBase {
         }
       }
       trades = sort_history_rows(filter_history_in_range(trades, start_time_in_ms, end_time_in_ms))
+      trades = utils.merge_trades_with_same_id(trades)
       cb({ success: true, body: trades })
     })().catch((error) => cb(error))
   }

package/lib/exchanges/weex.js

@@ -393,9 +393,7 @@ module.exports = class Weex extends ExchangeBase {
     }
     this.private_limiter.process(get_trades_base, pair, timeframe_in_ms, cb)
   }
-  get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
-    this._get_history_trades_via_timeframe(pair, start_time_in_ms, end_time_in_ms, cb)
-  }
+  // get_history_trades — not implemented, no native absolute-window endpoint
   get_all_deposits(timeframe_in_ms, cb) {
     let get_all_deposits_base = (cb) => {
       let [api_key, secret_key] = this.api_secret_key