@icgio/icg-exchanges 1.40.47 → 1.40.48

package/lib/exchanges/kucoin.js

@@ -546,39 +546,64 @@ module.exports = class Kucoin extends ExchangeBase {
   }
   get_history_trades(pair, start_time_in_ms, end_time_in_ms, cb) {
     let get_history_trades_base = (pair, start_time_in_ms, end_time_in_ms, cb) => {
-      let params = {
-        symbol: pre_process_pair(pair),
-        startAt: start_time_in_ms,
-        endAt: end_time_in_ms,
-        type: 'limit',
+      let page_size = 50
+      let build_trade = (fill) => {
+        return {
+          order_id: fill.orderId.toString(),
+          ...(fill.tradeId != null ? { trade_id: fill.tradeId.toString() } : {}),
+          pair,
+          type: fill.side,
+          price: parseFloat(fill.price),
+          amount: parseFloat(fill.size),
+          total: parseFloat(fill.price) * parseFloat(fill.size),
+          open_time: new Date(fill.createdAt),
+          fees: {
+            [post_process_cur(fill.feeCurrency)]: parseFloat(fill.fee),
+          },
+        }
       }
-      let options = get_options(Date.now(), 'GET', '/api/v1/fills', params, this.api_secret_key, this.passphrase)
-      needle.get('https://api.kucoin.com/api/v1/fills?' + qs.stringify(params), options, (err, res, body) => {
-        if (body && body.code === '200000') {
-          let trades = body.data.items.map((o) => {
-            return {
-              order_id: o.orderId.toString(),
-              ...(o.tradeId != null ? { trade_id: o.tradeId.toString() } : {}),
-              pair,
-              type: o.side,
-              price: parseFloat(o.price),
-              amount: parseFloat(o.size),
-              total: parseFloat(o.price) * parseFloat(o.size),
-              open_time: new Date(o.createdAt),
-              fees: {
-                [post_process_cur(o.feeCurrency)]: parseFloat(o.fee),
-              },
-            }
-          })
-          cb({ success: true, body: trades })
-        } else if (body && body.code === '429000') {
-          cb({ success: false, error: error_codes.service_unavailable, body })
-        } else if (body) {
-          cb({ success: false, error: error_codes.other, body })
-        } else {
-          cb({ success: false, error: error_codes.timeout })
+      let dedupe_history_trades = (trades) => {
+        let by_fill_identity = new Map()
+        trades.forEach((trade) => {
+          let time = trade.open_time instanceof Date ? trade.open_time.getTime() : new Date(trade.open_time).getTime()
+          let fees = trade.fees && typeof trade.fees === 'object' ? JSON.stringify(trade.fees) : ''
+          let key =
+            trade.trade_id ||
+            [trade.order_id || '', pair, trade.type || '', trade.price || 0, trade.amount || 0, trade.total || 0, Number.isFinite(time) ? time : 0, fees].join('|')
+          if (!by_fill_identity.has(key)) by_fill_identity.set(key, trade)
+        })
+        return [...by_fill_identity.values()]
+      }
+      let fetch_page = (current_page, collected_trades) => {
+        let params = {
+          symbol: pre_process_pair(pair),
+          startAt: start_time_in_ms,
+          endAt: end_time_in_ms,
+          type: 'limit',
+          currentPage: current_page,
+          pageSize: page_size,
         }
-      })
+        let options = get_options(Date.now(), 'GET', '/api/v1/fills', params, this.api_secret_key, this.passphrase)
+        needle.get('https://api.kucoin.com/api/v1/fills?' + qs.stringify(params), options, (err, res, body) => {
+          if (body && body.code === '200000' && body.data && Array.isArray(body.data.items)) {
+            let trades = body.data.items.map((o) => build_trade(o))
+            let all_trades = collected_trades.concat(trades)
+            let total_pages = Math.max(parseInt(body.data.totalPage || 1), current_page)
+            if (current_page < total_pages && trades.length > 0) {
+              fetch_page(current_page + 1, all_trades)
+            } else {
+              cb({ success: true, body: dedupe_history_trades(all_trades) })
+            }
+          } else if (body && body.code === '429000') {
+            cb({ success: false, error: error_codes.service_unavailable, body })
+          } else if (body) {
+            cb({ success: false, error: error_codes.other, body })
+          } else {
+            cb({ success: false, error: error_codes.timeout })
+          }
+        })
+      }
+      fetch_page(1, [])
     }
     this.private_limiter.process(get_history_trades_base, pair, start_time_in_ms, end_time_in_ms, cb)
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@icgio/icg-exchanges",
-  "version": "1.40.47",
+  "version": "1.40.48",
   "description": "icgio exchanges package",
   "main": "./exchanges.js",
   "scripts": {