@icgio/icg-exchanges-wrapper 1.21.20 → 1.21.22

package/functions/get-exchanges-rates-market-history-ohlcv.js

@@ -156,11 +156,12 @@ const get_exchanges_rates = function (Exchanges, exchange_pair_dict, cb, ws_enab
             ws_promise_with_fallback = ws_connection_promises_with_fallback[ws_key]
           }
         } else {
-          // Create new WebSocket connection
-          // Log only when actually creating a new connection
-          if (all_pairs.length > 0) {
-            console.log(`[WebSocket Rates] ${Exchange_name}: Creating connection with ${all_pairs.length} pair(s): ${all_pairs.join(', ')}`)
-          }
+          // Re-enter this branch every poll (we no longer cache ws_promise below) so
+          // a fresh rate_ws cycle runs against the live asks_dict/bids_dict each time.
+          // `first_time[Exchange_name]` gates the actual ws_market call so the WS is
+          // set up exactly once per process — the "Creating connection" log lives
+          // inside that gate so it only fires on the genuine one-shot setup, not on
+          // every 30s poll.
           ws_connection_pairs[ws_key] = all_pairs
           ws_promise = new Promise((resolve, reject) => {
             if (!Exchange.ws || !Exchange.ws.market) {
@@ -169,9 +170,13 @@ const get_exchanges_rates = function (Exchanges, exchange_pair_dict, cb, ws_enab
               return
             }
 
-            // Create WebSocket with ALL pairs collected in first pass
-            // This ensures only ONE WebSocket per exchange, even with multiple clients/pairs
-            Exchange.ws_market(all_pairs)
+            if (!first_time[Exchange_name]) {
+              if (all_pairs.length > 0) {
+                console.log(`[WebSocket Rates] ${Exchange_name}: Creating connection with ${all_pairs.length} pair(s): ${all_pairs.join(', ')}`)
+              }
+              Exchange.ws_market(all_pairs)
+              first_time[Exchange_name] = true
+            }
 
             const WS_TIMEOUT_MS = 30000 // 30 seconds timeout
             const MAX_CHECKS = 300 // 30 seconds / 100ms
@@ -316,12 +321,16 @@ const get_exchanges_rates = function (Exchanges, exchange_pair_dict, cb, ws_enab
 
             check_status()
           })
-          // Store the cached promise AFTER `new Promise(...)` returns — assigning inside
-          // the synchronous executor reads the outer binding while it's still undefined.
-          // Keep the entry alive while the socket is alive; the next tick's
-          // `is_opening_or_opened` check reads `Exchange.ws.market.status` and the
-          // else-branch above overwrites this slot when the socket is closed/stopped.
-          ws_connection_promises[ws_key] = ws_promise
+          // Do NOT cache this promise. `Exchange.rate_ws(pair, cb)` returns a SNAPSHOT
+          // of `asks_dict[pair]`/`bids_dict[pair]` at call time — for exchanges using
+          // ordered_dict (e.g. Bybit) `.entries().map(...)` creates a new array, and
+          // for exchanges using a plain-array depth (e.g. Mexc) every depth message
+          // REPLACES the array reference. Either way the result is frozen once the
+          // promise resolves. Rerunning the else branch each poll lets a new rate_ws
+          // call pick up changes the WebSocket has applied since last tick;
+          // `first_time[Exchange_name]` above prevents the underlying WS from being
+          // reopened, so there's no reconnect cost. Mirrors v1.17.27 (f815363) which
+          // fixed the same bug for get_exchanges_market_history.
         }
 
         // Wrap WebSocket promise to handle rejection and fall back to REST

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@icgio/icg-exchanges-wrapper",
-  "version": "1.21.20",
+  "version": "1.21.22",
   "description": "",
   "main": "index.js",
   "scripts": {