@ic-reactor/react 3.11.0 → 3.12.1

package/src/defineReactor.ts

@@ -87,7 +87,8 @@ export interface DefineReactorSharedParameters
    * When omitted, a ClientManager is created from the agent options below.
    *
    * A supplied or adopted manager brings its own agent and QueryClient, so
-   * `agentOptions` and `queryClient` apply only when this call creates one.
+   * `agentOptions`, `queryClient` and `allowEnvConfig` apply only when this
+   * call creates one.
    */
   clientManager?: ClientManager
   /**
@@ -183,6 +184,8 @@ export function defineReactor<Service = BaseActor>(
     auth,
     display,
     agentOptions,
+    allowEnvConfig,
+    allowEnvRootKey,
     name,
     idlFactory,
     canisterId,
@@ -215,12 +218,38 @@ export function defineReactor<Service = BaseActor>(
     )
   }
 
+  // Same reasoning as `auth`, and it matters more here: an ignored
+  // `allowEnvConfig: false` reads as "I locked the cookie out" while the
+  // supplied manager carries whatever decision it was built with.
+  if (
+    (providedClientManager || providedAuthentication) &&
+    (allowEnvConfig !== undefined || allowEnvRootKey !== undefined)
+  ) {
+    const passed = [
+      allowEnvConfig !== undefined && "allowEnvConfig",
+      allowEnvRootKey !== undefined && "allowEnvRootKey",
+    ]
+      .filter(Boolean)
+      .join(", ")
+    throw new Error(
+      `[ic-reactor] defineReactor("${name}") received both a ClientManager and \`${passed}\`. ` +
+        `That option is resolved when a ClientManager is constructed, so the supplied one already carries its own ` +
+        `decision and this would be ignored — silently changing nothing about whether the ic_env cookie is trusted. ` +
+        `Pass it where that ClientManager is created, or drop \`clientManager\` to build one here.`
+    )
+  }
+
   const clientManager =
     providedClientManager ??
     providedAuthentication?.clientManager ??
     new ClientManager({
       queryClient: providedQueryClient ?? createDefaultQueryClient(),
       agentOptions,
+      // Forwarded, not dropped: the type has always accepted these (it extends
+      // ClientManagerParameters) while the call ignored them, so the one
+      // documented setup path silently discarded the ic_env opt-in it advertised.
+      allowEnvConfig,
+      allowEnvRootKey,
     })
 
   // Always report the QueryClient actually in use: when a ClientManager is