@ibgib/web-gib 0.0.57 → 0.0.59

package/src/ui/component/identity/keystone-details/keystone-details.mts

@@ -22,6 +22,7 @@ import { getKeystoneSyncService } from "../../../../identity/keystone-sync-servi
 import { updateSpecialIndex } from "@ibgib/core-gib/dist/timeline/timeline-api.mjs";
 import { getTjpAddr, toDto } from "@ibgib/core-gib/dist/common/other/ibgib-helper.mjs";
 import { parseSpaceIb } from "@ibgib/core-gib/dist/witness/space/space-helper.mjs";
+import { executeSsoOAuthPopup } from "../../../../identity/sso-popup-helper.mjs";
 
 import { getComponentCtorArg } from "../../../../app-bootstrap/init-orchestration.mjs";
 import { promptForSecret } from "../../../../helpers.web.mjs";
@@ -403,7 +404,7 @@ export class KeystoneDetailsComponentInstance
 
             await this.updateFrameDetailsView();
         } catch (error) {
-            console.error(`${lc} ${extractErrorMsg(error)}`);
+            console.error(`${lc} Registered identity keystone address ${this.ibGibAddr} not found in local browser space: ${extractErrorMsg(error)} (E: a123456789abcdef0123456789c0003)`);
             throw error;
         } finally {
             if (logalot) { console.log(`${lc} complete.`); }
@@ -1039,70 +1040,17 @@ export class KeystoneDetailsComponentInstance
         this.setSSOStatus(`Linking ${providerId}...`, "info");
 
         try {
-            // 1. Fetch public SSO configs from server
-            const res = await fetch('/api/identity/sso/config');
-            if (!res.ok) {
-                throw new Error(`Failed to fetch SSO config from server: ${res.statusText}`);
-            }
-            const data = await res.json();
-            if (!data.success || !data.providers) {
-                throw new Error(`SSO configuration fetch failed: ${data.message || 'unknown error'}`);
-            }
-
-            const providerConfig = data.providers.find((p: any) => p.providerId === providerId);
-            if (!providerConfig) {
-                throw new Error(`SSO provider '${providerId}' is not configured on the server.`);
-            }
-
-            // 2. Generate a secure, high-entropy user nonce
-            const userNonce = (Math.random().toString(36).substring(2) + Math.random().toString(36).substring(2)).substring(0, 32);
-
-            // 3. Construct state payload
-            const stateObj = {
+            const resPopup = await executeSsoOAuthPopup({
                 providerId,
-                parentTjpAddr: this.ibGibAddr,
-                userNonce
-            };
-            const state = btoa(JSON.stringify(stateObj));
-
-            // 4. Construct Auth URL
-            const authUrl = `${providerConfig.authUrl}?client_id=${providerConfig.clientId}&redirect_uri=${encodeURIComponent(providerConfig.redirectUri)}&response_type=code&scope=${encodeURIComponent(providerConfig.scope)}&state=${encodeURIComponent(state)}`;
-
-            // 5. Open popup window
-            const popup = window.open(
-                authUrl,
-                'sso-oauth-popup',
-                'width=600,height=700,status=yes,toolbar=no,menubar=no,location=yes'
-            );
-            if (!popup) {
-                throw new Error("Popup blocked by browser. Please enable popups for this site.");
-            }
+                parentTjpAddr: this.ibGibAddr
+            });
 
-            // 6. Listen for callback from pop-up
-            let checkClosedInterval: any;
-            const messageListener = async (event: MessageEvent) => {
-                if (event.origin !== window.location.origin) return;
-                const callbackData = event.data;
-                if (callbackData && callbackData.type === 'sso-oauth-callback') {
-                    window.removeEventListener('message', messageListener);
-                    clearInterval(checkClosedInterval);
-                    await this.handleSSOLinkCallback(callbackData.code, stateObj, providerConfig.redirectUri);
-                }
-            };
-            window.addEventListener('message', messageListener);
-
-            // 7. Poll for manual closure of the popup window
-            checkClosedInterval = setInterval(() => {
-                if (popup.closed) {
-                    clearInterval(checkClosedInterval);
-                    window.removeEventListener('message', messageListener);
-                    const statusEl = this.elements!.ssoStatusMsgEl;
-                    if (statusEl.textContent && statusEl.textContent.startsWith('Linking')) {
-                        this.setSSOStatus('Linking cancelled (window closed).', 'error');
-                    }
-                }
-            }, 500);
+            if (!resPopup.success || !resPopup.code) {
+                this.setSSOStatus(resPopup.message || `Linking cancelled.`, "error");
+                return;
+            }
 
+            await this.handleSSOLinkCallback(resPopup.code, resPopup.stateObj, resPopup.redirectUri!);
         } catch (error) {
             console.error(`${lc} SSO link initiation failed: ${extractErrorMsg(error)}`);
             this.setSSOStatus(`Link failed: ${extractErrorMsg(error)}`, "error");

package/tools/auto-generated-agent-skills/skills/ibgib-implementation-plan/SKILL.md

@@ -67,6 +67,9 @@ Break the work into small, incremental, independently verifiable steps:
 
 ## 🧪 Testing & Verification Strategy
 
+> [!IMPORTANT]
+> Always review and follow [`docs/RESPEC_GIB_GUIDANCE.md`](file:///c:/Users/billm/antigravity/ibgib/docs/RESPEC_GIB_GUIDANCE.md) for respec testing patterns, including the strict use of `ifWeMight` blocks, avoiding artificial delays, and proper error handling.
+
 *   **Unit & Integration Tests**: `respec-gib` test commands (`npm run test:core-gib`) and specific `ifWeMight` focus instructions.
 *   **Manual & E2E Checks**: Step-by-step verification steps in browser or CLI environment.