@ibgib/space-gib 0.0.5 → 0.0.7

package/src/client/dev-tools/phase-4-3.mts

@@ -1,19 +1,17 @@
-import { extractErrorMsg, getUUID, getTimestamp } from '@ibgib/helper-gib/dist/helpers/utils-helper.mjs';
+import { extractErrorMsg } from '@ibgib/helper-gib/dist/helpers/utils-helper.mjs';
 import { Factory_V1 as factory } from '@ibgib/ts-gib/dist/V1/factory.mjs';
 import { ROOT } from '@ibgib/ts-gib/dist/V1/constants.mjs';
 import { getIbGibAddr } from '@ibgib/ts-gib/dist/helper.mjs';
 import { KeystoneIbGib_V1 } from '@ibgib/core-gib/dist/keystone/keystone-types.mjs';
-import { KeystoneService_V1 } from '@ibgib/core-gib/dist/keystone/keystone-service-v1.mjs';
 import { getGlobalMetaspace_waitIfNeeded } from "@ibgib/web-gib/dist/helpers.mjs";
 import { mut8Timeline } from '@ibgib/core-gib/dist/timeline/timeline-api.mjs';
 import { graphsAreEquivalent } from '@ibgib/core-gib/dist/common/other/graph-helper.mjs';
-import { SyncPeerWebSocketSender_V1 } from '@ibgib/core-gib/dist/sync/sync-peer/sync-peer-websocket/sync-peer-websocket-sender/sync-peer-websocket-sender-v1.mjs';
-import { SyncSagaCoordinator } from '@ibgib/core-gib/dist/sync/sync-saga-coordinator.mjs';
-import { SyncConflictStrategy } from '@ibgib/core-gib/dist/sync/sync-constants.mjs';
-import { SESSION_KEYSTONE_POLICY, getSpaceGibPoolConfig } from "../../common/keystone-policies.mjs";
 import { SpaceGibApiBridge } from '../api/space-gib-api-bridge.mjs';
 
-import { debugState, devLog, lc } from './common.mjs';
+import {
+    debugState, devLog, lc,
+    setupDomainAndDelegateIdentities, runSyncPass, verifyIdentitiesOnServer
+} from './common.mjs';
 
 export function init4_3bSetupButton(): void {
     const btn = document.getElementById('btn-4-3b-setup') as HTMLButtonElement | null;
@@ -27,32 +25,18 @@ export function init4_3bSetupButton(): void {
             const space = await metaspace.getLocalUserSpace({});
             if (!space) { throw new Error("No default space."); }
 
-            const keystoneService = new KeystoneService_V1();
+            const apiBridge = new SpaceGibApiBridge();
 
-            const domainI = await keystoneService.genesis({
+            // Create domain + delegate identities (DRY helper)
+            await setupDomainAndDelegateIdentities({
                 masterSecret: 'test-sender-secret-phase4-3',
-                configs: [
-                    getSpaceGibPoolConfig('sync', 'senderidentitysyncsaltphase4-3'),
-                    getSpaceGibPoolConfig('manage', 'senderidentitymanagesaltphase4-3'),
-                ],
-                metaspace,
-                space,
-                frameDetails: { client: 'space-gib-web-dev', timestamp: getTimestamp() }
+                syncSalt: 'senderidentitysyncsaltphase4-3',
+                manageSalt: 'senderidentitymanagesaltphase4-3',
+                metaspace, space, apiBridge,
+                phaseText: '4.3B'
             });
 
-            debugState.domainI = domainI;
-            debugState.domainIMasterSecret = 'test-sender-secret-phase4-3';
-
-            devLog(`4.3B Setup: ✓ Domain Keystone (I) created locally: ${getIbGibAddr({ ibGib: domainI })}`);
-
-            const apiBridge = new SpaceGibApiBridge();
-            const resGenesis = await apiBridge.postGenesisKeystone(domainI);
-            if (resGenesis.success) {
-                devLog(`4.3B Setup: ✓ Domain Keystone registered on server.`);
-            } else {
-                throw new Error(`Server rejected genesis domain keystone: ${resGenesis.message}`);
-            }
-
+            // Create timeline V0 → V1
             const resV0 = await factory.firstGen({
                 parentIbGib: ROOT,
                 ib: 'timeline_root_partial_4_3b',
@@ -68,8 +52,7 @@ export function init4_3bSetupButton(): void {
             const r1_v1 = await mut8Timeline({
                 timeline: r1_v0,
                 mut8Opts: { dataToAddOrPatch: { type: 'comment', label: 'V1_4_3b' } },
-                metaspace,
-                space,
+                metaspace, space,
             });
 
             debugState.targetC1 = r1_v1;
@@ -97,106 +80,36 @@ async function performPhaseSync4_3b(): Promise<void> {
 
     try {
         btn.disabled = true;
-        devLog(`4.3B Sync: Starting Pass 1 (Sync V1 to server)...`);
 
-        const domainI = debugState.domainI;
         const targetV1 = debugState.targetX;
-        if (!domainI || !targetV1) {
+        if (!debugState.domainI || !targetV1) {
             devLog(`⚠ 4.3B Sync: Missing setup state. Please run Setup first.`);
             btn.disabled = false;
             return;
         }
 
-        const domainAddr = getIbGibAddr({ ibGib: domainI });
         const metaspace = await getGlobalMetaspace_waitIfNeeded();
         const space = await metaspace.getLocalUserSpace({});
         if (!space) { throw new Error("No default space."); }
 
-        const protocol = location.protocol === 'https:' ? 'wss:' : 'ws:';
-
-        let senderPeer = new SyncPeerWebSocketSender_V1({
-            classname: 'SyncPeerWebSocketSender_V1',
-            httpEvolveUrl: `${location.protocol}//${location.host}/api/keystone/evolve/${encodeURIComponent(domainAddr)}`,
-            wsUrl: `${protocol}//${location.host}/api/sync/ws/${encodeURIComponent(domainAddr)}`
-        });
-
-        let coordinator = new SyncSagaCoordinator();
-        let sagaId = await getUUID();
-        debugState.sagaId = sagaId;
-        debugState.senderPeer = senderPeer;
-
-        await senderPeer.initializeOpts({
-            localMetaspace: metaspace,
-            localSpace: space,
-            senderIdentity: domainI,
-            fnSenderSecret: async () => debugState.domainIMasterSecret!,
-            sagaId,
-            sessionConnectPoolConfig: SESSION_KEYSTONE_POLICY.CONNECT_POOL as any,
-            sessionSyncPoolConfig: SESSION_KEYSTONE_POLICY.DEFAULT_POOL as any,
-            targetAddrs: [domainAddr]
-        });
-
-        let syncSaga = await coordinator.sync({
-            domainIbGibs: [targetV1],
-            senderIdentity: domainI,
-            fnSenderSecret: async () => debugState.domainIMasterSecret!,
-            peer: senderPeer,
-            localSpace: space,
-            metaspace,
-            conflictStrategy: SyncConflictStrategy.optimisticWithLCS,
-        });
-        await syncSaga.done;
+        // Pass 1: Sync V1
+        devLog(`4.3B Sync: Starting Pass 1 (Sync V1 to server)...`);
+        await runSyncPass({ domainIbGibs: [targetV1], passLabel: 'Pass 1 (Sync V1)', metaspace, space });
         devLog(`4.3B Sync: ✓ Pass 1 Complete (V1 synced).`);
 
-        const latestSenderAddr1 = await metaspace.getLatestAddr({
-            addr: getIbGibAddr({ ibGib: domainI }),
-            space,
-        });
-        const resGetLatestI1 = await metaspace.get({ addrs: [latestSenderAddr1!], space });
-        const senderIdentityEvolved1 = resGetLatestI1.ibGibs![0] as KeystoneIbGib_V1;
-
+        // Mutate V1 → V2
         devLog(`4.3B Sync: Mutating V1 to V2 locally...`);
         const r1_v2 = await mut8Timeline({
             timeline: targetV1,
             mut8Opts: { dataToAddOrPatch: { type: 'comment', label: 'V2_4_3b' } },
-            metaspace,
-            space,
+            metaspace, space,
         });
         debugState.targetX = r1_v2;
         devLog(`4.3B Sync: ✓ V2 created locally: ${getIbGibAddr({ ibGib: r1_v2 })}`);
 
+        // Pass 2: Sync V2
         devLog(`4.3B Sync: Starting Pass 2 (Sync V2 delta to server)...`);
-        senderPeer = new SyncPeerWebSocketSender_V1({
-            classname: 'SyncPeerWebSocketSender_V1',
-            httpEvolveUrl: `${location.protocol}//${location.host}/api/keystone/evolve/${encodeURIComponent(domainAddr)}`,
-            wsUrl: `${protocol}//${location.host}/api/sync/ws/${encodeURIComponent(domainAddr)}`
-        });
-        coordinator = new SyncSagaCoordinator();
-        sagaId = await getUUID();
-        debugState.sagaId = sagaId;
-        debugState.senderPeer = senderPeer;
-
-        await senderPeer.initializeOpts({
-            localMetaspace: metaspace,
-            localSpace: space,
-            senderIdentity: senderIdentityEvolved1,
-            fnSenderSecret: async () => debugState.domainIMasterSecret!,
-            sagaId,
-            sessionConnectPoolConfig: SESSION_KEYSTONE_POLICY.CONNECT_POOL as any,
-            sessionSyncPoolConfig: SESSION_KEYSTONE_POLICY.DEFAULT_POOL as any,
-            targetAddrs: [domainAddr]
-        });
-
-        syncSaga = await coordinator.sync({
-            domainIbGibs: [r1_v2],
-            senderIdentity: senderIdentityEvolved1,
-            fnSenderSecret: async () => debugState.domainIMasterSecret!,
-            peer: senderPeer,
-            localSpace: space,
-            metaspace,
-            conflictStrategy: SyncConflictStrategy.optimisticWithLCS,
-        });
-        await syncSaga.done;
+        await runSyncPass({ domainIbGibs: [r1_v2], passLabel: 'Pass 2 (Sync V2)', metaspace, space });
         devLog(`4.3B Sync: ✓ Pass 2 Complete (V2 synced).`);
 
         devLog(`✓ 4.3B Sync Sequence Complete! Ready for State Checks.`);
@@ -215,9 +128,7 @@ async function performPhaseSync4_3b(): Promise<void> {
 export function init4_3bSyncButton(): void {
     const btn = document.getElementById('btn-4-3b-sync') as HTMLButtonElement | null;
     if (!btn) { return; }
-    btn.addEventListener('click', () => {
-        performPhaseSync4_3b();
-    });
+    btn.addEventListener('click', () => { performPhaseSync4_3b(); });
 }
 
 export function init4_3bCheckButton(): void {
@@ -239,146 +150,94 @@ export function init4_3bCheckButton(): void {
             const v1Addr = getIbGibAddr({ ibGib: targetV1 });
             const v2Addr = getIbGibAddr({ ibGib: targetV2 });
             const domainAddr = getIbGibAddr({ ibGib: domainI });
+            const apiBridge = new SpaceGibApiBridge();
 
             // 1. Verify V1 and V2 exist locally
             const localV1Res = await metaspace.get({ addrs: [v1Addr], space });
             const localV2Res = await metaspace.get({ addrs: [v2Addr], space });
             if (!localV1Res.success || !localV1Res.ibGibs?.[0]) {
-                devLog('✗ Check: Timeline frame V1 NOT found locally.');
-                return;
+                devLog('✗ Check: Timeline frame V1 NOT found locally.'); return;
             }
             if (!localV2Res.success || !localV2Res.ibGibs?.[0]) {
-                devLog('✗ Check: Timeline frame V2 NOT found locally.');
-                return;
+                devLog('✗ Check: Timeline frame V2 NOT found locally.'); return;
             }
             devLog(`✓ Check: Timeline frames V1 and V2 exist locally.`);
 
-            // 2. Fetch server's graphs for V2
-            const apiBridge = new SpaceGibApiBridge();
+            // 2. Verify V2 on server with correct past ref and matching graph
             const serverV2Res = await apiBridge.getIbGib(domainAddr, v2Addr);
             if (!serverV2Res.success || !serverV2Res.ibGib) {
-                devLog(`✗ Check: Timeline frame V2 NOT found on server: ${serverV2Res.message}`);
-                return;
+                devLog(`✗ Check: Timeline frame V2 NOT found on server: ${serverV2Res.message}`); return;
             }
             devLog(`✓ Check: Timeline frame V2 exists on server.`);
 
-            const serverV2IbGib = serverV2Res.ibGib;
-            const pastAddr = serverV2IbGib.rel8ns?.past?.at(-1);
+            const pastAddr = serverV2Res.ibGib.rel8ns?.past?.at(-1);
             if (pastAddr === v1Addr) {
                 devLog('✓ Check: Server V2 correctly references V1 in its past relation.');
             } else {
-                devLog(`✗ Check: Server V2 does not reference V1 in past relation! got: ${pastAddr}`);
-                return;
+                devLog(`✗ Check: Server V2 does not reference V1 in past relation! got: ${pastAddr}`); return;
             }
 
-            const localV2Graph = await metaspace.getDependencyGraph({
-                ibGibAddr: v2Addr,
-                space
-            });
+            const localV2Graph = await metaspace.getDependencyGraph({ ibGibAddr: v2Addr, space });
             const serverV2GetGraphRes = await apiBridge.getIbGibGraph(domainAddr, v2Addr, true);
             if (!serverV2GetGraphRes.success || !serverV2GetGraphRes.graph) {
-                devLog(`✗ Check: Failed to fetch V2 graph from server: ${serverV2GetGraphRes.message}`);
-                return;
+                devLog(`✗ Check: Failed to fetch V2 graph from server: ${serverV2GetGraphRes.message}`); return;
             }
-            const serverV2Graph = serverV2GetGraphRes.graph;
-
-            const v2GraphsEqual = graphsAreEquivalent({ graphA: localV2Graph, graphB: serverV2Graph });
-            if (v2GraphsEqual) {
-                devLog('✓ Check: V2 timeline dependency graphs are equivalent on client and server.');
-            } else {
-                devLog('✗ Check: V2 timeline dependency graphs mismatch between client and server!');
-                return;
+            if (!graphsAreEquivalent({ graphA: localV2Graph, graphB: serverV2GetGraphRes.graph })) {
+                devLog('✗ Check: V2 timeline dependency graphs mismatch between client and server!'); return;
             }
+            devLog('✓ Check: V2 timeline dependency graphs are equivalent on client and server.');
 
-            // 3. Verify evolved sender identity I exists locally and on server, n = 2
-            const latestLocalIAddr = await metaspace.getLatestAddr({
-                addr: domainAddr,
-                space
-            });
-            if (!latestLocalIAddr) {
-                devLog('✗ Check: Evolved domain keystone tip NOT found in local space!');
-                return;
-            }
+            // 3. Verify domain keystone n=1, then verify domain/delegate/session on server.
+            //    I only evolves once (delegate registration during setup).
+            //    The delegate is the sync sender and evolves during sync passes, not I.
+            const latestLocalIAddr = await metaspace.getLatestAddr({ addr: domainAddr, space });
+            if (!latestLocalIAddr) { devLog('✗ Check: Domain keystone tip not found locally!'); return; }
             const localIRes = await metaspace.get({ addrs: [latestLocalIAddr], space });
             const localI = localIRes.ibGibs?.[0] as KeystoneIbGib_V1 | undefined;
-            if (!localI) {
-                devLog('✗ Check: Failed to load evolved I from local space.');
-                return;
-            }
-            devLog(`✓ Check: Evolved Domain Keystone exists locally: ${latestLocalIAddr}`);
+            if (!localI) { devLog('✗ Check: Failed to load domain keystone!'); return; }
 
             const nI = localI.data?.n;
             devLog(`✓ Check: Evolved I tip is at n = ${nI}.`);
-            if (nI !== 2) {
-                devLog(`✗ Check: Expected I to evolve to n = 2, got n = ${nI}.`);
-                return;
+            if (nI !== 1) {
+                devLog(`✗ Check: Expected I to evolve to n = 1 (delegate registration only), got n = ${nI}.`); return;
             }
 
-            const serverIGetRes = await apiBridge.getIbGib(domainAddr, latestLocalIAddr);
-            if (!serverIGetRes.success || !serverIGetRes.ibGib) {
-                devLog(`✗ Check: Evolved Domain Keystone tip NOT found on server!`);
-                return;
-            }
-            devLog(`✓ Check: Evolved Domain Keystone tip exists on server.`);
-
-            // 4. Verify session identity S tip exists locally and on server, n = 3
-            const syncProof = localI.data?.proofs?.find(p => p.claim?.verb === 'sync');
-            const sessionIdentityTjpAddr = syncProof?.claim?.target;
-            if (!sessionIdentityTjpAddr) {
-                devLog('✗ Check: Evolved I sync claim does not target a session keystone.');
-                return;
-            }
-
-            const latestLocalSAddr = await metaspace.getLatestAddr({
-                addr: sessionIdentityTjpAddr,
-                space
+            const { sessionIdentityTjpAddr } = await verifyIdentitiesOnServer({
+                localI, metaspace, space, apiBridge, domainAddr
             });
+
+            // 4. Verify session keystone S n=3 and graph matches
+            const latestLocalSAddr = await metaspace.getLatestAddr({ addr: sessionIdentityTjpAddr, space });
             if (!latestLocalSAddr) {
-                devLog('✗ Check: Latest Session Keystone (S) NOT found in local space.');
-                return;
+                devLog('✗ Check: Latest Session Keystone (S) NOT found in local space.'); return;
             }
             devLog(`✓ Check: Found latest session keystone (S) locally: ${latestLocalSAddr}`);
 
             const localSRes = await metaspace.get({ addrs: [latestLocalSAddr], space });
             const sessionS = localSRes.ibGibs?.[0] as KeystoneIbGib_V1 | undefined;
-            if (!sessionS) {
-                devLog('✗ Check: Failed to load latest Session Keystone (S) locally.');
-                return;
-            }
+            if (!sessionS) { devLog('✗ Check: Failed to load Session Keystone (S) locally.'); return; }
 
             const nS = sessionS.data?.n;
             devLog(`✓ Check: Latest session S tip evolved to n = ${nS}.`);
             if (nS !== 3) {
-                devLog(`✗ Check: Expected latest session S to evolve to n = 3, got n = ${nS}.`);
-                return;
+                devLog(`✗ Check: Expected latest session S to evolve to n = 3, got n = ${nS}.`); return;
             }
 
             const serverSGetRes = await apiBridge.getIbGib(domainAddr, latestLocalSAddr);
             if (!serverSGetRes.success || !serverSGetRes.ibGib) {
-                devLog(`✗ Check: Latest Session Keystone (S) NOT found on server!`);
-                return;
+                devLog(`✗ Check: Latest Session Keystone (S) NOT found on server!`); return;
             }
             devLog(`✓ Check: Latest Session Keystone (S) exists on server.`);
 
-            // 5. Assert S graph is identical on client and server
-            const localSGraph = await metaspace.getDependencyGraph({
-                ibGibAddr: latestLocalSAddr,
-                space
-            });
+            const localSGraph = await metaspace.getDependencyGraph({ ibGibAddr: latestLocalSAddr, space });
             const serverSGetGraphRes = await apiBridge.getIbGibGraph(domainAddr, sessionIdentityTjpAddr, true);
             if (!serverSGetGraphRes.success || !serverSGetGraphRes.graph) {
-                devLog(`✗ Check: Failed to fetch session S graph from server: ${serverSGetGraphRes.message}`);
-                return;
+                devLog(`✗ Check: Failed to fetch session S graph from server: ${serverSGetGraphRes.message}`); return;
             }
-            const serverSGraph = serverSGetGraphRes.graph;
-
-            const sGraphsEqual = graphsAreEquivalent({ graphA: localSGraph, graphB: serverSGraph });
-            if (sGraphsEqual) {
-                devLog('✓ Check: Session Keystone (S) dependency graphs are equivalent on client and server.');
-            } else {
-                devLog('✗ Check: Session Keystone (S) dependency graphs mismatch between client and server!');
-                return;
+            if (!graphsAreEquivalent({ graphA: localSGraph, graphB: serverSGetGraphRes.graph })) {
+                devLog('✗ Check: Session Keystone (S) dependency graphs mismatch between client and server!'); return;
             }
+            devLog('✓ Check: Session Keystone (S) dependency graphs are equivalent on client and server.');
 
             devLog('🎉 ALL PHASE 4.3B TRANSACTION SYNC CHECKS PASSED FLAWLESSLY! ✓');
             btn.textContent = '✓ 4.3B All Passed';