@ibgib/core-gib 0.1.59 → 0.1.61

package/src/sync/sync-saga-coordinator.mts

@@ -32,7 +32,7 @@ import {
     HandleSagaResponseContextResult,
     SyncSagaFrameDependencyGraph,
 } from "./sync-types.mjs";
-import { getSyncSagaFrameOrigin, getFullSyncSagaHistory, getSyncIb, getTempSpaceName, isPastFrame, putInSpace_dnasThenNonDnas, validateFullSyncSagaHistory, getAllOrphanedAddresses, getFinalConflictsInfo } from "./sync-helpers.mjs";
+import { getSyncSagaFrameOrigin, getFullSyncSagaHistory, getSyncIb, getTempSpaceName, isPastFrame, putInSpace_dnasThenNonDnas, validateFullSyncSagaHistory, getAllOrphanedAddresses, getFinalConflictsInfo, getSyncSagaFrameDependencyGraph } from "./sync-helpers.mjs";
 import { getDeltaDependencyGraph, getDependencyGraph, toFlatGraph } from "../common/other/graph-helper.mjs";
 import {
     SyncSagaMessageData_V1, SyncSagaMessageInitData_V1,
@@ -466,144 +466,158 @@ export class SyncSagaCoordinator {
             }));
             // #endregion set up peer observable for any domainPayloadsMap
 
-            // ...create/compose the Request Context itself...
-            const requestCtx = await this.createSyncSagaContext({
-                sagaFrame: currentFrame,
-                /**
-                 * init frame: empty
-                 * ack frame: possible push offers
-                 * delta frame: requested ibgibs or commit offer
-                 * commit frame: empty
-                 */
-                payloadIbGibsDomain: nextDomainIbGibs,
-                localSpace,
-                metaspace,
-                sessionIdentityAddr: peer.currentSessionIdentityAddr,
-                peer,
-            });
+            try {
+                // ...create/compose the Request Context itself...
+                const requestCtx = await this.createSyncSagaContext({
+                    sagaFrame: currentFrame,
+                    /**
+                     * init frame: empty
+                     * ack frame: possible push offers
+                     * delta frame: requested ibgibs or commit offer
+                     * commit frame: empty
+                     */
+                    payloadIbGibsDomain: nextDomainIbGibs,
+                    localSpace,
+                    metaspace,
+                    sessionIdentityAddr: peer.currentSessionIdentityAddr,
+                    peer,
+                });
 
-            // #region Log what we're sending
-            if (logalotControlDomain) {
-                const domainAddrs = nextDomainIbGibs.map(p => getIbGibAddr({ ibGib: p }));
-                console.log(`${lc}${lcControlDomain} SENDER TRANSMIT -> peer.witness (I: 5b0081803698770f0bf64992220b312)`);
-                console.log(`${lc}${lcControlDomain}   Context: ${getIbGibAddr({ ibGib: requestCtx })}`);
-                console.log(`${lc}${lcControlDomain}   Frame: ${getIbGibAddr({ ibGib: currentFrame })}`);
-                console.log(`${lc}${lcControlDomain}   DOMAIN Payloads (${domainAddrs.length}): ${domainAddrs.join(', ') || '(none)'}`);
-            }
-            // #endregion Log what we're sending
-
-            // update our saga listeners...
-            // if (logalot) { console.log(`${lc} transmitting... requestCtx: ${pretty(requestCtx)} (I: 8cf20817c66899abdb1e76df50356826)`); }
-            updates$.next(requestCtx); // spins off for saga UI updates
-
-            // ...And send the context.
-            peer.setOptionalOpts({ localSpace, localTempSpace: tempSpace, });
-            const responseCtx = await peer.witness(requestCtx);
-
-            // the send returned, but a peer can return a falsy responseCtx, if
-            // we just sent a commit to them and they're done. If so, there will
-            // necessarily be no payload to wait to receive
-            if (!responseCtx) {
-                if (currentFrame) {
-                    // Check for Commit (Peer silence expected)
-                    const msg = await getSyncSagaMessageFromFrame({ frameIbGib: currentFrame, space: localSpace });
-                    if (msg?.data?.stage === SyncStage.commit) {
-                        if (logalot) { console.log(`${lc} Sender sent Commit. Peer returned no response. Saga Complete. (I: 26f9ee073858ca78b8284753368b5226)`); }
-                        currentFrame = null;
-                        break;
+                // #region Log what we're sending
+                if (logalotControlDomain) {
+                    const domainAddrs = nextDomainIbGibs.map(p => getIbGibAddr({ ibGib: p }));
+                    console.log(`${lc}${lcControlDomain} SENDER TRANSMIT -> peer.witness (I: 5b0081803698770f0bf64992220b312)`);
+                    console.log(`${lc}${lcControlDomain}   Context: ${getIbGibAddr({ ibGib: requestCtx })}`);
+                    console.log(`${lc}${lcControlDomain}   Frame: ${getIbGibAddr({ ibGib: currentFrame })}`);
+                    console.log(`${lc}${lcControlDomain}   DOMAIN Payloads (${domainAddrs.length}): ${domainAddrs.join(', ') || '(none)'}`);
+                }
+                // #endregion Log what we're sending
+
+                // update our saga listeners...
+                // if (logalot) { console.log(`${lc} transmitting... requestCtx: ${pretty(requestCtx)} (I: 8cf20817c66899abdb1e76df50356826)`); }
+                updates$.next(requestCtx); // spins off for saga UI updates
+
+                // ...And send the context.
+                peer.setOptionalOpts({ localSpace, localTempSpace: tempSpace, });
+                const responseCtx = await peer.witness(requestCtx);
+
+                // the send returned, but a peer can return a falsy responseCtx, if
+                // we just sent a commit to them and they're done. If so, there will
+                // necessarily be no payload to wait to receive
+                if (!responseCtx) {
+                    if (currentFrame) {
+                        // Check for Commit (Peer silence expected)
+                        const msg = await getSyncSagaMessageFromFrame({ frameIbGib: currentFrame, space: localSpace });
+                        if (msg?.data?.stage === SyncStage.commit) {
+                            if (logalot) { console.log(`${lc} Sender sent Commit. Peer returned no response. Saga Complete. (I: 26f9ee073858ca78b8284753368b5226)`); }
+                            currentFrame = null;
+                            break;
+                        } else {
+                            throw new Error(`(UNEXPECTED) responseCtx falsy and currentFrame truthy, but we're not in the commit stage? This may be expected ultimately, but atow I am not seeing this as being expected. (E: cc34498962bd370deeff351fac939f26)`);
+                        }
                     } else {
-                        throw new Error(`(UNEXPECTED) responseCtx falsy and currentFrame truthy, but we're not in the commit stage? This may be expected ultimately, but atow I am not seeing this as being expected. (E: cc34498962bd370deeff351fac939f26)`);
+                        throw new Error(`(UNEXPECTED) no response and currentFrame falsy? (E: 8d1085ea2f28cfc3f9c922649864a826)`);
                     }
-                } else {
-                    throw new Error(`(UNEXPECTED) no response and currentFrame falsy? (E: 8d1085ea2f28cfc3f9c922649864a826)`);
                 }
-            }
 
-            // at this point, we did indeed receive a response to analyze. BUT!
-            // we have only necessarily received the response context ibgib.
-            // if there were payloads expected to be transferred, they may not
-            // be done yet.
-
-            if (!responseCtx.data) { throw new Error(`(UNEXPECTED) responseCtx.data falsy? (E: a969992bae53ab18a827ec58aec15826)`); }
-            updates$.next(responseCtx); // spins off for saga UI updating
-
-            // immediately validate context/saga frame (but not payloads because
-            // we may not have those yet)
-            const contextAndSagaFrameValidationErrors =
-                await validateContextAndSagaFrame({ context: responseCtx });
-            if (contextAndSagaFrameValidationErrors.length > 0) { throw new Error(`contextAndSagaFrameValidationErrors: ${contextAndSagaFrameValidationErrors} (E: 6eebe8e7fa437c00a8cde3ada3c66826)`); }
-
-            // Extract expected domain addresses from response context
-            const responsePayloadAddrsDomain = responseCtx.data[SYNC_SAGA_PAYLOAD_ADDRS_DOMAIN] as string[] || [];
-
-            // Poll for them if needed. see above jsdocs for domainPayloadsMap
-            if (responsePayloadAddrsDomain.length > 0) {
-                responseCtx.payloadIbGibsDomain = await this.pollForDomainPayloads({
-                    expectedAddrs: responsePayloadAddrsDomain,
-                    pollIntervalMs: 20, // relatively arbitrary right now
-                    domainPayloadsMap,
-                    tempSpace,
-                });
-            }
+                // at this point, we did indeed receive a response to analyze. BUT!
+                // we have only necessarily received the response context ibgib.
+                // if there were payloads expected to be transferred, they may not
+                // be done yet.
 
-            // #region Log what we received back
-            if (!responseCtx.sagaFrame) { throw new Error(`(UNEXPECTED) responseCtx.sagaFrame falsy? the Peer should have set this when it got the response back from the remote. (E: e650adadf9a2063ec6764a1e31d3d826)`); }
-            if (logalotControlDomain) {
-                const responseControlAddrs = responseCtx.data?.['@payloadAddrsControl'] as string[] || [];
-                console.log(`${lc}${lcControlDomain} SENDER RECEIVED <- peer.witness (I: 3dc76a9744d89a4fc3e2f076c2be4826)`);
-                console.log(`${lc}${lcControlDomain}   Response Context: ${getIbGibAddr({ ibGib: responseCtx })}`);
-                console.log(`${lc}${lcControlDomain}   Response Saga Frame: ${getIbGibAddr({ ibGib: responseCtx.sagaFrame })}`);
-                console.log(`${lc}${lcControlDomain}   CONTROL Payloads (${responseControlAddrs.length}): ${responseControlAddrs.join(', ') || '(none)'}`);
-                console.log(`${lc}${lcControlDomain}   DOMAIN Payloads (${responsePayloadAddrsDomain.length}): ${responsePayloadAddrsDomain.join(', ') || '(none)'}`);
-            }
-            // #endregion Log what we received back
+                if (!responseCtx.data) { throw new Error(`(UNEXPECTED) responseCtx.data falsy? (E: a969992bae53ab18a827ec58aec15826)`); }
+                updates$.next(responseCtx); // spins off for saga UI updating
 
-            // at this point, we have received the context AND **all** of the
-            // domain payloads (if applicable), so we are ready to do the next
-            // iteration in the saga loop
+                // immediately validate context/saga frame (but not payloads because
+                // we may not have those yet)
+                const contextAndSagaFrameValidationErrors =
+                    await validateContextAndSagaFrame({ context: responseCtx });
+                if (contextAndSagaFrameValidationErrors.length > 0) { throw new Error(`contextAndSagaFrameValidationErrors: ${contextAndSagaFrameValidationErrors} (E: 6eebe8e7fa437c00a8cde3ada3c66826)`); }
 
-            // this is the part that drives the FSM forward, i.e., when we
-            // evolve the sync saga ibgib itself to the next frame if we aren't
-            // finished/errored out.
-            const contextResult = await this.handleResponseSagaContext({
-                sagaContext: responseCtx,
-                initDomainGraph,
-                mySpace: localSpace,
-                myTempSpace: tempSpace,
-                metaspace,
-            });
+                // Turn-by-turn continuation & identity checks
+                const returnContextErrors = await this.validateReturnContext({
+                    requestCtx,
+                    responseCtx,
+                    localSpace,
+                });
+                if (returnContextErrors.length > 0) {
+                    throw new Error(`validateReturnContext errors: ${returnContextErrors.join(', ')} (E: cb8a023b9d0728cceb09fa3da0bb8226)`);
+                }
 
-            if (!contextResult) {
-                // should this ever hit?
-                console.error(`${lc} NAG ERROR (DOES NOT THROW): does this ever hit now? (E: e04d02efc2a8e72a88b79f1f0f95ca26)`);
-                break;
-            } else if (contextResult.nextFrameInfo?.sagaComplete) {
-                if (logalot) { console.log(`${lc} Handler returned null (Saga End). (I: 123bf9e7dca8886de72553a8d4f29e26)`); }
-                break;
-            }
+                // Extract expected domain addresses from response context
+                const responsePayloadAddrsDomain = responseCtx.data[SYNC_SAGA_PAYLOAD_ADDRS_DOMAIN] as string[] || [];
 
-            // #region error conditions throw
-            if (contextResult.errorMsg) {
-                throw new Error(`Couldn't handle response saga context. errorMsg: ${contextResult.errorMsg} (E: c948e81d513b2a0eb8b8afa878edc626)`);
-            } else if (!contextResult.nextFrameInfo) {
-                throw new Error(`(UNEXPECTED) contextResult.nextFrameInfo falsy? (E: c287a82e823e662a77923278e2418826)`);
-            }
-            // #endregion error conditions throw
+                // Poll for them if needed. see above jsdocs for domainPayloadsMap
+                if (responsePayloadAddrsDomain.length > 0) {
+                    responseCtx.payloadIbGibsDomain = await this.pollForDomainPayloads({
+                        expectedAddrs: responsePayloadAddrsDomain,
+                        pollIntervalMs: 20, // relatively arbitrary right now
+                        domainPayloadsMap,
+                        tempSpace,
+                    });
+                }
 
-            // we have another frame to process and send out, with possibly
-            // payload domain ibgibs as well
-            const { frame, payloadIbGibsDomain, } = contextResult.nextFrameInfo;
-            currentFrame = frame;
-            nextDomainIbGibs = [...(payloadIbGibsDomain || [])];
-
-            // #region Log handler output for next iteration
-            if (logalotControlDomain) {
-                const handlerDomainAddrs = nextDomainIbGibs.map(p => getIbGibAddr({ ibGib: p }));
-                console.log(`${lc}${lcControlDomain} HANDLER RESULT -> next iteration (I: 6b0d88c4c28857ccd812381515bd7826)`);
-                console.log(`${lc}${lcControlDomain}   Next Frame: ${getIbGibAddr({ ibGib: currentFrame })}`);
-                console.log(`${lc}${lcControlDomain}   DOMAIN for next (${handlerDomainAddrs.length}): ${handlerDomainAddrs.join(', ') || '(none)'}`);
+                // #region Log what we received back
+                if (!responseCtx.sagaFrame) { throw new Error(`(UNEXPECTED) responseCtx.sagaFrame falsy? the Peer should have set this when it got the response back from the remote. (E: e650adadf9a2063ec6764a1e31d3d826)`); }
+                if (logalotControlDomain) {
+                    const responseControlAddrs = responseCtx.data?.['@payloadAddrsControl'] as string[] || [];
+                    console.log(`${lc}${lcControlDomain} SENDER RECEIVED <- peer.witness (I: 3dc76a9744d89a4fc3e2f076c2be4826)`);
+                    console.log(`${lc}${lcControlDomain}   Response Context: ${getIbGibAddr({ ibGib: responseCtx })}`);
+                    console.log(`${lc}${lcControlDomain}   Response Saga Frame: ${getIbGibAddr({ ibGib: responseCtx.sagaFrame })}`);
+                    console.log(`${lc}${lcControlDomain}   CONTROL Payloads (${responseControlAddrs.length}): ${responseControlAddrs.join(', ') || '(none)'}`);
+                    console.log(`${lc}${lcControlDomain}   DOMAIN Payloads (${responsePayloadAddrsDomain.length}): ${responsePayloadAddrsDomain.join(', ') || '(none)'}`);
+                }
+                // #endregion Log what we received back
+
+                // at this point, we have received the context AND **all** of the
+                // domain payloads (if applicable), so we are ready to do the next
+                // iteration in the saga loop
+
+                // this is the part that drives the FSM forward, i.e., when we
+                // evolve the sync saga ibgib itself to the next frame if we aren't
+                // finished/errored out.
+                const contextResult = await this.handleResponseSagaContext({
+                    sagaContext: responseCtx,
+                    initDomainGraph,
+                    mySpace: localSpace,
+                    myTempSpace: tempSpace,
+                    metaspace,
+                });
+
+                if (!contextResult) {
+                    // should this ever hit?
+                    console.error(`${lc} NAG ERROR (DOES NOT THROW): does this ever hit now? (E: e04d02efc2a8e72a88b79f1f0f95ca26)`);
+                    break;
+                } else if (contextResult.nextFrameInfo?.sagaComplete) {
+                    if (logalot) { console.log(`${lc} Handler returned null (Saga End). (I: 123bf9e7dca8886de72553a8d4f29e26)`); }
+                    break;
+                }
+
+                // #region error conditions throw
+                if (contextResult.errorMsg) {
+                    throw new Error(`Couldn't handle response saga context. errorMsg: ${contextResult.errorMsg} (E: c948e81d513b2a0eb8b8afa878edc626)`);
+                } else if (!contextResult.nextFrameInfo) {
+                    throw new Error(`(UNEXPECTED) contextResult.nextFrameInfo falsy? (E: c287a82e823e662a77923278e2418826)`);
+                }
+                // #endregion error conditions throw
+
+                // we have another frame to process and send out, with possibly
+                // payload domain ibgibs as well
+                const { frame, payloadIbGibsDomain, } = contextResult.nextFrameInfo;
+                currentFrame = frame;
+                nextDomainIbGibs = [...(payloadIbGibsDomain || [])];
+
+                // #region Log handler output for next iteration
+                if (logalotControlDomain) {
+                    const handlerDomainAddrs = nextDomainIbGibs.map(p => getIbGibAddr({ ibGib: p }));
+                    console.log(`${lc}${lcControlDomain} HANDLER RESULT -> next iteration (I: 6b0d88c4c28857ccd812381515bd7826)`);
+                    console.log(`${lc}${lcControlDomain}   Next Frame: ${getIbGibAddr({ ibGib: currentFrame })}`);
+                    console.log(`${lc}${lcControlDomain}   DOMAIN for next (${handlerDomainAddrs.length}): ${handlerDomainAddrs.join(', ') || '(none)'}`);
+                }
+                // #endregion Log handler output for next iteration
+            } finally {
+                await subscription.unsubscribe();
             }
-            // #endregion Log handler output for next iteration
         }
     }
 
@@ -738,6 +752,16 @@ export class SyncSagaCoordinator {
 
             // Attach actual ibgibs for transport
             contextIbGib.sagaFrame = sagaFrame;
+
+            const { msgStones } = await getSyncSagaFrameDependencyGraph({
+                sagaIbGib: sagaFrame,
+                localSpace: localSpace,
+            });
+            if (msgStones.length !== 1) {
+                throw new Error(`(UNEXPECTED) msgStones.length !== 1 inside createSyncSagaContext? (E: a98165cf46ab4e82b7bd5e45a273b826)`);
+            }
+            contextIbGib.sagaFrameMsg = msgStones[0];
+
             if (payloadIbGibsDomain && payloadIbGibsDomain.length > 0) {
                 contextIbGib.payloadIbGibsDomain = payloadIbGibsDomain;
             }
@@ -942,6 +966,54 @@ export class SyncSagaCoordinator {
         }
     }
 
+    /**
+     * Validates that the return context received from a peer is a valid
+     * continuation of the outbound context and that the session identity
+     * is consistent.
+     */
+    private async validateReturnContext({
+        requestCtx,
+        responseCtx,
+        localSpace,
+    }: {
+        requestCtx: SyncSagaContextIbGib_V1,
+        responseCtx: SyncSagaContextIbGib_V1,
+        localSpace: IbGibSpaceAny,
+    }): Promise<string[]> {
+        const lc = `${this.lc}[${this.validateReturnContext.name}]`;
+        const errors: string[] = [];
+        try {
+            // 1. Verify saga frame continuation
+            if (requestCtx.sagaFrame && responseCtx.sagaFrame) {
+                const requestFrameAddr = getIbGibAddr({ ibGib: requestCtx.sagaFrame });
+                const responseFrameAddr = getIbGibAddr({ ibGib: responseCtx.sagaFrame });
+                
+                const isContinuation = await isPastFrame({
+                    olderAddr: requestFrameAddr,
+                    newerAddr: responseFrameAddr,
+                    space: localSpace,
+                });
+                if (!isContinuation) {
+                    errors.push(`Response saga frame (${responseFrameAddr}) is not a valid continuation of request saga frame (${requestFrameAddr}). (E: 2c85e8d97318ff24ac8a02bd3a068226)`);
+                }
+            } else {
+                errors.push(`Missing sagaFrame on requestCtx or responseCtx. (E: b65c68ff891000ddca8d22384a088226)`);
+            }
+
+            // 2. Verify session identity has not changed
+            const expectedSessionIdAddr = requestCtx.signedSessionIdentity ?
+                getIbGibAddr({ ibGib: requestCtx.signedSessionIdentity }) :
+                requestCtx.rel8ns?.sessionIdentity?.[0];
+            const responseSessionIdAddr = responseCtx.rel8ns?.sessionIdentity?.[0];
+            if (expectedSessionIdAddr !== responseSessionIdAddr) {
+                errors.push(`Session identity mismatch. Expected ${expectedSessionIdAddr}, got ${responseSessionIdAddr}. (E: ab98716bca88d2243cc822187768226)`);
+            }
+        } catch (error) {
+            errors.push(`Error during validateReturnContext: ${extractErrorMsg(error)} (E: da878e1239aa88ee27bdfca005c28226)`);
+        }
+        return errors;
+    }
+
     /**
      * Helper to poll for streaming domain payloads and put them in the
      * local {@link tempSpace}.
@@ -965,7 +1037,8 @@ export class SyncSagaCoordinator {
 
             let resultDomainPayloads: IbGib_V1[] = [];
 
-            let pending = [...expectedAddrs];
+            const uniqueExpectedAddrs = [...new Set(expectedAddrs)];
+            let pending = [...uniqueExpectedAddrs];
             const start = Date.now();
             /**
              * This needs
@@ -999,8 +1072,8 @@ export class SyncSagaCoordinator {
                 if (pending.length > 0) { await delay(pollIntervalMs); }
             }
 
-            if (expectedAddrs.length !== resultDomainPayloads.length) {
-                throw new Error(`(UNEXPECTED) expectedAddrs.length !== resultDomainPayloads.length? at this point, we expect all of the payload ibgibs to have been received. (E: 03749a7478c4b8b28bfc86951887a826)`);
+            if (uniqueExpectedAddrs.length !== resultDomainPayloads.length) {
+                throw new Error(`(UNEXPECTED) uniqueExpectedAddrs.length !== resultDomainPayloads.length? at this point, we expect all of the payload ibgibs to have been received. (E: 03749a7478c4b8b28bfc86951887a826)`);
             }
 
             return resultDomainPayloads;
@@ -1594,12 +1667,10 @@ export class SyncSagaCoordinator {
              */
             const outgoingPayloadIbGibsDomain_conflicts: IbGib_V1[] = [];
 
+            const activeConflicts: SyncSagaConflictInfo[] = [];
             if (conflicts.length > 0) {
                 if (logalot) { console.log(`${lc} [CONFLICT DEBUG] Processing ${conflicts.length} non-terminal conflicts`); }
 
-                // we will need to resolve conflicts, so no commit yet
-                proposeCommit = false;
-
                 for (const conflict of conflicts) {
                     const {
                         receiverTipAddr,
@@ -1671,11 +1742,24 @@ export class SyncSagaCoordinator {
                         const deltaPayloadIbGib = deltaGraph[deltaPayloadAddr];
                         outgoingPayloadIbGibsDomain_conflicts.push(deltaPayloadIbGib);
                     });
-                    if (conflict.accretivePayloadAddrs) { throw new Error(`(UNEXPECTED) conflict.accretivePayloadAddrs already truthy? This is expected to be falsy at this point in the sync. (E: 6b6b1846779867849cbde208f4374326)`); }
-                    conflict.accretivePayloadAddrs = accretivePayloadAddrs;
+
+                    const isFastForward = latestCommonFrameAddr === receiverTipAddr;
+                    if (isFastForward) {
+                        if (logalot) { console.log(`${lc} [CONFLICT DEBUG] TJP ${tjpAddr}: Fast-forward detected (receiver behind sender). Excluding from active conflicts and sending delta payload.`); }
+                    } else {
+                        if (conflict.accretivePayloadAddrs) { throw new Error(`(UNEXPECTED) conflict.accretivePayloadAddrs already truthy? This is expected to be falsy at this point in the sync. (E: 6b6b1846779867849cbde208f4374326)`); }
+                        conflict.accretivePayloadAddrs = accretivePayloadAddrs;
+                        activeConflicts.push(conflict);
+                    }
+                }
+
+                if (activeConflicts.length > 0) {
+                    proposeCommit = false;
+                } else {
+                    proposeCommit = true;
                 }
 
-                if (logalot) { console.log(`${lc} [CONFLICT DEBUG] Finished processing ${conflicts.length} conflicts. outgoingPayloadIbGibsDomain_conflicts.length (total outgoing payload ibgibs for ALL conflicts): ${outgoingPayloadIbGibsDomain_conflicts.length}`); }
+                if (logalot) { console.log(`${lc} [CONFLICT DEBUG] Finished processing ${conflicts.length} conflicts. Active (divergent) conflicts: ${activeConflicts.length}. outgoingPayloadIbGibsDomain_conflicts.length (total outgoing payload ibgibs for ALL conflicts): ${outgoingPayloadIbGibsDomain_conflicts.length}`); }
             } else {
                 if (logalot) { console.log(`${lc} [CONFLICT DEBUG] No optimistic conflicts to process`); }
             }
@@ -1715,7 +1799,7 @@ export class SyncSagaCoordinator {
                 /**
                  * these are the modified conflicts with additional information.
                  */
-                conflicts,
+                conflicts: activeConflicts,
                 /**
                  * we're sending these domain ibgibs as payload (they were
                  * requested by receiver and/or they are being sent as delta

package/src/sync/sync-withid.pingpong.respec.mts

@@ -9,7 +9,7 @@
  */
 
 import {
-    respecfully, ifWeMight, iReckon,
+    respecfully, ifWeMight, iReckon, ifWe,
 } from '@ibgib/helper-gib/dist/respec-gib/respec-gib.mjs';
 const maam = `[${import.meta.url}]`, sir = maam;
 import { clone, delay, extractErrorMsg } from '@ibgib/helper-gib/dist/helpers/utils-helper.mjs';
@@ -34,7 +34,8 @@ import { IbGibAddr } from '@ibgib/ts-gib/dist/types.mjs';
 import { getIdentity_throwIfUndefined } from '../keystone/keystone-helpers.mjs';
 import { Factory_V1 } from '@ibgib/ts-gib/dist/V1/factory.mjs';
 import { IbGib_V1 } from '@ibgib/ts-gib/dist/V1/types.mjs';
-import { getDependencyGraph } from '../common/other/graph-helper.mjs';
+import { getDependencyGraph, graphsAreEquivalent } from '../common/other/graph-helper.mjs';
+import { getFromSpace } from '../witness/space/space-helper.mjs';
 
 const logalot = GLOBAL_LOG_A_LOT;
 const lc = sir;
@@ -153,9 +154,81 @@ await respecfully(sir, `Test Phase 3A: Ping Pong Sync with Identity`, async () =
         syncError = error;
     }
 
-    await ifWeMight(sir, 'completes the entire sync saga successfully', async () => {
+    await ifWe(sir, 'completes the entire sync saga successfully', async () => {
         const errorMsg = syncError ? extractErrorMsg(syncError) : '';
         iReckon(sir, syncError).asTo(`syncError: ${errorMsg}`).isGonnaBeFalsy();
     });
 
+    await ifWe(sir, 'alpha dep graph matches on source and dest', async () => {
+        const resGetDest = await getFromSpace({ space: destSpace, addr: xStoneAddr });
+        iReckon(sir, resGetDest.success && resGetDest.ibGibs?.length === 1).asTo('xStone exists in destSpace').isGonnaBeTrue();
+        if (resGetDest.success && resGetDest.ibGibs?.[0]) {
+            const xStoneDest = resGetDest.ibGibs[0];
+            const depGraphSource = await getDependencyGraph({ ibGib: xStone, space: sourceSpace });
+            const depGraphDest = await getDependencyGraph({ ibGib: xStoneDest, space: destSpace });
+            const equal = graphsAreEquivalent({ graphA: depGraphSource, graphB: depGraphDest });
+            iReckon(sir, equal).asTo('graphs are equivalent').isGonnaBeTrue();
+        }
+    });
+
+    await ifWe(sir, 'sessionIdentity evolved the expected number of times', async () => {
+        const latestS = peer.currentSessionIdentity;
+        iReckon(sir, latestS).asTo('latest session identity exists on peer').isGonnaBeTruthy();
+        if (latestS) {
+            iReckon(sir, latestS.data?.n).asTo('session identity data.n').isGonnaBe(2);
+        }
+    });
+
+    await ifWe(sir, 'sender durable space has I (evolved frame)', async () => {
+        const latestSenderIdentityAddr = await metaspace.getLatestAddr({
+            addr: getIbGibAddr({ ibGib: senderIdentity }),
+            space: sourceSpace,
+        });
+        iReckon(sir, latestSenderIdentityAddr).asTo('latestSenderIdentityAddr exists').isGonnaBeTruthy();
+        if (latestSenderIdentityAddr) {
+            const resGetSourceI = await getFromSpace({ space: sourceSpace, addr: latestSenderIdentityAddr });
+            iReckon(sir, resGetSourceI.success && resGetSourceI.ibGibs?.length === 1).asTo('evolved I exists in sourceSpace').isGonnaBeTrue();
+            if (resGetSourceI.success && resGetSourceI.ibGibs?.[0]) {
+                const evolvedI = resGetSourceI.ibGibs[0];
+                iReckon(sir, evolvedI.data?.n).asTo('evolved I data.n').isGonnaBe(1);
+            }
+        }
+    });
+
+    await ifWe(sir, 'receiver durable space has I (evolved frame)', async () => {
+        const latestSenderIdentityAddr = await metaspace.getLatestAddr({
+            addr: getIbGibAddr({ ibGib: senderIdentity }),
+            space: sourceSpace,
+        });
+        iReckon(sir, latestSenderIdentityAddr).asTo('latestSenderIdentityAddr exists').isGonnaBeTruthy();
+        if (latestSenderIdentityAddr) {
+            const resGetDestI = await getFromSpace({ space: destSpace, addr: latestSenderIdentityAddr });
+            iReckon(sir, resGetDestI.success && resGetDestI.ibGibs?.length === 1).asTo('evolved I exists in destSpace').isGonnaBeTrue();
+            if (resGetDestI.success && resGetDestI.ibGibs?.[0]) {
+                const evolvedI = resGetDestI.ibGibs[0];
+                iReckon(sir, evolvedI.data?.n).asTo('evolved I data.n').isGonnaBe(1);
+            }
+        }
+    });
+
+    await ifWe(sir, 'sender durable space has full S dep graph', async () => {
+        const latestS = peer.currentSessionIdentity;
+        iReckon(sir, latestS).asTo('latestS exists').isGonnaBeTruthy();
+        if (latestS) {
+            const depGraphS = await getDependencyGraph({ ibGib: latestS, space: sourceSpace });
+            const addrs = Object.keys(depGraphS);
+            iReckon(sir, addrs.length > 2).asTo('number of nodes in S graph > 2').isGonnaBeTrue();
+        }
+    });
+
+    await ifWe(sir, 'receiver durable space has full S dep graph', async () => {
+        const latestS = peer.currentSessionIdentity;
+        iReckon(sir, latestS).asTo('latestS exists').isGonnaBeTruthy();
+        if (latestS) {
+            const depGraphS = await getDependencyGraph({ ibGib: latestS, space: destSpace });
+            const addrs = Object.keys(depGraphS);
+            iReckon(sir, addrs.length > 2).asTo('number of nodes in S graph in destSpace > 2').isGonnaBeTrue();
+        }
+    });
+
 });

package/src/timeline/timeline-api.mts

@@ -293,11 +293,7 @@ export async function appendToTimeline({
                 });
             }
 
-            // should we publish within the lock or not within the lock?
-            // should we await the publish or spin it off
-            // right now I have this spin off, inside the lock
-            // await metaspace.registerNewIbGib({ ibGib: newTimelineIbGib, space });
-            metaspace.registerNewIbGib({ ibGib: newTimelineIbGib, space }); // spin off
+            await metaspace.registerNewIbGib({ ibGib: newTimelineIbGib, space }); // already spins off
 
             return newTimelineIbGib;
         };
@@ -314,12 +310,6 @@ export async function appendToTimeline({
                 fn,
             });
 
-        // should we publish within the lock or not within the lock?
-        // should we await the publish or spin it off
-        // right now I have this spin off, inside the lock
-        // await metaspace.registerNewIbGib({ ibGib: newTimelineIbGib, space });
-        // metaspace.registerNewIbGib({ ibGib: newTimelineIbGib, space }); // spin off
-
         return newTimelineIbGib;
     } catch (error) {
         console.error(`${lc} ${extractErrorMsg(error)}`);
@@ -691,10 +681,6 @@ export async function mut8Timeline<TData extends IbGibData_V1 = any>({
                 });
             }
 
-            // should we publish within the lock or not within the lock?
-            // should we await the publish or spin it off
-            // right now I have this spin off, inside the lock
-            // await metaspace.registerNewIbGib({ ibGib: newTimelineIbGib, space });
             // we await the register call because this spins off the publish events (we are assuming implementation details here)
             await metaspace.registerNewIbGib({ ibGib: newTimelineIbGib, space }); // already spins off
 

package/src/timeline/timeline-api.respec.mts

@@ -186,14 +186,14 @@ respecfully(sir, `[timeline-api]`, async () => {
              * I'm getting output (warnings?) that the transform ibgib addr
              * already exists. This stems from the fact that dna/transform
              * ibgibs do not have timestamps or anything, they simply are
-             * memoized args to the transform functions. So we need something 
+             * memoized args to the transform functions. So we need something
              * unique _in the arg itself_, which in this case means in the
              * `dataToAddOrPatch` field.
-             * 
+             *
              * Note, however, that it is expected for the original `fork`
              * transform that created tInitial to be common and for it to
              * already have this fork dna ibgib. But this shouldn't happen for
-             * each mut8 transform. 
+             * each mut8 transform.
              */
             const uniqueIdsForUniqueTransforms: string[] = [];
             for (let i = 0; i < N; i++) {