@ibgib/core-gib 0.1.28 → 0.1.30

package/src/sync/docs/architecture.md

@@ -10,8 +10,8 @@ Synchronization is not a stateless request/response. It is a **Saga**: a durable
 *   **Symmetry**: Both peers (Alice and Bob) run the exact same `SyncSagaCoordinator`. There is no "Client" or "Server" code, only "Initiator" and "Reactor".
 
 ### 1.2 Smart Diff (Partial Updates)
-To optimize bandwidth, the protocol exchanges "Knowledge Vectors" to calculate the precise difference between peers.
-*   **Knowledge Vector**: A summary of what a peer knows (Timelines, Tips, and Ancestors).
+To optimize bandwidth, the protocol exchanges "Knowledge Maps" to calculate the precise difference between peers.
+*   **Knowledge Map**: A summary of what a peer knows (Timelines, Tips, and Ancestors).
 *   **Space-Side Dependency Graph**: The `Space.getDependencyGraph` capability allows the "Network" layer to request *only* the new nodes in a graph, skipping everything the receiver already has.
 
 ## 2. Protocol Workflow (The State Machine)
@@ -22,12 +22,12 @@ The `SyncSagaCoordinator` drives a Finite State Machine (FSM) via the `handleSag
 
 1.  **Start (Initiator)**:
     *   Initiator (Alice) calls `startSaga`.
-    *   Generates `Init` frame containing her `KnowledgeVector` and `Mode` (Push/Pull/Sync).
+    *   Generates `Init` frame containing her `KnowledgeMap` and `Mode` (Push/Pull/Sync).
     *   Sends `Init` to Bob.
 
 2.  **Gap Analysis (`handleInitFrame`)**:
     *   Reactor (Bob) receives `Init`.
-    *   Bob compares Alice's `KnowledgeVector` against his own local space.
+    *   Bob compares Alice's `KnowledgeMap` against his own local space.
     *   **Identifies Gaps**:
         *   **Delta Request**: "Alice has `X`, I don't. Send me `X`."
         *   **Push Offer**: "I have `Y` (newer than Alice's). Do you want `Y`?"
@@ -36,7 +36,7 @@ The `SyncSagaCoordinator` drives a Finite State Machine (FSM) via the `handleSag
 3.  **Payload Generation (`handleAckFrame`)**:
     *   Alice receives `Ack`.
     *   **Process Requests**: Iterates `deltaReqAddrs` (what Bob wants).
-    *   **Smart Diff**: Uses Bob's `KnowledgeVector` (sent in Ack) to exclude all shared history.
+    *   **Smart Diff**: Uses Bob's `KnowledgeMap` (sent in Ack) to exclude all shared history.
     *   **Payload**: Generates a bundle of new ibGibs.
     *   Alice sends `Delta` frame containing the payload.
 
@@ -57,7 +57,7 @@ All frames are `SyncIbGib`s carrying specific data payloads.
 
 *   `sagaId`: Unique UUID for the session.
 *   `stage`: `init` | `ack` | `delta` | `commit` | `conflict`.
-*   `knowledgeVector`: `{ [tjpAddr]: [tipAddr, ...ancestors] }`.
+*   `knowledgeMap`: `{ [tjpAddr]: [tipAddr, ...ancestors] }`.
 
 ### 3.2 Constants vs Timelines
 The protocol supports two types of data:

package/src/sync/strategies/conflict-optimistic.mts

@@ -1,8 +1,8 @@
 /**
  * @module conflict-optimistic
- * 
+ *
  * Implements the Optimistic Conflict Resolution Strategy.
- * 
+ *
  * Logic:
  * 1. findLCA: Traverses `past` to find common ancestor.
  * 2. mergeDivergentTimelines: Replays DNA to create a merged tip.
@@ -10,11 +10,12 @@
 
 import { IbGib_V1, IbGibRel8ns_V1, IbGibData_V1 } from '@ibgib/ts-gib/dist/V1/types.mjs';
 import { getIbGibAddr } from '@ibgib/ts-gib/dist/helper.mjs';
+
 import { IbGibSpaceAny } from '../../witness/space/space-base-v1.mjs';
 import { getFromSpace, putInSpace } from '../../witness/space/space-helper.mjs';
 import { mut8Timeline } from '../../timeline/timeline-api.mjs';
 
-const lc = `[conflict-optimistic]`;
+const logalot = GLOBAL_LOG_A_LOT || true;
 
 export interface LCAResult {
     lcaAddr: string;
@@ -22,9 +23,42 @@ export interface LCAResult {
     branchB: IbGib_V1[]; // Path from LCA to Tip B (exclusive of LCA)
 }
 
+export interface TimelinesAnalysis {
+    latestCommonAddr: IbGibAddr;
+    uniqueBranchA
+}
+
+/**
+ * gets a quick analysis comparing/contrasting two timeline addrs.
+ *
+ * This does not do in-depth analysis that would involve retrieving ibgibs
+ from
+ * any spaces.
+ */
+export function analyzeTimelinesShallow({
+    a,
+    b,
+}: {
+    a: IbGibAddr[],
+    b: IbGibAddr[],
+}
+): IbGibAddr {
+    const lc = `[${analyzeTimelinesShallow.name}]`;
+    try {
+        if (logalot) { console.log(`${lc} starting... (I: 1f65b883a2089948842c927c6a08c826)`); }
+
+        throw new Error(`not implemented (E: eab7ac95806ff9c60dafa22eb59cb926)`);
+    } catch (error) {
+        console.error(`${lc} ${extractErrorMsg(error)}`);
+        throw error;
+    } finally {
+        if (logalot) { console.log(`${lc} complete.`); }
+    }
+}
+
 /**
  * Finds the Last Common Ancestor (LCA) between two divergent timelines.
- * 
+ *
  * Note: simplistic implementation assuming simple linear divergence.
  * Complex DAGs might require more robust graph traversal.
  */
@@ -114,6 +148,9 @@ export async function findLCA({
 }
 
 import { graftTimelines, mergeTextLCS } from '../graft-info/graft-info-helpers.mjs';
+import { IbGibAddr } from '@ibgib/ts-gib';
+import { GLOBAL_LOG_A_LOT } from '../../core-constants.mjs';
+import { extractErrorMsg } from '@ibgib/helper-gib/dist/helpers/utils-helper.mjs';
 
 /**
  * Optimistically grafts two divergent timelines by inspecting DNA and replaying transforms.

package/src/sync/sync-conflict.respec.mts

@@ -166,7 +166,7 @@ await respecfully(sir, `Sync Conflict Resolution`, async () => {
         // This ensures the conflict precondition exists.
         await ifWe(sir, 'verify receiver KV pre-sync', async () => {
             try {
-                const destKV = await receiverCoordinator.getKnowledgeVector({
+                const destKV = await receiverCoordinator.getKnowledgeMap({
                     space: destSpace,
                     metaspace,
                     domainIbGibs: [v1_Dest]
@@ -186,7 +186,7 @@ await respecfully(sir, `Sync Conflict Resolution`, async () => {
 
             } catch (error) {
                 console.error(`${lc} ${extractErrorMsg(error)}`);
-                iReckon(sir, true).asTo('getKnowledgeVector errored out').isGonnaBeFalse();
+                iReckon(sir, true).asTo('getKnowledgeMap errored out').isGonnaBeFalse();
             }
         });
 
@@ -251,7 +251,7 @@ await respecfully(sir, `Sync Conflict Resolution`, async () => {
 
             try {
                 // Get the KV for the Source Space
-                const sourceKV = await senderCoordinator.getKnowledgeVector({
+                const sourceKV = await senderCoordinator.getKnowledgeMap({
                     space: sourceSpace,
                     metaspace,
                     domainIbGibs: [testRoot] // We want to know the tip of this timeline
@@ -260,7 +260,7 @@ await respecfully(sir, `Sync Conflict Resolution`, async () => {
                     getTjpAddr({ ibGib: testRoot, defaultIfNone: 'incomingAddr' }) ??
                     getIbGibAddr({ ibGib: testRoot });
 
-                if (logalot) { console.log(`${lc} getKnowledgeVector returned. sourceKV: ${pretty(sourceKV)} (I: e8780cda37c8b2a46eeb85786874e926)`); }
+                if (logalot) { console.log(`${lc} getKnowledgeMap returned. sourceKV: ${pretty(sourceKV)} (I: e8780cda37c8b2a46eeb85786874e926)`); }
 
                 const sourceTipAddr = sourceKV[tjpAddr];
                 if (!sourceTipAddr) {
@@ -319,7 +319,7 @@ await respecfully(sir, `Sync Conflict Resolution`, async () => {
                 }
             } catch (error) {
                 console.error(`${lc} ${extractErrorMsg(error)}`);
-                iReckon(sir, true).asTo('getKnowledgeVector errored out').isGonnaBeFalse();
+                iReckon(sir, true).asTo('getKnowledgeMap errored out').isGonnaBeFalse();
             }
 
         });

package/src/sync/sync-helpers.mts

@@ -7,7 +7,7 @@ import { getIbGibAddr } from "@ibgib/ts-gib/dist/helper.mjs";
 
 import { GLOBAL_LOG_A_LOT } from "../core-constants.mjs";
 import { SYNC_ATOM, SYNC_MSG_REL8N_NAME } from "./sync-constants.mjs";
-import { isValidSyncConflictStrategy, SYNC_CONFLICT_STRATEGY_VALID_VALUES, SyncData_V1, SyncExecutionContext, SyncIb_V1, SyncIbGib_V1, SyncSagaFrameDependencyGraph } from "./sync-types.mjs";
+import { isValidSyncConflictStrategy, SYNC_CONFLICT_STRATEGY_VALID_VALUES, SyncData_V1, SyncSagaFrameOrigin, SyncIb_V1, SyncIbGib_V1, SyncSagaFrameDependencyGraph } from "./sync-types.mjs";
 import { IbGibSpaceAny } from "../witness/space/space-base-v1.mjs";
 import { getFromSpace, putInSpace } from "../witness/space/space-helper.mjs";
 import { IbGibSpaceResultData, IbGibSpaceResultIbGib, IbGibSpaceResultRel8ns } from "../witness/space/space-types.mjs";
@@ -380,10 +380,14 @@ export async function putInSpace_dnasThenNonDnas({
         }
 
         // dnas are the simplest and we store those first...
-        await putInSpace({ ibGibs: payload_Dnas, isDna: true, space, });
+        if (payload_Dnas.length > 0) {
+            await putInSpace({ ibGibs: payload_Dnas, isDna: true, space, });
+        }
 
         // then put all non-dnas ("regular" ibgibs) in the space
-        await putInSpace({ ibGibs: payload_NonDnas, isDna: false, space, });
+        if (payload_NonDnas.length > 0) {
+            await putInSpace({ ibGibs: payload_NonDnas, isDna: false, space, });
+        }
 
         return { payload_Dnas, payload_NonDnas };
     } catch (error) {
@@ -395,14 +399,14 @@ export async function putInSpace_dnasThenNonDnas({
 }
 
 /**
- * @see {@link SyncExecutionContext}
+ * @see {@link SyncSagaFrameOrigin}
  */
-export function getExecutionContext({
+export function getSyncSagaFrameOrigin({
     sagaFrame,
 }: {
     sagaFrame: SyncIbGib_V1,
-}): SyncExecutionContext {
-    const lc = `[${getExecutionContext.name}]`;
+}): SyncSagaFrameOrigin {
+    const lc = `[${getSyncSagaFrameOrigin.name}]`;
     try {
         if (logalot) { console.log(`${lc} starting... (I: 93521332d0dd2f5e88398b7db95e8126)`); }
         if (!sagaFrame) { throw new Error(`(UNEXPECTED) sagaFrame falsy? (E: 01fb28be6668d88ea49bb298c739c926)`); }
@@ -414,9 +418,9 @@ export function getExecutionContext({
         // odd => receiver
 
         if (modulo === 0) {
-            return SyncExecutionContext.sender;
+            return SyncSagaFrameOrigin.sender;
         } else if (modulo === 1) {
-            return SyncExecutionContext.receiver;
+            return SyncSagaFrameOrigin.receiver;
         } else {
             throw new Error(`(UNEXPECTED) modulo is neither 0 nor 1? my logic sucks! This was way too defensive on my part... (E: 559488a2eef8d17b57079ca8886ee826)`);
         }

package/src/sync/sync-innerspace-constants.respec.mts

@@ -55,8 +55,8 @@ await respecfully(sir, `Sync Constants (No TJP)`, async () => {
         // 2. Create Constant (C1) in Source
         // Factory_V1.constant returns Promise<IbGib_V1>, not { newIbGib: ... }
         const c1 = await Factory_V1.constant({
-            ib: 'constant_c1',
             parentPrimitiveIb: 'root',
+            ib: 'constant_c1',
             data: { some: 'data' },
         });
         const addrC1 = getIbGibAddr({ ibGib: c1 });
@@ -81,7 +81,7 @@ await respecfully(sir, `Sync Constants (No TJP)`, async () => {
 
         // 4. Sync C1 (First Pass)
         let resSync = await senderCoordinator.sync({
-            peer: peer,
+            peer,
             localSpace: sourceSpace,
             metaspace: metaspace,
             domainIbGibs: [c1],
@@ -94,43 +94,43 @@ await respecfully(sir, `Sync Constants (No TJP)`, async () => {
         const getC1Dest = await getFromSpace({ space: destSpace, addr: addrC1 });
         iReckon(sir, getC1Dest.success && !!getC1Dest.ibGibs![0]).asTo('Dest has C1 after sync').isGonnaBeTrue();
 
-        // 5. Sync C1 (Second Pass - Idempotency / Smart Diff)
-        // Should NOT send payload again.
-        resSync = await senderCoordinator.sync({
-            peer: peer,
-            localSpace: sourceSpace,
-            metaspace: metaspace,
-            domainIbGibs: [c1],
-            useSessionIdentity: false,
-        });
-        await resSync.done;
-        iReckon(sir, true).asTo('Sync execution 2 (idempotent) completes').isGonnaBeTrue();
-
-        // 6. Create "Constant with Dependency" (C2 -> C1)
-        const c2 = await Factory_V1.constant({
-            ib: 'constant_c2',
-            parentPrimitiveIb: 'root',
-            rel8ns: {
-                link: [addrC1], // C2 links to C1
-            },
-        });
-        const addrC2 = getIbGibAddr({ ibGib: c2 });
-        await putInSpace({ space: sourceSpace, ibGibs: [c2] });
-
-        // Sync C2
-        resSync = await senderCoordinator.sync({
-            peer: peer,
-            localSpace: sourceSpace,
-            metaspace: metaspace,
-            domainIbGibs: [c2],
-            useSessionIdentity: false,
-        });
-        await resSync.done;
-        iReckon(sir, true).asTo('Sync C2 completes').isGonnaBeTrue();
-
-        // Verify C2 in Dest
-        const getC2Dest = await getFromSpace({ space: destSpace, addr: addrC2 });
-        iReckon(sir, getC2Dest.success).asTo('Dest has C2').isGonnaBeTrue();
+        // // 5. Sync C1 (Second Pass - Idempotency / Smart Diff)
+        // // Should NOT send payload again.
+        // resSync = await senderCoordinator.sync({
+        //     peer: peer,
+        //     localSpace: sourceSpace,
+        //     metaspace: metaspace,
+        //     domainIbGibs: [c1],
+        //     useSessionIdentity: false,
+        // });
+        // await resSync.done;
+        // iReckon(sir, true).asTo('Sync execution 2 (idempotent) completes').isGonnaBeTrue();
+
+        // // 6. Create "Constant with Dependency" (C2 -> C1)
+        // const c2 = await Factory_V1.constant({
+        //     ib: 'constant_c2',
+        //     parentPrimitiveIb: 'root',
+        //     rel8ns: {
+        //         link: [addrC1], // C2 links to C1
+        //     },
+        // });
+        // const addrC2 = getIbGibAddr({ ibGib: c2 });
+        // await putInSpace({ space: sourceSpace, ibGibs: [c2] });
+
+        // // Sync C2
+        // resSync = await senderCoordinator.sync({
+        //     peer: peer,
+        //     localSpace: sourceSpace,
+        //     metaspace: metaspace,
+        //     domainIbGibs: [c2],
+        //     useSessionIdentity: false,
+        // });
+        // await resSync.done;
+        // iReckon(sir, true).asTo('Sync C2 completes').isGonnaBeTrue();
+
+        // // Verify C2 in Dest
+        // const getC2Dest = await getFromSpace({ space: destSpace, addr: addrC2 });
+        // iReckon(sir, getC2Dest.success).asTo('Dest has C2').isGonnaBeTrue();
 
     });
 });

package/src/sync/sync-innerspace-deep-updates.respec.mts

@@ -11,20 +11,20 @@ import {
 const maam = `[${import.meta.url}]`, sir = maam;
 import { clone, delay, extractErrorMsg, pretty } from '@ibgib/helper-gib/dist/helpers/utils-helper.mjs';
 import { getIbGibAddr } from '@ibgib/ts-gib/dist/helper.mjs';
-import { getDependencyGraph } from '../common/other/graph-helper.mjs';
 
+import { GLOBAL_LOG_A_LOT } from '../core-constants.mjs';
+import { getDependencyGraph } from '../common/other/graph-helper.mjs';
 import { SyncSagaCoordinator } from './sync-saga-coordinator.mjs';
-import { putInSpace, getFromSpace } from '../witness/space/space-helper.mjs';
+import { getFromSpace } from '../witness/space/space-helper.mjs';
 import { Metaspace_Innerspace } from '../witness/space/metaspace/metaspace-innerspace/metaspace-innerspace.mjs';
 import { InnerSpace_V1 } from '../witness/space/inner-space/inner-space-v1.mjs';
 import { createTimelineRootHelper, getTestKeystoneServiceHelper } from '../agent-helpers.mjs';
 import { mut8Timeline } from '../timeline/timeline-api.mjs';
 import { DEFAULT_INNER_SPACE_DATA_V1 } from '../witness/space/inner-space/inner-space-types.mjs';
-import { toDto } from '../common/other/ibgib-helper.mjs';
 import { SyncPeerInnerspace_V1 } from './sync-peer/sync-peer-innerspace/sync-peer-innerspace-v1.mjs';
 import { SYNC_PEER_INNERSPACE_DEFAULT_DATA_V1 } from './sync-peer/sync-peer-innerspace/sync-peer-innerspace-constants.mjs';
 
-const logalot = true;
+const logalot = GLOBAL_LOG_A_LOT || true;
 const lc = `[sync-innerspace-deep-updates.respec]`;
 
 await respecfully(sir, `Sync InnerSpaces (Deep Updates)`, async () => {
@@ -121,8 +121,8 @@ await respecfully(sir, `Sync InnerSpaces (Deep Updates)`, async () => {
             localSpace: sourceSpace,
             metaspace: metaspace,
             domainIbGibs: [commentV2], // Sync the TIP
+            useSessionIdentity: false,
         });
-
         await resSync.done;
 
         // 5. Verify Dest

package/src/sync/sync-innerspace-dest-ahead.respec.mts

@@ -11,10 +11,10 @@ import {
 const maam = `[${import.meta.url}]`, sir = maam;
 import { clone, delay, extractErrorMsg, pretty } from '@ibgib/helper-gib/dist/helpers/utils-helper.mjs';
 import { getIbGibAddr } from '@ibgib/ts-gib/dist/helper.mjs';
-import { getDependencyGraph } from '../common/other/graph-helper.mjs';
+import { IbGibAddr } from '@ibgib/ts-gib/dist/types.mjs';
 
 import { SyncSagaCoordinator } from './sync-saga-coordinator.mjs';
-import { putInSpace, getFromSpace } from '../witness/space/space-helper.mjs';
+import { putInSpace, getFromSpace, registerNewIbGib } from '../witness/space/space-helper.mjs';
 import { Metaspace_Innerspace } from '../witness/space/metaspace/metaspace-innerspace/metaspace-innerspace.mjs';
 import { InnerSpace_V1 } from '../witness/space/inner-space/inner-space-v1.mjs';
 import { createTimelineRootHelper, getTestKeystoneServiceHelper } from '../agent-helpers.mjs';
@@ -23,6 +23,8 @@ import { DEFAULT_INNER_SPACE_DATA_V1 } from '../witness/space/inner-space/inner-
 import { toDto } from '../common/other/ibgib-helper.mjs';
 import { SyncPeerInnerspace_V1 } from './sync-peer/sync-peer-innerspace/sync-peer-innerspace-v1.mjs';
 import { SYNC_PEER_INNERSPACE_DEFAULT_DATA_V1 } from './sync-peer/sync-peer-innerspace/sync-peer-innerspace-constants.mjs';
+import { GetIbGibResult } from '../common/other/other-types.mjs';
+import { IbGibSpaceAny } from '../witness/space/space-base-v1.mjs';
 
 const logalot = true;
 const lc = `[sync-innerspace-dest-ahead.respec]`;
@@ -73,22 +75,43 @@ await respecfully(sir, `Sync InnerSpaces (Dest Ahead)`, async () => {
         // Root -> V1 (Shared) -> V2 (Dest has New)
         // Source only has V1.
 
-        const root = await createTimelineRootHelper<TestData>({
+        const v0 = await createTimelineRootHelper<TestData>({
             ib: 'timeline_root_ff',
             data: { type: 'root', label: 'Root' },
             space: sourceSpace,
         });
+        const addrV0 = getIbGibAddr({ ibGib: v0 });
+        console.log(pretty(v0));
+
+        console.log('0000000000000')
+        console.log('0000000000000')
+        console.log('0000000000000')
+        console.log('0000000000000')
+        console.log('0000000000000')
 
         // V1 (Both have it, but we create in source and copy to dest)
         const v1 = await mut8Timeline<TestData>({
-            timeline: root,
+            timeline: v0,
             mut8Opts: { dataToAddOrPatch: { type: 'comment', label: 'V1' } },
             metaspace,
             space: sourceSpace,
         });
+        const addrV1 = getIbGibAddr({ ibGib: v1 });
+        console.log(pretty(v1));
+
 
         // Transfer Root & V1 to Dest
-        await putInSpace({ space: destSpace, ibGibs: [root, v1] }); // Naive seeding
+        await putInSpace({ space: destSpace, ibGibs: [v0, v1] }); // Naive seeding
+        await registerNewIbGib({ space: destSpace, ibGib: v0 });
+        await registerNewIbGib({ space: destSpace, ibGib: v1 });
+
+        console.log('1111111111111111111111111111111')
+        console.log('1111111111111111111111111111111')
+        console.log('1111111111111111111111111111111')
+        console.log('1111111111111111111111111111111')
+        console.log('1111111111111111111111111111111')
+        console.log('1111111111111111111111111111111')
+        console.log('1111111111111111111111111111111')
 
         // V2 (Created in Dest ONLY)
         const v2 = await mut8Timeline<TestData>({
@@ -98,12 +121,31 @@ await respecfully(sir, `Sync InnerSpaces (Dest Ahead)`, async () => {
             space: destSpace, // Mutate in Dest
         });
         const addrV2 = getIbGibAddr({ ibGib: v2 });
+        console.log(pretty(v2));
+
+        const fnAddrExistsInSpace = async (addr: IbGibAddr, space: IbGibSpaceAny) => {
+            const resGet = await getFromSpace({ addr, space });
+            return resGet.success && resGet.ibGibs && resGet.ibGibs.length === 1;
+        }
+
+        console.log('22222222222')
+        console.log('22222222222')
+        console.log('22222222222')
+        console.log('22222222222')
+        console.log('22222222222')
+        console.log('22222222222')
+        console.log('22222222222')
+
 
         await ifWeMight(sir, 'verify setup', async () => {
             // Ensure V2 is ONLY in Dest (it is, per `space: destSpace`)
             // Ensure Source does NOT have V2
-            const checkV2InSource = await getFromSpace({ space: sourceSpace, addr: addrV2 });
-            iReckon(sir, checkV2InSource.success && !!checkV2InSource.ibGibs?.length).asTo('Source has V2').isGonnaBeFalse();
+            iReckon(sir, await fnAddrExistsInSpace(addrV0, sourceSpace)).asTo('source has V0').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV1, sourceSpace)).asTo('source has V1').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV2, sourceSpace)).asTo('source has V2').isGonnaBeFalse();
+            iReckon(sir, await fnAddrExistsInSpace(addrV0, destSpace)).asTo('dest has V0').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV1, destSpace)).asTo('dest has V1').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV2, destSpace)).asTo('dest has V2').isGonnaBeTrue();
         });
 
         // 3. Setup Sync
@@ -119,6 +161,14 @@ await respecfully(sir, `Sync InnerSpaces (Dest Ahead)`, async () => {
             receiverCoordinator,
             receiverMetaspace: metaspace,
         });
+        console.log('333333333')
+        console.log('333333333')
+        console.log('333333333')
+        console.log('333333333')
+        console.log('333333333')
+        console.log('333333333')
+        console.log('333333333')
+
 
         // 4. Run Sync (Source Pushes V1)
         console.log(`${lc} Running Sync...`);
@@ -132,13 +182,27 @@ await respecfully(sir, `Sync InnerSpaces (Dest Ahead)`, async () => {
 
         await resSync.done;
 
-        // 5. Verify Dest (Should still have V2 as latest)
+        console.log('444444444')
+        console.log('444444444')
+        console.log('444444444')
+        console.log('444444444')
+        console.log('444444444')
+        console.log('444444444')
+        console.log('444444444')
+
+        // 5. Verify Sync (v2 should be in both source and dest now)
         console.log(`${lc} Verifying Destination...`);
 
         await ifWeMight(sir, `verify dest stays ahead`, async () => {
             // Verify Tip (V2)
             const getV2 = await getFromSpace({ space: destSpace, addr: addrV2 });
-            iReckon(sir, getV2.success).asTo('V2 still present in Dest').isGonnaBeTrue();
+
+            iReckon(sir, await fnAddrExistsInSpace(addrV0, sourceSpace)).asTo('source has V0').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV1, sourceSpace)).asTo('source has V1').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV2, sourceSpace)).asTo('source has V2').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV0, destSpace)).asTo('dest has V0').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV1, destSpace)).asTo('dest has V1').isGonnaBeTrue();
+            iReckon(sir, await fnAddrExistsInSpace(addrV2, destSpace)).asTo('dest has V2').isGonnaBeTrue();
 
             // Verify V2 points to V1
             const v2IbGib = getV2.ibGibs![0];

package/src/sync/sync-innerspace.respec.mts

@@ -13,6 +13,7 @@ const maam = `[${import.meta.url}]`, sir = maam;
 import { clone, delay, extractErrorMsg, pretty } from '@ibgib/helper-gib/dist/helpers/utils-helper.mjs';
 import { getIbGibAddr } from '@ibgib/ts-gib/dist/helper.mjs';
 
+import { GLOBAL_LOG_A_LOT } from '../core-constants.mjs';
 import { SyncSagaCoordinator } from './sync-saga-coordinator.mjs';
 import { getFromSpace } from '../witness/space/space-helper.mjs';
 import { Metaspace_Innerspace } from '../witness/space/metaspace/metaspace-innerspace/metaspace-innerspace.mjs';
@@ -25,7 +26,7 @@ import { fnObs } from '../common/pubsub/observer/observer-helper.mjs';
 import { SyncPeerInnerspace_V1 } from './sync-peer/sync-peer-innerspace/sync-peer-innerspace-v1.mjs';
 import { SYNC_PEER_INNERSPACE_DEFAULT_DATA_V1 } from './sync-peer/sync-peer-innerspace/sync-peer-innerspace-constants.mjs';
 
-const logalot = true;
+const logalot = GLOBAL_LOG_A_LOT;
 const lc = `[sync-innerspace.respec]`;
 
 await respecfully(sir, `Sync InnerSpaces`, async () => {
@@ -47,7 +48,7 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
         const defaultLocalUserSpace = await metaspace.getLocalUserSpace({ lock: false });
         if (!defaultLocalUserSpace) { throw new Error(`(UNEXPECTED) defaultLocalUserSpace falsy? (E: 56f019430b29b45147e0caa4d5931826)`); }
         await defaultLocalUserSpace.initialized;
-        console.log(`defaultLocalUserSpace: ${pretty(toDto({ ibGib: defaultLocalUserSpace }))}`);
+        if (logalot) { console.log(`defaultLocalUserSpace: ${pretty(toDto({ ibGib: defaultLocalUserSpace }))}`); }
 
         sourceSpace = new InnerSpace_V1({
             ...DEFAULT_INNER_SPACE_DATA_V1,
@@ -56,7 +57,7 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
             description: 'source test space',
         });
         await sourceSpace.initialized;
-        console.log(`sourceSpace: ${pretty(toDto({ ibGib: sourceSpace }))}`);
+        if (logalot) { console.log(`sourceSpace: ${pretty(toDto({ ibGib: sourceSpace }))}`); }
         // await (sourceSpace as any).initialize(); // DO NOT AWAIT THIS. THIS IS AUTOMATICALLY AWAITED IN PLUMBING
 
         destSpace = new InnerSpace_V1({
@@ -66,11 +67,11 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
             description: 'dest test space',
         });
         await destSpace.initialized;
-        console.log(`destSpace: ${pretty(toDto({ ibGib: destSpace }))}`);
+        if (logalot) { console.log(`destSpace: ${pretty(toDto({ ibGib: destSpace }))}`); }
         // await (destSpace as any).initialized; // DO NOT AWAIT THIS. THIS IS AUTOMATICALLY AWAITED IN PLUMBING
 
         // 2. Seed Source Data
-        console.log(`${lc} Creating data in Source...`);
+        if (logalot) { console.log(`${lc} Creating data in Source...`); }
         const root = await createTimelineRootHelper({
             ib: 'timeline_root',
             // data: { type: 'root', n: 0 }, // DO NOT TRY TO MANUALLY SET n
@@ -90,11 +91,11 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
         const childAddr = getIbGibAddr({ ibGib: child });
 
         // 3. Setup Coordinators & Peer
-        console.log(`${lc} Setting up Coordinators...`);
+        if (logalot) { console.log(`${lc} Setting up Coordinators...`); }
         const mockKeystone = await getTestKeystoneServiceHelper();
         // const identity = await (mockKeystone as any).getIdentity(); // SKIP IDENTITY FOR INITIAL TESTING SIMPLICITY
 
-        // Sender Coordinator 
+        // Sender Coordinator
         const senderCoordinator = new SyncSagaCoordinator(mockKeystone);
 
         // Receiver Coordinator
@@ -114,7 +115,7 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
         });
 
         // 4. Run Sync
-        console.log(`${lc} Running Sync...`);
+        if (logalot) { console.log(`${lc} Running Sync...`); }
         const resSync = await senderCoordinator.sync({
             peer: peer,
             localSpace: sourceSpace,
@@ -123,7 +124,7 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
             useSessionIdentity: false,
         }); // Type cast if needed until we align optional params
 
-        console.log(`${lc} resSync: ${pretty(resSync)}`);
+        if (logalot) { console.log(`${lc} resSync: ${pretty(resSync)}`); }
 
         const sublc = `${lc}[updates$]`;
         /**
@@ -132,24 +133,24 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
          */
         const subscription = await resSync.updates$.subscribe(fnObs({
             next: async (ctxIbGib) => {
-                console.log(`${sublc} next fired`);
+                if (logalot) { console.log(`${sublc} next fired`); }
             },
             error: async (e) => {
-                console.log(`${sublc} error fired`);
+                if (logalot) { console.log(`${sublc} error fired`); }
             },
             complete: async () => {
-                console.log(`${sublc} complete fired`);
+                if (logalot) { console.log(`${sublc} complete fired`); }
             },
         }));
 
-        console.log(`${lc} awaiting resSync.done`)
+        if (logalot) { console.log(`${lc} awaiting resSync.done`) }
         await resSync.done;
 
 
         // todo: add iReckon assertions about resSync
 
         // 5. Verify Dest
-        console.log(`${lc} Verifying Destination...`);
+        if (logalot) { console.log(`${lc} Verifying Destination...`); }
         try {
             const getChildInDest = await getFromSpace({ space: destSpace, addr: childAddr });
 
@@ -159,7 +160,7 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
 
             await ifWe(sir, `verify getChildInDest.ibGibs`, async () => {
                 const firstChild = getChildInDest.ibGibs?.[0];
-                console.log(`${lc} firstChild: ${pretty(firstChild)}`);
+                if (logalot) { console.log(`${lc} firstChild: ${pretty(firstChild)}`); }
                 iReckon(sir, firstChild?.data?.n).asTo('Child content matches').isGonnaBe(2);
             });
 
@@ -169,7 +170,7 @@ await respecfully(sir, `Sync InnerSpaces`, async () => {
                 iReckon(sir, true).asTo(`error: ${extractErrorMsg(error)}`).isGonnaBeFalse();
             });
         } finally {
-            console.log(`${lc} Test complete.`);
+            if (logalot) { console.log(`${lc} Test complete.`); }
         }
     });