@ibgib/core-gib 0.0.47 → 0.0.49

package/src/witness/space/filesystem-space/node-filesystem-space/node-filesystem-space-v1.mts

@@ -239,10 +239,12 @@ export class NodeFilesystemSpace_V1<
                 // binary
                 const binIbGib = ibGib as BinIbGib_V1;
                 data = binIbGib.data;
-                if (!data) { throw new Error(`(UNEXPECTED) binIbGib.data falsy? I'm trying to have data always populated for bin ibgibs even if it is an empty Buffer. (E: 8c9c3650ec97792b1913754ed0877824)`); }
-                if (!Buffer.isBuffer(data)) {
-                    throw new Error(`(UNEXPECTED) !Buffer.isBuffer(data)? I'm trying to have binIbGib.data always populated and it should be a Buffer. (E: 179c97da10ac082b77376c0db9077d24)`);
-                }
+                if (!data) { throw new Error(`(UNEXPECTED) binIbGib.data falsy? I'm trying to have data always populated for bin ibgibs even if it is an empty Uint8Array. (E: 8c9c3650ec97792b1913754ed0877824)`); }
+
+                // if (!Buffer.isBuffer(data)) {
+                //     debugger; // checking to see if !Buffer.isBuffer(data) fails for Uint8Array
+                //     throw new Error(`(UNEXPECTED) !Buffer.isBuffer(data)? I'm trying to have binIbGib.data always populated and it should be a Buffer. (E: 179c97da10ac082b77376c0db9077d24)`);
+                // }
                 // encoding = parseBinIb({ addr }).binEncoding ?? undefined
 
                 // write bins directly as buffers

package/src/witness/space/metaspace/metaspace-base.mts

@@ -65,6 +65,7 @@ import {
 } from './metaspace-types.mjs';
 import { MetaspaceService, TempCacheEntry } from './metaspace-types.mjs';
 import { InnerSpace_V1 } from '../../../witness/space/inner-space/inner-space-v1.mjs';
+
 import { GLOBAL_LOG_A_LOT, GLOBAL_TIMER_NAME } from '../../../core-constants.mjs';
 import { newupSubject } from '../../../common/pubsub/subject/subject-helper.mjs';
 import { ObservableWitness, } from '../../../common/pubsub/observable/observable-types.mjs';
@@ -2297,6 +2298,7 @@ export abstract class MetaspaceBase implements MetaspaceService {
         createIfNone,
         dontPrompt,
         space,
+        outerspaceIds,
         fnSpaceFactory,
         fnPromptSecret,
         fnPromptEncryption,
@@ -2312,6 +2314,10 @@ export abstract class MetaspaceBase implements MetaspaceService {
          */
         dontPrompt?: boolean,
         space?: IbGibSpaceAny,
+        /**
+         * @see {@link syncIbGibs} arg of the same name
+         */
+        outerspaceIds?: SpaceId[],
         fnSpaceFactory: (unencryptedSpaceData: any) => Promise<IbGibSpaceAny>,
         fnPromptSecret: (space: IbGibSpaceAny) => Promise<SecretIbGib_V1 | undefined>,
         fnPromptEncryption: (space: IbGibSpaceAny) => Promise<EncryptionIbGib | undefined>,
@@ -2333,20 +2339,31 @@ export abstract class MetaspaceBase implements MetaspaceService {
                     space,
                 });
 
+            // filter if applicable
+            const hasOuterspaceIds = (outerspaceIds?.length ?? 0) > 0;
+            if (hasOuterspaceIds) {
+                appSyncSpaces = appSyncSpaces.filter(x => outerspaceIds!.includes(x.data!.uuid!));
+            }
+
             // create if applicable
-            if (appSyncSpaces.length === 0 && createIfNone) {
-                const createdReqs = await this._createOuterspaceAndRequiredIbGibs({
-                    space,
-                    fnPromptSecret,
-                    fnPromptEncryption,
-                    fnPromptOuterSpace,
-                });
-                if (createdReqs) {
-                    appSyncSpaces = await this.getSpecialRel8dIbGibs<IbGibSpaceAny>({
-                        type: "outerspaces",
-                        rel8nName: SYNC_SPACE_REL8N_NAME,
+            if (appSyncSpaces.length === 0) {
+                if (createIfNone) {
+                    if (hasOuterspaceIds) { throw new Error(`(UNEXPECTED) both createIfNone true and outerspaceIds (filter) also true? you cannot have both of these set, it's one of the other. (E: 9caaa121dee3e41e6e29916614cd4e24)`); }
+                    const createdReqs = await this._createOuterspaceAndRequiredIbGibs({
                         space,
+                        fnPromptSecret,
+                        fnPromptEncryption,
+                        fnPromptOuterSpace,
                     });
+                    if (createdReqs) {
+                        appSyncSpaces = await this.getSpecialRel8dIbGibs<IbGibSpaceAny>({
+                            type: "outerspaces",
+                            rel8nName: SYNC_SPACE_REL8N_NAME,
+                            space,
+                        });
+                    }
+                } else {
+                    throw new Error(`No sync spaces found. First create a sync outerspace (like a cloud sync space) in order to synchronize with it (E: 8f395f226ac7b558b9317befefbcb724)`);
                 }
             }
 
@@ -2554,6 +2571,7 @@ export abstract class MetaspaceBase implements MetaspaceService {
         dependencyGraphIbGibs,
         // confirm,
         watch,
+        outerspaceIds,
         fnPreSyncProgress,
         fnSpaceFactory,
         fnPromptSecret,
@@ -2567,6 +2585,11 @@ export abstract class MetaspaceBase implements MetaspaceService {
          * (tjps).
          */
         watch?: boolean,
+        /**
+         * if provided, these will determine which outerspace(s) we will sync
+         * the {@link dependencyGraphIbGibs} with.
+         */
+        outerspaceIds?: SpaceId[],
         /**
          * The meat of the sync process is tracked via a status within the sync
          * spaces themselves. I'm addign this fn to track the pre and post progress
@@ -2640,6 +2663,7 @@ export abstract class MetaspaceBase implements MetaspaceService {
                 unwrapEncrypted: true,
                 createIfNone: true,
                 space: localUserSpace,
+                outerspaceIds,
                 fnSpaceFactory,
                 fnPromptSecret,
                 fnPromptEncryption,
@@ -2648,14 +2672,14 @@ export abstract class MetaspaceBase implements MetaspaceService {
             if (fnPreSyncProgress) { fnPreSyncProgress('build complete. (I: 391a9aa7749d45b1aecf9a0010d9937f)'); }
             console.timeLog(syncTimelogName, 'getAppSyncSpaces starting (unwrapEncrypted is true) complete.');
             if (appSyncSpaces.length === 0) {
-                const msg = `Can't sync without sync spaces...wrong password? Cancelling. Restart app to retry password (I know it sucks!...just me coding this thing right now)`;
+                const msg = `Hmm, we seem to not have any sync spaces, and we can't exactly sync without them. Sometimes this is because of a wrong password? (I: 902bd3e00c3246abb646a750f2f2b782)`;
                 if (logalot) { console.log(`${lc} ${msg}`) };
                 const fnAlert = this.getFnAlert!();
-                await fnAlert({ title: "Cancelled", msg });
+                await fnAlert({ title: "Sync Cancelled", msg });
                 this._syncing = false;
                 console.timeLog(syncTimelogName, 'cancelled');
                 console.timeEnd(syncTimelogName);
-                return;
+                return undefined; /* <<<< returns early */
             }
             // const localUserSpace = await this.getLocalUserSpace({});
             const participants: ParticipantInfo[] = [

package/src/witness/space/metaspace/metaspace-types.mts

@@ -572,14 +572,26 @@ export interface MetaspaceService {
         fnPromptApp: (space: IbGibSpaceAny, ibGib: AppIbGib_V1 | null) => Promise<AppPromptResult | undefined>,
         space?: IbGibSpaceAny,
     }): Promise<AppIbGib_V1[]>;
+    /**
+     * sync a dependency graph of ibgibs with one or more (external)
+     * outerspaces.
+     */
     syncIbGibs(arg: {
+        /**
+         * ibgibs to be synced.
+         */
         dependencyGraphIbGibs?: IbGib_V1[],
         // confirm?: boolean,
         /**
          * If true, will watch ibgibs in dependency graph that have timelines
-         * (tjps).
+         * (tjps) to keep in sync going forward.
          */
         watch?: boolean,
+        /**
+         * if provided, these will determine which outerspace(s) we will sync
+         * the {@link dependencyGraphIbGibs} with.
+         */
+        outerspaceIds?: SpaceId[],
         /**
          * The meat of the sync process is tracked via a status within the sync
          * spaces themselves. I'm addign this fn to track the pre and post progress

package/src/witness/space/outer-space/outer-space-types.mts

@@ -135,6 +135,9 @@ export type SyncSpaceSubtype =
     'local-machine-node';
 export const SyncSpaceSubtype = {
     aws_dynamodb: 'aws-dynamodb' as SyncSpaceSubtype,
+    /**
+     * not implemented yet
+     */
     local_machine_node: 'local-machine-node' as SyncSpaceSubtype,
 }