@ibgib/core-gib 0.0.13 → 0.0.15

package/src/witness/app/app-base-v1.mts

@@ -14,7 +14,6 @@ import { PicIbGib_V1 } from '../../common/pic/pic-types.mjs';
 import { ErrorIbGib_V1 } from '../../common/error/error-types.mjs';
 import { validateCommonAppData } from './app-helper.mjs';
 import { argy_, isArg, isCommand, resulty_ } from '../witness-helper.mjs';
-import { IbGibLocalSpaceService_AllPowerful } from '../../core-types.mjs';
 import { pretty } from '@ibgib/helper-gib';
 import { GLOBAL_LOG_A_LOT } from '../../core-constants.mjs';
 import { errorIbGib } from '../../common/error/error-helper.mjs';
@@ -22,6 +21,7 @@ import { getIbGibAddr } from '@ibgib/ts-gib';
 import { isComment } from '../../common/comment/comment-helper.mjs';
 import { isPic } from '../../common/pic/pic-helper.mjs';
 import { WitnessWithContextBase_V1 } from '../witness-with-context/witness-with-context-base-v1.mjs';
+import { MetaspaceService } from '../space/metaspace/metaspace-types.mjs';
 
 const logalot = GLOBAL_LOG_A_LOT || false;
 
@@ -62,7 +62,7 @@ export abstract class AppBase_V1<
      * Reference to the local ibgibs service, which is one way at getting at the
      * local user space.
      */
-    ibgibsSvc: IbGibLocalSpaceService_AllPowerful | undefined;
+    ibgibsSvc: MetaspaceService | undefined;
 
     constructor(initialData?: TData, initialRel8ns?: TRel8ns) {
         super(initialData, initialRel8ns);

package/src/witness/app/app-helper.mts

@@ -4,7 +4,7 @@ import { validateIbGibIntrinsically } from '@ibgib/ts-gib/dist/V1/validate-helpe
 
 
 import { GLOBAL_LOG_A_LOT } from '../../core-constants.mjs';
-import { AppData_V1, } from './app-types.mjs';
+import { AppData_V1, AppIbGib_V1, AppPromptResult, } from './app-types.mjs';
 import { APP_NAME_REGEXP, APP_REL8N_NAME, } from './app-constants.mjs';
 import { IbGibAppAny } from './app-base-v1.mjs';
 // import { CommonService } from '../../services/common.service.mjs';
@@ -13,9 +13,9 @@ import { IbGibSpaceAny } from '../space/space-base-v1.mjs';
 import { WitnessFormBuilder } from '../witness-form-builder.mjs';
 // import { persistTransformResult, registerNewIbGib, rel8ToSpecialIbGib } from './space.mjs';
 import { IbGib_V1 } from '@ibgib/ts-gib/dist/V1/index.mjs';
-import { IbGibLocalSpaceService_AllPowerful } from '../../core-types.mjs';
 import { IbGibTimelineUpdateInfo } from '../../common/other/other-types.mjs';
 import { persistTransformResult, registerNewIbGib, rel8ToSpecialIbGib } from '../space/space-helper.mjs';
+import { MetaspaceService } from '../space/metaspace/metaspace-types.mjs';
 
 const logalot = GLOBAL_LOG_A_LOT || false;
 
@@ -207,14 +207,16 @@ export function getInfoFromAppInfoIb({
  * @returns newly created app ibgib (witness)
  */
 export async function createNewApp({
+    fnPromptApp,
     ibgibs,
     space,
 }: {
+    fnPromptApp: (space: IbGibSpaceAny, ibGib: AppIbGib_V1 | null) => Promise<AppPromptResult | undefined>,
     /**
      * Either {@link common} or {@link ibgibs} is required
      * @hack
      */
-    ibgibs?: IbGibLocalSpaceService_AllPowerful,
+    ibgibs?: MetaspaceService,
     /**
      * space within which to create the app. if not provided, the
      * defaults to the local user space via {@link common} or {@link ibgibs}.
@@ -231,7 +233,7 @@ export async function createNewApp({
 
         // prompt user to create the ibgib, passing in null because we're
         // creating not editing.
-        let resApp = await ibgibs.fnPromptApp(space, /*ibGib*/ null);
+        let resApp = await fnPromptApp(space, /*ibGib*/ null);
 
         if (!resApp) { throw new Error(`resApp falsy after prompt for app. (E: 2225a567abcd680a5e957e81fbb64123)`); }
 

package/src/witness/app/app-types.mts

@@ -70,7 +70,6 @@ export interface AppData_V1 extends WitnessData_V1 {
 
 }
 
-
 export interface AppRel8ns_V1 extends WitnessRel8ns_V1 {
 }
 
@@ -188,16 +187,16 @@ export interface AppResultIbGib<
   extends WitnessResultIbGib<TIbGib, TResultData, TResultRel8ns> {
 }
 
-/**
- * When coming from the extension in firefox/chrome(chromium), this info
- * represents a selection to be converted/saved in an ibgib graph.
- */
-export interface ExtensionSelectionInfo {
-  type: 'comment' | 'link';
-  text: string;
-  url?: string;
-  children?: ExtensionSelectionInfo[];
-}
+// /**
+//  * When coming from the extension in firefox/chrome(chromium), this info
+//  * represents a selection to be converted/saved in an ibgib graph.
+//  */
+// export interface ExtensionSelectionInfo {
+//   type: 'comment' | 'link';
+//   text: string;
+//   url?: string;
+//   children?: ExtensionSelectionInfo[];
+// }
 
 /**
  * this is generated in background.js (WARNING! background.js atow is generated
@@ -208,45 +207,45 @@ export interface ExtensionSelectionInfo {
  * text or clicks an ibgib context menu item to initiate the app, this info is
  * passed to the app via query params (atow).
  */
-export interface ExtensionLaunchInfo {
-  /** brand the event so we know it's ours */
-  ib: boolean;
-  /**
-   * indicate to the receiving angular app that we're launching
-   * from an extension in firefox/chrome. (this is obvious here in
-   * background.js but in the angular app, not so much).
-   */
-  isExtensionLaunch: boolean;
-  /**
-   * So consumer knows where this is coming from. (obvious to us
-   * here, but helps consumer)
-   */
-  lc: string,
-  /**
-   * text of the context menu clicked
-   * @link https://developer.chrome.com/docs/extensions/reference/contextMenus/#type-OnClickData
-   */
-  menuItemId: string;
-  /**
-   * url of the page that _initiates_ the click and starts the app.
-   * so if the user is on wikipedia.org, selects some text and clicks on the ibgib link,
-   * in order to generate some ibgib data based on the page, this will be
-   * https://en.wikipedia.org/wiki/Phanerozoic (or whatever).
-   *
-   * @link https://developer.chrome.com/docs/extensions/reference/contextMenus/#type-OnClickData
-   */
-  pageUrl: string;
-  /**
-   * info about selections user made when starting the (extension) app.
-   *
-   * So if they highlight some text and add it, that is one info. If they highlight a whole paragraph
-   * it will create a comment for the p and possibly children infos for links in that paragraph.
-   *
-   * Same goes for if they select a header tag.
-   *
-   * @link https://developer.chrome.com/docs/extensions/reference/contextMenus/#type-OnClickData
-   */
-  selectionInfos?: ExtensionSelectionInfo[];
-}
+// export interface ExtensionLaunchInfo {
+//   /** brand the event so we know it's ours */
+//   ib: boolean;
+//   /**
+//    * indicate to the receiving angular app that we're launching
+//    * from an extension in firefox/chrome. (this is obvious here in
+//    * background.js but in the angular app, not so much).
+//    */
+//   isExtensionLaunch: boolean;
+//   /**
+//    * So consumer knows where this is coming from. (obvious to us
+//    * here, but helps consumer)
+//    */
+//   lc: string,
+//   /**
+//    * text of the context menu clicked
+//    * @link https://developer.chrome.com/docs/extensions/reference/contextMenus/#type-OnClickData
+//    */
+//   menuItemId: string;
+//   /**
+//    * url of the page that _initiates_ the click and starts the app.
+//    * so if the user is on wikipedia.org, selects some text and clicks on the ibgib link,
+//    * in order to generate some ibgib data based on the page, this will be
+//    * https://en.wikipedia.org/wiki/Phanerozoic (or whatever).
+//    *
+//    * @link https://developer.chrome.com/docs/extensions/reference/contextMenus/#type-OnClickData
+//    */
+//   pageUrl: string;
+//   /**
+//    * info about selections user made when starting the (extension) app.
+//    *
+//    * So if they highlight some text and add it, that is one info. If they highlight a whole paragraph
+//    * it will create a comment for the p and possibly children infos for links in that paragraph.
+//    *
+//    * Same goes for if they select a header tag.
+//    *
+//    * @link https://developer.chrome.com/docs/extensions/reference/contextMenus/#type-OnClickData
+//    */
+//   selectionInfos?: ExtensionSelectionInfo[];
+// }
 
 export type AppPromptResult = TransformResult<IbGibAppAny>;

package/src/witness/robbot/robbot-base-v1.mts

@@ -28,7 +28,6 @@ import { CommentIbGib_V1 } from '../../common/comment/comment-types.mjs';
 import { PicIbGib_V1 } from '../../common/pic/pic-types.mjs';
 import { getInteractionIbGib_V1, validateCommonRobbotData } from './robbot-helper.mjs';
 import { argy_, isArg, resulty_ } from '../witness-helper.mjs';
-import { IbGibLocalSpaceService_AllPowerful } from '../../core-types.mjs';
 import { validateIbGibIntrinsically } from '@ibgib/ts-gib/dist/V1/validate-helper.mjs';
 import { ErrorIbGib_V1 } from '../../common/error/error-types.mjs';
 import { Lex, clone, delay, getTimestamp, getUUID, pretty } from '@ibgib/helper-gib';

package/src/witness/robbot/robbot-helper.mts

@@ -13,14 +13,14 @@ import {
     DEFAULT_ROBBOT_REQUEST_ESCAPE_STRING,
     RobbotData_V1, RobbotIbGib_V1, RobbotInteractionData_V1, RobbotInteractionIbGib_V1,
     RobbotInteractionIbInfo, RobbotInteractionRel8ns_V1, RobbotInteractionType,
-    ROBBOT_INTERACTION_ATOM, ROBBOT_SESSION_ATOM, DEFAULT_ROBBOT_REQUEST_MAX_LENGTH,
+    ROBBOT_INTERACTION_ATOM, ROBBOT_SESSION_ATOM, DEFAULT_ROBBOT_REQUEST_MAX_LENGTH, RobbotPromptResult,
 } from './robbot-types.mjs';
 import { IbGibSpaceAny } from '../space/space-base-v1.mjs';
 import { persistTransformResult, registerNewIbGib, rel8ToSpecialIbGib } from '../space/space-helper.mjs';
 import { isComment, parseCommentIb } from '../../common/comment/comment-helper.mjs';
 import { ROBBOT_REL8N_NAME } from './robbot-constants.mjs';
-import { IbGibLocalSpaceService_AllPowerful } from '../../core-types.mjs';
 import { GLOBAL_LOG_A_LOT, ROBBOT_NAME_REGEXP, ROBBOT_PREFIX_SUFFIX_REGEXP, ROBBOT_PREFIX_SUFFIX_REGEXP_DESC } from '../../core-constants.mjs';
+import { MetaspaceService } from '../space/metaspace/metaspace-types.mjs';
 
 
 const logalot = GLOBAL_LOG_A_LOT || false;
@@ -196,15 +196,16 @@ export function parseRobbotIb({
  * @returns newly created robbot ibgib (witness)
  */
 export async function createNewRobbot({
-    // common,
+    fnPromptRobbot,
     ibgibs,
     space,
 }: {
+    fnPromptRobbot: (space: IbGibSpaceAny, ibGib: RobbotIbGib_V1 | null) => Promise<RobbotPromptResult | undefined>;
     /**
      * Either {@link common} or {@link ibgibs} is required
      * @hack
      */
-    ibgibs?: IbGibLocalSpaceService_AllPowerful,
+    ibgibs?: MetaspaceService,
     /**
      * space within which to create the robbot. if not provided, the
      * defaults to the local user space via {@link common} or {@link ibgibs}.
@@ -221,7 +222,7 @@ export async function createNewRobbot({
 
         // prompt user to create the ibgib, passing in null because we're
         // creating not editing.
-        let resRobbot = await ibgibs.fnPromptRobbot(space, /*ibGib because creating*/null);
+        let resRobbot = await fnPromptRobbot(space, /*ibGib because creating*/null);
 
         if (!resRobbot) { throw new Error(`robbot prompt returned nothing. canceled? (E: 1a08529b53bd3d79c6587b196e5e0823)`); }
 

package/src/witness/space/metaspace/metaspace-base.mts

@@ -188,7 +188,6 @@ export abstract class MetaspaceBase implements MetaspaceService {
         const lc = `${this.lc}[${this.getLocalUserSpace.name}]`;
         try {
             if (logalot) { console.log(`${lc} starting...`); }
-            debugger;
 
             // if we're not explicit with skipLock, go by platform
             // we only need to lock when doing the web, because we could
@@ -2388,9 +2387,11 @@ export abstract class MetaspaceBase implements MetaspaceService {
 
     async getAppRobbotIbGibs({
         createIfNone,
+        fnPromptRobbot,
         space,
     }: {
         createIfNone: boolean,
+        fnPromptRobbot: (space: IbGibSpaceAny, ibGib: RobbotIbGib_V1 | null) => Promise<RobbotPromptResult | undefined>;
         space?: IbGibSpaceAny,
     }): Promise<RobbotIbGib_V1[]> {
         const lc = `${this.lc}[${this.getAppRobbotIbGibs.name}]`;
@@ -2436,7 +2437,7 @@ export abstract class MetaspaceBase implements MetaspaceService {
 
             if (appRobbots.length === 0 && createIfNone) {
                 console.error(`${lc} creating new robbot but should be not casting this on next line in src code. (E: 3252c5917e11421dbc1c26b280b8aeef)`);
-                let robbot = await createNewRobbot({ ibgibs: this as any, space });
+                let robbot = await createNewRobbot({ ibgibs: this as any, space, fnPromptRobbot });
                 if (robbot) {
                     appRobbots = await this.getSpecialRel8dIbGibs<RobbotIbGib_V1>({
                         type: "robbots",
@@ -2455,9 +2456,11 @@ export abstract class MetaspaceBase implements MetaspaceService {
 
     async getAppAppIbGibs({
         createIfNone,
+        fnPromptApp,
         space,
     }: {
         createIfNone: boolean,
+        fnPromptApp: (space: IbGibSpaceAny, ibGib: AppIbGib_V1 | null) => Promise<AppPromptResult | undefined>,
         space?: IbGibSpaceAny,
     }): Promise<AppIbGib_V1[]> {
         const lc = `${this.lc}[${this.getAppAppIbGibs.name}]`;
@@ -2495,7 +2498,7 @@ export abstract class MetaspaceBase implements MetaspaceService {
             // create if applicable
             if (appApps.length === 0 && createIfNone) {
                 console.error(`${lc} creating new app but should be not casting this on next line in src code. (E: 3252c5917e11421dbc1c26b280b8aeef)`);
-                let app = await createNewApp({ ibgibs: this as any, space });
+                let app = await createNewApp({ ibgibs: this as any, space, fnPromptApp });
                 if (app) {
                     appApps = await this.getSpecialRel8dIbGibs<AppIbGib_V1>({
                         type: "apps",

package/src/witness/space/metaspace/metaspace-types.mts

@@ -24,8 +24,8 @@ import {
     EncryptionData_V1, EncryptionIbGib, EncryptionInfo_EncryptGib,
     SecretData_V1, SecretIbGib_V1, SecretInfo_Password
 } from '../../../common/encrypt/encrypt-types.mjs';
-import { RobbotIbGib_V1 } from '../../../witness/robbot/robbot-types.mjs';
-import { AppIbGib_V1 } from '../../../witness/app/app-types.mjs';
+import { RobbotIbGib_V1, RobbotPromptResult } from '../../../witness/robbot/robbot-types.mjs';
+import { AppIbGib_V1, AppPromptResult } from '../../../witness/app/app-types.mjs';
 import { rel8ToSpecialIbGib, } from '../../../witness/space/space-helper.mjs';
 import { GetDependencyGraphOptions } from '../../../common/other/graph-helper.mjs';
 
@@ -559,10 +559,12 @@ export interface MetaspaceService {
     }): Promise<IbGibSpaceAny[]>;
     getAppRobbotIbGibs(arg: {
         createIfNone: boolean,
+        fnPromptRobbot: (space: IbGibSpaceAny, ibGib: RobbotIbGib_V1 | null) => Promise<RobbotPromptResult | undefined>;
         space?: IbGibSpaceAny,
     }): Promise<RobbotIbGib_V1[]>;
     getAppAppIbGibs(arg: {
         createIfNone: boolean,
+        fnPromptApp: (space: IbGibSpaceAny, ibGib: AppIbGib_V1 | null) => Promise<AppPromptResult | undefined>,
         space?: IbGibSpaceAny,
     }): Promise<AppIbGib_V1[]>;
     syncIbGibs(arg: {

package/src/witness/witness-base-v1.mts

@@ -9,7 +9,6 @@ import { validateGib, validateIb, validateIbGibIntrinsically } from '@ibgib/ts-g
 import { ErrorIbGib_V1 } from '../common/error/error-types.mjs';
 import { toDto } from '../common/other/ibgib-helper.mjs';
 import { GLOBAL_LOG_A_LOT } from '../core-constants.mjs';
-import { IbGibLocalSpaceService_AllPowerful } from '../core-types.mjs';
 import { clone, pretty } from '@ibgib/helper-gib';
 
 const logalot = GLOBAL_LOG_A_LOT || false;

package/src/witness/witness-with-context/witness-with-context-base-v1.mts

@@ -11,7 +11,6 @@ import { WitnessBase_V1, } from '../witness-base-v1.mjs';
 import { CommentIbGib_V1 } from '../../common/comment/comment-types.mjs';
 import { PicIbGib_V1 } from '../../common/pic/pic-types.mjs';
 import { argy_, isArg, resulty_ } from '../witness-helper.mjs';
-import { IbGibLocalSpaceService_AllPowerful } from '../../core-types.mjs';
 import { ErrorIbGib_V1 } from '../../common/error/error-types.mjs';
 import { errorIbGib } from '../../common/error/error-helper.mjs';
 import { createCommentIbGib, parseCommentIb } from '../../common/comment/comment-helper.mjs';
@@ -20,6 +19,7 @@ import { getTjpAddr } from '../../common/other/ibgib-helper.mjs';
 import { IbGibTimelineUpdateInfo } from '../../common/other/other-types.mjs';
 import { WitnessArgIbGib, WitnessData_V1, WitnessRel8ns_V1 } from '../witness-types.mjs';
 import { WitnessWithContextData_V1, WitnessWithContextRel8ns_V1 } from './witness-with-context-types.mjs';
+import { MetaspaceService } from '../space/metaspace/metaspace-types.mjs';
 
 const logalot = GLOBAL_LOG_A_LOT || true;
 
@@ -97,7 +97,7 @@ export abstract class WitnessWithContextBase_V1<
      * Reference to the local ibgibs service, which is one way at getting at the
      * local user space.
      */
-    public ibgibsSvc: IbGibLocalSpaceService_AllPowerful | undefined;
+    public ibgibsSvc: MetaspaceService | undefined;
 
     protected _contextChangesSubscription: Subscription | undefined;
     protected _currentWorkingContextIbGib: IbGib_V1 | undefined;
@@ -206,7 +206,7 @@ export abstract class WitnessWithContextBase_V1<
         /**
          * If provided, will register the newly created ibgib.
          */
-        ibgibsSvc?: IbGibLocalSpaceService_AllPowerful,
+        ibgibsSvc?: MetaspaceService,
         // /**
         //  * If given (which atow is most likely the case), then the {@link TransformResult} will
         //  * be persisted in this `space`.
@@ -360,7 +360,7 @@ export abstract class WitnessWithContextBase_V1<
         text: string,
         contextIbGib: IbGib_V1,
         rel8nName: string,
-        ibgibsSvc?: IbGibLocalSpaceService_AllPowerful,
+        ibgibsSvc?: MetaspaceService,
     }): Promise<void> {
         const lc = `${this.lc}[${this.createCommentAndRel8ToContextIbGib.name}]`;
         try {