@ian2018cs/agenthub 0.1.85 → 0.1.86

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ian2018cs/agenthub",
-  "version": "0.1.85",
+  "version": "0.1.86",
   "description": "A web-based UI for AI Agents",
   "type": "module",
   "main": "server/index.js",

package/server/routes/agents.js

@@ -868,28 +868,62 @@ router.post('/install', async (req, res) => {
 
     // Remove skills that existed in old version but are no longer in new version
     const newSkillNames = new Set((agent.skills || []).filter(s => s.name).map(s => s.name));
-    for (const old of prevAgentInfo?.installedSkills || []) {
-      if (!newSkillNames.has(old.name)) {
-        try {
-          await uninstallSkill(old.name, userUuid, projectDir);
-          console.log(`[AgentInstall] Removed old skill "${old.name}" (no longer in agent)`);
-        } catch (e) {
-          console.warn(`[AgentInstall] Could not remove old skill "${old.name}":`, e.message);
+    if (prevAgentInfo?.installedSkills?.length > 0) {
+      // Precise diff using recorded data
+      for (const old of prevAgentInfo.installedSkills) {
+        if (!newSkillNames.has(old.name)) {
+          try {
+            await uninstallSkill(old.name, userUuid, projectDir);
+            console.log(`[AgentInstall] Removed old skill "${old.name}" (no longer in agent)`);
+          } catch (e) {
+            console.warn(`[AgentInstall] Could not remove old skill "${old.name}":`, e.message);
+          }
         }
       }
+    } else if (prevAgentInfo) {
+      // No recorded data — fallback: scan actual skills dir and remove anything not in new agent
+      try {
+        const skillsDir = path.join(projectDir, '.claude', 'skills');
+        const entries = await fs.readdir(skillsDir).catch(() => []);
+        for (const name of entries) {
+          if (!newSkillNames.has(name)) {
+            try {
+              await fs.unlink(path.join(skillsDir, name));
+              console.log(`[AgentInstall] Removed residual skill "${name}" (fallback cleanup)`);
+            } catch (e) {
+              console.warn(`[AgentInstall] Could not remove residual skill "${name}":`, e.message);
+            }
+          }
+        }
+      } catch {}
     }
 
     // Remove MCPs that existed in old version but are no longer in new version
     const newMcpNames = new Set((agent.mcps || []).filter(m => m.name).map(m => m.name));
-    for (const old of prevAgentInfo?.installedMcps || []) {
-      if (!newMcpNames.has(old.name)) {
-        try {
-          await uninstallMcp(old.keys, userUuid, projectDir);
-          console.log(`[AgentInstall] Removed old MCP "${old.name}" (no longer in agent)`);
-        } catch (e) {
-          console.warn(`[AgentInstall] Could not remove old MCP "${old.name}":`, e.message);
+    if (prevAgentInfo?.installedMcps?.length > 0) {
+      // Precise diff using recorded data (includes exact server keys)
+      for (const old of prevAgentInfo.installedMcps) {
+        if (!newMcpNames.has(old.name)) {
+          try {
+            await uninstallMcp(old.keys, userUuid, projectDir);
+            console.log(`[AgentInstall] Removed old MCP "${old.name}" (no longer in agent)`);
+          } catch (e) {
+            console.warn(`[AgentInstall] Could not remove old MCP "${old.name}":`, e.message);
+          }
         }
       }
+    } else if (prevAgentInfo) {
+      // No recorded data — fallback: remove ALL project-scoped MCP keys (will be reinstalled)
+      try {
+        const userPaths = getUserPaths(userUuid);
+        const claudeJsonPath = path.join(userPaths.claudeDir, '.claude.json');
+        const claudeConfig = JSON.parse(await fs.readFile(claudeJsonPath, 'utf-8'));
+        const projectMcpKeys = Object.keys(claudeConfig.projects?.[projectDir]?.mcpServers || {});
+        if (projectMcpKeys.length > 0) {
+          await uninstallMcp(projectMcpKeys, userUuid, projectDir);
+          console.log(`[AgentInstall] Removed ${projectMcpKeys.length} residual project MCPs (fallback cleanup)`);
+        }
+      } catch {}
     }
 
     // Install skills
@@ -1853,18 +1887,37 @@ router.post('/submissions/:id/approve', async (req, res) => {
 
                 // Update skill dependencies
                 const newSkills = (publishedAgent.skills || []).filter(s => s.name && s.repo);
-                const oldSkills = entry.agentInfo.installedSkills || [];
+                const oldSkills = entry.agentInfo.installedSkills;
                 const newSkillNames = new Set(newSkills.map(s => s.name));
 
-                for (const old of oldSkills) {
-                  if (!newSkillNames.has(old.name)) {
-                    try {
-                      await uninstallSkill(old.name, user.uuid, projectDir);
-                      console.log(`[AgentApprove] Removed old skill "${old.name}" for user ${user.uuid}`);
-                    } catch (e) {
-                      console.warn(`[AgentApprove] Could not remove old skill "${old.name}" for user ${user.uuid}:`, e.message);
+                if (oldSkills?.length > 0) {
+                  // Precise diff using recorded data
+                  for (const old of oldSkills) {
+                    if (!newSkillNames.has(old.name)) {
+                      try {
+                        await uninstallSkill(old.name, user.uuid, projectDir);
+                        console.log(`[AgentApprove] Removed old skill "${old.name}" for user ${user.uuid}`);
+                      } catch (e) {
+                        console.warn(`[AgentApprove] Could not remove old skill "${old.name}" for user ${user.uuid}:`, e.message);
+                      }
                     }
                   }
+                } else {
+                  // No recorded data — fallback: scan actual skills dir
+                  try {
+                    const skillsDir = path.join(projectDir, '.claude', 'skills');
+                    const entries = await fs.readdir(skillsDir).catch(() => []);
+                    for (const name of entries) {
+                      if (!newSkillNames.has(name)) {
+                        try {
+                          await fs.unlink(path.join(skillsDir, name));
+                          console.log(`[AgentApprove] Removed residual skill "${name}" for user ${user.uuid} (fallback cleanup)`);
+                        } catch (e) {
+                          console.warn(`[AgentApprove] Could not remove residual skill "${name}" for user ${user.uuid}:`, e.message);
+                        }
+                      }
+                    }
+                  } catch {}
                 }
 
                 const newInstalledSkills = [];
@@ -1880,18 +1933,33 @@ router.post('/submissions/:id/approve', async (req, res) => {
 
                 // Update MCP dependencies
                 const newMcps = (publishedAgent.mcps || []).filter(m => m.name && m.repo);
-                const oldMcps = entry.agentInfo.installedMcps || [];
+                const oldMcps = entry.agentInfo.installedMcps;
                 const newMcpNames = new Set(newMcps.map(m => m.name));
 
-                for (const old of oldMcps) {
-                  if (!newMcpNames.has(old.name)) {
-                    try {
-                      await uninstallMcp(old.keys, user.uuid, projectDir);
-                      console.log(`[AgentApprove] Removed old MCP "${old.name}" for user ${user.uuid}`);
-                    } catch (e) {
-                      console.warn(`[AgentApprove] Could not remove old MCP "${old.name}" for user ${user.uuid}:`, e.message);
+                if (oldMcps?.length > 0) {
+                  // Precise diff using recorded data (includes exact server keys)
+                  for (const old of oldMcps) {
+                    if (!newMcpNames.has(old.name)) {
+                      try {
+                        await uninstallMcp(old.keys, user.uuid, projectDir);
+                        console.log(`[AgentApprove] Removed old MCP "${old.name}" for user ${user.uuid}`);
+                      } catch (e) {
+                        console.warn(`[AgentApprove] Could not remove old MCP "${old.name}" for user ${user.uuid}:`, e.message);
+                      }
                     }
                   }
+                } else {
+                  // No recorded data — fallback: remove ALL project-scoped MCP keys (will be reinstalled)
+                  try {
+                    const userPaths = getUserPaths(user.uuid);
+                    const claudeJsonPath = path.join(userPaths.claudeDir, '.claude.json');
+                    const claudeConfig = JSON.parse(await fs.readFile(claudeJsonPath, 'utf-8'));
+                    const projectMcpKeys = Object.keys(claudeConfig.projects?.[projectDir]?.mcpServers || {});
+                    if (projectMcpKeys.length > 0) {
+                      await uninstallMcp(projectMcpKeys, user.uuid, projectDir);
+                      console.log(`[AgentApprove] Removed ${projectMcpKeys.length} residual project MCPs for user ${user.uuid} (fallback cleanup)`);
+                    }
+                  } catch {}
                 }
 
                 const newInstalledMcps = [];