@ian-pascoe/pi-advisor 0.4.0 → 0.5.0

package/README.md

@@ -17,6 +17,7 @@ Advisor is **disabled by default**. Configuration precedence is session, trusted
 ## Commands
 
 ```text
+/advisor
 /advisor status
 /advisor on|off [--global|--project]
 /advisor inherit [key] [--global|--project]
@@ -29,6 +30,12 @@ Advisor is **disabled by default**. Configuration precedence is session, trusted
 
 Argument autocomplete suggests command names, settings keys, and valid trailing scope flags.
 
+In the interactive TUI, `/advisor` alone opens a settings menu built from Pi's native settings list, like `/settings`. A Scope row chooses where edits are written (session, trusted project, or global), and each setting shows its effective value with any non-default source. `enabled`, `includeSubagents`, and `thinkingLevel` cycle the selected scope's own value in place (`inherit → on → off`, or through each thinking level); while that scope has none, the row shows what it inherits, such as `inherit (on · project)`, and a value overridden by a higher-precedence scope is marked. Model, tools, numbers, and the prompt open submenus, and the prompt uses Pi's own editor component. Every edit is validated and applied immediately; a paused Advisor shows its reason and a Resume row. Closing the menu records one status entry listing the changes it applied, or nothing if none were. Without the TUI, `/advisor` records the status entry instead.
+
+`/advisor status` and the other subcommands each record a status entry in the transcript. Collapsed, it shows state, model, backlog, usage and cost, unavailable tools, and the last error; expanded, it lists every setting with its source and each watched Child Agent. A mutating command's entry starts with the changes it applied. While enabled, the footer shows `advisor` when idle, `advisor: reviewing`/`consulting` with any `backlog N`, or `advisor: paused`, plus Child Agents that are reviewing or paused. `advisor_ask` renders its question and a Markdown answer preview, and Child Agent findings carry a `↳ <agentId>` label.
+
+Interventions render with their severity and Advisor attribution. Long Nits collapse until expanded; Concerns and Blockers always show in full.
+
 ## On-demand consultations
 
 When Advisor is enabled, the main agent can call `advisor_ask({ message })` for analysis or a second opinion. The call waits for the current Review, then returns plain Markdown before any further Review Backlog is processed. Follow-up calls continue the same private Advisor Session.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ian-pascoe/pi-advisor",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "private": false,
   "description": "Background review and attributed corrective advice for Pi agent sessions.",
   "keywords": [

package/src/advisor-command.ts

@@ -15,7 +15,7 @@ export function completeAdvisorCommandArguments(prefix: string): AutocompleteIte
   if (scopePrefix) {
     try {
       const command = parseAdvisorCommand(scopePrefix);
-      if (command.action !== "status" && command.scope === "session")
+      if ("scope" in command && command.scope === "session")
         candidates.push(`${scopePrefix}--global`, `${scopePrefix}--project`);
     } catch {
       // Incomplete commands and JSON values cannot accept a scope yet.
@@ -27,7 +27,7 @@ export function completeAdvisorCommandArguments(prefix: string): AutocompleteIte
 }
 
 const usage =
-  "Usage: /advisor [on|off|status|prompt|inherit [key]|set <key> <JSON>] [--global|--project]";
+  "Usage: /advisor [on|off|status|prompt|inherit [key]|set <key> <JSON>] [--global|--project]; /advisor alone opens settings";
 
 /** Parse one configuration change; validated patches cannot invent option keys. */
 export function parseAdvisorCommand(input: string) {
@@ -38,14 +38,19 @@ export function parseAdvisorCommand(input: string) {
       : flag?.[1] === "project"
         ? ("project" as const)
         : ("session" as const);
-  const text = (flag ? input.trim().slice(0, flag.index) : input.trim()) || "status";
-  if (text === "status") {
+  const text = flag ? input.trim().slice(0, flag.index) : input.trim();
+  if (text === "" || text === "status") {
     if (flag) throw new Error(usage);
-    return { action: "status" as const };
+    return text === "" ? { action: "menu" as const } : { action: "status" as const };
   }
   if (text === "prompt") return { action: "prompt" as const, scope };
   if (text === "on" || text === "off") {
-    return { action: "set" as const, scope, patch: { enabled: text === "on" } };
+    return {
+      action: "set" as const,
+      scope,
+      key: "enabled" as const,
+      patch: { enabled: text === "on" },
+    };
   }
   const inherit = /^inherit(?:\s+(\S+))?$/.exec(text);
   if (inherit) {
@@ -53,6 +58,7 @@ export function parseAdvisorCommand(input: string) {
   }
   const set = /^set\s+(\S+)\s+([\s\S]+)$/.exec(text);
   if (!set?.[1] || !set[2]) throw new Error(usage);
-  const patch: AdvisorOptions = parseAdvisorOptions({ [set[1]]: JSON.parse(set[2]) }, scope);
-  return { action: "set" as const, scope, patch };
+  const key = advisorOptionKey(set[1]);
+  const patch: AdvisorOptions = parseAdvisorOptions({ [key]: JSON.parse(set[2]) }, scope);
+  return { action: "set" as const, scope, key, patch };
 }

package/src/advisor-contract.ts

@@ -0,0 +1,33 @@
+import { Type, type Static } from "typebox";
+
+/** Intervention severities, in ascending urgency. */
+export const advisorSeveritySchema = Type.Union([
+  Type.Literal("nit"),
+  Type.Literal("concern"),
+  Type.Literal("blocker"),
+]);
+export type AdvisorSeverity = Static<typeof advisorSeveritySchema>;
+
+/** One reported finding; also the journaled details of an Intervention message. */
+export const advisorFindingSchema = Type.Object(
+  {
+    severity: advisorSeveritySchema,
+    message: Type.String({ minLength: 1, maxLength: 4000 }),
+  },
+  { additionalProperties: false },
+);
+export type AdvisorFinding = Static<typeof advisorFindingSchema>;
+
+/** Observer lifecycle state reported by its `status`. */
+export const advisorObserverStateSchema = Type.Union([
+  Type.Literal("disabled"),
+  Type.Literal("armed"),
+  Type.Literal("reviewing"),
+  Type.Literal("consulting"),
+  Type.Literal("paused"),
+]);
+export type AdvisorObserverState = Static<typeof advisorObserverStateSchema>;
+
+/** State recorded in status entries; private Advisor Sessions cannot host an Advisor. */
+export const advisorStateSchema = Type.Union([advisorObserverStateSchema, Type.Literal("private")]);
+export type AdvisorState = Static<typeof advisorStateSchema>;