@ian-pascoe/pi-advisor 0.3.3 → 0.3.5

package/README.md

@@ -54,7 +54,7 @@ Consultation authorizes analysis and investigation, not implementation or other
 | Findings per Review            | 4                            |
 | Automatic Corrective Turns     | 1 per request/task           |
 
-A Tool Grant names tools; it does not sandbox their full native interfaces. Explicitly granting `lsp`, for example, permits its native operations, including mutations. Unavailable names are ignored and reported. Advisor never autogrants missing tools. Granting `codemode` lets the Advisor script its other granted tools; it inherits the observed `codemode.mode`, so under `"only"` the Advisor calls `advisor_report` from a script.
+A Tool Grant names tools; it does not sandbox their full native interfaces. Explicitly granting `lsp`, for example, permits its native operations, including mutations. Unavailable names are ignored and reported. Advisor never autogrants missing tools. Granting `codemode` lets the Advisor script its other granted tools; it inherits the observed `codemode.mode`, so under `"only"` the Advisor calls `advisor_report` from a script. It also inherits whether scripts get the `models` API: Minimal Subagents Child Agents have none, so neither do their Advisors.
 
 The Advisor inherits each observed agent's model and thinking level independently unless configured otherwise. One root policy can cover current and future Minimal Subagents descendants when enabled.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ian-pascoe/pi-advisor",
-  "version": "0.3.3",
+  "version": "0.3.5",
   "private": false,
   "description": "Background review and attributed corrective advice for Pi agent sessions.",
   "keywords": [

package/skills/pi-advisor/SKILL.md

@@ -2,6 +2,7 @@
 name: pi-advisor
 description: Diagnose Pi Advisor when reviews or advisor_ask are missing, consultation fails, the Advisor is paused, settings are ineffective, backlog waits do not release, or corrective advice is not delivered safely.
 license: MIT
+disable-model-invocation: true
 ---
 
 # Pi Advisor

package/src/advisor-session.ts

@@ -31,6 +31,8 @@ export interface AdvisorResourceInputs {
     readonly hidden?: boolean | undefined;
   }[];
   flagValues: ReadonlyMap<string, boolean | string>;
+  /** Whether the owner's built-in codemode gives scripts the `models` API; Pi's default is true. */
+  codemodeModels?: boolean | undefined;
 }
 
 /** Fresh factories and native services; the observed session supplies data, never bound handlers. */
@@ -228,9 +230,13 @@ async function buildAdvisorSession(
           `Unsupported Advisor resources: this Pi runtime does not export ${factoryExport} to recreate ${extension.path}`,
         );
       recreated.add(index);
+      const codemodeModels = options.resourceInputs?.codemodeModels;
       builtins.push({
         name,
-        factory: create(),
+        factory:
+          name === "codemode" && codemodeModels !== undefined
+            ? piSdk.createCodemodeExtension({ models: codemodeModels })
+            : create(),
         builtin: true,
         replaceable: extension.replaceable === true,
       });

package/src/index.ts

@@ -19,6 +19,7 @@ import { completeAdvisorCommandArguments, parseAdvisorCommand } from "./advisor-
 import { AdvisorObserver } from "./advisor-observer.js";
 import { isAdvisorSession, type AdvisorResourceInputs } from "./advisor-session.js";
 import { advisorRuntimeWarning } from "./advisor-runtime.js";
+import { TROUBLESHOOTING_HINT } from "./troubleshooting-skill.js";
 
 interface WatchedChild {
   agentId: string;
@@ -39,6 +40,7 @@ const childRequestSchema = Type.Object({
     agentDir: Type.String({ minLength: 1 }),
     extensions: Type.Array(Type.Unknown()),
     flagValues: Type.Unknown(),
+    codemodeModels: Type.Optional(Type.Boolean()),
   }),
 });
 
@@ -76,13 +78,20 @@ export default function advisor(pi: ExtensionAPI): void {
         parameters: askToolParameters,
         executionMode: "sequential",
         execute: async (_id, { message }, signal) => {
-          const current = observer;
-          if (!current)
-            throw new Error(
-              `${error ?? "Advisor consultation is unavailable"}. Inspect /advisor status, then run /advisor on or correct its configuration.`,
-            );
-          const answer = await current.consult(message, signal);
-          return { content: [{ type: "text", text: answer }], details: {} };
+          try {
+            const current = observer;
+            if (!current)
+              throw new Error(
+                `${error ?? "Advisor consultation is unavailable"}. Inspect /advisor status, then run /advisor on or correct its configuration.`,
+              );
+            const answer = await current.consult(message, signal);
+            return { content: [{ type: "text", text: answer }], details: {} };
+          } catch (cause) {
+            // Caller cancellation is not a malfunction the Skill diagnoses.
+            if (signal?.aborted) throw cause;
+            const text = cause instanceof Error ? cause.message : String(cause);
+            throw new Error(`${text}\n\n${TROUBLESHOOTING_HINT}`, { cause });
+          }
         },
       });
       askToolRegistered = true;
@@ -238,6 +247,7 @@ export default function advisor(pi: ExtensionAPI): void {
         agentDir: payload.resourceInputs.agentDir,
         extensions,
         flagValues: new Map(resources.runtime.flagValues),
+        codemodeModels: payload.resourceInputs.codemodeModels,
       },
       observer: undefined,
     };

package/src/troubleshooting-skill.ts

@@ -0,0 +1,9 @@
+import { fileURLToPath } from "node:url";
+
+/** Absolute path of this package's user-invoked troubleshooting Skill. */
+export const TROUBLESHOOTING_SKILL_PATH = fileURLToPath(
+  new URL("../skills/pi-advisor/SKILL.md", import.meta.url),
+);
+
+/** Model-facing pointer appended to failures this package's Skill diagnoses. */
+export const TROUBLESHOOTING_HINT = `For diagnosis, read the pi-advisor troubleshooting Skill at ${TROUBLESHOOTING_SKILL_PATH}.`;