@i4e/invest4edu-access-core 0.29.0 → 0.31.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@i4e/invest4edu-access-core",
-  "version": "0.29.0",
+  "version": "0.31.0",
   "description": "Shared access-control primitives for NeoFindesk: tenant keystone, role capabilities, reportee tree, feature flags, and the unified access engine (registry schema, snapshot resolver, visibleWhen).",
   "type": "module",
   "exports": {

package/src/entitlement-store.js

@@ -157,7 +157,28 @@ export function createEntitlementStore({
        * The per-plan override is your "premium plans give more usage" lever: eCAS can cost 2 on
        * Discover and 1 on Grow without any per-feature matrix returning through the back door.
        */
-      if (creditsMode) {
+      /**
+       * A per-feature BUDGET opts out of credits mode.
+       *
+       * `quota` is overloaded, and the two meanings need opposite handling: on VPD it is "12
+       * sessions a year" — a budget that must decrement and refuse at zero — while on stock tips it
+       * is "5 ideas per answer", a ceiling read on every request and never spent. Credits mode
+       * counts only the wallet, so a budget expressed that way silently never moved: Grow showed
+       * 12 VPD sessions that could be used forever.
+       *
+       * So a row with a real number, on a feature that does NOT shape a response, falls through to
+       * count mode and is governed by its own counter. Credits stay for what is priced in credits.
+       * `shapes_response` is the discriminator because it is a property of the FEATURE — whether it
+       * trims an answer or counts a use — not of the plan that sells it.
+       */
+      const budgetRow = creditsMode ? resolveEntitlementRow(rows, featureCode, now) : null;
+      const isOwnBudget = !!budgetRow
+        && budgetRow.unlocked !== false
+        && feature.shapes_response !== true
+        && budgetRow.quota !== null && budgetRow.quota !== undefined && budgetRow.quota !== ""
+        && Number.isFinite(Number(budgetRow.quota));
+
+      if (creditsMode && !isOwnBudget) {
         const svcRow = resolveEntitlementRow(rows, featureCode, now);
         // Not named in a credits plan → the same fail-open NOT_IN_PLAN as count mode. A plan
         // that forgot to include a feature is a config gap, not a paywall.
@@ -210,8 +231,28 @@ export function createEntitlementStore({
             ? { ...creditRows[0], quota: result.quota, overage_policy: result.overage_policy || creditRows[0].overage_policy }
             : null;
 
+          /**
+           * A CEILING survives credits mode.
+           *
+           * `limit` shapes a response — "your list shows 5" — and is read on every request without
+           * ever being spent. A PRICE is what a use costs. They are orthogonal, and the two live on
+           * different fields for exactly that reason.
+           *
+           * Without this line the credits branch returned the wallet's numbers and no `limit` at
+           * all, so a consumer reading `ent.limit` (NFD AI's stock-tips shaper does) saw nothing
+           * and applied no ceiling. A free plan promising five stock ideas silently served every
+           * one of them — the paywall looked configured and was not.
+           *
+           * Same UNSET-vs-0 care as count mode: null means "no ceiling", 0 means "show nothing".
+           */
+          const rawCeiling = svcRow.quota;
+          const ceiling = rawCeiling === null || rawCeiling === undefined || rawCeiling === ""
+            ? null
+            : Number(rawCeiling);
+
           return {
             ...result,
+            limit: ceiling !== null && Number.isFinite(ceiling) && ceiling >= 0 ? ceiling : null,
             mode: "credits",
             carriedSubjectType: subjectType,
             carriedSubjectId: subjectId,