@i4e/invest4edu-access-core 0.17.0 → 0.17.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@i4e/invest4edu-access-core",
-  "version": "0.17.0",
+  "version": "0.17.2",
   "description": "Shared access-control primitives for NeoFindesk: tenant keystone, role capabilities, reportee tree, feature flags, and the unified access engine (registry schema, snapshot resolver, visibleWhen).",
   "type": "module",
   "exports": {

package/src/entitlement-store.js

@@ -155,8 +155,20 @@ export function createEntitlementStore({ getDb, toObjectId = (v) => v, logger =
         subscription, entitlementRows: rows, featureCode, feature, used, credits, identity, bypass, now,
       });
 
-      // Carry what consume() needs, so it cannot recompute the period key and count against a
-      // different bucket than the one that was just checked.
+      /**
+       * Carry what consume() needs, so it cannot recompute the period key and count against a
+       * different bucket than the one that was just checked.
+       *
+       * The carried row takes its ceiling from the RESOLVED result, not from the raw plan row —
+       * because a per-subject override changes the decision without changing the row it came
+       * from. Carrying the raw row meant consume guarded on the plan's quota while the check had
+       * already passed on the overridden one: a subject granted 5 was refused at 2, and it
+       * surfaced as a counter that had simply stopped moving.
+       */
+      const effectiveRow = row
+        ? { ...row, quota: result.quota, overage_policy: result.overage_policy || row.overage_policy }
+        : null;
+
       return {
         ...result,
         carriedSubjectType: subjectType,
@@ -164,7 +176,7 @@ export function createEntitlementStore({ getDb, toObjectId = (v) => v, logger =
         carriedSubscriptionId: subscription._id,
         carriedPeriodStart: subscription.period_start || null,
         carriedIdentity: identity,
-        carriedRow: row,
+        carriedRow: effectiveRow,
       };
     } catch (e) {
       logger.warn(`[entitlement] resolve failed for ${featureCode}, allowing through: ${e.message}`);

package/src/entitlement.js

@@ -93,7 +93,20 @@ export function resolveEntitlementRow(rows = [], featureCode, now = new Date())
 
 /** Apply a per-firm override on top of the plan row. Concessions live on the subscription. */
 function withOverride(row, overrides = [], featureCode) {
-  const o = (overrides || []).find((x) => x && x.feature_code === featureCode);
+  /**
+   * Two shapes in the wild, and getting this wrong is silent AND total.
+   *
+   * Everything that WRITES an override — the model, the admin API, the Subscribers view — uses an
+   * object map keyed by feature code. This function only understood an array, so `.find` on the
+   * object threw, `resolveEntitlement` failed open, and the subscriber stopped being metered
+   * altogether. Setting a per-customer allowance therefore disabled that customer's counting —
+   * the opposite of the intent, with no error anywhere.
+   *
+   * Both shapes are accepted now. The map is the canonical one.
+   */
+  const o = Array.isArray(overrides)
+    ? overrides.find((x) => x && x.feature_code === featureCode)
+    : (overrides && typeof overrides === "object" ? overrides[featureCode] : null);
   if (!o) return row;
   const merged = { ...row };
   for (const k of ["unlocked", "quota", "period_granularity", "quota_scope", "overage_policy", "single_usage_price"]) {