@hytopia.com/server-protocol 1.4.34 → 1.4.35

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@hytopia.com/server-protocol",
-  "version": "1.4.34",
+  "version": "1.4.35",
   "main": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"

package/packets/PacketCore.ts

@@ -104,13 +104,12 @@ export function createPacket<TId extends PacketId, TSchema>(
   return packet;
 }
 
-export function createPacketBufferUnframer(): (chunk: Uint8Array) => Uint8Array[] {
+export function createPacketBufferUnframer(onMessage: (message: Uint8Array) => void): (chunk: Uint8Array) => void {
   let buffer = new Uint8Array(512 * 1024); // 512KB initial buffer
+  let view = new DataView(buffer.buffer, buffer.byteOffset, buffer.byteLength);
   let used = 0;
 
-  return (chunk: Uint8Array): Uint8Array[] => {
-    const messages: Uint8Array[] = [];
-
+  return (chunk: Uint8Array): void => {
     // Grow buffer if needed
     if (used + chunk.length > buffer.length) {
       const requiredSize = Math.max(buffer.length * 2, used + chunk.length);
@@ -118,39 +117,48 @@ export function createPacketBufferUnframer(): (chunk: Uint8Array) => Uint8Array[
       // Enforce max buffer size cap
       if (requiredSize > MAX_FRAME_BUFFER_SIZE) {
         console.error(`Unframer packet buffer exceeded maximum size of ${MAX_FRAME_BUFFER_SIZE} bytes, discarding packet...`);
-        used = 0; // Reset buffer state to discard oversized packet and continue processing future packets
-        return [];
+        used = 0;
+        return;
       }
       
       const grown = new Uint8Array(requiredSize);
       grown.set(buffer.subarray(0, used));
       buffer = grown;
+      view = new DataView(buffer.buffer, buffer.byteOffset, buffer.byteLength);
     }
 
     // Append new chunk
     buffer.set(chunk, used);
     used += chunk.length;
 
-    // Extract complete messages
-    while (used >= FRAME_HEADER_SIZE) {
-      const view = new DataView(buffer.buffer, buffer.byteOffset);
-      const length = view.getUint32(0, false); // false = big-endian
+    // Extract and process complete messages
+    let readOffset = 0;
+    
+    while (used - readOffset >= FRAME_HEADER_SIZE) {
+      const length = view.getUint32(readOffset, false); // big-endian
+      const totalFrameSize = FRAME_HEADER_SIZE + length;
       
       // Wait for complete message
-      if (used < FRAME_HEADER_SIZE + length) {
+      if (used - readOffset < totalFrameSize) {
         break;
       }
 
-      // Extract message (skip 4-byte header)
-      const message = buffer.slice(FRAME_HEADER_SIZE, FRAME_HEADER_SIZE + length);
-      messages.push(message);
-
-      // Shift buffer
-      buffer.copyWithin(0, FRAME_HEADER_SIZE + length, used);
-      used -= FRAME_HEADER_SIZE + length;
+      // Zero-copy: subarray() returns a view, not a copy
+      // BUT! Callback must process immediately before buffer is modified
+      const messageStart = readOffset + FRAME_HEADER_SIZE;
+      onMessage(buffer.subarray(messageStart, messageStart + length));
+      
+      readOffset += totalFrameSize;
     }
 
-    return messages;
+    // Shift remaining data to start (after all callbacks complete)
+    if (readOffset > 0) {
+      if (used > readOffset) {
+        buffer.copyWithin(0, readOffset, used);
+      }
+
+      used -= readOffset;
+    }
   };
 }